[PATCH] docs: Update path that mentions deprecated.rst

2021-07-23 Thread Mao Zhongyi
Missed in commit f3478392 "docs: Move deprecation, build and license info out of system/" Signed-off-by: Mao Zhongyi --- MAINTAINERS | 2 +- configure | 2 +- target/i386/cpu.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 42

Re: [PATCH for-6.1 v3 1/1] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cornelia Huck
On Fri, Jul 23 2021, Yanan Wang wrote: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the topology parameters >

[PATCH for-6.1 v4 1/1] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify the topology parameters as zero like "sockets=0" are meaningless, so disal

[PATCH for-6.1 v4 0/1] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify t

Re: [PATCH 1/2] acpi: x86: pcihp: cleanup devfn usage in build_append_pci_bus_devices()

2021-07-23 Thread Igor Mammedov
On Thu, 22 Jul 2021 13:56:18 -0400 "Michael S. Tsirkin" wrote: > I would add a description: we want to scan all functions > not just function 0 to describe hotplug into bridges > at function != 0. in preparation for this, refactor code to not > skip functions != 0. > > On Thu, Jul 22, 2021 at 06

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 8:55 AM, Gerd Hoffmann wrote: > On Fri, Jul 23, 2021 at 08:47:09AM +0200, Philippe Mathieu-Daudé wrote: >> On 7/23/21 8:32 AM, Gerd Hoffmann wrote: >>> On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: * Gerd Hoffmann (kra...@redhat.com) wrote: > Since comm

Re: [PATCH for-6.1 2/2] docs: Move licence/copyright from HTML output to rST comments

2021-07-23 Thread Michael S. Tsirkin
On Thu, Jul 22, 2021 at 08:20:16PM +0100, Peter Maydell wrote: > Our built HTML documentation now has a standard footer which > gives the license for QEMU (and its documentation as a whole). > In almost all pages, we either don't bother to state the > copyright/license for the individual rST source

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Igor Mammedov
On Thu, 22 Jul 2021 13:49:34 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > > Commit 17858a1695 (hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35) > > switched PCI hotplug from native to ACPI one by default. > > > > That however breaks i

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 22.07.21 19:41, Peter Xu wrote: On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: I'll give it a churn. Thanks, David. Migration of a 8 GiB VM * within the same host * after Linux is up and idle * free page hinting enabled * after dirtying most VM memory using memhog * k

Re: [PATCH] misc/pca9552: Fix LED status register indexing in pca955x_get_led()

2021-07-23 Thread Cédric Le Goater
On 7/23/21 6:36 AM, Andrew Jeffery wrote: > There was a bit of a thinko in the state calculation where every odd pin > in was reported in e.g. "pwm0" mode rather than "off". This was the > result of an incorrect bit shift for the 2-bit field representing each > LED state. > > Fixes: a90d8f84674d (

[PATCH v4 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-23 Thread Bin Meng
From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. While Linux e1000 driver always writes VET register to 0x8100, it is not always the case for everyone. Drivers relying on the reset value of VET won't be able to transmit and

[PATCH v4 3/3] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor

2021-07-23 Thread Bin Meng
From: Christina Wang In the legacy RX descriptor mode, VLAN tag was saved to d->special by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but it was then zeroed out again at the end of the call, which is wrong. Fixes: c89d416a2b0f ("e1000e: Don't zero out buffer address in rx descri

[PATCH v4 2/3] hw/net: e1000e: Correct the initial value of VET register

2021-07-23 Thread Bin Meng
From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. While Linux e1000e driver always writes VET register to 0x8100, it is not always the case for everyone. Drivers relying on the reset value of VET won't be able to transmit and

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: >> In the SMP configuration, we should either specify a topology >> parameter with a reasonable value (equal to or greater than 1) >> or just leave it omitted and QEMU will calculate its value. >> Configurati

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 22.07.21 16:51, Peter Xu wrote: On Thu, Jul 22, 2021 at 09:57:13AM +, Wang, Wei W wrote: On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote: On 22.07.21 10:30, Wei Wang wrote: When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap nee

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
On 7/23/21 8:25 AM, Gerd Hoffmann wrote: > Hi, > >> --- a/accel/accel-softmmu.c >> +++ b/accel/accel-softmmu.c >> @@ -79,7 +79,10 @@ void accel_init_ops_interfaces(AccelClass *ac) >> * all accelerators need to define ops, providing at least a mandatory >> * non-NULL create_vcpu_threa

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Michael S. Tsirkin
On Fri, Jul 23, 2021 at 09:47:26AM +0200, Igor Mammedov wrote: > On Thu, 22 Jul 2021 13:49:34 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > > > Commit 17858a1695 (hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35) > > > switched PCI

Re: [PATCH for-6.1 1/2] docs: Remove stale TODO comments about license and version

2021-07-23 Thread Markus Armbruster
Peter Maydell writes: > Since commits 13f934e79fa and 3a50c8f3067aaf, our HTML docs include a > footer to all pages stating the license and version. We can > therefore delete the TODO comments suggesting we should do that from > our .rst files. > > Signed-off-by: Peter Maydell Reviewed-by: Mar

Re: [PATCH for-6.1 2/2] docs: Move licence/copyright from HTML output to rST comments

2021-07-23 Thread Markus Armbruster
Peter Maydell writes: > Our built HTML documentation now has a standard footer which > gives the license for QEMU (and its documentation as a whole). > In almost all pages, we either don't bother to state the > copyright/license for the individual rST sources, or we put > it in an rST comment. Th

RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread Wang, Wei W
On Friday, July 23, 2021 3:50 PM, David Hildenbrand wrote: > > Migration of a 8 GiB VM > * within the same host > * after Linux is up and idle > * free page hinting enabled > * after dirtying most VM memory using memhog Thanks for the tests! I think it would be better to test using idle guests (

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 23.07.21 10:14, Wang, Wei W wrote: On Friday, July 23, 2021 3:50 PM, David Hildenbrand wrote: Migration of a 8 GiB VM * within the same host * after Linux is up and idle * free page hinting enabled * after dirtying most VM memory using memhog Thanks for the tests! I think it would be bett

Re: [PATCH for-6.1] i386: do not call cpudef-only models functions for max, host, base

2021-07-23 Thread Claudio Fontana
On 7/22/21 6:13 PM, Philippe Mathieu-Daudé wrote: > On 7/22/21 10:38 AM, Claudio Fontana wrote: > > It seems the subject got dropped and the first line > used as subject... But I'm not sure you want to > start the description with it. hmm the subject got dropped from where? I see it in the mail s

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Markus Armbruster
"Jose R. Ziviani" writes: > When a module is not found, specially accelerators, QEMU displays > a error message that not easy to understand[1]. This patch improves > the readability by offering a user-friendly message[2]. > > This patch also moves the accelerator ops check to runtine (instead > o

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
Hello Markus On 7/23/21 10:28 AM, Markus Armbruster wrote: > "Jose R. Ziviani" writes: > >> When a module is not found, specially accelerators, QEMU displays >> a error message that not easy to understand[1]. This patch improves >> the readability by offering a user-friendly message[2]. >> >> Th

RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread Wang, Wei W
On Friday, July 23, 2021 4:17 PM, David Hildenbrand wrote: > > On Friday, July 23, 2021 3:50 PM, David Hildenbrand wrote: > >> > >> Migration of a 8 GiB VM > >> * within the same host > >> * after Linux is up and idle > >> * free page hinting enabled > >> * after dirtying most VM memory using memho

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Igor Mammedov
On Fri, 23 Jul 2021 04:05:18 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 23, 2021 at 09:47:26AM +0200, Igor Mammedov wrote: > > On Thu, 22 Jul 2021 13:49:34 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > > > > Commit 1785

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread wangyanan (Y)
On 2021/7/23 16:02, Markus Armbruster wrote: Daniel P. Berrangé writes: On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU wi

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/23/21 8:55 AM, Gerd Hoffmann wrote: >> On Fri, Jul 23, 2021 at 08:47:09AM +0200, Philippe Mathieu-Daudé wrote: >>> On 7/23/21 8:32 AM, Gerd Hoffmann wrote: On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cornelia Huck
On Fri, Jul 23 2021, "wangyanan (Y)" wrote: > On 2021/7/23 16:02, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >>> On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: +/* + * The topology parameters must be specified equal to or great than one +

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Daniel P . Berrangé
On Thu, Jul 22, 2021 at 01:49:34PM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > > Commit 17858a1695 (hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35) > > switched PCI hotplug from native to ACPI one by default. > > > > That however break

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Daniel P . Berrangé
On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > Commit 17858a1695 (hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35) > switched PCI hotplug from native to ACPI one by default. > > That however breaks ihotplug on following CLI that used to work: s/ihotplug/hotplug/ >-nod

Re: [PATCH v4] failover: unregister ROM on unplug

2021-07-23 Thread Laurent Vivier
On 21/07/2021 18:19, Michael S. Tsirkin wrote: > On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote: >> The intend of failover is to allow to migrate a VM with a VFIO >> networking card without disrupting the network operation by switching >> to a virtio-net device during the migration.

Re: [PATCH v3 00/13] new plugin argument passing scheme

2021-07-23 Thread Mahmoud Mandour
On Thu, Jul 22, 2021 at 9:12 AM Mahmoud Mandour wrote: > Hello, > > This series removes passing arguments to plugins through "arg=" since > it's redundant and reduces readability especially when the argument > itself is composed of a name and a value. > > Also, passing arguments through "arg=" st

Re: [PATCH] docs: Update path that mentions deprecated.rst

2021-07-23 Thread Peter Maydell
On Fri, 23 Jul 2021 at 07:59, Mao Zhongyi wrote: > > Missed in commit f3478392 "docs: Move deprecation, build > and license info out of system/" > > Signed-off-by: Mao Zhongyi > --- > MAINTAINERS | 2 +- > configure | 2 +- > target/i386/cpu.c | 2 +- > 3 files changed, 3 insertion

[PATCH v2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Igor Mammedov
Commit [1] switched PCI hotplug from native to ACPI one by default. That however breaks hotplug on following CLI that used to work: -nodefaults -machine q35 \ -device pcie-root-port,id=pcie-root-port-0,multifunction=on,bus=pcie.0,addr=0x1,chassis=1 \ -device pcie-root-port,id=pcie-root

[PATCH v2] mips/tlb_helper: Add support for 'info tlb' cmd

2021-07-23 Thread Arkadiy
From: NDNF This adds hmp 'info tlb' command support for the mips platform. 1k pages are not supported. Signed-off-by: Ivanov Arkady --- hmp-commands-info.hx | 3 ++- target/mips/cpu.h| 3 +++ target/mips/meson.build | 1 + target/mips/monitor.c| 26 ++ t

Re: [PATCH v3 3/4] vhost-user-rng: backend: Add RNG vhost-user daemon implementation

2021-07-23 Thread Alex Bennée
Mathieu Poirier writes: > On Wed, Jul 21, 2021 at 09:14:31PM +0100, Alex Bennée wrote: >> >> Mathieu Poirier writes: >> >> > This patch provides the vhost-user backend implementation to work >> > in tandem with the vhost-user-rng implementation of the QEMU VMM. >> > >> > It uses the vhost-us

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-23 Thread Michael S. Tsirkin
On Fri, Jul 23, 2021 at 09:48:23AM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 22, 2021 at 01:49:34PM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > > > Commit 17858a1695 (hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35) > > > switched

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
On 7/23/21 12:09 AM, Jose R. Ziviani wrote: > When a module is not found, specially accelerators, QEMU displays > a error message that not easy to understand[1]. This patch improves > the readability by offering a user-friendly message[2]. > > This patch also moves the accelerator ops check to run

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-23 Thread Gerd Hoffmann
Hi, > >> Migration fails and you want know why. > >> > >> Reason migration fails is the guest violates qxl specs (which doesn't > >> cause actual problems unless you want migrate the guest). > > > > Then I agree error_report() is better ("Report an error to the current > > monitor if we have on

Re: [PATCH 1/2] qapi: introduce forwarding visitor

2021-07-23 Thread Paolo Bonzini
On 22/07/21 17:34, Markus Armbruster wrote: This is not a fifth type of visitor, it's a wrapper for the existing types (two of them, input and output; the other two don't break horribly but make no sense either). Unlike the other visitors, this one isn't of a fixed type. I think mentioning thi

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Gerd Hoffmann
> > -g_assert(ops != NULL); > > +if (ops == NULL) { > > +exit(1); > > +} > > + > > > Ah, again, why? > This change looks wrong to me, > > the ops code should be present when ops interfaces are initialized: > it should be a code level assertion, as it has to do with the prope

[PATCH for-6.1 v5 1/1] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify the topology parameters as zero like "sockets=0" are meaningless, so disal

[PATCH for-6.1 v5 0/1] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify the topology parameters as zero like "sockets=0" are meaningless, so disal

Re: [PATCH for-6.1 v4 0/1] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread wangyanan (Y)
Note: the latest v5 has been sent with minor text change. Hopefully that would be the last version. Thanks, Yanan On 2021/7/23 15:31, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it

[PING][PATCH v2] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-07-23 Thread Denis Plotnikov
ping! On 19.07.2021 17:21, Denis Plotnikov wrote: On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and VHOST_USER_SET_VRING_ADDR per each started

[PULL 1/2] qapi: introduce forwarding visitor

2021-07-23 Thread Paolo Bonzini
This new adaptor visitor takes a single field of the adaptee, and exposes it with a different name. This will be used for QOM alias properties. Alias targets can of course have a different name than the alias property itself (e.g. a machine's pflash0 might be an alias of a property named 'drive')

[PULL 0/2] QAPI/QOM bugfix for QEMU 6.1

2021-07-23 Thread Paolo Bonzini
The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' into staging (2021-07-19 19:06:05 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream-qapi

[PULL 2/2] qom: use correct field name when getting/setting alias properties

2021-07-23 Thread Paolo Bonzini
Alias targets have a different name than the alias property itself (e.g. a machine's pflash0 might be an alias of a property named 'drive'). When the target's getter or setter invokes the visitor, it will use a different name than what the caller expects, and the visitor will not be able to find it

[PATCH 0/3] MAINTAINERS: "Host Memory Backends" and "Memory API" updates

2021-07-23 Thread David Hildenbrand
Some maintainer and file updates for "Host Memory Backends" and "Memory API". David Hildenbrand (3): MAINTAINERS: Replace Eduardo as "Host Memory Backends" maintainer MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API" MAINTAINERS: Add memory_mapping.h and memory_mapping.c

[PATCH 1/3] MAINTAINERS: Replace Eduardo as "Host Memory Backends" maintainer

2021-07-23 Thread David Hildenbrand
Edurdo asked me to take over co-maintaining "Host Memory Backends" with Igor, as Eduardo has plenty of other things to look after. Thanks a lot Eduardo for your excellent work in the past! Cc: Peter Maydell Cc: Eduardo Habkost Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-by: David Hildenbra

[PATCH 2/3] MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API"

2021-07-23 Thread David Hildenbrand
Peter and myself volunteered to help out co-maintaining "Memory API" with Paolo, so let's update the MAINTAINERS file. Cc: Peter Maydell Cc: Paolo Bonzini Cc: Peter Xu Signed-off-by: David Hildenbrand --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAIN

[PATCH 3/3] MAINTAINERS: Add memory_mapping.h and memory_mapping.c to "Memory API"

2021-07-23 Thread David Hildenbrand
Both files logically belong to "Memory API" and are not yet listed anywhere else explicitly. Let's add them to "Memory API". Cc: Peter Maydell Cc: Paolo Bonzini Cc: Peter Xu Signed-off-by: David Hildenbrand --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MA

Re: [PULL 00/15] Misc bugfix patches for 2021-07-22

2021-07-23 Thread Peter Maydell
On Thu, 22 Jul 2021 at 16:39, Paolo Bonzini wrote: > > The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' > into staging (2021-07-19 19:06:05 +0100) > > are available in the Git repository a

Re: [PATCH 1/3] MAINTAINERS: Replace Eduardo as "Host Memory Backends" maintainer

2021-07-23 Thread Igor Mammedov
On Fri, 23 Jul 2021 12:05:30 +0200 David Hildenbrand wrote: > Edurdo asked me to take over co-maintaining "Host Memory Backends" with > Igor, as Eduardo has plenty of other things to look after. > > Thanks a lot Eduardo for your excellent work in the past! > > Cc: Peter Maydell > Cc: Eduardo H

Re: [PATCH 2/3] MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API"

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 12:05 PM, David Hildenbrand wrote: > Peter and myself volunteered to help out co-maintaining "Memory API" > with Paolo, so let's update the MAINTAINERS file. I'm very interested in following changes in this area (although I'm not assigned to work on it, I have genuine interest and found

Re: [PATCH 2/3] MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API"

2021-07-23 Thread David Hildenbrand
On 23.07.21 12:23, Philippe Mathieu-Daudé wrote: On 7/23/21 12:05 PM, David Hildenbrand wrote: Peter and myself volunteered to help out co-maintaining "Memory API" with Paolo, so let's update the MAINTAINERS file. I'm very interested in following changes in this area (although I'm not assigned

[PATCH 0/4] chardev fixes

2021-07-23 Thread marcandre . lureau
From: Marc-André Lureau Hi, Two small fixes related to fd handling for "serial" and "file" backend and some API comments and minor improvement. Marc-André Lureau (4): chardev: fix qemu_chr_open_fd() being called with fd=-1 chardev: fix qemu_chr_open_fd() with fd_in==fd_out chardev: remove

[PATCH 2/4] chardev: fix qemu_chr_open_fd() with fd_in==fd_out

2021-07-23 Thread marcandre . lureau
From: Marc-André Lureau The "serial" chardev calls qemu_chr_open_fd() with the same fd. This may lead to double-close as each QIOChannel owns the fd. Instead, share the reference to the same QIOChannel. Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 15 +-- 1 file change

Re: [PATCH 2/3] MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API"

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 12:24 PM, David Hildenbrand wrote: > On 23.07.21 12:23, Philippe Mathieu-Daudé wrote: >> On 7/23/21 12:05 PM, David Hildenbrand wrote: >>> Peter and myself volunteered to help out co-maintaining "Memory API" >>> with Paolo, so let's update the MAINTAINERS file. >> >> I'm very interested

[PATCH 1/4] chardev: fix qemu_chr_open_fd() being called with fd=-1

2021-07-23 Thread marcandre . lureau
From: Marc-André Lureau The "file" chardev may call qemu_chr_open_fd() with fd_in=-1. This may cause invalid system calls, as the QIOChannel is assumed to be properly initialized later on. Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 22 +- 1 file changed, 13 in

[PATCH 3/4] chardev: remove needless class method

2021-07-23 Thread marcandre . lureau
From: Marc-André Lureau "chr_option_parsed" is only implemented by the "mux" chardev, we can specialize the code there to avoid the needless generic class method. Signed-off-by: Marc-André Lureau --- include/chardev/char.h | 1 - chardev/char-mux.c | 6 ++ 2 files changed, 2 insertions

[PATCH 4/4] chardev: add some comments about the class methods

2021-07-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/chardev/char.h | 33 + 1 file changed, 33 insertions(+) diff --git a/include/chardev/char.h b/include/chardev/char.h index 589e7fe46d..2e4c16f82f 100644 --- a/include/chardev/char.h +++ b/inclu

[PATCH v2] nbd/server: Add --selinux-label option

2021-07-23 Thread Richard W.M. Jones
v1 was here: https://lists.nongnu.org/archive/html/qemu-block/2021-07/threads.html#00713 v2 adds the changes to CI docker files as suggested by Dan Berrange in his review. Rich.

[PATCH v2] nbd/server: Add --selinux-label option

2021-07-23 Thread Richard W.M. Jones
Under SELinux, Unix domain sockets have two labels. One is on the disk and can be set with commands such as chcon(1). There is a different label stored in memory (called the process label). This can only be set by the process creating the socket. When using SELinux + SVirt and wanting qemu to b

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-07-23 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 11:33:03AM +0100, Richard W.M. Jones wrote: > Under SELinux, Unix domain sockets have two labels. One is on the > disk and can be set with commands such as chcon(1). There is a > different label stored in memory (called the process label). This can > only be set by the pr

[PATCH-for-6.1 v3 0/4] gitlab-ci: Document custom CI/CD variables, fix 'when:' conditions

2021-07-23 Thread Philippe Mathieu-Daudé
- Document custom CI/CD variables (thuth) - Fix 'when:' condition (danpb) Supersedes: <20210722181322.516635-1-phi...@redhat.com> Philippe Mathieu-Daudé (4): docs: Document GitLab custom CI/CD variables gitlab-ci: Fix 'when:' condition in acceptance_test_job_template gitlab-ci: Fix 'when:'

[PATCH-for-6.1 v3 2/4] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template

2021-07-23 Thread Philippe Mathieu-Daudé
Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: f56bf4caf71 ("gitlab: Run Avocado tests manually (except mainstream CI)") Reported-by: Daniel P

[PATCH-for-6.1 v3 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs

2021-07-23 Thread Philippe Mathieu-Daudé
Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: 71920809cea ("gitlab-ci.yml: Add jobs to build EDK2 firmware binaries") Reported-by: Daniel P.

[PATCH-for-6.1 v3 1/4] docs: Document GitLab custom CI/CD variables

2021-07-23 Thread Philippe Mathieu-Daudé
We introduced the QEMU_CI_AVOCADO_TESTING variable in commit f56bf4caf ("gitlab: Run Avocado tests manually (except mainstream CI)"), but forgot to document it properly. Do it now. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/ci.rst | 40 +++

[PATCH-for-6.1 v3 4/4] gitlab-ci: Extract OpenSBI job rules and fix 'when:' condition

2021-07-23 Thread Philippe Mathieu-Daudé
First, all jobs depending on 'docker-opensbi' job must use at most all the rules that triggers it. The simplest way to ensure that is to always use the same rules. Extract all the rules to a reusable section, and include this section (with the 'extends' keyword) in both 'docker-opensbi' and 'build-

Re: [PATCH-for-6.1 v3 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs

2021-07-23 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 01:07:59PM +0200, Philippe Mathieu-Daudé wrote: > Jobs depending on another should not use the 'when: always' > condition, because if a dependency failed we should not keep > running jobs depending on it. The correct condition is > 'when: on_success'. > > Fixes: 71920809cea

Re: [PATCH-for-6.1 v3 1/4] docs: Document GitLab custom CI/CD variables

2021-07-23 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 01:07:57PM +0200, Philippe Mathieu-Daudé wrote: > We introduced the QEMU_CI_AVOCADO_TESTING variable in commit f56bf4caf > ("gitlab: Run Avocado tests manually (except mainstream CI)"), but > forgot to document it properly. Do it now. > > Suggested-by: Thomas Huth > Signed

Re: [PATCH-for-6.1 v3 2/4] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template

2021-07-23 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 01:07:58PM +0200, Philippe Mathieu-Daudé wrote: > Jobs depending on another should not use the 'when: always' > condition, because if a dependency failed we should not keep > running jobs depending on it. The correct condition is > 'when: on_success'. > > Fixes: f56bf4caf71

Re: [PATCH for-6.1] i386: do not call cpudef-only models functions for max, host, base

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 10:19 AM, Claudio Fontana wrote: > On 7/22/21 6:13 PM, Philippe Mathieu-Daudé wrote: >> On 7/22/21 10:38 AM, Claudio Fontana wrote: >> >> It seems the subject got dropped and the first line >> used as subject... But I'm not sure you want to >> start the description with it. > > hmm the

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
On 7/23/21 11:52 AM, Gerd Hoffmann wrote: >>> -g_assert(ops != NULL); >>> +if (ops == NULL) { >>> +exit(1); >>> +} >>> + >> >> >> Ah, again, why? >> This change looks wrong to me, >> >> the ops code should be present when ops interfaces are initialized: >> it should be a code l

[PATCH] target/i386: Added consistency checks for CR3

2021-07-23 Thread Lara Lazier
All MBZ in CR3 must be zero (APM2 15.5) Added checks in both helper_vmrun and helper_write_crN. When EFER.LMA is zero the upper 32 bits needs to be zeroed. Signed-off-by: Lara Lazier --- target/i386/tcg/sysemu/misc_helper.c | 7 +++ target/i386/tcg/sysemu/svm_helper.c | 10 +++--- 2 fi

[PATCH] target/i386: Added VGIF feature

2021-07-23 Thread Lara Lazier
VGIF allows STGI and CLGI to execute in guest mode and control virtual interrupts in guest mode. When the VGIF feature is enabled then: * executing STGI in the guest sets bit 9 of the VMCB offset 60h. * executing CLGI in the guest clears bit 9 of the VMCB offset 60h. Signed-off-by: Lara Lazier

[PATCH for-6.1 v2] i386: do not call cpudef-only models functions for max, host, base

2021-07-23 Thread Claudio Fontana
Some cpu properties have to be set only for cpu models in builtin_x86_defs, registered with x86_register_cpu_model_type, and not for cpu models "base", "max", and the subclass "host". These properties are the ones set by function x86_cpu_apply_props, (also including kvm_default_props, tcg_default_

[PATCH v2] gitlab: only let pages be published from default branch

2021-07-23 Thread Daniel P . Berrangé
GitLab will happily publish pages generated by the latest CI pipeline from any branch: https://docs.gitlab.com/ee/user/project/pages/introduction.html "Remember that GitLab Pages are by default branch/tag agnostic and their deployment relies solely on what you specify in .gitlab-ci.yml. Y

[PATCH] meson: fix dependencies for modinfo #2

2021-07-23 Thread Gerd Hoffmann
modinfo runs the preprocessor and therefore needs all generated input files to be there. The "depends" clause does not work in Meson 0.55.3, so for now use "input". Part #2: Update the rule for target-specific modules too. Signed-off-by: Gerd Hoffmann --- meson.build | 4 ++-- 1 file changed,

Re: [PATCH for 6.1 v2] ui/gtk: Fix relative mouse with multiple monitors

2021-07-23 Thread Gerd Hoffmann
On Tue, Jul 20, 2021 at 04:39:41PM +0200, Dennis Wölfing wrote: > To handle relative mouse input the event handler needs to move the mouse > away from the screen edges. Failing to do so results in the mouse > getting stuck at invisible walls. However the current implementation for > this is broken

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
On 7/23/21 1:20 PM, Claudio Fontana wrote: > On 7/23/21 11:52 AM, Gerd Hoffmann wrote: -g_assert(ops != NULL); +if (ops == NULL) { +exit(1); +} + >>> >>> >>> Ah, again, why? >>> This change looks wrong to me, >>> >>> the ops code should be present when

Re: [PATCH 2/3] MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API"

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 12:28:30PM +0200, Philippe Mathieu-Daudé wrote: > On 7/23/21 12:24 PM, David Hildenbrand wrote: > > On 23.07.21 12:23, Philippe Mathieu-Daudé wrote: > >> On 7/23/21 12:05 PM, David Hildenbrand wrote: > >>> Peter and myself volunteered to help out co-maintaining "Memory API"

Re: [PATCH 3/3] MAINTAINERS: Add memory_mapping.h and memory_mapping.c to "Memory API"

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 12:05:32PM +0200, David Hildenbrand wrote: > Both files logically belong to "Memory API" and are not yet listed > anywhere else explicitly. Let's add them to "Memory API". > > Cc: Peter Maydell > Cc: Paolo Bonzini > Cc: Peter Xu > Signed-off-by: David Hildenbrand Acked

Re: [PATCH v2] gitlab: only let pages be published from default branch

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 1:30 PM, Daniel P. Berrangé wrote: > GitLab will happily publish pages generated by the latest CI pipeline > from any branch: > > https://docs.gitlab.com/ee/user/project/pages/introduction.html > > "Remember that GitLab Pages are by default branch/tag agnostic >and their deployme

Re: [PATCH v2] gitlab: only let pages be published from default branch

2021-07-23 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 02:41:47PM +0200, Philippe Mathieu-Daudé wrote: > On 7/23/21 1:30 PM, Daniel P. Berrangé wrote: > > GitLab will happily publish pages generated by the latest CI pipeline > > from any branch: > > > > https://docs.gitlab.com/ee/user/project/pages/introduction.html > > > >

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Gerd Hoffmann
> > bool have_tcg = accel_find("tcg"); > > > > return true when the code is actually not there, there seems to be a larger > > issue to solve. > > > > I think we need to think more broadly about this. > > Overall, building the whole code base to be modular, > and then _not_ including unwanted m

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 09:50:18AM +0200, David Hildenbrand wrote: > On 22.07.21 19:41, Peter Xu wrote: > > On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: > > > I'll give it a churn. > > > > Thanks, David. > > > > Migration of a 8 GiB VM > * within the same host > * after Lin

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-23 Thread David Hildenbrand
On 23.07.21 14:51, Peter Xu wrote: On Fri, Jul 23, 2021 at 09:50:18AM +0200, David Hildenbrand wrote: On 22.07.21 19:41, Peter Xu wrote: On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: I'll give it a churn. Thanks, David. Migration of a 8 GiB VM * within the same host *

virtio-gpu: Mapping blob resources

2021-07-23 Thread Antonio Caggiano
Hi, I am trying to implement blob resource mapping support, but there is something I still did not manage to figure out. According to the spec, VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB maps a host-only blob resource into an offset in the host visible memory region. So, I believe I will need somethin

Re: [PATCH] target/i386: Added consistency checks for CR3

2021-07-23 Thread Paolo Bonzini
On 23/07/21 13:27, Lara Lazier wrote: All MBZ in CR3 must be zero (APM2 15.5) Added checks in both helper_vmrun and helper_write_crN. When EFER.LMA is zero the upper 32 bits needs to be zeroed. Signed-off-by: Lara Lazier --- target/i386/tcg/sysemu/misc_helper.c | 7 +++ target/i386/tcg/

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Jose R. Ziviani
On Fri, Jul 23, 2021 at 11:41:19AM +0200, Claudio Fontana wrote: > On 7/23/21 12:09 AM, Jose R. Ziviani wrote: > > When a module is not found, specially accelerators, QEMU displays > > a error message that not easy to understand[1]. This patch improves > > the readability by offering a user-friendl

Re: virtio-gpu: Mapping blob resources

2021-07-23 Thread Gerd Hoffmann
On Fri, Jul 23, 2021 at 03:33:24PM +0200, Antonio Caggiano wrote: > Hi, > > I am trying to implement blob resource mapping support, but there is > something I still did not manage to figure out. > > According to the spec, VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB maps a host-only > blob resource into an o

Re: [PATCH] target/i386: Added VGIF feature

2021-07-23 Thread Paolo Bonzini
On 23/07/21 13:27, Lara Lazier wrote: @@ -353,9 +358,12 @@ void helper_vmrun(CPUX86State *env, int aflag, int next_eip_addend) tlb_flush(cs); break; } - -env->hflags2 |= HF2_GIF_MASK; - +if (virtual_gif_enabled(env, int_ctl)) { +x86_stl_phys(cs, env->vm_

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
On 7/23/21 3:50 PM, Jose R. Ziviani wrote: > On Fri, Jul 23, 2021 at 11:41:19AM +0200, Claudio Fontana wrote: >> On 7/23/21 12:09 AM, Jose R. Ziviani wrote: >>> When a module is not found, specially accelerators, QEMU displays >>> a error message that not easy to understand[1]. This patch improves

Re: [PATCH] hw/intc/arm_gic: Fix set/clear pending of PPI/SPI

2021-07-23 Thread Sebastian Huber
On 09/07/2021 11:49, Sebastian Huber wrote: According to the GICv3 specification register GICD_ISPENDR0 is Banked for each connected PE with GICR_TYPER.Processor_Number < 8. For Qemu this is the case since GIC_NCPU == 8. For SPI, make the interrupt pending on all CPUs and not just the processor

Re: [PATCH] hw/intc/arm_gic: Fix set/clear pending of PPI/SPI

2021-07-23 Thread Philippe Mathieu-Daudé
Cc'ing qemu-arm@ On 7/9/21 11:49 AM, Sebastian Huber wrote: > According to the GICv3 specification register GICD_ISPENDR0 is Banked for each > connected PE with GICR_TYPER.Processor_Number < 8. For Qemu this is the case > since GIC_NCPU == 8. > > For SPI, make the interrupt pending on all CPUs a

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 4:02 PM, Claudio Fontana wrote: > On 7/23/21 3:50 PM, Jose R. Ziviani wrote: >> On Fri, Jul 23, 2021 at 11:41:19AM +0200, Claudio Fontana wrote: >>> On 7/23/21 12:09 AM, Jose R. Ziviani wrote: When a module is not found, specially accelerators, QEMU displays a error message tha

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cleber Rosa
wangyanan (Y) writes: > Hi Cleber, > > On 2021/7/23 6:25, Cleber Rosa wrote: >> Yanan Wang writes: >> >>> In the SMP configuration, we should either specify a topology >>> parameter with a reasonable value (equal to or greater than 1) >>> or just leave it omitted and QEMU will calculate its valu

  1   2   3   >