> > - g_assert(ops != NULL);
> > + if (ops == NULL) {
> > + exit(1);
> > + }
> > +
>
>
> Ah, again, why?
> This change looks wrong to me,
>
> the ops code should be present when ops interfaces are initialized:
> it should be a code level assertion, as it has to do with the proper order of
> initializations in QEMU,
>
> why would we want to do anything else but to assert here?
>
> Am I blind to something obvious?
Building tcg accel ops modular moves that from coding error to possible
user error (user wants use tcg but has qemu-accel-tcg-$arch.rpm not
installed).
The second part of the patch makes qemu print a message on the failed
module load, so the user would have a chance to figure where the assert
comes from, but replacing the assert with a more friendly message still
makes sense to me.
take care,
Gerd
