> > bool have_tcg = accel_find("tcg");
> >
> > return true when the code is actually not there, there seems to be a larger
> > issue to solve.
> >
> > I think we need to think more broadly about this.
>
> Overall, building the whole code base to be modular,
> and then _not_ including unwanted modules in the base distro package,
> is the whole point of going through this at all.
Yes.
Right now we are only half-through. tcg-accel-ops is modular, but
tcg-accel is not (yet). Which I guess is why the assert() can trigger
now.
So add a patch with error message and a FIXME comment, which we can
revert when isn't needed any more?
> So we need more work to make this actually work right.
Yes. I want have all of tcg in the tcg accel module, not only parts of
it, but that needs some more refactoring. I'll go start looking at this
once I managed to wade through my vacation backlog.
take care,
Gerd
