Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message

2020-09-01 Thread Laurent Vivier
Le 17/07/2020 à 14:35, Kenta Ishiguro a écrit : > Fix a typo in an error message for KVM_SET_IRQCHIP ioctl: > "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP". > > Signed-off-by: Kenta Ishiguro > --- > hw/i386/kvm/ioapic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw

Re: [PATCH 4/6] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot

2020-09-01 Thread Edgar E. Iglesias
On Mon, Aug 31, 2020 at 11:40:16AM -0700, Richard Henderson wrote: > It is legal to put an mts instruction into a delay slot. > We should continue to return to the main loop in that > case so that we recognize any pending interrupts. > > Signed-off-by: Richard Henderson > --- > target/microblaze

Re: [PATCH-for-5.1 v2] hw/isa/isa-superio: Fix IDE controller realization

2020-09-01 Thread Laurent Vivier
Le 21/07/2020 à 14:45, Philippe Mathieu-Daudé a écrit : > When realizing a Super I/O with IDE controller [*], we get: > > qom/object.c:1684: object_property_try_add_child: Assertion > `!child->parent' failed. > Aborted (core dumped) > > This is because the device is already realized when we

[PATCH v2] meson: use pkg-config method to find dependencies

2020-09-01 Thread Paolo Bonzini
We do not need to ask cmake for the dependencies, so just use the pkg-config mechanism. Keep "auto" for SDL so that it tries using sdl-config too. The documentation is adjusted to use SDL2_image as the example, rather than SDL which does not use the "pkg-config" method. Signed-off-by: Paolo Bonz

Re: [PATCH 0/6] target/microblaze: Use tcg_gen_lookup_and_goto_ptr

2020-09-01 Thread Edgar E. Iglesias
On Mon, Aug 31, 2020 at 11:40:12AM -0700, Richard Henderson wrote: > Based-on: <20200831160601.833692-1-richard.hender...@linaro.org> > ("[PULL 00/76] target/microblaze improvements") > > Hello again, Edgar. > > I had dropped the tcg_gen_lookup_and_goto_ptr patch from the > previous omnibus patch

Re: [PATCH-for-5.2] stubs/cmos: Use correct include

2020-09-01 Thread Laurent Vivier
Le 24/07/2020 à 10:43, Philippe Mathieu-Daudé a écrit : > cmos_get_fd_drive_type() is declared in "hw/block/fdc.h". > This currently works because "hw/i386/pc.h" happens to > include it. Simplify including the correct header. > > Fixes: 2055dbc1c9 ("acpi: move aml builder code for floppy device")

Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region

2020-09-01 Thread Gerd Hoffmann
Hi, > +/* wraparound */ > +memory_region_set_dirty(&s->vga.vram, off_cur, > s->cirrus_addr_mask - off_cur); > So the len is 's->cirrus_addr_mask->off_cur+1'. Correct. > +memory_region_set_dirty(&s->vga.vram, 0, off_cur_end); > > For the 'off_cur_end' here,

Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation

2020-09-01 Thread Laurent Vivier
Le 27/08/2020 à 15:03, Peter Maydell a écrit : > On Thu, 27 Aug 2020 at 14:00, Tianjia Zhang > wrote: >> Other opinions needed? > > No, the patch just got lost by accident; sorry. > > Jason, could you take this via your net tree, please? > > thanks > -- PMM > >> >> On 7/27/20 5:44 PM, Michael

Re: [RFC PATCH v4 1/2] hw/riscv: sifive_u: Add backend drive support

2020-09-01 Thread Green Wan
Hi Bin, Thanks for the remindings. I didn't notice the write operation and will add the write functionality based on bit by bit mechanism. Regards, Green On Fri, Aug 28, 2020 at 8:54 PM Bin Meng wrote: > > Hi Green, > > On Thu, Aug 27, 2020 at 3:47 PM Green Wan wrote: > > > > Add '-drive' sup

[PATCH v6 02/16] icount: rename functions to be consistent with the module name

2020-09-01 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- accel/tcg/cpu-exec.c| 4 ++-- docs/replay.txt | 6 +++--- include/sysemu/cpu-timers.h | 16 +++--- include/sysemu/replay.h | 4 ++-- replay/replay.c | 2 +- softmmu/cpu-timers.c| 4 ++-- softmmu/cpus.c

[PATCH v6 04/16] cpus: extract out TCG-specific code to accel/tcg

2020-09-01 Thread Claudio Fontana
TCG is the first accelerator to register a "CpusAccel" interface on initialization, providing functions for starting a vcpu, kicking a vcpu, sychronizing state and getting virtual clock and ticks. Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daud

[PATCH v6 07/16] cpus: extract out hax-specific code to target/i386/

2020-09-01 Thread Claudio Fontana
register a "CpusAccel" interface for HAX as well. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- softmmu/cpus.c| 80 +--- target/i386/hax-all.c | 6 ++- target/i386/hax-cpus.c| 85 +++ ta

[PATCH v6 09/16] cpus: extract out hvf-specific code to target/i386/hvf/

2020-09-01 Thread Claudio Fontana
register a "CpusAccel" interface for HVF as well. Signed-off-by: Claudio Fontana Reviewed-by: Roman Bolshakov [added const] Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- softmmu/cpus.c | 66 -- target/i386/hvf/hvf-cpus.c | 131 +++

[PATCH v6 01/16] cpu-timers, icount: new modules

2020-09-01 Thread Claudio Fontana
refactoring of cpus.c continues with cpu timer state extraction. cpu-timers: responsible for the softmmu cpu timers state, including cpu clocks and ticks. icount: counts the TCG instructions executed. As such it is specific to the TCG accelerator. Therefore, it is built only under CON

[PATCH v6 10/16] cpus: cleanup now unneeded includes

2020-09-01 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- softmmu/cpus.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 2420a447eb..3d8350fba9 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -29,20 +29,13 @@ #include "qapi/qapi-comman

[PATCH v6 00/16] QEMU cpus.c refactoring part2

2020-09-01 Thread Claudio Fontana
Motivation and higher level steps: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html Main Open topics: * in some cases the virtual clock is queried before an accelerator is set or ticks are enabled with qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) by the qcow2.c code (ending

[PATCH v6 03/16] cpus: prepare new CpusAccel cpu accelerator interface

2020-09-01 Thread Claudio Fontana
The new interface starts unused, will start being used by the next patches. It provides methods for each accelerator to start a vcpu, kick a vcpu, synchronize state, get cpu virtual clock and elapsed ticks. In qemu_wait_io_event, make it clear that APC is used only for HAX on Windows. Signed-off

[PATCH v6 12/16] cpus: add handle_interrupt to the CpusAccel interface

2020-09-01 Thread Claudio Fontana
kvm: uses the generic handler qtest: uses the generic handler whpx: changed to use the generic handler (identical implementation) hax: changed to use the generic handler (identical implementation) hvf: changed to use the generic handler (identical implementation) tcg: adapt tcg-cpus to point to the

[PATCH v6 13/16] hvf: remove hvf specific functions from global includes

2020-09-01 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- accel/stubs/hvf-stub.c | 30 -- accel/stubs/meson.build| 1 - include/sysemu/hvf.h | 8 target/i386/hvf/hvf-cpus.h | 8 target/i386/hvf/x86hvf.c | 2 ++ target/i386

[PATCH v6 06/16] cpus: extract out kvm-specific code to accel/kvm

2020-09-01 Thread Claudio Fontana
register a "CpusAccel" interface for KVM as well. Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [added const] Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- accel/kvm/kvm-all.c| 14 ++- accel/kvm/kvm-cpus.c |

[PATCH v6 14/16] whpx: remove whpx specific functions from global includes

2020-09-01 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- accel/stubs/meson.build | 1 - accel/stubs/whpx-stub.c | 47 - include/sysemu/whpx.h | 19 - target/i386/whpx-cpus.h | 17 +++ 4 files changed, 17 insertions(+

[PATCH v6 08/16] cpus: extract out whpx-specific code to target/i386/

2020-09-01 Thread Claudio Fontana
register a "CpusAccel" interface for WHPX as well. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- MAINTAINERS | 1 + softmmu/cpus.c | 79 - target/i386/meson.build | 5 ++- target/i386/whpx-all.c | 3 ++ target/i386/whp

[PATCH v6 05/16] cpus: extract out qtest-specific code to accel/qtest

2020-09-01 Thread Claudio Fontana
register a "CpusAccel" interface for qtest as well. Signed-off-by: Claudio Fontana --- MAINTAINERS | 2 +- accel/meson.build | 2 +- accel/qtest/meson.build | 7 +++ accel/qtest/qtest-cpus.c | 91 +++ accel/qtest/qtest-cpus.h | 17

[PATCH] configure: remove dead code for in-tree builds

2020-09-01 Thread Paolo Bonzini
The $pwd_is_source_path variable is never "y", since configure re-executes itself from a build directory. Remove code that will never run. Cc: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/config

[PATCH v6 11/16] cpus: remove checks for non-NULL cpus_accel

2020-09-01 Thread Claudio Fontana
now that all accelerators support the CpusAccel interface, we can remove most checks for non-NULL cpus_accel, we just add a sanity check/assert at vcpu creation. Signed-off-by: Claudio Fontana --- softmmu/cpus.c | 33 + 1 file changed, 21 insertions(+), 12 deletio

Re: [PATCH-for-5.2 2/2] hw/core/sysbus: Assert memory region index is in range

2020-09-01 Thread Laurent Vivier
Le 06/08/2020 à 15:09, Philippe Mathieu-Daudé a écrit : > Devices incorrectly modelled might use invalid index while > calling sysbus_mmio_get_region(), leading to OOB access. > Help developers by asserting the index is in range. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/sysbus.c

[PATCH v6 15/16] hax: remove hax specific functions from global includes

2020-09-01 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- accel/stubs/hax-stub.c| 10 -- include/sysemu/hax.h | 17 - target/i386/hax-all.c | 1 - target/i386/hax-cpus.c| 1 - target/i386/hax-cpus.h| 16 target/i386/hax-mem.

Re: [PATCH-for-5.2 1/2] hw/core/sysbus: Fix a typo

2020-09-01 Thread Laurent Vivier
Le 06/08/2020 à 15:09, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/sysbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c > index 70239b7e7d..77ab351ce1 100644 > --- a/hw/core/sysbus.c > +

[PATCH v6 16/16] kvm: remove kvm specific functions from global includes

2020-09-01 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- accel/kvm/kvm-cpus.h | 7 +++ accel/stubs/kvm-stub.c | 22 -- include/sysemu/kvm.h | 7 --- 3 files changed, 7 insertions(+), 29 deletions(-) diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpu

Re: [PATCH] docs: Fix broken links

2020-09-01 Thread Laurent Vivier
Le 07/08/2020 à 12:17, Han Han a écrit : > Signed-off-by: Han Han > --- > docs/amd-memory-encryption.txt | 4 ++-- > docs/pvrdma.txt| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt > index

Re: [PATCH-for-5.2] Revert "mailmap: Update philmd email address"

2020-09-01 Thread Laurent Vivier
Le 06/08/2020 à 15:58, Philippe Mathieu-Daudé a écrit : > This mailmap entry does not work as I expected. I am receiving > emails related to my hobbyist contributions in my work mailbox > and I get distracted :) Remove the entry to keep things separated. > > This reverts commit 289371239153b24cb7b

Re: [kvm-unit-tests RFC 4/4] spe: Test Profiling Buffer Events

2020-09-01 Thread Auger Eric
Hi, On 8/31/20 9:34 PM, Eric Auger wrote: > Setup the infrastructure to check the occurence of events. > The test checks the Buffer Full event occurs when no space > is available. The PPI is handled and we check the syndrome register > against the expected event. > > Signed-off-by: Eric Auger >

RE: [PATCH v4 5/7] misc: Add versal-usb2-regs module

2020-09-01 Thread Sai Pavan Boddu
Hi Gred, > -Original Message- > From: Gerd Hoffmann > Sent: Monday, August 31, 2020 12:33 PM > To: Sai Pavan Boddu > Cc: Peter Maydell ; Markus Armbruster > ; 'Marc-André Lureau' > ; Paolo Bonzini ; > Edgar Iglesias ; Francisco Eduardo Iglesias > ; qemu-devel@nongnu.org; Alistair Francis

Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region

2020-09-01 Thread Li Qiang
Gerd Hoffmann 于2020年9月1日周二 下午3:16写道: > > Hi, > > > +/* wraparound */ > > +memory_region_set_dirty(&s->vga.vram, off_cur, > > s->cirrus_addr_mask - off_cur); > > > So the len is 's->cirrus_addr_mask->off_cur+1'. > > Correct. So do you agree me the first set size should be

[Bug 1893744] [NEW] meson: incomplete 'make help'

2020-09-01 Thread Philippe Mathieu-Daudé
Public bug reported: Since the meson switch, 'make help' doesn't list various targets. Diff before/after: --- Generic targets: all- Build all dir/file.o - Build specified target only install- Install QEMU ctags/

Re: [PATCH v2 2/7] vhost: check queue state in the vhost_dev_set_log routine

2020-09-01 Thread Dima Stepanov
On Mon, Aug 31, 2020 at 11:22:14PM -0400, Raphael Norwitz wrote: > On Mon, Aug 31, 2020 at 4:37 AM Dima Stepanov wrote: > > > > On Thu, Aug 27, 2020 at 09:46:03PM -0400, Raphael Norwitz wrote: > > > On Mon, Aug 24, 2020 at 4:41 AM Dima Stepanov > > > wrote: > > > > > > > > If the vhost-user-blk

Re: [PATCH] cirrus.yml: Split FreeBSD job into two parts

2020-09-01 Thread Daniel P . Berrangé
On Mon, Aug 31, 2020 at 05:44:05PM +0200, Thomas Huth wrote: > The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI. > We have to split the build targets here to make sure that the job > finishes in time again. According to the Cirrus-CI docs and some > tests that I did, it also seems

Re: [PATCH] configure: remove dead code for in-tree builds

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 03:24:06AM -0400, Paolo Bonzini wrote: > The $pwd_is_source_path variable is never "y", since > configure re-executes itself from a build directory. > Remove code that will never run. > > Cc: Daniel P. Berrangé > Signed-off-by: Paolo Bonzini > --- > configure | 14 ++

Re: [PATCH v2] .mailmap: Update Paul Burton email address

2020-09-01 Thread Laurent Vivier
Le 07/07/2020 à 04:25, Philippe Mathieu-Daudé a écrit : > Following the Linux kernel equivalent patch posted on > linux-m...@vger.kernel.org [*], update Paul Burton email > address to avoid emails bouncing. > > [*] 'MAINTAINERS: Use @kernel.org address for Paul Burton' > https://lore.kernel.org/pa

Re: [PATCH-for-5.2 0/3] trivial: Remove 'and and' in descriptions

2020-09-01 Thread Laurent Vivier
Le 11/08/2020 à 17:16, Philippe Mathieu-Daudé a écrit : > Remove duplicated 'and' in comments. > > Philippe Mathieu-Daudé (3): > hw/i2c: Fix typo in description > util/qemu-timer: Fix typo in description > util/vfio-helpers: Fix typo in description > > include/hw/i2c/i2c.h | 2 +- > util/q

[PULL 00/24] Meson changes for 2020-09-01

2020-09-01 Thread Paolo Bonzini
The following changes since commit 2f4c51c0f384d7888a04b4815861e6d5fd244d75: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20200831-pull-request' into staging (2020-08-31 19:39:13 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream f

[PULL 09/24] build-sys: remove install target from Makefile

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Now covered by meson Signed-off-by: Marc-André Lureau Message-Id: <20200826130622.553318-7-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile | 5 - 1 file changed, 5 deletions(-) diff --git a/Makefile b/Makefile index 9a9e7c0301..75db8be52e 10

[PULL 01/24] meson: bump submodule to 0.55.1

2020-09-01 Thread Paolo Bonzini
This version includes an important bugfix to avoid including unnecessary -Wl,-rpath flags. It also avoids the warnings on custom_targets with more than one output. Reported-by: Laurent Vivier Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Paolo Bonzini --- configure | 2

[PULL 03/24] meson: fix SDL2_image detection

2020-09-01 Thread Paolo Bonzini
From: Volker Rümelin Configure used to probe for SDL2_image in sdl_image_probe (). Meson should do the same. This fixes the following error on my system: Run-time dependency sdl2 found: YES 2.0.8 Found CMake: /usr/bin/cmake (3.17.0) Run-time dependency sdl-image found: NO (tried pkgconfig and c

[PULL 02/24] block: always link with zlib

2020-09-01 Thread Paolo Bonzini
The qcow2 driver needs the zlib dependency. While emulators provided it through the migration code, this is not true of the tools. Move the dependency from the qcow1 rule directly into block_ss so that it is included unconditionally. Fixes build with --disable-qcow1. Reported-by: Thomas Huth R

[PULL 06/24] meson: install icons

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200826130622.553318-4-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile | 12 ui/icons/meson.build | 13 + ui/meson.build | 1 + 3 files changed, 14 insertio

[PULL 08/24] meson: install $localstatedir/run for qga

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200826130622.553318-6-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile| 10 +- qga/meson.build | 2 ++ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefi

[PULL 05/24] meson: install scripts/qemu-trace-stap

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200826130622.553318-3-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile| 3 --- meson.build | 1 + scripts/meson.build | 3 +++ 3 files changed, 4 insertions(+), 3 deletions(-) cre

[PULL 07/24] meson: install desktop file

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200826130622.553318-5-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile | 3 --- ui/meson.build | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index d1

[PULL 21/24] configure: do not include ${prefix} in firmwarepath

2020-09-01 Thread Paolo Bonzini
Left out in commit 22a87800e6 ("configure: expand path variables for meson configure", 2020-08-21), do it now. Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b9e977f13d..8a3acef89d 100755 --- a/configure

[PULL 10/24] meson: move zlib detection to meson

2020-09-01 Thread Paolo Bonzini
Meson includes the same logic that tries to look for -lz if pkg-config (and cmake) cannot find zlib. The undocumented --disable-zlib-test option becomes a no-op. There is still an instance of "-lz" in the LIBS directory. It will go away as soon as tests are converted to meson, because the zlib de

[PULL 04/24] meson: install pc-bios blobs

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200826130622.553318-2-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile| 31 -- pc-bios/meson.build | 63 + 2 files changed,

[PULL 22/24] meson: use pkg-config method to find dependencies

2020-09-01 Thread Paolo Bonzini
We do not need to ask cmake for the dependencies, so just use the pkg-config mechanism. Keep "auto" for SDL so that it tries using sdl-config too. The documentation is adjusted to use SDL2_image as the example, rather than SDL which does not use the "pkg-config" method. Signed-off-by: Paolo Bonz

[PULL 14/24] meson: pass qemu_suffix option

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau The following patches will make use of it to fix installation paths. Signed-off-by: Marc-André Lureau Message-Id: <20200826110419.528931-5-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 1 + meson_options.txt | 2 ++ 2 files changed,

[PATCH v8 1/8] Introduce yank feature

2020-09-01 Thread Lukas Straub
The yank feature allows to recover from hanging qemu by "yanking" at various parts. Other qemu systems can register themselves and multiple yank functions. Then all yank functions for selected instances can be called by the 'yank' out-of-band qmp command. Available instances can be queried by a 'qu

[PULL 11/24] configure: rename confsuffix option

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau The value is used to construct conf/mod/data directories. Signed-off-by: Marc-André Lureau Message-Id: <20200826110419.528931-2-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 delet

[PULL 12/24] configure: always /-seperate directory from qemu_suffix

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Otherwise, we may accept very strange directory names... While at it, quote the variables. Signed-off-by: Marc-André Lureau Message-Id: <20200826110419.528931-3-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 14 +++--- 1 file changed

[PULL 13/24] configure: build docdir like other suffixed directories

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau As documented in --help for --docdir. Signed-off-by: Marc-André Lureau Message-Id: <20200826110419.528931-4-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/co

[PULL 18/24] meson: add NSIS building

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20200826110419.528931-9-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile| 56 --- meson.build | 25 scripts/

[PULL 17/24] meson: use meson mandir instead of qemu_mandir

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau When cross-compiling, by default qemu_mandir is 'c:\Program Files\QEMU', which is not recognized as being an absolute path, and meson will end up adding the prefix again. Use the pre-prefixed meson mandir option instead. Reviewed-by: Daniel P. Berrangé Signed-off-by: Ma

[PULL 23/24] build: fix recurse-all target

2020-09-01 Thread Paolo Bonzini
The missing "/all" suffix prevents the pc-bios/ parts of the build from running. In the meanwhile, -Wall has moved from QEMU_CFLAGS to CFLAGS. Simplify everything by not passing down CFLAGS, and add -Wall in the recursive Makefiles. Reported-by: Miroslav Rezanina Reviewed-by: Miroslav Rezanina

[PULL 16/24] meson: pass docdir option

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' which is not recognized as being an absolute path, and meson will end up adding the prefix again. Add an option to pass docdir location to meson, pre-prefixed like we do with other directories, build

[PULL 15/24] meson: use meson datadir instead of qemu_datadir

2020-09-01 Thread Paolo Bonzini
From: Marc-André Lureau When cross-compiling, by default qemu_datadir is 'c:\Program Files\QEMU', which is not recognized as being an absolute path, and meson will end up adding the prefix again. Signed-off-by: Marc-André Lureau Message-Id: <20200826110419.528931-6-marcandre.lur...@redhat.com>

[PULL 19/24] meson: add pixman dependency to chardev/baum module

2020-09-01 Thread Paolo Bonzini
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200830204640.482214-1...@weilnetz.de> Signed-off-by: Paolo Bonzini --- chardev/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/meson.build b/chardev/meson.bu

Re: [PATCH] mailmap: Add entry for Greg Kurz

2020-09-01 Thread Laurent Vivier
Le 12/08/2020 à 17:37, Greg Kurz a écrit : > I had stopped using gk...@linux.vnet.ibm.com a while back already but > this email address was shutdown last June when I quit IBM. It's about > time to map it to gr...@kaod.org. > > Signed-off-by: Greg Kurz > --- > .mailmap |1 + > 1 file changed,

[PULL 20/24] meson: add pixman dependency to UI modules

2020-09-01 Thread Paolo Bonzini
Pixman used to be included directly in QEMU_CFLAGS and therefore the include path was added to every compiler invocation. Now that (just like basically everything else) it is a separate dependency, we need to add it to all build target, especially UI modules that need it due to their including ui/

[PATCH v8 4/8] migration: Add yank feature

2020-09-01 Thread Lukas Straub
Register yank functions on sockets to shut them down. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Acked-by: Dr. David Alan Gilbert --- migration/channel.c | 12 migration/migration.c | 25 + migration/multifd.c | 10 +++

[PATCH v8 3/8] chardev/char-socket.c: Add yank feature

2020-09-01 Thread Lukas Straub
Register a yank function to shutdown the socket on yank. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- chardev/char-socket.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-soc

[PULL 24/24] meson: add description to options

2020-09-01 Thread Paolo Bonzini
This will be useful in the future to generate configure command line parsing from meson_options.txt. Signed-off-by: Paolo Bonzini --- meson_options.txt | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index c

[PATCH v8 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-09-01 Thread Lukas Straub
Hello Everyone, So here is v8. We still need ACKs from NBD and chardev maintainers. Changes: v8: -add Reviewed-by and Acked-by tags -rebase onto master -minor change to migration -convert to meson -change "Since:" to 5.2 -varios code style fixes (Markus Armbruster) -point to oob restrict

Re: [PATCH 0/7] block: Use definitions instead of magic values

2020-09-01 Thread Laurent Vivier
Le 14/08/2020 à 10:28, Philippe Mathieu-Daudé a écrit : > Trivial block patches: > - Fix a typo > - Replace '1 << 30' by '1 * GiB' in null-co > - Replace 512 by BDRV_SECTOR_SIZE when appropriate. > > Philippe Mathieu-Daudé (7): > block/null: Make more explicit the driver default size is 1GiB >

Re: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS

2020-09-01 Thread Laurent Vivier
Le 12/08/2020 à 17:53, Thomas Huth a écrit : > The examples look nicer when using "::" code blocks. > Also mention that "-d in_asm" only outputs instructions that have not > been translated by the JIT layer yet. > And while we're at it, also add the AVR doc file to the MAINTAINERS file. > > Signed

[PATCH v8 6/8] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown

2020-09-01 Thread Lukas Straub
Migration and yank code assume that qio_channel_shutdown is thread -safe and can be called from qmp oob handler. Document this after checking the code. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi --- include/io/channel.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH] hw/net/xilinx_axienet: Remove unused code

2020-09-01 Thread Laurent Vivier
Le 14/08/2020 à 15:30, Philippe Mathieu-Daudé a écrit : > Most of the MDIOBus fields are unused. The ADVERTISE_10HALF > definition is unused. Remove unused code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/xilinx_axienet.c | 23 --- > 1 file changed, 23 deletio

Re: [PATCH 01/13] fuzz: use qemu_get_exec_dir

2020-09-01 Thread Thomas Huth
On 01/09/2020 08.20, Paolo Bonzini wrote: > Make things consistent with how softmmu/vl.c uses os_find_datadir. > Initializing the path to the executables will also be needed for > get_relocatable_path to work. > > Signed-off-by: Paolo Bonzini > --- > tests/qtest/fuzz/fuzz.c | 3 ++- > 1 file cha

Re: [PATCH v6 13/16] hvf: remove hvf specific functions from global includes

2020-09-01 Thread Roman Bolshakov
On Tue, Sep 01, 2020 at 09:21:58AM +0200, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > Reviewed-by: Richard Henderson > --- > accel/stubs/hvf-stub.c | 30 -- > accel/stubs/meson.build| 1 - > include/sysemu/hvf.h | 8 > target/i38

[PATCH v8 2/8] block/nbd.c: Add yank feature

2020-09-01 Thread Lukas Straub
Register a yank function which shuts down the socket and sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- block/nbd.c | 129 -

Re: [PATCH v6 11/16] cpus: remove checks for non-NULL cpus_accel

2020-09-01 Thread Roman Bolshakov
On Tue, Sep 01, 2020 at 09:21:56AM +0200, Claudio Fontana wrote: > now that all accelerators support the CpusAccel interface, > we can remove most checks for non-NULL cpus_accel, > we just add a sanity check/assert at vcpu creation. > > Signed-off-by: Claudio Fontana > --- > softmmu/cpus.c | 33

Re: [PATCH v4 9/9] scsi/scsi_bus: fix races in REPORT LUNS

2020-09-01 Thread Maxim Levitsky
On Mon, 2020-08-31 at 18:01 +0300, Maxim Levitsky wrote: > Currently scsi_target_emulate_report_luns iterates > over child devices list twice, and there is guarantee, that > it will not be changed meanwhile. > > This reason for two loops is that it needs to know how much memory > to allocate. > >

Re: [PATCH] util/vfio-helpers: Unify trace-events size format

2020-09-01 Thread Laurent Vivier
Le 20/08/2020 à 19:10, Philippe Mathieu-Daudé a écrit : > Some 'qemu_vfio_*' trace events sizes are displayed using > decimal notation, other using hexadecimal notation: > > qemu_vfio_ram_block_added s 0xf2448d90 host 0x5bc0 size > 0x400 > qemu_vfio_dma_map s 0xf2448d90 ho

[PATCH v8 5/8] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe

2020-09-01 Thread Lukas Straub
Make qio_channel_tls_shutdown thread-safe by using atomics when accessing tioc->shutdown. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- io/channel-tls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/channel-tls.c b/io/c

Re: [PATCH v6 12/16] cpus: add handle_interrupt to the CpusAccel interface

2020-09-01 Thread Roman Bolshakov
On Tue, Sep 01, 2020 at 09:21:57AM +0200, Claudio Fontana wrote: > kvm: uses the generic handler > qtest: uses the generic handler > whpx: changed to use the generic handler (identical implementation) > hax: changed to use the generic handler (identical implementation) > hvf: changed to use the gen

[PATCH v8 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test

2020-09-01 Thread Lukas Straub
A connecting chardev object has an additional reference by the connecting thread, so if the chardev is still connecting by the end of the test, then the chardev object won't be freed. This in turn means that the yank instance won't be unregistered and when running the next test-case yank_register_i

[PATCH v8 7/8] MAINTAINERS: Add myself as maintainer for yank feature

2020-09-01 Thread Lukas Straub
I'll maintain this for now as the colo usecase is the first user of this functionality. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5a22c8be42..c1

Re: [PATCH v3 08/16] hw/riscv: microchip_pfsoc: Connect a Cadence SDHCI controller and an SD card

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 3:39 AM, Bin Meng wrote: > From: Bin Meng > > Microchip PolarFire SoC integrates one Cadence SDHCI controller. > On the Icicle Kit board, one eMMC chip and an external SD card > connect to this controller depending on different configuration. > > As QEMU does not support eMMC yet, we j

Re: [PATCH v6 11/16] cpus: remove checks for non-NULL cpus_accel

2020-09-01 Thread Claudio Fontana
On 9/1/20 11:34 AM, Roman Bolshakov wrote: > On Tue, Sep 01, 2020 at 09:21:56AM +0200, Claudio Fontana wrote: >> now that all accelerators support the CpusAccel interface, >> we can remove most checks for non-NULL cpus_accel, >> we just add a sanity check/assert at vcpu creation. >> >> Signed-off-b

Re: [PATCH v8 1/8] Introduce yank feature

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 11:15:07AM +0200, Lukas Straub wrote: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the 'yank

Re: [PATCH] usb: call usb_packet_cleanup on usb_packet_map failure

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 7:27 AM, Gerd Hoffmann wrote: Reported-by: Prasad J Pandit > Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé > --- > hw/usb/hcd-ehci.c | 2 ++ > hw/usb/hcd-xhci.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c > i

Re: [PATCH v8 4/8] migration: Add yank feature

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 11:15:18AM +0200, Lukas Straub wrote: > Register yank functions on sockets to shut them down. > > Signed-off-by: Lukas Straub > Acked-by: Stefan Hajnoczi > Acked-by: Dr. David Alan Gilbert > --- > migration/channel.c | 12 > migration/migration.c

Re: [PATCH v8 6/8] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 11:15:25AM +0200, Lukas Straub wrote: > Migration and yank code assume that qio_channel_shutdown is thread > -safe and can be called from qmp oob handler. Document this after > checking the code. > > Signed-off-by: Lukas Straub > Acked-by: Stefan Hajnoczi > --- > include

Re: [PATCH v3 15/16] hw/riscv: clint: Avoid using hard-coded timebase frequency

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 3:39 AM, Bin Meng wrote: > From: Bin Meng > > At present the CLINT timestamp is using a hard-coded timebase > frequency value SIFIVE_CLINT_TIMEBASE_FREQ. This might not be > true for all boards. > > Add a new 'timebase-freq' property to the CLINT device, and > update various functions

Re: [PATCH v6 12/16] cpus: add handle_interrupt to the CpusAccel interface

2020-09-01 Thread Claudio Fontana
On 9/1/20 11:38 AM, Roman Bolshakov wrote: > On Tue, Sep 01, 2020 at 09:21:57AM +0200, Claudio Fontana wrote: >> kvm: uses the generic handler >> qtest: uses the generic handler >> whpx: changed to use the generic handler (identical implementation) >> hax: changed to use the generic handler (identi

Re: [PATCH v3 01/16] target/riscv: cpu: Add a new 'resetvec' property

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 3:38 AM, Bin Meng wrote: > From: Bin Meng > > Currently the reset vector address is hard-coded in a RISC-V CPU's > instance_init() routine. In a real world we can have 2 exact same > CPUs except for the reset vector address, which is pretty common in > the RISC-V core IP licensing busin

Re: [PATCH v3 02/16] hw/riscv: hart: Add a new 'resetvec' property

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 3:38 AM, Bin Meng wrote: > From: Bin Meng > > RISC-V machines do not instantiate RISC-V CPUs directly, instead > they do that via the hart array. Add a new property for the reset > vector address to allow the value to be passed to the CPU, before > CPU is realized. > > Signed-off-by: B

[PATCH] piix4: don't reserve hw resources when hotplug is off globally

2020-09-01 Thread Ani Sinha
When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related amls for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case acpi pci hotplug is off globally.

Re: [kvm-unit-tests RFC 0/4] KVM: arm64: Statistical Profiling Extension Tests

2020-09-01 Thread Alexandru Elisei
Hi Eric, These patches are extremely welcome! I took over the KVM SPE patches from Andrew Murray, and I was working on something similar to help with development. The KVM series on the public mailing list work only by chance because it is impossible to reliably map the SPE buffer at EL2 when prof

Re: [PATCH v7 4/8] ppc/e500: Use start-powered-off CPUState property

2020-09-01 Thread Philippe Mathieu-Daudé
On 8/26/20 7:55 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use > the start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Also change creation of CPU object from cpu_create() to object_new()

Re: [PATCH v3 03/16] target/riscv: cpu: Set reset vector based on the configured property value

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 3:38 AM, Bin Meng wrote: > From: Bin Meng > > Now that we have the newly introduced 'resetvec' property in the > RISC-V CPU and HART, instead of hard-coding the reset vector addr > in the CPU's instance_init(), move that to riscv_cpu_realize() > based on the configured property value fr

Re: [PATCH v3 11/16] hw/net: cadence_gem: Add a new 'phy-addr' property

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 3:39 AM, Bin Meng wrote: > From: Bin Meng > > At present the PHY address of the PHY connected to GEM is hard-coded > to either 23 (BOARD_PHY_ADDRESS) or 0. This might not be the case for > all boards. Add a new 'phy-addr' property so that board can specify > the PHY address for each GEM

Re: [PATCH v7 6/8] sparc/sun4m: Don't set cs->halted = 0 in main_cpu_reset()

2020-09-01 Thread Philippe Mathieu-Daudé
On 8/26/20 7:55 AM, Thiago Jung Bauermann wrote: > We rely on cpu_common_reset() to set cs->halted to 0, it's redundant to do > it in main_cpu_reset(). > > Signed-off-by: Thiago Jung Bauermann > --- > hw/sparc/sun4m.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/sparc/sun4m.c b/hw

  1   2   3   4   5   6   >