Re: [Qemu-devel] [PATCH] decodetree: Force Python to print unsigned values

On 11/12/18 12:06 AM, Philippe Mathieu-Daudé wrote: >> On 11/11/18 1:02 AM, Philippe Mathieu-Daudé wrote: >>> Python internal representation is signed, so unsigned values >>> bigger than 31-bit are interpreted as signed (and printed with >>> a '-' signed). >>> Mask out to force unsigned values. >>>

Re: [Qemu-devel] [PATCH v1 1/3] intel-iommu: differentiate host address width from IOVA address width.

On Fri, Nov 09, 2018 at 07:49:45PM +0800, Yu Zhang wrote: > Currently, vIOMMU is using the value of IOVA address width, instead of > the host address width(HAW) to calculate the number of reserved bits in > data structures such as root entries, context entries, and entries of > DMA paging structure

Re: [Qemu-devel] [RFC PATCH 03/11] target/mips: Move the !ISA_MIPS32R6 check out of decode_opc_special2_legacy

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC PATCH 04/11] target/mips: Avoid access to CPUMIPSState from decode* functions

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > The DisasContext is already initialized from the CPUMIPSState in > mips_tr_init_disas_context(). > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 4 ++-- > 1 file changed, 2 insert

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > Python internal representation is signed, so unsigned values > bigger than 31-bit are interpreted as signed (and printed with > a '-' signed). > Mask out to force unsigned values. > > Signed-off-by: Philippe Mathieu-Daudé > --- > TODO: display

Re: [Qemu-devel] [RFC PATCH 06/11] scripts/decodetree: Allow empty specifications

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > Starting with empty specifications allow to write stubs/templates, > useful when testing/rebasing. > > This fixes: > > decode.inc.c: In function ‘decode’: > decode.inc.c:9:7: error: unused variable ‘u’ [-Werror=unused-variable] > } u;

Re: [Qemu-devel] [RFC PATCH 07/11] scripts/decodetree: Add add_func_check()

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > for n, f in self.fields.items(): > output(ind, 'u.f_', arg, '.', n, ' = ', f.str_extract(), ';\n') > +for f, a in self.check_funcs: > +output(ind, 'check_', f, '(ctx, ', a, ');\n') > output(ind,

Re: [Qemu-devel] [PATCH v1 2/3] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

On Fri, Nov 09, 2018 at 07:49:46PM +0800, Yu Zhang wrote: > A 5-level paging capable VM may choose to use 57-bit IOVA address width. > E.g. guest applications like DPDK prefer to use its VA as IOVA when > performing VFIO map/unmap operations, to avoid the burden of managing the > IOVA space. Since

Re: [Qemu-devel] [PATCH v1 3/3] intel-iommu: search iotlb for levels supported by the address width.

On Fri, Nov 09, 2018 at 07:49:47PM +0800, Yu Zhang wrote: > This patch updates vtd_lookup_iotlb() to search cached mappings only > for all page levels supported by address width of current vIOMMU. Also, > to cover 57-bit width, the shift of source id(VTD_IOTLB_SID_SHIFT) and > of page level(VTD_IOT

Re: [Qemu-devel] List of files containing devices which have not been QOMified

On 2018-11-09 14:16, Paolo Bonzini wrote: > On 09/11/2018 13:39, Thomas Huth wrote: >> On 2018-11-09 12:29, Gerd Hoffmann wrote: >>> On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: Hi, > I am also suspicious about hw/bt/ but don't know enough > about that subsyste

Re: [Qemu-devel] [PATCH v1 0/3] intel-iommu: add support for 5-level virtual IOMMU.

On Fri, Nov 09, 2018 at 07:49:44PM +0800, Yu Zhang wrote: > Intel's upcoming processors will extend maximum linear address width to > 57 bits, and introduce 5-level paging for CPU. Meanwhile, the platform > will also extend the maximum guest address width for IOMMU to 57 bits, > thus introducing th

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin wrote: > On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > > @@ -66,12 +143,16 @@ typedef struct VirtIONet { > > > VirtIONetQueue *vqs; > > > VirtQueue *ctrl_vq; > > > NICState *nic; > > > +

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

On Mon, Nov 12, 2018 at 9:20 AM Richard Henderson wrote: > On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > > Python internal representation is signed, so unsigned values > > bigger than 31-bit are interpreted as signed (and printed with > > a '-' signed). > > Mask out to force unsigned value

Re: [Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub

On 11/12/18 6:37 AM, Aleksandar Markovic wrote: >> Subject: [RFC PATCH 08/11] target/mips: Add a decodetree stub > > There is no plan to use decodetree for MIPS target. MIPS decoding engine is > mostly stable mature code that was well tested over many years, and there is > no > point in introduci

[Qemu-devel] qdev has no maintainer (was: [PATCH] hw: set_netdev: remove useless code)

Thomas Huth writes: > On 2018-11-09 09:21, Laurent Vivier wrote: >> On 09/11/2018 09:13, Li Qiang wrote: >>> In set_netdev(), the peers[i] is initialized >>> qemu_find_net_clients_except() when i is in >>> 0 between 'queues' it can't be NULL. >>> >>> Signed-off-by: Li Qiang >>> --- >>> hw/core/

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] ppc/spapr: Receive and store device tree blob from SLOF

On Mon, 12 Nov 2018 15:12:26 +1100 Alexey Kardashevskiy wrote: > On 12/11/2018 05:10, Greg Kurz wrote: > > Hi Alexey, > > > > Just a few remarks. See below. > > > > On Thu, 8 Nov 2018 12:44:06 +1100 > > Alexey Kardashevskiy wrote: > > > >> SLOF receives a device tree and updates it with va

Re: [Qemu-devel] [PATCH 0/2] Fix the last Hyp mode bug and turn it on for A7, A15

On 11/9/18 6:35 PM, Peter Maydell wrote: > Not entirely sure what to do about this for 3.1 -- maybe > put in the bugfix patch but hold off on actually setting > the feature bit til 4.0? I would put them both in for 3.1. r~

Re: [Qemu-devel] [RFC] [PATCH] kvm: arm: Introduce error code KVM_EINVARIANT

Hi Manish, On Sat, Nov 10, 2018 at 10:18:47PM +, Manish Jaggi wrote: > > CCing a larger audience. > Please review. > > On 10/23/2018 03:51 PM, Jaggi, Manish wrote: > > From: Manish Jaggi > > > > This patch introduces an error code KVM_EINVARIANT which is returned > > by KVM when userland tr

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

Max Reitz writes: > On 08.11.18 13:43, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Hi Markus, >>> >>> >>> Le jeu. 8 nov. 2018 09:46, Markus Armbruster a écrit : >>> Cleber Rosa writes: > On 11/7/18 1:05 AM, Markus Armbruster wrote: >> [...] >> PEP 394 r

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

On Sat, Nov 10, 2018 at 08:36:39PM +0100, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 11/9/18 3:20 PM, Gerd Hoffmann wrote: > > The rate of pulseaudio absorbing the audio stream is used to control the > > the rate of the guests audio stream. When the emulated hardware uses > > small chunks (l

Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > +dclz011100 . . . . 100100 @rs_rt_rd > ?ctx->insn_flags&ISA_MIPS64 > +dclo011100 . . . . 100101 @rs_rt_rd > ?ctx->insn_flags&ISA_MIPS64 This syntax I do not like. I preferred yo

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

Peter Maydell writes: > On 9 November 2018 at 14:14, Gerd Hoffmann wrote: >> Broken (segfaultson first keypress) and appearently unused. >> >> Signed-off-by: Gerd Hoffmann Please show the reproducer in the commit message. Stack backtrace wouldn't hurt. >> --- >> include/hw/bt.h | 3 -

Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree

On Mon, Nov 12, 2018 at 10:15 AM Richard Henderson wrote: > > On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > > +dclz011100 . . . . 100100 @rs_rt_rd > > ?ctx->insn_flags&ISA_MIPS64 > > +dclo011100 . . . . 100101 @rs_rt_rd > >

Re: [Qemu-devel] [PATCH] edid: silence a stringop-overflow warning

Marc-André Lureau writes: > Simplify the code that doesn't need strncpy() since length of string > is already computed. > > /home/elmarco/src/qemu/hw/display/edid-generate.c: In function > 'edid_desc_text': > /home/elmarco/src/qemu/hw/display/edid-generate.c:168:5: error: 'strncpy' > specified

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On 2018/11/12 下午4:57, Yuri Benditovich wrote: On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin > wrote: On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: >     > @@ -66,12 +143,16 @@ typedef struct VirtIONet { >     >      VirtIONetQueue

Re: [Qemu-devel] [PATCH v1 3/3] intel-iommu: search iotlb for levels supported by the address width.

On Mon, Nov 12, 2018 at 04:51:22PM +0800, Peter Xu wrote: > On Fri, Nov 09, 2018 at 07:49:47PM +0800, Yu Zhang wrote: > > This patch updates vtd_lookup_iotlb() to search cached mappings only > > for all page levels supported by address width of current vIOMMU. Also, > > to cover 57-bit width, the s

Re: [Qemu-devel] [PATCH v1 1/3] intel-iommu: differentiate host address width from IOVA address width.

On Mon, Nov 12, 2018 at 04:15:46PM +0800, Peter Xu wrote: > On Fri, Nov 09, 2018 at 07:49:45PM +0800, Yu Zhang wrote: > > Currently, vIOMMU is using the value of IOVA address width, instead of > > the host address width(HAW) to calculate the number of reserved bits in > > data structures such as ro

Re: [Qemu-devel] [PATCH v1 3/3] intel-iommu: search iotlb for levels supported by the address width.

On Mon, Nov 12, 2018 at 05:25:48PM +0800, Yu Zhang wrote: > On Mon, Nov 12, 2018 at 04:51:22PM +0800, Peter Xu wrote: > > On Fri, Nov 09, 2018 at 07:49:47PM +0800, Yu Zhang wrote: > > > This patch updates vtd_lookup_iotlb() to search cached mappings only > > > for all page levels supported by addre

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

On 12/11/18 10:12, Gerd Hoffmann wrote: On Sat, Nov 10, 2018 at 08:36:39PM +0100, Philippe Mathieu-Daudé wrote: Hi Gerd, On 11/9/18 3:20 PM, Gerd Hoffmann wrote: The rate of pulseaudio absorbing the audio stream is used to control the the rate of the guests audio stream. When the emulated har

Re: [Qemu-devel] [PATCH v1 2/3] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

On Mon, Nov 12, 2018 at 04:36:34PM +0800, Peter Xu wrote: > On Fri, Nov 09, 2018 at 07:49:46PM +0800, Yu Zhang wrote: > > A 5-level paging capable VM may choose to use 57-bit IOVA address width. > > E.g. guest applications like DPDK prefer to use its VA as IOVA when > > performing VFIO map/unmap op

Re: [Qemu-devel] [PATCH] 9p: write lock path in v9fs_co_open2()

On Mon, 12 Nov 2018 16:28:28 +0800 zhibin hu wrote: > hi, > > i use this patch with qemu 3.0.0 and it seems not fix completely. > > [root@localhost ~]# ./qemu-system-x86_64 -snapshot -m 1024 -smp 2 > -enable-kvm -net nic,model=e1000 -net > tap,helper=/usr/libexec/qemu-bridge-helper -hda > /var/

[Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated

It has been unmaintained since years, and there were only trivial or tree-wide changes to the related files since many years, so the code is likely very bitrotten and broken. For example the following segfaults as soon as as you press a key: qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -

Re: [Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub

Hello, Richard. I am a little taken aback by your tone. I hope we can communicate in much friendlier maner, as we used to do. >You have just this year added yet another encoding scheme for nanomips. Your >statement "well tested over many years" is a bit of a stretch. I wrote "mostly stable mat

Re: [Qemu-devel] [RFC] [PATCH] kvm: arm: Introduce error code KVM_EINVARIANT

On Sun, Nov 11, 2018 at 11:36:44AM +, Marc Zyngier wrote: > On Sat, 10 Nov 2018 22:18:47 +, > Manish Jaggi wrote: > > > > > > CCing a larger audience. > > Please review. > > > > On 10/23/2018 03:51 PM, Jaggi, Manish wrote: > > > From: Manish Jaggi > > > > > > This patch introduces an e

Re: [Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

On Mon, 12 Nov 2018 01:14:55 + xiezhide wrote: > These patches provide the qmp interface, to set/query the io throttle > status of the all fsdev devices that are present in a vm. > Some of the patches also remove the > duplicate code that was present in block and fsdev files. > > Zhide Xie (

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

On 2018-11-09 15:14, Gerd Hoffmann wrote: > Broken (segfaultson first keypress) and appearently unused. Broken since QEMU v2.1 (!) already, if I've got that right - please mention that version number, so that it is clear that it is broken since more than two releases (i.e. it has been "deprecated"

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

On 12 November 2018 at 09:16, Markus Armbruster wrote: > Peter Maydell writes: > >> On 9 November 2018 at 14:14, Gerd Hoffmann wrote: >>> Broken (segfaultson first keypress) and appearently unused. >>> >>> Signed-off-by: Gerd Hoffmann > > Please show the reproducer in the commit message. Stack

Re: [Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options()

On Sun 11 Nov 2018 10:01:05 PM CET, Max Reitz wrote: > On 07.11.18 13:59, Alberto Garcia wrote: >> This function takes three options (cache.direct, cache.no-flush and >> read-only) from a QemuOpts object and updates the flags accordingly. > > and auto-read-only now Oops, will update. > Hm, seems

Re: [Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options()

On Sun 11 Nov 2018 10:01:05 PM CET, Max Reitz wrote: >> -assert(qemu_opt_find(opts, BDRV_OPT_CACHE_DIRECT)); >> if (qemu_opt_get_bool_del(opts, BDRV_OPT_CACHE_DIRECT, false)) { >> *flags |= BDRV_O_NOCACHE; >> } >> >> *flags &= ~BDRV_O_RDWR; > > Unrelated to this patch,

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: > The initial goal of this RFC is to get feedback on tests not specific > to the QEMU main binary, but specific to other components such as > qemu-img. > > For this experiment, a small issue with the zero and negative number > of I/O operations g

Re: [Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub

On 11/12/18 11:04 AM, Aleksandar Markovic wrote: > Hello, Richard. > > I am a little taken aback by your tone. I hope we can communicate in much > friendlier maner, as we used to do. I too was put off by your tone. Beginning with "there is no plan" and continuing with "there is no point" is a c

Re: [Qemu-devel] List of files containing devices which have not been QOMified

On 10 November 2018 at 15:20, Mark Cave-Ayland wrote: > On 09/11/2018 10:31, Peter Maydell wrote: >> I think the code I saw that looked like a non-QOMified >> device was cpu_timer_create(). > Ah okay. The above timers are certainly internal CPU timers rather than > external, so > should they sti

Re: [Qemu-devel] [PULL 0/4] slirp updates

On 10 November 2018 at 14:09, Samuel Thibault wrote: > The following changes since commit 160e5c22e55b3f775c2003dfc626fa872ee4a7a1: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2018-11-09 10:54:10 +) > > are available in the Git repository at: > > htt

Re: [Qemu-devel] [libvirt] [PATCH] bt: Mark the bluetooth subsystem as deprecated

On Mon, Nov 12, 2018 at 11:00:30 +0100, Thomas Huth wrote: > It has been unmaintained since years, and there were only trivial or > tree-wide changes to the related files since many years, so the > code is likely very bitrotten and broken. For example the following > segfaults as soon as as you pre

Re: [Qemu-devel] [PATCH 1/2] target/arm: Hyp mode R14 is shared with User and System

On Fri, Nov 09, 2018 at 05:35:52PM +, Peter Maydell wrote: > Hyp mode is an exception to the general rule that each AArch32 > mode has its own r13, r14 and SPSR -- it has a banked r13 and > SPSR but shares its r14 with User and System mode. We were > incorrectly implementing it as banked, which

Re: [Qemu-devel] [PATCH 2/2] target/arm/cpu: Give Cortex-A15 and -A7 the EL2 feature

On Fri, Nov 09, 2018 at 05:35:53PM +, Peter Maydell wrote: > The Cortex-A15 and Cortex-A7 both have EL2; now we've implemented > it properly we can enable the feature bit. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias > --- > target/arm/cpu.c | 2 ++ > 1 file changed, 2

Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write

Richard Henderson writes: > This would cause an infinite recursion or loop. > > Signed-off-by: Richard Henderson I feel the title undersells the importance of the fix ;-) Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] target/arm: Hyp mode R14 is shared with User and System

On Fri, Nov 09, 2018 at 06:15:20PM +, Peter Maydell wrote: > On 9 November 2018 at 17:35, Peter Maydell wrote: > > Hyp mode is an exception to the general rule that each AArch32 > > mode has its own r13, r14 and SPSR -- it has a banked r13 and > > SPSR but shares its r14 with User and System m

Re: [Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

Hi Marc, When I play with the v3 patch set, the qemu hangs again and I need to kill it with "kill -9". I got below from guest: [ 104.828127] nvme nvme0: I/O 52 QID 1 timeout, aborting [ 104.828470] nvme nvme0: Abort status: 0x4001 nvme abort is not supported by qemu and therefore 0x4001 (NVME

Re: [Qemu-devel] [PATCH] 9p: write lock path in v9fs_co_open2()

On Mon, 12 Nov 2018 19:05:59 +0800 zhibin hu wrote: > yes, and this : > Yeah, all call sites of v9fs_path_copy() in v9fs_create() are called in the context of the main thread. They may race with any other access to the fid path performed by some other command in the context of a worker thread.

Re: [Qemu-devel] [PATCH V4 3/5] hw/misc/pvpanic: Add the MMIO interface

On Thu, Nov 08, 2018 at 09:38:54AM +, Peter Maydell wrote: > On 25 October 2018 at 12:38, Philippe Mathieu-Daudé wrote: > > Depending of the response to Peter's question [*]: > > > > I'd also like some confirmation from folks more familiar with the > > current state of the art in guest

Re: [Qemu-devel] [PATCH for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write

On 10 November 2018 at 12:17, Richard Henderson wrote: > This would cause an infinite recursion or loop. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 963

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

On Mon, Nov 12, 2018 at 10:51:36AM +0100, Philippe Mathieu-Daudé wrote: > On 12/11/18 10:12, Gerd Hoffmann wrote: > > On Sat, Nov 10, 2018 at 08:36:39PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Gerd, > > > > > > On 11/9/18 3:20 PM, Gerd Hoffmann wrote: > > > > The rate of pulseaudio absorbing

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: > > > > On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin > > wrote: > > > > On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > > > @@ -66,

Re: [Qemu-devel] [PATCH v3 2/5] target/arm: Fill in ARMISARegisters for kvm64

On 8 November 2018 at 17:52, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > /* Old kernels may not know about the PREFERRED_TARGET ioctl: however > * we know these will only support creating one kind of guest CPU, > * which is its preferred CPU type. Fortuna

Re: [Qemu-devel] [PATCH v3 4/5] target/arm: Fill in ARMISARegisters for kvm32

On 8 November 2018 at 17:52, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/kvm32.c | 33 - > 1 file changed, 28 insertions(+), 5 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

On 12/11/18 12:28, Gerd Hoffmann wrote: On Mon, Nov 12, 2018 at 10:51:36AM +0100, Philippe Mathieu-Daudé wrote: On 12/11/18 10:12, Gerd Hoffmann wrote: On Sat, Nov 10, 2018 at 08:36:39PM +0100, Philippe Mathieu-Daudé wrote: Hi Gerd, On 11/9/18 3:20 PM, Gerd Hoffmann wrote: The rate of pulsea

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] target/arm: Hyp mode R14 is shared with User and System

Peter Maydell writes: > On 9 November 2018 at 17:35, Peter Maydell wrote: >> Hyp mode is an exception to the general rule that each AArch32 >> mode has its own r13, r14 and SPSR -- it has a banked r13 and >> SPSR but shares its r14 with User and System mode. We were >> incorrectly implementing

Re: [Qemu-devel] [Qemu-arm] [PATCH for-3.1] target/arm: Remove antique TODO comment

Peter Maydell writes: > Remove a TODO comment about implementing the vectored interrupt > controller. We have had an implementation of that for a decade; > it's in hw/intc/pl190.c. Reviewed-by: Alex Bennée > > Signed-off-by: Peter Maydell > --- > target/arm/helper.c | 1 - > 1 file changed

Re: [Qemu-devel] [Qemu-arm] [PATCH for-v3.1 1/3] Revert "target/arm: Implement HCR.VI and VF"

Peter Maydell writes: > This reverts commit 8a0fc3a29fc2315325400c738f807d0d4ae0ab7f. > > The implementation of HCR.VI and VF in that commit is not > correct -- they do not track the overall "is there a pending > VIRQ or VFIQ" status, but whether there is a pending interrupt > due to "this mech

Re: [Qemu-devel] [Qemu-arm] [PATCH for-v3.1 2/3] target/arm: Track the state of our irq lines from the GIC explicitly

Peter Maydell writes: > Currently we track the state of the four irq lines from the GIC > only via the cs->interrupt_request or KVM irq state. That means > that we assume that an interrupt is asserted if and only if the > external line is set. This assumption is incorrect for VIRQ > and VFIQ, b

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

> > Also, when making chunk size configurable we should not leave that > > to the confused user but pick a working value automatically, probably > > depending on the emulated device. I can't see what the benefit would > > be though, especially given that intel-hda is probably used in most > > conf

Re: [Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

On Mon, Nov 12, 2018 at 12:58 PM Gerd Hoffmann wrote: > > > > Also, when making chunk size configurable we should not leave that > > > to the confused user but pick a working value automatically, probably > > > depending on the emulated device. I can't see what the benefit would > > > be though,

Re: [Qemu-devel] [PATCH v1 3/3] intel-iommu: search iotlb for levels supported by the address width.

On Mon, Nov 12, 2018 at 05:36:38PM +0800, Peter Xu wrote: > On Mon, Nov 12, 2018 at 05:25:48PM +0800, Yu Zhang wrote: > > On Mon, Nov 12, 2018 at 04:51:22PM +0800, Peter Xu wrote: > > > On Fri, Nov 09, 2018 at 07:49:47PM +0800, Yu Zhang wrote: > > > > This patch updates vtd_lookup_iotlb() to search

Re: [Qemu-devel] [PATCH v3 4/5] target/arm: Fill in ARMISARegisters for kvm32

On 8 November 2018 at 17:52, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/kvm32.c | 33 - > 1 file changed, 28 insertions(+), 5 deletions(-) > > diff --git a/target/arm/kvm32.c b/target/arm/kvm32.c > index de573f9aa8..9ededa3c73 1

Re: [Qemu-devel] [PATCH v3 0/7] KVM Guest Debug fixes (plus TCG EL2 debug tweaks)

On 9 November 2018 at 15:21, Alex Bennée wrote: > Hi, > > I missed a fix I'd applied locally from v2 so this is a resend with > some additional tags, some changes suggested by rth and one more fix > for the test case. > > So these are fixes for guest debug when running under KVM. While > re-spinni

Re: [Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated

On Mon, Nov 12, 2018 at 11:00:30AM +0100, Thomas Huth wrote: > It has been unmaintained since years, and there were only trivial or > tree-wide changes to the related files since many years, so the > code is likely very bitrotten and broken. For example the following > segfaults as soon as as you p

Re: [Qemu-devel] [PATCH] edid: silence a stringop-overflow warning

On Sat, Nov 10, 2018 at 03:16:23PM +0400, Marc-André Lureau wrote: > Simplify the code that doesn't need strncpy() since length of string > is already computed. > > /home/elmarco/src/qemu/hw/display/edid-generate.c: In function > 'edid_desc_text': > /home/elmarco/src/qemu/hw/display/edid-generate

Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

On Tue, Oct 30, 2018 at 09:23:40AM +0100, Gerd Hoffmann wrote: > Fixes: CVE-2018-??? > Cc: P J P ping, do we have a cve number meanwhile? cheers, Gerd

[Qemu-devel] [Bug 1802915] [NEW] GTK display refresh rate is throttled

Public bug reported: Guest OS running with GL enabled GTK display shows a reduced refresh rate, e.g. moving cursor around with iGVT-g DMA Buf. It seems that a default refresh interval GUI_REFRESH_INTERVAL_DEFAULT (30ms) is defined in include/ui/console.h, throttling the display refresh rate at 33

Re: [Qemu-devel] [libvirt] [PATCH] bt: Mark the bluetooth subsystem as deprecated

On Mon, Nov 12, 2018 at 02:14:02PM +0100, Gerd Hoffmann wrote: > On Mon, Nov 12, 2018 at 11:00:30AM +0100, Thomas Huth wrote: > > It has been unmaintained since years, and there were only trivial or > > tree-wide changes to the related files since many years, so the > > code is likely very bitrotte

[Qemu-devel] [Bug 1802915] Re: GTK display refresh rate is throttled

Slow motion clips for host/guest were uploaded as attachments. ** Attachment added: "slow motion for host os" https://bugs.launchpad.net/qemu/+bug/1802915/+attachment/5211843/+files/host.mov -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH] 9p: write lock path in v9fs_co_open2()

hi, i use this patch with qemu 3.0.0 and it seems not fix completely. [root@localhost ~]# ./qemu-system-x86_64 -snapshot -m 1024 -smp 2 -enable-kvm -net nic,model=e1000 -net tap,helper=/usr/libexec/qemu-bridge-helper -hda /var/lib/libvirt/images/test.qcow2 -fsdev local,id=test_dev,path=/tmp,secur

Re: [Qemu-devel] [PATCH] 9p: write lock path in v9fs_co_open2()

yes, and this : ==6094==ERROR: AddressSanitizer: heap-use-after-free on address 0x602e6751 at pc 0x562a8dc492b8 bp 0x7f6805d2fa10 sp 0x7f6805d2fa00 READ of size 1 at 0x602e6751 thread T21 #0 0x562a8dc492b7 in local_open_nofollow hw/9pfs/9p-local.c:59 #1 0x562a8dc49361 in local_open

Re: [Qemu-devel] [PATCH v4 0/8] Use 'https://' instead of 'git://'

On 8 November 2018 at 11:15, Stefan Hajnoczi wrote: > v4: > * Once more, with feeling! Fix 'https//' in get_maintainer.pl [Philippe] > v3: > * Fix broken openhackware URL [Eric] > * Convert a few remaining URLs [Eric] > v2: > * Use HTTPS for repo.or.cz [Eric] > > Jeff Cody has enabled git sma

Re: [Qemu-devel] [PATCH v2 12/22] vmxnet3: Move some definitions to header file

On Thu, Nov 8, 2018 at 6:09 PM Yuval Shaia wrote: > > pvrdma setup requires vmxnet3 device on PCI function 0 and PVRDMA device > on PCI function 1. > pvrdma device needs to access vmxnet3 device object for several reasons: > 1. Make sure PCI function 0 is vmxnet3. > 2. To monitor vmxnet3 device st

[Qemu-devel] [PATCH v5 08/16] block: Use bdrv_reopen_set_read_only() in the mirror driver

The 'block-commit' QMP command is implemented internally using two different drivers. If the source image is the active layer then the mirror driver is used (commit_active_start()), otherwise the commit driver is used (commit_start()). In both cases the destination image must be put temporarily in

[Qemu-devel] [PATCH v5 05/16] block: Use bdrv_reopen_set_read_only() in stream_start/complete()

This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/stream.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --gi

[Qemu-devel] [PATCH v5 15/16] block: Assert that flags are up-to-date in bdrv_reopen_prepare()

Towards the end of bdrv_reopen_queue_child(), before starting to process the children, the update_flags_from_options() function is called in order to have BDRVReopenState.flags in sync with the options from the QDict. This is necessary because during the reopen process flags must be updated for al

[Qemu-devel] [PATCH v5 16/16] block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()

Commit e35bdc123a4ace9f4d3fcca added the auto-read-only option and the code to update its corresponding flag in update_flags_from_options(), but forgot to clear the flag if auto-read-only is false. Signed-off-by: Alberto Garcia Reported-by: Max Reitz --- block.c | 4 +--- 1 file changed, 1 inse

[Qemu-devel] [PATCH v5 11/16] block: Clean up reopen_backing_file() in block/replication.c

This function is used to put the hidden and secondary disks in read-write mode before launching the backup job, and back in read-only mode afterwards. This patch does the following changes: - Use an options QDict with the "read-only" option instead of passing the changes as flags only. -

[Qemu-devel] [PATCH v5 06/16] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()

This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/bl

[Qemu-devel] [PATCH v5 03/16] block: Use bdrv_reopen_set_read_only() in commit_start/complete()

This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v5 12/16] block: Remove flags parameter from bdrv_reopen_queue()

Now that all callers are passing all flag changes as QDict options, the flags parameter is no longer necessary, so we can get rid of it. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 5 +++-- block/replication.c | 6 ++ include/block/block.h | 3 +-- qem

[Qemu-devel] [PATCH v5 02/16] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename()

This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block

[Qemu-devel] [PATCH v5 13/16] block: Stop passing flags to bdrv_reopen_queue_child()

Now that all callers are passing the new options using the QDict we no longer need the 'flags' parameter. This patch makes the following changes: 1) The update_options_from_flags() call is no longer necessary so it can be removed. 2) The update_flags_from_options() call is now used i

[Qemu-devel] [PATCH v5 14/16] block: Remove assertions from update_flags_from_options()

This function takes four options (cache.direct, cache.no-flush, read-only and auto-read-only) from a QemuOpts object and updates the flags accordingly. If any of those options is not set (because it was missing from the original QDict or because it had an invalid value) then the function aborts wi

[Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue()

Hi all, when reopening a BlockDriverState using bdrv_reopen() and friends the new options can be specified either with a QDict or with flags. Both methods overlap and that makes the semantics and the implementation unnecessarily complicated. This series removes the 'flags' parameter from these fu

[Qemu-devel] [PATCH v5 09/16] block: Drop bdrv_reopen()

No one is using this function anymore, so we can safely remove it. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 21 - include/block/block.h | 1 - 2 files changed, 22 deletions(-) diff --git a/block.c b/block.c index cfa53f7114..31de7b22

[Qemu-devel] [PATCH v5 01/16] block: Add bdrv_reopen_set_read_only()

Most callers of bdrv_reopen() only use it to switch a BlockDriverState between read-only and read-write, so this patch adds a new function that does just that. We also want to get rid of the flags parameter in the bdrv_reopen() API, so this function sets the "read-only" option and passes the origi

[Qemu-devel] [PATCH v5 10/16] qemu-io: Put flag changes in the options QDict in reopen_f()

When reopen_f() puts a block device in the reopen queue, some of the new options are passed using a QDict, but others ("read-only" and the cache options) are passed as flags. This patch puts those flags in the QDict. This way the flags parameter becomes redundant and we'll be able to get rid of it

[Qemu-devel] [PATCH v5 07/16] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()

This patch replaces the bdrv_reopen() call that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.

[Qemu-devel] [PATCH v5 04/16] block: Use bdrv_reopen_set_read_only() in bdrv_commit()

This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/commit

Re: [Qemu-devel] [PATCH v3 4/5] target/arm: Fill in ARMISARegisters for kvm32

On 11/12/18 1:42 PM, Peter Maydell wrote: > Adding the following change allowed me to boot: > > diff --git a/target/arm/kvm32.c b/target/arm/kvm32.c > index 8b2c9b3..2f7df81 100644 > --- a/target/arm/kvm32.c > +++ b/target/arm/kvm32.c > @@ -84,9 +84,15 @@ bool kvm_arm_get_host_cpu_features(ARMHost

Re: [Qemu-devel] [PATCH v3 7/7] memory-device: rewrite address assignment using ranges

On 23.10.18 17:23, David Hildenbrand wrote: > Let's rewrite it properly using ranges. This fixes certain overflows that > are right now possible. E.g. > > qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ > -object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=2G > -device p

Re: [Qemu-devel] [PATCH v3 2/5] target/arm: Fill in ARMISARegisters for kvm64

On 11/12/18 12:37 PM, Peter Maydell wrote: > On 8 November 2018 at 17:52, Richard Henderson > wrote: >> Signed-off-by: Richard Henderson >> --- > >> /* Old kernels may not know about the PREFERRED_TARGET ioctl: however >> * we know these will only support creating one kind of guest CP

Re: [Qemu-devel] [PATCH v3 2/5] target/arm: Fill in ARMISARegisters for kvm64

On 12 November 2018 at 14:09, Richard Henderson wrote: > On 11/12/18 12:37 PM, Peter Maydell wrote: >> On 8 November 2018 at 17:52, Richard Henderson >> wrote: >>> Signed-off-by: Richard Henderson >>> --- >> >>> /* Old kernels may not know about the PREFERRED_TARGET ioctl: however >>>

Re: [Qemu-devel] [RFC PATCH 2/2] qemu-img: consider a zero number of I/O requests an invalid count

On 9/11/18 23:12, Cleber Rosa wrote: It's debatable whether it makes sense to consider the bench command successful when no I/O requests will be performed. This changes the behavior to consider a zero count of I/O requests an invalid value. While at it, avoid using signed types for number of I/O

Re: [Qemu-devel] [PATCH] linux-user: Remove dead error-checking code

On 19 October 2018 at 17:26, Laurent Vivier wrote: > Le 19/10/2018 à 18:17, Peter Maydell a écrit : >> Remove some dead code spotted by Coverity (CID 1009855, >> 1390854, 1390847). The underlying cause in all these cases >> is the same: QEMU's put_user operations can't result in >> errors, but the

Re: [Qemu-devel] [PATCH 0/2] linux-user: Don't call gdb_handlesig unnecessarily

Ping? This got reviewed but hasn't made it to master... thanks -- PMM On 19 October 2018 at 18:49, Peter Maydell wrote: > This patchset fixes a minor bug in our handling of SIGTRAP > in linux-user. > > The CPU main-loop routines for linux-user generally call > gdb_handlesig() when they're about

  1   2   3   4   >