On 9 November 2018 at 15:21, Alex Bennée <alex.ben...@linaro.org> wrote: > Hi, > > I missed a fix I'd applied locally from v2 so this is a resend with > some additional tags, some changes suggested by rth and one more fix > for the test case. > > So these are fixes for guest debug when running under KVM. While > re-spinning these I came across an anomaly which pointed to a kernel bug > that caused the 1st single-step to fail. This is being discussed at on > the kvm-arm list: > > Subject: [RFC PATCH] KVM: arm64: don't single-step for non-emulated faults > Date: Wed, 7 Nov 2018 17:10:31 +0000 > Message-Id: <20181107171031.22573-1-alex.ben...@linaro.org> > > It looks like there will be another patch series on its way to address > this. > > As debugging HYP mode code is next to impossible on real hardware I > tried re-creating the single-step bug under TCG. As a result I ran into > some debug and EL2 cases that failed. The final two patches are some > fixes but I'm still seeing some weird behaviour although it is currently > obscured by timer interrupts constantly firing as I enter the to be > single-stepped guest EL1 instruction so they can probably be skipped for > 3.1. > > The following patches still need review: > 0001/target arm64 properly handle DBGVR RESS bits.patch > 0005/tests guest debug don t use symbol resolution for.patch > 0007/arm fix aa64_generate_debug_exceptions to work wi.patch
Richard had a review comment on 5, so I'm applying 1-4 and 6-7 to target-arm.next and will let you respin 5. thanks -- PMM
