On 12/11/18 12:28, Gerd Hoffmann wrote:
On Mon, Nov 12, 2018 at 10:51:36AM +0100, Philippe Mathieu-Daudé wrote:
On 12/11/18 10:12, Gerd Hoffmann wrote:
On Sat, Nov 10, 2018 at 08:36:39PM +0100, Philippe Mathieu-Daudé wrote:
Hi Gerd,
On 11/9/18 3:20 PM, Gerd Hoffmann wrote:
The rate of pulseaudio absorbing the audio stream is used to control the
the rate of the guests audio stream. When the emulated hardware uses
small chunks (like intel-hda does) we need small chunks on the audio
backend side too, otherwise that feedback loop doesn't work very well.
Shouldn't this be user-configurable?
Why?
When emulated hardware is not intel-hda?
Ok, maybe it is not required then, but it also doesn't hurt.
Also, when making chunk size configurable we should not leave that
to the confused user but pick a working value automatically, probably
depending on the emulated device. I can't see what the benefit would
be though, especially given that intel-hda is probably used in most
configurations these days.
For nowadays uses I agree with your patch.
For retrocomputing and other weird stuffs, if we don't have this
user-configurable, I think we need a comment in the code about this
change, else it might be hard for other people to figure this change in
the git history.
With a such comment:
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Regards,
Phil.
