[Qemu-devel] [Bug 1802465] [NEW] typing string via VNC is unreliable

2018-11-09 Thread Zhaocong
Public bug reported: QEMU version is 3.0.0 # Description The problem is that, when typing string through VNC, it can be unreliable -- sometimes some key strokes get skipped, sometimes get swapped, sometimes get repeated. There's no problem when typing through VNC on physical hardware. # Steps

[Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-09 Thread xiezhide
These patches provide the qmp interface, to set/query the io throttle status of the all fsdev devices that are present in a vm. Some of the patches also remove the duplicate code that was present in block and fsdev files. Zhide Xie (2): fsdev-qmp: qmp interface for set/query io throttle for fsde

[Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Li Qiang
In set_netdev(), the peers[i] is initialized qemu_find_net_clients_except() when i is in 0 between 'queues' it can't be NULL. Signed-off-by: Li Qiang --- hw/core/qdev-properties-system.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-proper

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_except() when i is in > 0 between 'queues' it can't be NULL. > > Signed-off-by: Li Qiang > --- > hw/core/qdev-properties-system.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Thomas Huth
On 2018-11-09 09:21, Laurent Vivier wrote: > On 09/11/2018 09:13, Li Qiang wrote: >> In set_netdev(), the peers[i] is initialized >> qemu_find_net_clients_except() when i is in >> 0 between 'queues' it can't be NULL. >> >> Signed-off-by: Li Qiang >> --- >> hw/core/qdev-properties-system.c | 4 ---

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 09:26, Thomas Huth wrote: > On 2018-11-09 09:21, Laurent Vivier wrote: >> On 09/11/2018 09:13, Li Qiang wrote: >>> In set_netdev(), the peers[i] is initialized >>> qemu_find_net_clients_except() when i is in >>> 0 between 'queues' it can't be NULL. >>> >>> Signed-off-by: Li Qiang >>>

Re: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension

2018-11-09 Thread Luc Michel
On 11/8/18 5:09 PM, Philippe Mathieu-Daudé wrote: > On 6/11/18 12:05, Luc Michel wrote: >> changes since v3: >>    - patch 1    cpu_cluster.h: remove QEMU_ from the multiple includes >>     guard #ifdef/#define [Alistair] >> >>    - patch 1    cpu_cluster.c: include osdep.h first [Alist

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Thomas Huth
On 2018-11-09 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_except() when i is in > 0 between 'queues' it can't be NULL. > > Signed-off-by: Li Qiang > --- > hw/core/qdev-properties-system.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v5 13/24] hw: acpi: Do not create hotplug method when handler is not defined

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:36 +0100 Samuel Ortiz wrote: > CPU and memory ACPI hotplug are not necessarily handled through SCI > events. For example, with Hardware-reduced ACPI, the GED device will > manage ACPI hotplug entirely. > As a consequence, we make the CPU and memory specific events AML >

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_except() when i is in > 0 between 'queues' it can't be NULL. > > Signed-off-by: Li Qiang > --- > hw/core/qdev-properties-system.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 02:48 hat Dongli Zhang geschrieben: > > > On 11/09/2018 12:47 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 10:09:00PM +0800, Dongli Zhang wrote: > >> It looks the kernel space vhost-blk can only process raw image. > >> > >> How about to verify that only raw image is

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Aleksandar Markovic
> From: Fredrik Noring > Subject: Re: [PATCH v2 4/6] target/mips: Fix decoding mechanism of special > R5900 opcodes > > Hi Aleksandar, > > > Fredrik, do you know by any chance if a document exists that would justify > > inclusion of non-R5900 DMULT, DMULTU, DDIV, DDIVU in R5900 executables by >

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Paolo Bonzini
On 09/11/2018 09:29, Laurent Vivier wrote: > On 09/11/2018 09:26, Thomas Huth wrote: >> On 2018-11-09 09:21, Laurent Vivier wrote: >>> On 09/11/2018 09:13, Li Qiang wrote: In set_netdev(), the peers[i] is initialized qemu_find_net_clients_except() when i is in 0 between 'queues' it c

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Juergen Gross
On 09/11/2018 10:57, Li Zhijian wrote: > On 11/9/2018 3:20 PM, Ingo Molnar wrote: >> * Li Zhijian wrote: >> If the kernel initrd creation process creates an initrd which is larger than 2GB and also claims that it can't be placed with any part of it above 2GB, then that sounds like a

Re: [Qemu-devel] QEMU and Kconfig

2018-11-09 Thread Paolo Bonzini
On 08/11/2018 22:00, Eduardo Habkost wrote: > Understood. My interpretation of "target" was just "a QEMU > binary". In other words, I thought we were talking about > anything that could be compiled in/out from a specific QEMU > binary. The idea is "target" as opposed to "host". > Do you have a

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Gerd Hoffmann
On Thu, Nov 08, 2018 at 11:05:10AM +0100, Lukáš Hrázký wrote: > Hello, > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > + * The device_display_id_{start,count} denotes the sequence of device > > > display > > > + * IDs that map to the zero-based sequence of monitor

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Mark Cave-Ayland
On 06/11/2018 18:43, Peter Maydell wrote: > I had an idea for how to get a rough list of source files > containing devices that haven't been QOMified. The theory > is that a pre-QOM device generally has an "init" function > which allocates memory for the device struct. So looking in > hw/ for file

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Frediano Ziglio
> On Thu, Nov 08, 2018 at 11:05:10AM +0100, Lukáš Hrázký wrote: > > Hello, > > > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > + * The device_display_id_{start,count} denotes the sequence of device > > > > display > > > > + * IDs that map to the zero-based se

Re: [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 08 November 2018 16:44 > To: Paul Durrant ; 'Kevin Wolf' > > Cc: Stefano Stabellini ; qemu-bl...@nongnu.org; > Tim Smith ; qemu-devel@nongnu.org; 'Markus > Armbruster' ; Anthony Perard > ; xen-de...@lists.xenproject.org; Max Reitz > > Subj

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 10:17, Mark Cave-Ayland wrote: > On 06/11/2018 18:43, Peter Maydell wrote: > >> I had an idea for how to get a rough list of source files >> containing devices that haven't been QOMified. The theory >> is that a pre-QOM device generally has an "init" function >> which allocat

Re: [Qemu-devel] [PATCH 1/2] linux-user/mips: Support the n32 ABI for the R5900

2018-11-09 Thread Laurent Vivier
On 08/11/2018 19:43, Fredrik Noring wrote: > Recognise the R5900, which reports itself as MIPS III, as a 64-bit CPU > supporting the n32 ABI. > > Signed-off-by: Fredrik Noring > --- > linux-user/mips64/target_elf.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/linux-user/mips64/ta

Re: [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 11:27 hat Paul Durrant geschrieben: > > -Original Message- > > From: Paul Durrant > > Sent: 08 November 2018 16:44 > > To: Paul Durrant ; 'Kevin Wolf' > > > > Cc: Stefano Stabellini ; qemu-bl...@nongnu.org; > > Tim Smith ; qemu-devel@nongnu.org; 'Markus > > Armbruster' ; A

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Gerd Hoffmann
Hi, > first output/display: > spice_qxl_set_device_info(instance1, path1, 0, 1); > second: > spice_qxl_set_device_info(instance2, path1, 1, 1); > third: > spice_qxl_set_device_info(instance3, path1, 2, 1); That is a much better example IMHO. cheers, Gerd

Re: [Qemu-devel] [PULL] A Single RISC-V Patch for 3.1-rc1

2018-11-09 Thread Peter Maydell
On 8 November 2018 at 18:52, Palmer Dabbelt wrote: > On Thu, 08 Nov 2018 10:38:51 PST (-0800), alistai...@gmail.com wrote: >> >> On Thu, Nov 8, 2018 at 10:35 AM Palmer Dabbelt wrote: >>> >>> >>> The following changes since commit >>> a7ce790a029bd94eb320d8c69f38900f5233997e: >>> >>> tcg/tcg-op.

Re: [Qemu-devel] [PATCH 0/2] linux-user/mips: Support the n32 ABI for the R5900

2018-11-09 Thread Laurent Vivier
On 08/11/2018 19:42, Fredrik Noring wrote: > Recognise the R5900, which reports itself as MIPS III, as a 64-bit CPU > supporting the n32 ABI. Test that DMULT is emulated in user mode. if you have time, o32 & n32 support needs to be reworked. We have two binaries qemu-mips and qemu-mipsn32 sharing

Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code

2018-11-09 Thread Laurent Vivier
On 09/11/2018 11:00, Paolo Bonzini wrote: > On 09/11/2018 09:29, Laurent Vivier wrote: >> On 09/11/2018 09:26, Thomas Huth wrote: >>> On 2018-11-09 09:21, Laurent Vivier wrote: On 09/11/2018 09:13, Li Qiang wrote: > In set_netdev(), the peers[i] is initialized > qemu_find_net_clients_e

[Qemu-devel] [PATCH RFC 5/6] test-string-input-visitor: split off uint64 list tests

2018-11-09 Thread David Hildenbrand
Basically copy all int64 list tests but adapt them to work on uint64 instead. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 71 +-- 1 file changed, 67 insertions(+), 4 deletions(-) diff --git a/tests/test-string-input-visitor.c b/tests/tes

[Qemu-devel] [PATCH RFC 6/6] test-string-input-visitor: add range overflow tests

2018-11-09 Thread David Hildenbrand
Let's make sure that the range handling code can properly deal with ranges that end at the biggest possible number. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/test-string-input-visitor.c b/tests/te

[Qemu-devel] [PATCH RFC 0/6] qapi: rewrite string-input-visitor

2018-11-09 Thread David Hildenbrand
Rewrite string-input-visitor to be (hopefully) less ugly. Support int and uint lists (including ranges, but not implemented via type "Range"). Virtual walks are now supported and more errors are cought (and some bugs fixed). Fix and extend the tests. Parsing of uint64_t is now properly supported.

[Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-09 Thread David Hildenbrand
Let's use the new function. Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index b3fdd0827d..dee708d384 100644 --- a/qapi/string-input-visitor.c +

[Qemu-devel] [PATCH RFC 4/6] test-string-input-visitor: use virtual walk

2018-11-09 Thread David Hildenbrand
We now support virtual walks, so use that instead. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 36 +++ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c i

[Qemu-devel] [PATCH RFC 1/6] cutils: add qemu_strtod()

2018-11-09 Thread David Hildenbrand
Let's provide a wrapper for strtod(). Signed-off-by: David Hildenbrand --- include/qemu/cutils.h | 1 + util/cutils.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h index 7071bfe2d4..84fb9e53c6 100644 --- a/incl

[Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-09 Thread David Hildenbrand
The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not supported and error messages are misleading - lists/ran

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Gerd Hoffmann
Hi, > I am also suspicious about hw/bt/ but don't know enough > about that subsystem to say if it could benefit from > using QOM objects more. I'm wondering whenever anyone would even notice if we just rm -rf hw/bt Looking through the changelog for the last five years (after hw/ split) the onl

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Gerd Hoffmann
On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: > Hi, > > > I am also suspicious about hw/bt/ but don't know enough > > about that subsystem to say if it could benefit from > > using QOM objects more. > > I'm wondering whenever anyone would even notice if we just rm -rf hw/bt >

[Qemu-devel] [RFC v8 01/18] update-linux-headers: Import virtio_iommu.h

2018-11-09 Thread Eric Auger
Update the script to update the virtio_iommu.h header. Signed-off-by: Eric Auger --- scripts/update-linux-headers.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 0a964fe240..55fd271a32 100755 --- a/scripts/update-l

[Qemu-devel] [RFC v8 07/18] virtio-iommu: Implement attach/detach command

2018-11-09 Thread Eric Auger
This patch implements the endpoint attach/detach to/from a domain. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index e

[Qemu-devel] [RFC v8 05/18] virtio-iommu: Add the iommu regions

2018-11-09 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented though. Signed-off-by: Eric Auger --- v6 -> v7: - use primary_bus - rebase on new translate proto featuring iommu_idx v5 -> v6: - include qapi/erro

[Qemu-devel] [RFC v8 06/18] virtio-iommu: Endpoint and domains structs and helpers

2018-11-09 Thread Eric Auger
This patch introduce domain and endpoint internal datatypes. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Helpers to get/put end points and domains are introduced. get() helpers will become static in subsequent patches. Signed-off-by: Eric Auger --- v6 -> v7

[Qemu-devel] [RFC v8 00/18] VIRTIO-IOMMU device

2018-11-09 Thread Eric Auger
This series rebases the virtio-iommu device on qemu 3.1.0-rc0 and implements the v0.8 virtio-iommu spec [1]. Most importantly the pci proxy for the virtio-iommu device is now available and gets instantiated by the ARM virt machine when the ",iommu=virtio" virt machine option is added. The virtio-i

[Qemu-devel] [RFC v8 08/18] virtio-iommu: Implement map/unmap

2018-11-09 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger --- v5 -> v6: - use new v0.6 fields - replace error_report by qemu_log_mask v3 -> v4: - implement unmap semantics as specified in v0.4 --- hw/virtio/trace-events | 3 ++ hw/virtio/virtio-iommu.c | 94 ++

[Qemu-devel] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property

2018-11-09 Thread Eric Auger
In case the msi_bypass property is set, it means we need to register the IOAPIC MSI window as a reserved region: 0xFEE0 - 0xFEEF. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 52 include/hw/virtio/virtio-iommu.h | 1 + 2 files ch

[Qemu-devel] [RFC v8 02/18] linux-headers: Partial update for virtio-iommu v0.8

2018-11-09 Thread Eric Auger
Partial sync against Jean-Philippe's branch: git://linux-arm.org/linux-jpb.git virtio-iommu/v0.8 Signed-off-by: Eric Auger --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_iommu.h | 159 ++ linux-headers/linux/virtio_iommu.h

[Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board

2018-11-09 Thread Eric Auger
Both the virtio-iommu device and its dedicated mmio transport get instantiated when requested. Signed-off-by: Eric Auger --- v6 -> v7: - align to the smmu instantiation code v4 -> v5: - VirtMachineClass no_iommu added in this patch - Use object_resolve_path_type --- hw/arm/virt.c | 48 +++

[Qemu-devel] [RFC v8 03/18] virtio-iommu: Add skeleton

2018-11-09 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- v7 -> v8: - expose VIRTIO_IOMMU_F_BYPASS and VIRTIO_F_VERSION_1 features - set_config dummy implementation + tracing - add trace in get_features - set the features on realize() and store the acked ones - r

[Qemu-devel] [RFC v8 10/18] virtio-iommu: Implement probe request

2018-11-09 Thread Eric Auger
This patch implements the PROBE request. At the moment, no reserved regions are returned as none are registered per device. Only a NONE property is returned. Signed-off-by: Eric Auger --- v7 -> v8: - adapt to removal of value filed in virtio_iommu_probe_property v6 -> v7: - adapt to the change

[Qemu-devel] [RFC v8 04/18] virtio-iommu: Decode the command payload

2018-11-09 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger --- v7 -> v8: - handle new domain parameter in detach - remove reserved checks v5 -> v6: - change map/unmap sema

[Qemu-devel] [RFC v8 13/18] virtio_iommu: Handle reserved regions in translation process

2018-11-09 Thread Eric Auger
When translating an address we need to check if it belongs to a reserved virtual address range. If it does, there are 2 cases: - it belongs to a RESERVED region: the guest should neither use this address in a MAP not instruct the end-point to DMA on them. We report an error - It belongs to an

[Qemu-devel] [RFC v8 12/18] virtio-iommu: Implement fault reporting

2018-11-09 Thread Eric Auger
The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 67 ++-- 2 files changed, 65 insertions(+), 3 deletions(-)

[Qemu-devel] [RFC v8 09/18] virtio-iommu: Implement translate

2018-11-09 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- v6 -> v7: - implemented bypass-mode v5 -> v6: - replace error_report by qemu_log_mask v4 -> v5: - check the device domain is not NULL - s/printf/error_report - set flags to IOMMU_NONE in case of all translation faults -

[Qemu-devel] [RFC v8 14/18] virtio-iommu-pci: Add virtio iommu pci support

2018-11-09 Thread Eric Auger
This patch adds virtio-iommu-pci, which is the pci proxy for the virtio-iommu device. Signed-off-by: Eric Auger --- hw/virtio/virtio-pci.c | 50 ++ hw/virtio/virtio-pci.h | 14 include/hw/pci/pci.h | 1 + qdev-monitor.c | 1 + 4 fi

[Qemu-devel] [RFC v8 16/18] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper

2018-11-09 Thread Eric Auger
To avoid code duplication, let's introduce an helper that fills one IORT ID mappings array index. Signed-off-by: Eric Auger --- v8: new --- hw/arm/virt-acpi-build.c | 43 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/hw/arm/virt-acpi-b

[Qemu-devel] [RFC v8 18/18] hw/arm/virt: Allow virtio-iommu instantiation

2018-11-09 Thread Eric Auger
The virtio-iommu now can be instantiated by adding the virt machine option "-M virt,iommu=virtio" Signed-off-by: Eric Auger --- hw/arm/virt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f2994c4359..d2080a1ba9 100644 --- a/hw/arm

[Qemu-devel] [RFC v8 17/18] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table

2018-11-09 Thread Eric Auger
This patch builds the virtio-iommu node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in the virtio-iommu which in turn maps to deviceid space 0x0-0x1 in the ITS group. The iommu RID (0x8) is excluded as described in virt

Re: [Qemu-devel] [PULL 0/1] 9p fixes for v3.1.0-rc1

2018-11-09 Thread Peter Maydell
On 8 November 2018 at 20:41, Greg Kurz wrote: > The following changes since commit a7ce790a029bd94eb320d8c69f38900f5233997e: > > tcg/tcg-op.h: Add multiple include guard (2018-11-08 15:15:32 +) > > are available in the Git repository at: > > https://github.com/gkurz/qemu.git tags/for-upstr

[Qemu-devel] [PATCH v1 3/3] intel-iommu: search iotlb for levels supported by the address width.

2018-11-09 Thread Yu Zhang
This patch updates vtd_lookup_iotlb() to search cached mappings only for all page levels supported by address width of current vIOMMU. Also, to cover 57-bit width, the shift of source id(VTD_IOTLB_SID_SHIFT) and of page level(VTD_IOTLB_LVL_SHIFT) are enlarged by 9 - the stride of one paging structu

[Qemu-devel] [PATCH v1 0/3] intel-iommu: add support for 5-level virtual IOMMU.

2018-11-09 Thread Yu Zhang
Intel's upcoming processors will extend maximum linear address width to 57 bits, and introduce 5-level paging for CPU. Meanwhile, the platform will also extend the maximum guest address width for IOMMU to 57 bits, thus introducing the 5-level paging for 2nd level translation(See chapter 3 in Intel

[Qemu-devel] [PATCH v1 2/3] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-11-09 Thread Yu Zhang
A 5-level paging capable VM may choose to use 57-bit IOVA address width. E.g. guest applications like DPDK prefer to use its VA as IOVA when performing VFIO map/unmap operations, to avoid the burden of managing the IOVA space. This patch extends the current vIOMMU logic to cover the extended addre

[Qemu-devel] [PATCH v1 1/3] intel-iommu: differentiate host address width from IOVA address width.

2018-11-09 Thread Yu Zhang
Currently, vIOMMU is using the value of IOVA address width, instead of the host address width(HAW) to calculate the number of reserved bits in data structures such as root entries, context entries, and entries of DMA paging structures etc. However values of IOVA address width and of the HAW may no

Re: [Qemu-devel] [PATCH] travis: Split the OSX job

2018-11-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > The current OSX job often reach the 50min Travis-CI time limit. > > Split it in two jobs, which as of this commit took: > - system: ~39min > - user:~9min > > Signed-off-by: Philippe Mathieu-Daudé I suggested a different split in: https://lists.gnu.org/a

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Thomas Huth
On 2018-11-09 12:29, Gerd Hoffmann wrote: > On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> I am also suspicious about hw/bt/ but don't know enough >>> about that subsystem to say if it could benefit from >>> using QOM objects more. >> >> I'm wondering whenever anyone

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 12:39, Thomas Huth wrote: > On 2018-11-09 12:29, Gerd Hoffmann wrote: >> On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: >>> Hi, >>> I am also suspicious about hw/bt/ but don't know enough about that subsystem to say if it could benefit from us

[Qemu-devel] [Bug 1795527] Re: Malformed audio and video output stuttering after upgrade to QEMU 3.0

2018-11-09 Thread tlloss
All issues solved by the patch. No clicks or glitches detected. Thank you. Will this be upstreamed? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1795527 Title: Malformed audio and video output st

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-09 Thread Paolo Bonzini
On 09/11/2018 13:39, Thomas Huth wrote: > On 2018-11-09 12:29, Gerd Hoffmann wrote: >> On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote: >>> Hi, >>> I am also suspicious about hw/bt/ but don't know enough about that subsystem to say if it could benefit from using QOM o

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Fredrik Noring
Hi Aleksandar, > > The R5900 reports itself as MIPS III ... > > This is very unclear. What do you mean by this? How does R5900 do that? I > can't find any trace of such intentions in R5900 docs. In QEMU, we have previously defined the R5900 as MIPS III by #define CPU_R5900 (CPU_MIPS3 | INSN_R59

Re: [Qemu-devel] [PATCH 0/2] ipmi: Allow UUID to be set for a BMC

2018-11-09 Thread Corey Minyard
On 11/8/18 5:22 PM, David Gibson wrote: On Thu, Nov 08, 2018 at 08:19:42AM -0600, miny...@acm.org wrote: The code was using the qemu UUID for the BMC. But that's really not a good method. In general, you don't want the GUID to change when you migrate, and you want the GUID to be the same betwe

Re: [Qemu-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:30 +0100 Samuel Ortiz wrote: > From: Yang Zhong > > Most of the AML build routines under acpi-build are not even > architecture specific. They can be moved to the more generic hw/acpi > folder where they could be shared across machine types and > architectures. I'd pr

Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-11-09 Thread Cornelia Huck
On Wed, 31 Oct 2018 16:56:54 + Alex Bennée wrote: > Emilio G. Cota writes: > > > On Wed, Oct 31, 2018 at 16:13:05 +, Alex Bennée wrote: > >> > @@ -353,10 +355,12 @@ void s390_cpu_unhalt(S390CPU *cpu) > >> > CPUState *cs = CPU(cpu); > >> > trace_cpu_unhalt(cs->cpu_index); > >

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Ingo Molnar
* Li Zhijian wrote: > > If the kernel initrd creation process creates an initrd which > > is larger than 2GB and also claims that it can't be placed > > with any part of it above 2GB, then that sounds like a bug > > in the initrd creation process... > > Exactly, it's a real problem. > > Add x

[Qemu-devel] [PATCH for-v3.1 3/3] target/arm: Correctly implement handling of HCR_EL2.{VI, VF}

2018-11-09 Thread Peter Maydell
In commit 8a0fc3a29fc2315325400 we tried to implement HCR_EL2.{VI,VF}, but we got it wrong and had to revert it. In that commit we implemented them as simply tracking whether there is a pending virtual IRQ or virtual FIQ. This is not correct -- these bits cause a software-generated VIRQ/VFIQ, whic

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Li Zhijian
Just noticed that there is a field xloadflags at recent protocol 60 Protocol 2.12: (Kernel 3.8) Added the xloadflags field and extension fields 61 to struct boot_params for loading bzImage and ramdisk 62 above 4G in 64bit. [snip] 617 Field name: xloadfl

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Li Zhijian
Just noticed that there is a field xloadflags at recent protocol 60 Protocol 2.12: (Kernel 3.8) Added the xloadflags field and extension fields 61 to struct boot_params for loading bzImage and ramdisk 62 above 4G in 64bit. [snip] 617 Field name: xloadfl

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-09 Thread Li Zhijian
On 11/9/2018 3:20 PM, Ingo Molnar wrote: * Li Zhijian wrote: If the kernel initrd creation process creates an initrd which is larger than 2GB and also claims that it can't be placed with any part of it above 2GB, then that sounds like a bug in the initrd creation process... Exactly, it's a re

Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-09 Thread Alberto Garcia
On Tue 06 Nov 2018 05:24:36 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> Is there any reason why some parts of the QEMU code use qemu_blockalign >> and others qemu_try_blockalign() ? From what I can see it seems to be up >> to whoever wrote it... > > As I understand, the good reason to use _try_

[Qemu-devel] [PATCH for-v3.1 0/3] Fix handling of HCR.VI and VF

2018-11-09 Thread Peter Maydell
This patchset reverts commit 8a0fc3a29fc2315325400, which tried to implement HCR.VI and VF, and then reimplements it correctly. The implementation of HCR.VI and VF in that commit is not correct -- they do not track the overall "is there a pending VIRQ or VFIQ" status, but whether there is a pendin

[Qemu-devel] [PATCH for-v3.1 2/3] target/arm: Track the state of our irq lines from the GIC explicitly

2018-11-09 Thread Peter Maydell
Currently we track the state of the four irq lines from the GIC only via the cs->interrupt_request or KVM irq state. That means that we assume that an interrupt is asserted if and only if the external line is set. This assumption is incorrect for VIRQ and VFIQ, because the HCR_EL2.{VI,VF} bits allo

[Qemu-devel] [PATCH for-v3.1 1/3] Revert "target/arm: Implement HCR.VI and VF"

2018-11-09 Thread Peter Maydell
This reverts commit 8a0fc3a29fc2315325400c738f807d0d4ae0ab7f. The implementation of HCR.VI and VF in that commit is not correct -- they do not track the overall "is there a pending VIRQ or VFIQ" status, but whether there is a pending interrupt due to "this mechanism", ie the hypervisor having set

Re: [Qemu-devel] [RFC v4 50/71] s390x: convert to cpu_interrupt_request

2018-11-09 Thread Cornelia Huck
On Thu, 25 Oct 2018 10:46:23 -0400 "Emilio G. Cota" wrote: > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Alexander Graf > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > hw/intc/s390_flic.c | 2 +- > target/

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Maciej W. Rozycki
On Fri, 9 Nov 2018, Aleksandar Markovic wrote: > > ... and DMULT, DMULTU, DDIV and DDIVU > > are part of the MIPS III ISA. They are emulated in user mode to support > > generic MIPS III programs. > > Pure MIPS III executables should not be a concern of the R5900 > emulation, but R5900 executable

[Qemu-devel] deprecating/removing bluetooth (was: Re: List of files containing devices which have not been QOMified)

2018-11-09 Thread Gerd Hoffmann
On Fri, Nov 09, 2018 at 02:16:53PM +0100, Paolo Bonzini wrote: > On 09/11/2018 13:39, Thomas Huth wrote: > > On 2018-11-09 12:29, Gerd Hoffmann wrote: > >> > >> Tried this after studying docs: > >> > >> qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard > >> > >> Segfaults right a

Re: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension

2018-11-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181106110548.4209-1-luc.mic...@greensocs.com Subject: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Gerd Hoffmann
Broken (segfaultson first keypress) and appearently unused. Signed-off-by: Gerd Hoffmann --- include/hw/bt.h | 3 - hw/bt/hid.c | 554 vl.c| 34 +--- hw/bt/Makefile.objs | 3 +- qemu-options.hx | 9 - 5 f

Re: [Qemu-devel] [PATCH 0/2] linux-user/mips: Support the n32 ABI for the R5900

2018-11-09 Thread Maciej W. Rozycki
On Fri, 9 Nov 2018, Laurent Vivier wrote: > if you have time, o32 & n32 support needs to be reworked. > > We have two binaries qemu-mips and qemu-mipsn32 sharing the same ELF > mask/magic. > > As n32 identifies a kernel ABI version, we should have only one binary > for qemu-mips and qemu-mipsn32

[Qemu-devel] [PATCH v2] pulseaudio: process audio data in smaller chunks

2018-11-09 Thread Gerd Hoffmann
The rate of pulseaudio absorbing the audio stream is used to control the the rate of the guests audio stream. When the emulated hardware uses small chunks (like intel-hda does) we need small chunks on the audio backend side too, otherwise that feedback loop doesn't work very well. Cc: Max Ehrlich

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Aleksandar Markovic
> From: Fredrik Noring > Subject: Re: [PATCH v2 4/6] target/mips: Fix decoding mechanism of special > R5900 opcodes > > > > > Could you please provide a document that would justify inclusion of these > > non-R5900 instruction in an R5900 emulation? > > Would you accept the TX79 manual mentioned

Re: [Qemu-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:24 +0100 Samuel Ortiz wrote: > ACPI tables are platform and machine type and even architecture > agnostic, and as such we want to provide an internal ACPI API that > only depends on platform agnostic information. > > For the x86 architecture, in order to build ACPI tabl

Re: [Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:25 +0100 Samuel Ortiz wrote: > This is going to be needed by the Hardware-reduced ACPI routines. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Samuel Ortiz the patch is probably misplaced withing series, if there is an e

Re: [Qemu-devel] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:32 +0100 Samuel Ortiz wrote: > The PCI hole properties are not pc or i386 specific. They belong to the > PCI host header instead. > > Signed-off-by: Samuel Ortiz > --- > include/hw/i386/pc.h | 5 - > include/hw/pci/pci_host.h | 6 ++ > 2 files changed, 6

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Fredrik Noring
Hi Aleksandar, > Tx79 mentions the opposite: that DDIV, DDIVU, DMULT, DMULTU are not > included in R5900 set. > > I think that the best solution that you exclude DDIV, DDIVU, DMULT, DMULTU > in a separate patch - there is no document to support their inclusion. As Maciej noted, the 64-bit MIPS L

Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-09 Thread Aleksandar Markovic
> From: Fredrik Noring > Subject: Re: [PATCH v2 4/6] target/mips: Fix decoding mechanism of special > R5900 opcodes > > Hi Aleksandar, > > > Tx79 mentions the opposite: that DDIV, DDIVU, DMULT, DMULTU are not > > included in R5900 set. > > > > I think that the best solution that you exclude DDI

Re: [Qemu-devel] [PATCH] qga-win: fix leaks of build_guest_disk_info()

2018-11-09 Thread Michael Roth
Quoting Marc-André Lureau (2018-11-03 08:01:43) > Introduced in commit b1ba8890e63ce9432c41c5c3fc229f54c87c9c99, vol_h > handle should be closed, and "out" cleanup should be done after > DeviceIoControl() fails. > > Signed-off-by: Marc-André Lureau Thanks, applied to qga tree: https://github.c

Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

2018-11-09 Thread Michael Roth
Quoting Peter Maydell (2018-11-08 06:52:23) > The guest-agent-core.h header was missing the usual guards > against multiple inclusion; add them. > > (Spotted by lgtm.com's static analyzer.) > > Signed-off-by: Peter Maydell Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qg

[Qemu-devel] [Bug 1795527] Re: Malformed audio and video output stuttering after upgrade to QEMU 3.0

2018-11-09 Thread Gerd Hoffmann
https://patchwork.ozlabs.org/patch/995566/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1795527 Title: Malformed audio and video output stuttering after upgrade to QEMU 3.0 Status in QEMU: New

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-09 Thread Liam Merwick
On 09/11/2018 14:14, Gerd Hoffmann wrote: Broken (segfaultson first keypress) and appearently unused. s/segfaultson/segfaults on/ s/appearently/apparently/ Signed-off-by: Gerd Hoffmann one question at the end, otherwise Reviewed-by: Liam Merwick --- include/hw/bt.h | 3 -

Re: [Qemu-devel] [PATCH 0/2] linux-user/mips: Support the n32 ABI for the R5900

2018-11-09 Thread Laurent Vivier
On 09/11/2018 15:14, Maciej W. Rozycki wrote: > On Fri, 9 Nov 2018, Laurent Vivier wrote: > >> if you have time, o32 & n32 support needs to be reworked. >> >> We have two binaries qemu-mips and qemu-mipsn32 sharing the same ELF >> mask/magic. >> >> As n32 identifies a kernel ABI version, we should

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-09 Thread Corey Minyard
On 11/8/18 12:03 PM, Peter Maydell wrote: On 8 November 2018 at 17:58, Corey Minyard wrote: On 11/8/18 8:08 AM, Peter Maydell wrote: This doesn't do anything for migration of the actual data contents. The current users of this device (hw/arm/aspeed.c and the smbus_eeprom_init() function) doesn

[Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-09 Thread Yuri Benditovich
This commit adds implementation of RX packets coalescing, compatible with requirements of Windows Hardware compatibility kit. The device enables feature VIRTIO_NET_F_RSC_EXT in host features if it supports extended RSC functionality as defined in the specification. This feature requires at least o

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 14:56, Corey Minyard wrote: > On 11/8/18 12:03 PM, Peter Maydell wrote: >> >> On 8 November 2018 at 17:58, Corey Minyard wrote: >>> >>> On 11/8/18 8:08 AM, Peter Maydell wrote: This doesn't do anything for migration of the actual data contents. The current use

[Qemu-devel] [PATCH 1/4] configure: keep track of Python version

2018-11-09 Thread Cleber Rosa
Some functionality is dependent on the Python version detected/configured on configure. While it's possible to run the Python version later and check for the version, doing it once is preferable. Also, it's a relevant information to keep in build logs, as the overall behavior of the build can be

[Qemu-devel] [PATCH 2/4] check-venv: use recorded Python version

2018-11-09 Thread Cleber Rosa
The current approach works fine, but it runs Python on every make command (even if it's not related to the venv usage). This is just an optimization, and not a change of behavior. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

  1   2   >