Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter

On Fri, Dec 01, 2017 at 01:57:49PM +0100, Juan Quintela wrote: > It will be used to store the uri tcp_port parameter. This is the only > parameter than can change and we can need to be able to connect to it. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri parameter, but it has

[Qemu-devel] [PATCHv2 2/5] net: introduce net_crc32_le() function

This provides a standard ethernet CRC32 little-endian implementation. Signed-off-by: Mark Cave-Ayland --- include/net/net.h | 2 ++ net/net.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/include/net/net.h b/include/net/net.h index 586098cb94..4afac1a9dd 1

[Qemu-devel] [PATCHv2 0/5] net: introduce common net_crc32() and net_crc32_le() functions

Whilst trying to debug a CRC32 endian issue for NIC multicast hash lookups, it struck me that it would make sense to have a common set of standard ethernet CRC32 functions (both little and big endian variants) in net.c. The first two patches introduce the relevant functions while the last 3 patche

[Qemu-devel] [PATCHv2 1/5] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function

Separate out the standard ethernet CRC32 calculation into a new net_crc32() function, renaming the constant POLYNOMIAL to POLYNOMIAL_BE to make it clear that this is a big-endian CRC32 calculation. Then remove the existing implementation from compute_mcast_idx() and call the new function in its pl

[Qemu-devel] [PATCHv2 3/5] pcnet: switch lnc_mchash() over to use net_crc32_le()

Signed-off-by: Mark Cave-Ayland --- hw/net/pcnet.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index 654455355f..c050993aa9 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -522,23 +522,9 @@ static inline void pcnet_rmd_s

[Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

Signed-off-by: Mark Cave-Ayland --- hw/net/eepro100.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 1c0def555b..4fe94b7471 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -327,26 +327,9 @@ static const

[Qemu-devel] [PATCHv2 5/5] sunhme: switch sunhme_receive() over to use net_crc32_le()

Signed-off-by: Mark Cave-Ayland --- hw/net/sunhme.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/hw/net/sunhme.c b/hw/net/sunhme.c index b1efa1b88d..df66e2630c 100644 --- a/hw/net/sunhme.c +++ b/hw/net/sunhme.c @@ -698,29 +698,6 @@ static inline vo

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/css: advertise unrestricted cssids

On 01.12.2017 15:31, Halil Pasic wrote: > Let us advertise the changes introduced by "s390x/css: unrestrict cssids" > to the management software (so it can tell are cssids unrestricted or > restricted). > > Signed-off-by: Halil Pasic > --- > > Boris says having the property on the virtual-css-br

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

On 01.12.2017 15:31, Halil Pasic wrote: > With the cssids unrestricted (commit "s390x/css: unrestrict > cssids") the s390-squash-mcss machine property should not be used. > Actually libvirt never supported this, so the expectation is that > removing it should be pretty painless. But let's play ni

Re: [Qemu-devel] [PATCH v2 0/5] target/m68k: implement 680x0 FPU (part 3)

On Wed, Nov 29, 2017 at 9:19 AM, Thomas Huth wrote: > On 29.11.2017 15:17, Laurent Vivier wrote: > > Le 29/11/2017 à 15:08, Thomas Huth a écrit : > >> On 29.11.2017 14:59, Peter Maydell wrote: > >>> On 29 November 2017 at 13:42, Laurent Vivier > wrote: > these functions come from: > >

Re: [Qemu-devel] [PATCH v2] iotests: fix 197 for vpc

Dne 5.12.2017 v 02:08 John Snow napsal(a): > VPC has some difficulty creating geometries of particular size. > However, we can indeed force it to use a literal one, so let's > do that for the sake of test 197, which is testing some specific > offsets. > > Signed-off-by: John Snow > Reviewed-by: E

Re: [Qemu-devel] [PATCH v2 0/5] target/m68k: implement 680x0 FPU (part 3)

Le 05/12/2017 à 09:56, william lin a écrit : > On Wed, Nov 29, 2017 at 9:19 AM, Thomas Huth > wrote: > > On 29.11.2017 15:17, Laurent Vivier wrote: > > Le 29/11/2017 à 15:08, Thomas Huth a écrit : > >> On 29.11.2017 14:59, Peter Maydell wrote: > >>> On 2

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

On Mon, 4 Dec 2017 19:37:26 +0100 David Hildenbrand wrote: > On 04.12.2017 18:58, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 18:56:00 +0100 > > David Hildenbrand wrote: > > > >> On 04.12.2017 18:53, Cornelia Huck wrote: > >>> On Mon, 4 Dec 2017 18:34:36 +0100 > >>> David Hildenbrand wrote

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/css: advertise unrestricted cssids

On 12/05/2017 09:28 AM, Thomas Huth wrote: > On 01.12.2017 15:31, Halil Pasic wrote: >> Let us advertise the changes introduced by "s390x/css: unrestrict cssids" >> to the management software (so it can tell are cssids unrestricted or >> restricted). >> >> Signed-off-by: Halil Pasic >> --- >> >>

Re: [Qemu-devel] [PATCH v1 for-2.12 2/5] s390x/tcg: fix and cleanup mcck injection

On Mon, 4 Dec 2017 18:27:06 +0100 David Hildenbrand wrote: > On 04.12.2017 18:20, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 13:55:02 +0100 > > David Hildenbrand wrote: > > > >> The architecture mode indication wasn't stored. The split of certain > >> 64bit fields was unnecessary. Also, the

Re: [Qemu-devel] [PATCH v1 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h

On Mon, 4 Dec 2017 18:16:15 +0100 David Hildenbrand wrote: > On 04.12.2017 18:03, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 13:55:01 +0100 > > David Hildenbrand wrote: > > > >> We'll need it later on in two places. Refactor it to just indicate the > >> valid bit. While at it, introduce a d

Re: [Qemu-devel] [PATCH 11/17] e500: derive baud from CCB clock

On Sun, Nov 26, 2017 at 03:59:09PM -0600, Michael Davidsaver wrote: > The CCB (Complex Core Bus) clock is the reference for the DUARTs > with an extra divide by 16. > > >From the mpc8540, mpc8544, and P2010 ref manuals. > CCB=333MHz, with divider=0x87a gives ~9600 baud. > 333e6 Hz/(16*0x87a) = 959

Re: [Qemu-devel] [PATCH 12/17] e500: add i2c controller to CCSR

On Sun, Nov 26, 2017 at 03:59:10PM -0600, Michael Davidsaver wrote: > Add i2c controller found on mpc8540, > mpc8544, and P2010 (newer ppc, unmodeled). This adds it unconditionally. Are there any E500 models where it doesn't exist? > > Signed-off-by: Michael Davidsaver > --- > hw/ppc/e500_ccs

Re: [Qemu-devel] [PATCH 19/25] spapr: add hcalls support for the XIVE interrupt mode

On Fri, Dec 01, 2017 at 06:46:45PM +0100, Cédric Le Goater wrote: > On 12/01/2017 05:01 AM, David Gibson wrote: > > On Thu, Nov 23, 2017 at 02:29:49PM +0100, Cédric Le Goater wrote: > >> A set of Hypervisor's call are used to configure the interrupt sources > >> and the event/notification queues of

Re: [Qemu-devel] [PATCH 13/17] e500: move PCI host bridge into CCSR

On Sun, Nov 26, 2017 at 03:59:11PM -0600, Michael Davidsaver wrote: > Signed-off-by: Michael Davidsaver Hmm. Is there anything you're *not* planning to move under the CCSR. If not, I'm really wondering if the CCSR ought to be a device in its own right, rather than just a container memory region

Re: [Qemu-devel] [PATCH 09/17] e500: move mpic under CCSR

On Sun, Nov 26, 2017 at 03:59:07PM -0600, Michael Davidsaver wrote: > Start moving code out of ppce500_init() > > Existing ppce500_init_mpic() suggests that MPIC may not be created w/ KVM. > However, ppce500_init() used mpicdev unconditionally, and would > fail if the MPIC isn't created. So requi

Re: [Qemu-devel] [PATCH 10/17] e500: move uarts CCSR

On Sun, Nov 26, 2017 at 03:59:08PM -0600, Michael Davidsaver wrote: > Signed-off-by: Michael Davidsaver > --- > hw/ppc/e500.c | 13 - > hw/ppc/e500_ccsr.c | 18 ++ > 2 files changed, 18 insertions(+), 13 deletions(-) > > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c

Re: [Qemu-devel] [PATCH v7 for-2.12 24/25] block/curl: Implement bdrv_refresh_filename()

On Mon 04 Dec 2017 07:26:02 PM CET, Max Reitz wrote: >>> +static void curl_refresh_filename(BlockDriverState *bs) >>> +{ >>> +BDRVCURLState *s = bs->opaque; >>> + >>> +if (!s->sslverify || s->cookie || >>> +s->username || s->password || s->proxyusername || s->proxypassword) >>> +

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

On 12/05/2017 04:49 PM, Avi Cohen (A) wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Tuesday, 05 December, 2017 9:19 AM To: Wei Wang; virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org; m...@redhat.com; marcandre.lur...@redhat.com; stefa...@redhat.com;

[Qemu-devel] [Bug 1736376] [NEW] CVE-2017-7471 repeated?

Public bug reported: In the hw/9pfs/9p-proxy.c file I can see the following which is changed because of CVE-2017-7471 in the hw/9pfs/9p-local.c. I might be wrong but I guess that should be changed as well. if(dir_path){ v9fs_path_sprintf(target,"%s/%s",dir_path->data,name); } else{ v9fs_path_spri

[Qemu-devel] [PATCH 3/9] block: don't keep AioContext acquired after drive_backup_prepare()

Signed-off-by: Stefan Hajnoczi --- blockdev.c | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c index 3b598f8f0e..5a56a1abf2 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1845,7 +1845,6 @@ static void external_sn

[Qemu-devel] [PATCH 5/9] block: don't keep AioContext acquired after internal_snapshot_prepare()

Signed-off-by: Stefan Hajnoczi --- blockdev.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/blockdev.c b/blockdev.c index d7ad76416e..6332a249ea 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1454,7 +1454,6 @@ struct BlkActionS

[Qemu-devel] [PATCH 0/9] blockdev: fix QMP 'transaction' with IOThreads

(This is for QEMU 2.12 because this bug is not -rc4 critical) Previously AioContext was held across QMP 'transaction' in an attempt to achieve bdrv_drained_begin/end() semantics. Nowadays we have bdrv_drained_begin/end() and the AioContext lock just protects state. Therefore there is no reason to

[Qemu-devel] [PATCH 6/9] block: drop unused BlockDirtyBitmapState->aio_context field

The dirty bitmap actions in qmp_transaction have not used AioContext since the dirty bitmap locking discipline was introduced in commit 2119882c7eb7e2c612b24fc0c8d86f5887d6f1c3 ("block: introduce dirty_bitmap_mutex"). Remove the unused field. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 13 -

[Qemu-devel] [PATCH 1/9] blockdev: hold AioContext for bdrv_unref() in external_snapshot_clean()

bdrv_unref() requires the AioContext lock because bdrv_flush() uses BDRV_POLL_WHILE(), which assumes the AioContext is currently held. If BDRV_POLL_WHILE() runs without AioContext held the pthread_mutex_unlock() call in aio_context_release() fails. This patch moves bdrv_unref() into the AioContex

[Qemu-devel] [PATCH 8/9] blockdev: add x-blockdev-set-iothread testing command

Currently there is no easy way for iotests to ensure that a BDS is bound to a particular IOThread. Normally the virtio-blk device calls blk_set_aio_context() when dataplane is enabled during guest driver initialization. This never happens in iotests since -machine accel=qtest means there is no gu

[Qemu-devel] [PATCH 2/9] block: don't keep AioContext acquired after external_snapshot_prepare()

It is not necessary to hold AioContext across transactions anymore since bdrv_drained_begin/end() is used to keep the nodes quiesced. In fact, using the AioContext lock for this purpose was always buggy. This patch reduces the scope of AioContext locked regions. This is not just a cleanup but al

[Qemu-devel] [PATCH 9/9] qemu-iotests: add 202 external snapshots IOThread test

QMP 'transaction' blockdev-snapshot-sync with multiple disks in an IOThread is an untested code path. Several bugs have been found in connection with this command. This patch adds a test case to prevent future regressions. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/202 | 95

[Qemu-devel] [PATCH 4/9] block: don't keep AioContext acquired after blockdev_backup_prepare()

Signed-off-by: Stefan Hajnoczi --- blockdev.c | 44 ++-- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5a56a1abf2..d7ad76416e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1936,7 +1936,6 @@ typedef struct Block

[Qemu-devel] [PATCH 7/9] iothread: add iothread_by_id() API

Encapsulate IOThread QOM object lookup so that callers don't need to know how and where IOThread objects live. Signed-off-by: Stefan Hajnoczi --- include/sysemu/iothread.h | 1 + iothread.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/sysemu/iothread.h b/inc

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

On 12/04/2017 01:20 AM, David Gibson wrote: > On Sat, Dec 02, 2017 at 08:46:19AM -0600, Benjamin Herrenschmidt wrote: >> On Sat, 2017-12-02 at 08:45 -0600, Benjamin Herrenschmidt wrote: >>> On Fri, 2017-12-01 at 15:10 +1100, David Gibson wrote: Hm, ok. Guest endian (or at least, not defi

Re: [Qemu-devel] [PATCH v1 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD

On Mon, 4 Dec 2017 13:55:03 +0100 David Hildenbrand wrote: > Needed for machine check handling inside Linux (when restoring registers). > > Except for SIGP and machine checks, we don't make use of the register > yet. Suficient for now. s/Suficient/Sufficient/ > > Signed-off-by: David Hildenb

Re: [Qemu-devel] [PULL 0/1] ppc-for-2.11 queue 20171205

Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171205 > > for you to fetch changes up to 044897ef4a22af89aecb8df509477beba0a2e0ce: > > target/ppc: Fix system lockups caused by interrupt_request

Re: [Qemu-devel] [PATCH v3 45/45] windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex

Ladi Prosek писал 2017-11-28 15:44: On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: [...] diff --git a/windbgstub.c b/windbgstub.c index 36372c0ea5..3bcf6a8cbb 100755 --- a/windbgstub.c +++ b/windbgstub.c @@ -224,6 +224,14 @@ static void windbg_process_manipulate_packet(ParsingContext

Re: [Qemu-devel] [PATCH v1 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h

On 05.12.2017 11:20, Cornelia Huck wrote: > On Mon, 4 Dec 2017 18:16:15 +0100 > David Hildenbrand wrote: > >> On 04.12.2017 18:03, Cornelia Huck wrote: >>> On Mon, 4 Dec 2017 13:55:01 +0100 >>> David Hildenbrand wrote: >>> We'll need it later on in two places. Refactor it to just indica

Re: [Qemu-devel] [PATCH v6 21/26] tcg: Add generic vector ops for multiplication

On Tue, 21 Nov 2017, Richard Henderson wrote: > Signed-off-by: Richard Henderson > +void tcg_gen_mul_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) > +{ > +TCGTemp *rt = tcgv_vec_temp(r); > +TCGTemp *at = tcgv_vec_temp(a); > +TCGTemp *bt = tcgv_vec_temp(b); > +TCGArg ri =

Re: [Qemu-devel] [PATCH v5 01/28] migration: better error handling with QEMUFile

* Peter Xu (pet...@redhat.com) wrote: > If the postcopy down due to some reason, we can always see this on dst: > > qemu-system-x86_64: RP: Received invalid message 0x length 0x > > However in most cases that's not the real issue. The problem is that > qemu_get_be16() has no way to show

Re: [Qemu-devel] [PATCH v7 for-2.12 24/25] block/curl: Implement bdrv_refresh_filename()

On Mon 20 Nov 2017 09:10:03 PM CET, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/curl.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/block/curl.c b/block/curl.c > index 11318a9a29..fe57223fda 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -957,

Re: [Qemu-devel] [PATCH v4 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

On 12/04/2017 08:23 PM, Max Reitz wrote: On 2017-12-04 16:17, Daniel Henrique Barboza wrote: This patch implements a test case for the scenario that was failing prior to the patch "migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END", commit acab30b85d. This new test file

[Qemu-devel] [PATCH v9 2/4] fw_cfg: do DMA read operation

Modify fw_cfg_read_blob() to use DMA if the device supports it. Return errors, because the operation may fail. The DMA operation is expected to run synchronously with today qemu, but the specification states that it may become async, so we run "control" field check in a loop for eventual changes.

[Qemu-devel] [PATCH v9 1/4] fw_cfg: add DMA register

Add an optional kernel module (or command line) parameter using the following syntax: [qemu_fw_cfg.]ioport=@[::[:]] or [qemu_fw_cfg.]mmio=@[::[:]] and initializes the register address using given or default offset. Signed-off-by: Marc-André Lureau Reviewed-by: Gabriel Somlo ---

[Qemu-devel] [PATCH v9 0/4] fw_cfg: add DMA operations & etc/vmcoreinfo support

Hi, This series adds DMA operations support to the qemu fw_cfg kernel module and populates "etc/vmcoreinfo" with vmcoreinfo location details. Note: the support for this entry handling has been merged for upcoming qemu release (2.11). v9: - do not rely on a global struct device * (Michael) - fix

[Qemu-devel] [PATCH v9 4/4] fw_cfg: write vmcoreinfo details

If the "etc/vmcoreinfo" fw_cfg file is present and we are not running the kdump kernel, write the addr/size of the vmcoreinfo ELF note. Signed-off-by: Marc-André Lureau Reviewed-by: Gabriel Somlo --- drivers/firmware/qemu_fw_cfg.c | 82 +- 1 file changed,

[Qemu-devel] [PATCH v9 3/4] crash: export paddr_vmcoreinfo_note()

The following patch is going to use the symbol from the fw_cfg module, to call the function and write the note location details in the vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. CC: Andrew Morton CC: Baoquan He CC: Dave Young CC: Dave Young CC: Hari Bathini CC: Tony

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

On 12/05/2017 09:41 AM, Thomas Huth wrote: > On 01.12.2017 15:31, Halil Pasic wrote: >> With the cssids unrestricted (commit "s390x/css: unrestrict >> cssids") the s390-squash-mcss machine property should not be used. >> Actually libvirt never supported this, so the expectation is that >> removi

Re: [Qemu-devel] About the light VM solution!

On Tue, Dec 05, 2017 at 02:33:13PM +0800, Yang Zhong wrote: > As you know, AWS has decided to switch to KVM in their clouds. This news make > almost all > china CSPs(clouds service provider) pay more attention on KVM/Qemu, > especially light VM > solution. > > Below are intel solution for light

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

On 12/05/2017 08:48 AM, Dong Jia Shi wrote: > * Dong Jia Shi [2017-12-05 15:43:00 +0800]: > >> * Cornelia Huck [2017-12-04 17:11:24 +0100]: >> >> [...] >> >> This one looks good to me too, so: >> Reviewed-by: Dong Jia Shi >> > BTW, since we are deprecating s390-squash-mcss, I think any more >

[Qemu-devel] [PATCH v2 0/1] Disk caches in VirtIO Balloon driver stats

This is a QEMU counterpart to the patch for VirtIO balloon driver posted here: https://lists.nongnu.org/archive/html/qemu-devel/2017-11/msg02106.html Tomáš Golembiovský (1): virtio-balloon: include statistics of disk/file caches hw/virtio/virtio-balloon.c | 1 + include/s

[Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches

Signed-off-by: Tomáš Golembiovský --- hw/virtio/virtio-balloon.c | 1 + include/standard-headers/linux/virtio_balloon.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 37cde38982..8141326a51

[Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") the HTAB migration stream contains a header set to "-1", meaning there is no HPT. Teach analyze-migration.py to ignore the section in this case. Without this fix, the script fails with a dump from a POWER9 guest: Traceba

Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

On 5 December 2017 at 00:59, Michael S. Tsirkin wrote: > On Mon, Dec 04, 2017 at 03:00:45PM -0500, Eric Farman wrote: >> >> >> On 12/04/2017 01:05 PM, Peter Maydell wrote: >> > On 4 December 2017 at 17:52, Eric Farman wrote: >> > > On 12/01/2017 10:16 AM, Paolo Bonzini wrote: >> > > > >> > > > On

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/css: advertise unrestricted cssids

On Tue, 5 Dec 2017 11:08:18 +0100 Halil Pasic wrote: > On 12/05/2017 09:28 AM, Thomas Huth wrote: > > On 01.12.2017 15:31, Halil Pasic wrote: > >> Let us advertise the changes introduced by "s390x/css: unrestrict cssids" > >> to the management software (so it can tell are cssids unrestricted or

Re: [Qemu-devel] [PATCH v2] pci: removed the is_express field since a uniform interface was inserted

Hi Yoni, Thanks for the patch. On 04/12/2017 12:18, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore * Dev

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

* Laurent Vivier (lviv...@redhat.com) wrote: > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") > the HTAB migration stream contains a header set to "-1", meaning there > is no HPT. Teach analyze-migration.py to ignore the section in this case. > > Without this fix, the

Re: [Qemu-devel] [PATCH v2] pci: removed the is_express field since a uniform interface was inserted

On 04/12/2017 21:46, Philippe Mathieu-Daudé wrote: Hi Yoni, Eduardo, Markus, On 12/04/2017 07:18 AM, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

On Tue, 5 Dec 2017 13:05:11 +0100 Halil Pasic wrote: > On 12/05/2017 09:41 AM, Thomas Huth wrote: > > On 01.12.2017 15:31, Halil Pasic wrote: > >> With the cssids unrestricted (commit "s390x/css: unrestrict > >> cssids") the s390-squash-mcss machine property should not be used. > >> Actually l

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

On Tue, Dec 05, 2017 at 02:46:35PM +0800, Fam Zheng wrote: > On Tue, 12/05 16:11, David Gibson wrote: > > On Tue, Dec 05, 2017 at 01:05:58PM +0800, Fam Zheng wrote: > > > On Tue, 12/05 06:49, Michael S. Tsirkin wrote: > > > > On Wed, Nov 29, 2017 at 05:18:47PM +0800, Fam Zheng wrote: > > > > > On W

Re: [Qemu-devel] [PATCH v7 for-2.12 23/25] block: Fix FIXME from "Add BDS.backing_overridden"

On Mon 20 Nov 2017 09:10:02 PM CET, Max Reitz wrote: > Said commit introduced a FIXME stating that bdrv_open_backing_file() > should set bs->backing_overridden to true not only if the file.filename > option was set, but if the "options" QDict contained any option that is > significant for any node

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

On Tue, Dec 05, 2017 at 12:44:40PM +, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: > > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") > > the HTAB migration stream contains a header set to "-1", meaning there > > is no HPT. Teach ana

Re: [Qemu-devel] [PATCH v7 for-2.12 19/25] block: Add BlockDriver.bdrv_gather_child_options

On Mon 20 Nov 2017 09:09:58 PM CET, Max Reitz wrote: > Some follow-up patches will rework the way bs->full_open_options is > refreshed in bdrv_refresh_filename(). The new implementation will remove > the need for the block drivers' bdrv_refresh_filename() implementations > to set bs->full_open_opti

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Tue, Dec 05, 2017 at 12:44:40PM +, Dr. David Alan Gilbert wrote: > > * Laurent Vivier (lviv...@redhat.com) wrote: > > > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration > > > stream") > > > the HTAB migration stream co

[Qemu-devel] [Bug 1736376] Re: CVE-2017-7471 repeated?

When using the proxy backend, all accesses to the host filesystem are handled by an external process running in a chroot() jail. No need to bother about paths in this case. CVE-2017-7471 is only applicable to the local backend, because accesses are handled by QEMU directly in this case. ** Chang

Re: [Qemu-devel] deadlock in rcu_init_lock() in usermode emulation

On 04/12/2017 18:13, Peter Maydell wrote: > Hi; in https://bugs.linaro.org/show_bug.cgi?id=3259 comment 27 > Stuart provides backtraces of a deadlock in user-mode in the RCU > code. > > How should this deadlock be broken ? Summing up: - fork thread: has mmap_lock, waits for rcu_sync_lock - RCU

Re: [Qemu-devel] [PATCH v7 for-2.12 05/25] block: Respect backing bs in bdrv_refresh_filename

On Mon 20 Nov 2017 09:09:44 PM CET, Max Reitz wrote: > @@ -5016,6 +5016,7 @@ void bdrv_refresh_filename(BlockDriverState *bs) > > opts = qdict_new(); > has_open_options = append_open_options(opts, bs); > +has_open_options |= bs->backing_overridden; > > /* If n

[Qemu-devel] [PATCH v5 0/1] savevm/loadvm with postcopy flag qemu-iotest

Changes from v4: - added a 'refcount_bits=1' constraint for internal snapshots Changes from v3: - rebased with master - file name changed from 198 to 201 - removed Creator/owner information (it can be retrieved with git) - added a migration successful check before executing savevm - removed a trai

Re: [Qemu-devel] About the light VM solution!

On 05/12/2017 13:06, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 02:33:13PM +0800, Yang Zhong wrote: >> As you know, AWS has decided to switch to KVM in their clouds. This news >> make almost all >> china CSPs(clouds service provider) pay more attention on KVM/Qemu, >> especially light VM >>

[Qemu-devel] [PATCH v5 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

This patch implements a test case for the scenario that was failing prior to the patch "migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END", commit acab30b85d. This new test file 201 was derived from the test file 181 authored by Kevin Wolf. CC: Kevin Wolf CC: Max Reitz CC:

[Qemu-devel] [PATCH] qdev: drop unused #include "sysemu/iothread.h"

Commit 1351d1ec89eabebc9fdff20451a62c413d7accc1 ("qdev: drop iothread property type") forgot to remove this include. Signed-off-by: Stefan Hajnoczi --- hw/core/qdev-properties-system.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-s

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

On Wed, 12/06 00:06, David Gibson wrote: > > > Another approach would be to have a "known good" build that runs every > > > so often. If the known good build fails, the bot disables itself (and > > > tells you to investigate). Obviously there are ways that could not > > > work as well, but it sho

Re: [Qemu-devel] About the light VM solution!

On Tue, Dec 5, 2017 at 1:35 PM, Paolo Bonzini wrote: > On 05/12/2017 13:06, Stefan Hajnoczi wrote: >> On Tue, Dec 05, 2017 at 02:33:13PM +0800, Yang Zhong wrote: >>> As you know, AWS has decided to switch to KVM in their clouds. This news >>> make almost all >>> china CSPs(clouds service provider

Re: [Qemu-devel] Debugging io deadlock

On Mon, Dec 04, 2017 at 08:22:48PM +0100, BALATON Zoltan wrote: > I'm seeing a possible deadlock that I don't know how to debug. Any hint on > how to find the cause or what should be checked further to identify the > reason why this is happening and how to fix it is greatly appreciated. > > Here a

Re: [Qemu-devel] About the light VM solution!

On 05/12/2017 14:47, Stefan Hajnoczi wrote: > On Tue, Dec 5, 2017 at 1:35 PM, Paolo Bonzini wrote: >> On 05/12/2017 13:06, Stefan Hajnoczi wrote: >>> On Tue, Dec 05, 2017 at 02:33:13PM +0800, Yang Zhong wrote: As you know, AWS has decided to switch to KVM in their clouds. This news make

Re: [Qemu-devel] [PATCH v4] gdbstub: add tracing

On Sat, Dec 02, 2017 at 08:30:37PM -0500, Doug Gale wrote: > Signed-off-by: Doug Gale > --- > Fix usage of %c in trace output, now uses 0x%02x > Fix possible sign extended char that could cause 0xfc to say 0xfffc > Add missing traces for hitting breakpoints, continuing, stepping > Fix incorrec

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

On 05/12/2017 07:00, Yang Zhong wrote: > On Mon, Dec 04, 2017 at 08:26:29PM +0800, Shannon Zhao wrote: >> Hi Yang, >> >> On 2017/12/4 20:03, Yang Zhong wrote: >>> On Fri, Dec 01, 2017 at 01:52:49PM +0100, Paolo Bonzini wrote: > On 01/12/2017 11:56, Yang Zhong wrote: >>> This issue should

Re: [Qemu-devel] [PATCH for-2.12] scsi-block: Add share-rw option

On 05/12/2017 08:19, Fam Zheng wrote: > Scsi-block doesn't use the DEFINE_BLOCK_PROPERTIES() macro so it didn't > gain the share-rw back when it was added to all other storage devices. > This option is meaningful here, and need to be used when attaching a > shared storage to guest. > > Signed-off-

Re: [Qemu-devel] [PATCH] MAITAINERS: List Fam Zheng as reviewer for SCSI patches

On 05/12/2017 08:22, Fam Zheng wrote: > Just so that I notice those patches more easily. > > Signed-off-by: Fam Zheng > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0255113470..64a138c380 100644 > --- a/MAINTAINERS > +++ b/MAINTA

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/net/eepro100.c | 19 +-- > 1 file changed, 1 insertion(+), 18 deletions(-) > > -if (carry) { > -crc = ((crc ^ POLYNOMIAL) | carry); How does this compile aft

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

On Tue, Dec 05, 2017 at 11:33:09AM +0800, Wei Wang wrote: > Vhost-pci is a point-to-point based inter-VM communication solution. This > patch series implements the vhost-pci-net device setup and emulation. The > device is implemented as a virtio device, and it is set up via the > vhost-user protoco

Re: [Qemu-devel] [PATCHv2 2/5] net: introduce net_crc32_le() function

On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: > This provides a standard ethernet CRC32 little-endian implementation. > > Signed-off-by: Mark Cave-Ayland > --- > include/net/net.h | 2 ++ > net/net.c | 22 ++ > 2 files changed, 24 insertions(+) Reviewed-by: Eric B

Re: [Qemu-devel] [PATCHv2 3/5] pcnet: switch lnc_mchash() over to use net_crc32_le()

On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/net/pcnet.c | 16 +--- > 1 file changed, 1 insertion(+), 15 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtu

Re: [Qemu-devel] [PATCHv2 5/5] sunhme: switch sunhme_receive() over to use net_crc32_le()

On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/net/sunhme.c | 25 + > 1 file changed, 1 insertion(+), 24 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-

Re: [Qemu-devel] [PATCH 1/9] blockdev: hold AioContext for bdrv_unref() in external_snapshot_clean()

On 12/05/2017 04:41 AM, Stefan Hajnoczi wrote: > bdrv_unref() requires the AioContext lock because bdrv_flush() uses > BDRV_POLL_WHILE(), which assumes the AioContext is currently held. If > BDRV_POLL_WHILE() runs without AioContext held the > pthread_mutex_unlock() call in aio_context_release() f

Re: [Qemu-devel] [PATCH 8/9] blockdev: add x-blockdev-set-iothread testing command

On 12/05/2017 04:41 AM, Stefan Hajnoczi wrote: > Currently there is no easy way for iotests to ensure that a BDS is bound > to a particular IOThread. Normally the virtio-blk device calls > blk_set_aio_context() when dataplane is enabled during guest driver > initialization. This never happens in

Re: [Qemu-devel] [PATCH 19/25] spapr: add hcalls support for the XIVE interrupt mode

On Tue, 2017-12-05 at 18:00 +1100, David Gibson wrote: > > The CPU revision. But we won't introduce XIVE exploitation mode on > > anything else than DD2.0 which has full XIVE support. Even STORE_EOI > > that we should be adding. > > Hrm. Host CPU? That's a problem - if guest visible properties

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

On 12/05/2017 06:05 AM, Halil Pasic wrote: > Good catch! Regarding omitting the machine name, I was surprised that > it works, but it does. Our documentation is a bit strange on this: we > document the machine name as non-optional: > "-machine [type=]name[,prop=value[,...]]" > but then use -machin

[Qemu-devel] [PATCH 0/4] block: Fix BlockDriver callbacks in bdrv_drain_all_begin()

I was looking into the drain functions in order to develop them a bit in the direction that Fam suggested, to unify the code between bdrv_drain() and bdrv_drain_all() a bit more, and maybe to find a place to take coroutine locks for graph changes. The first thing I found is a bug in bdrv_drain_all

[Qemu-devel] [PATCH 1/4] block: Make bdrv_drain_invoke() recursive

This change separates bdrv_drain_invoke(), which calls the BlockDriver drain callbacks, from bdrv_drain_recurse(). Instead, the function performs its own recursion now. One reason for this is that bdrv_drain_recurse() can be called multiple times bdrv_drain_recurse(), but the callbacks may only be

[Qemu-devel] [PATCH 4/4] block: bdrv_drain_recurse(): Remove unused begin parameter

Now that the bdrv_drain_invoke() calls are pulled up to the callers of bdrv_drain_recurse(), the 'begin' parameter isn't needed any more. Signed-off-by: Kevin Wolf --- block/io.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index 603f5b

[Qemu-devel] [PATCH 2/4] block: Call .drain_begin only once in bdrv_drain_all_begin()

bdrv_drain_all_begin() used to call the .bdrv_co_drain_begin() driver callback inside its polling loop. This means that how many times it got called for each node depended on long it had to poll the event loop. This is obviously not right and results in nodes that stay drained even after bdrv_drai

[Qemu-devel] [PATCH 3/4] test-bdrv-drain: Test BlockDriver callbacks for drain

This adds a test case that the BlockDriver callbacks for drain are called in bdrv_drained_all_begin/end(), and that both of them are called exactly once. Signed-off-by: Kevin Wolf --- tests/test-bdrv-drain.c | 137 tests/Makefile.include | 2 +

Re: [Qemu-devel] [PATCH v1 for-2.12 3/9] s390x/tcg: wire up SET ADDRESS LIMIT

On Mon, 4 Dec 2017 15:01:44 +0100 David Hildenbrand wrote: > Let's handle it just like KVM: > Depending on the model, this instruction may not be > provided. When this instruction is not provided, it is > checked for operand exception and privileged-opera- > tion exception, and t

Re: [Qemu-devel] [virtio-dev] [PATCH v3 2/7] vhost-pci-net: add vhost-pci-net

On Tue, Dec 05, 2017 at 11:33:11AM +0800, Wei Wang wrote: > Add the vhost-pci-net device emulation. The device uses bar 2 to expose > the remote VM's memory to the guest. The first 4KB of the the bar area > stores the metadata which describes the remote memory and vring info. This device looks lik

Re: [Qemu-devel] deadlock in rcu_init_lock() in usermode emulation

On 5 December 2017 at 13:19, Paolo Bonzini wrote: > Probably the best solution is to add start_exclusive/end_exclusive > respectively at the beginning and the end of fork_start and fork_end. > This is safer in general, as it ensures that the disappeared child > threads were quiescent. > > In fact,

Re: [Qemu-devel] [PATCH 1/4] block: Make bdrv_drain_invoke() recursive

On 05/12/2017 15:54, Kevin Wolf wrote: > } > > +bdrv_drain_invoke(bs, true); > bdrv_drain_recurse(bs, true); > } > > @@ -294,6 +298,7 @@ void bdrv_drained_end(BlockDriverState *bs) > } > > bdrv_parent_drained_end(bs); > +bdrv_drain_invoke(bs, false); > bdrv_d

Re: [Qemu-devel] [Bug 1735384] [NEW] OpenJDK JVM segfaults on qemu-sh4 (regression)

John Paul Adrian Glaubitz writes: > Public bug reported: > > Some of the recent changes introduced a regression which makes the > OpenJDK JVM crash on qemu-sh4: > > (sid-sh4-sbuild)root@nofan:/# java -version > qemu: uncaught target signal 11 (Segmentation fault) - core dumped > Segmentation fau

  1   2   3   >