On 12/05/2017 06:05 AM, Halil Pasic wrote: > Good catch! Regarding omitting the machine name, I was surprised that > it works, but it does. Our documentation is a bit strange on this: we > document the machine name as non-optional: > "-machine [type=]name[,prop=value[,...]]" > but then use -machine prop=value in the deprecation section (that's > with no name).
QemuOpts at their "finest". If it sees the first hunk as a value without an =, then that value is fed to type=name; but you are also free to make the first hunk be an explicit name=value (whether type=name or prop=value), at which point it is up to the backend whether type can be omitted. So in this case, '-machine prop=value' manages to work just fine, and it's a question of how you would convey that information in the --help documentation. > > Since the documentation doesn't make it clear that the property is > existent only for the s390-ccw-virtio family of the machines I think > being your suggestion has a lot of charm. @Connie: do you agree to > removing the machine name (type)? > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
