On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > --- > hw/net/eepro100.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) >
> - if (carry) {
> - crc = ((crc ^ POLYNOMIAL) | carry);
How does this compile after 1/5 renames POLYNOMIAL to POLYNOMIAL_BE in
net.h?
/me looks
Oh, you have a redundant definition in the .c file, which is now a dead
define. Patch 1 should be updated to remove the duplicate definitions,
and fix code to uniformly use POLYNOMIAL_BE.
But overall, I like what the series is doing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
