On 5 December 2017 at 00:59, Michael S. Tsirkin <m...@redhat.com> wrote:
> On Mon, Dec 04, 2017 at 03:00:45PM -0500, Eric Farman wrote:
>>
>>
>> On 12/04/2017 01:05 PM, Peter Maydell wrote:
>> > On 4 December 2017 at 17:52, Eric Farman <far...@linux.vnet.ibm.com> wrote:
>> > > On 12/01/2017 10:16 AM, Paolo Bonzini wrote:
>> > > >
>> > > > On 01/12/2017 16:15, Eric Farman wrote:
>> > > > > diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
>> > > > > index cd4ab05233..9c1bea8ff3 100644
>> > > > > --- a/hw/scsi/vhost-scsi.c
>> > > > > +++ b/hw/scsi/vhost-scsi.c
>> > > > > @@ -233,6 +233,8 @@ static Property vhost_scsi_properties[] = {
>> > > > > DEFINE_PROP_STRING("wwpn", VirtIOSCSICommon, conf.wwpn),
>> > > > > DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon,
>> > > > > conf.boot_tpgt,
>> > > > > 0),
>> > > > > DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon,
>> > > > > conf.num_queues,
>> > > > > 1),
>> > > > > + DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon,
>> > > > > conf.virtqueue_size,
>> > > > > + 128),
>> > > > > DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon,
>> > > > > conf.max_sectors,
>> > > > > 0xFFFF),
>> > > > > DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon,
>> > > > > conf.cmd_per_lun, 128),
>> >
>> > > Wow, super quick, thank you! Seeing conversations today, is this queued
>> > > for
>> > > -rc4, or 2.12 and backport to qemu-stable?
>> >
>> > If people can come to a consensus on whether this is -rc4 material
>> > by Tuesday 12:00 GMT that would be helpful.
>>
>> I'd vote for -rc4, since it's a new guest crash since 2.10.
>
> I think so too.
Thanks; spoke also with Paolo on irc, and have pushed this to master
for -rc4.
-- PMM
