Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-18 Thread Paolo Bonzini
- Original Message - > From: "Michael S. Tsirkin" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "alex williamson" , > borntrae...@de.ibm.com, fel...@nutanix.com > Sent: Thursday, November 17, 2016 11:33:24 PM > Subject: Re: [PATCH 2/3] virtio: access ISR atomically > > On Thu, No

Re: [Qemu-devel] [PATCH for-2.8] migration: Fix return code of ram_save_iterate()

2016-11-18 Thread Thomas Huth
On 17.11.2016 04:45, David Gibson wrote: > On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote: >> Thomas Huth wrote: >>> qemu_savevm_state_iterate() expects the iterators to return 1 >>> when they are done, and 0 if there is still something left to do. >>> However, ram_save_iterate() do

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-18 Thread Christian Borntraeger
On 11/16/2016 07:05 PM, Paolo Bonzini wrote: > Following the recent refactoring of virtio notifiers [1], more specifically > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] > by default, core virtio code requires

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-18 Thread Andrea Bolognani
On Thu, 2016-11-17 at 13:02 +1100, Alexey Kardashevskiy wrote: > > That said, considering that a big part of the PCI address > > allocation logic is based off whether the specific machine > > type exposes a legay PCI Root Bus or a PCI Express Root Bus, > > libvirt will need a way to be able to tell

[Qemu-devel] [PATCH] ipmi: fix qemu crash while migrating with ipmi

2016-11-18 Thread Zhuangyanying
From: ZhuangYanying Qemu crash in the source side while migrating, after starting ipmi service inside vm. ./x86_64-softmmu/qemu-system-x86_64 --enable-kvm -smp 4 -m 4096 \ -drive file=/work/suse/suse11_sp3_64_vt,format=raw,if=none,id=drive-virtio-disk0,cache=none \ -device virtio-blk-pci,scs

Re: [Qemu-devel] [PATCH RFC 2/2] numa: make -numa parser dynamically allocate CPUs masks

2016-11-18 Thread Igor Mammedov
On Wed, 16 Nov 2016 15:08:26 -0200 Eduardo Habkost wrote: > On Wed, Nov 16, 2016 at 05:02:56PM +0100, Igor Mammedov wrote: > > so it won't impose an additional limits on max_cpus limits > > supported by different targets. > > > > It removes global MAX_CPUMASK_BITS constant and need to > > bump i

Re: [Qemu-devel] [PATCH v5 03/17] qga/schema: improve guest-set-vcpus Returns: section

2016-11-18 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > The documentation parser we are going to add finishes a section after an > > empty line. > > Is this still true? No longer true, the parser only breaks on argument empty line, as explained in cover letter. I'll bring back the

Re: [Qemu-devel] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support

2016-11-18 Thread Cédric Le Goater
>>> +/** >>> + * Initialize the device >>> + * @param i2c the i2c device instance >>> + */ >>> +static int rx8900_init(I2CSlave *i2c) >>> +{ >>> +TRACE(*i2c, "Initialized"); >>> + >>> +return 0; >>> +} >> >> you can remove this routine. >> > > I don't think I can, core.c:i2c_slave_qdev_in

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ppc: add appropriate warning message for qemu_find_file() NULL return

2016-11-18 Thread Laurent Vivier
On 18/11/2016 02:03, Anand J wrote: > Add check for qemu_find_file() NULL return and throw a warning message > can provide better visibility to the upcoming error message if any. You should cc: email address given by ./scripts/get_maintainer.pl > Signed-off-by: Anand J > --- > hw/ppc/e500.c

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Daniel P. Berrange
On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: > On Wed, Nov 16, 2016 at 08:12:41AM +, Stefan Hajnoczi wrote: > > On Tue, Nov 15, 2016 at 10:38 PM, ashish mittal wrote: > > > On Wed, Sep 28, 2016 at 2:45 PM, Stefan Hajnoczi > > > wrote: > > >> On Tue, Sep 27, 2016 at 09:09:49PM -

Re: [Qemu-devel] [PATCH v5 11/17] docs: add master qapi texi files

2016-11-18 Thread Markus Armbruster
Marc-André Lureau writes: > The qapi2texi script generates a file to be included in a texi file. Add > "QEMU QMP Reference Manual" and "QEMU Guest Agent Protocol Reference" > master texi files. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH] hw/char/spapr_vty: Return amount of free buffer entries in vty_can_receive()

2016-11-18 Thread Thomas Huth
The can_receive() callbacks of the character devices should return the amount of characters that can be accepted at once, not just a boolean value (which rather means only one character at a time). Signed-off-by: Thomas Huth --- hw/char/spapr_vty.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

2016-11-18 Thread Zhenyu Wang
On 2016.11.17 16:51:45 -0700, Alex Williamson wrote: > On Thu, 17 Nov 2016 23:29:38 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, November 18, 2016 5:25 AM > > > > > > On Thu, 17 Nov 2016 02:16:12 +0530 > > > Kirti Wankhede wr

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-18 Thread Paolo Bonzini
On 18/11/2016 04:32, Namhyung Kim wrote: >> In addition, the firmware will need to reserve a few KB of RAM for the error >> log >> address range (I checked a real system and it reserves 8KB). The first eight >> bytes are needed for the record identifier interface, because there's no such >> thi

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-18 Thread Paolo Bonzini
On 18/11/2016 05:07, Michael S. Tsirkin wrote: > On Fri, Nov 18, 2016 at 12:32:06PM +0900, Namhyung Kim wrote: >> Btw I prefer using the kvmtool for my kernel work since it's much more >> simpler.. > > Up to you but then you should extend that to support 1.0 spec. > I strongly object to adding t

Re: [Qemu-devel] [RFC PATCH 8/8] quorum: Inline quorum_fifo_aio_cb()

2016-11-18 Thread Alberto Garcia
On Thu 10 Nov 2016 06:19:09 PM CET, Kevin Wolf wrote: > Inlining the function removes some boilerplace code and replaces > recursion by a simple loop, so the code becomes somewhat easier to > understand. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-18 Thread Alberto Garcia
On Fri 11 Nov 2016 11:22:26 AM CET, Kevin Wolf wrote: >> Honestly I don't see the point. It seems easier, more practical and >> more effective to convert bdrv_aio_* to byte ranges, especially since >> QED would be basically a rewrite. > > Well, it's an RFC for a reason, I want people to give thei

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Stefan Hajnoczi
On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: > * Daniel pointed out that there is no authentication method for taking to a > remote server. This seems a bit scary. Maybe all that is needed here is > some clarification of the security scheme for authentication? My > impression

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread Rafael David Tinoco
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => In Progress ** Changed in: qemu (Ubuntu) Assignee: (unassigned) => Rafael David Tinoco (inaddy) -- You received this bug notification because you are a member of qe

Re: [Qemu-devel] [PATCH v5 12/17] qapi: rename QAPIExprError/QAPILineError

2016-11-18 Thread Markus Armbruster
Make the summary line "qapi: Rename QAPIExprError to QAPILineError". Marc-André Lureau writes: > There is nothing specific about expressions in this exception, > the following patch will use it without expressions. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi.py | 146 > +

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread Rafael David Tinoco
** Changed in: qemu (Ubuntu Xenial) Status: New => In Progress ** Changed in: qemu (Ubuntu Yakkety) Status: New => In Progress ** Changed in: qemu (Ubuntu Xenial) Assignee: (unassigned) => Rafael David Tinoco (inaddy) ** Changed in: qemu (Ubuntu Yakkety) Assignee: (unassi

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread Louis Bouchard
** Also affects: qemu (Ubuntu Yakkety) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Zesty) Importance: Undecided Assignee: Rafael David Tinoco (inaddy) Status: In Progress ** Also affects: qemu (Ubuntu Xenial) Importance: Undecided Status: New

[Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
The guest sends discard requests as u64 sector/count pairs, but the block layer operates internally with s64/s32 pairs. The conversion leads to IO errors in the guest, the discard request is not processed. domU.cfg: 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2' domU: mkfs.e

Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
On Fri, Nov 18, Olaf Hering wrote: > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > +if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) { > +goto err; How is error handling supposed to work here? Initially I forgot the "!", which

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread Rafael David Tinoco
For Ubuntu Xenial (Mitaka), Yakkety (Newton), Zesty: Commit 0d34fbabc1 fixes the issue for vhost-net kernel. Vhost-net kernel doesn't use shared log so the verification is not used and apparmor profiles won't block the live migration. With customers using vhost-user that might still cause migration

Re: [Qemu-devel] [PATCH v5 12/17] qapi: rename QAPIExprError/QAPILineError

2016-11-18 Thread Marc-André Lureau
- Original Message - > Make the summary line "qapi: Rename QAPIExprError to QAPILineError". > ok > Marc-André Lureau writes: > > > There is nothing specific about expressions in this exception, > > the following patch will use it without expressions. > > > > Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Ketan Nilangekar
On 11/18/16, 12:56 PM, "Jeff Cody" wrote: >On Wed, Nov 16, 2016 at 08:12:41AM +, Stefan Hajnoczi wrote: >> On Tue, Nov 15, 2016 at 10:38 PM, ashish mittal wrote: >> > On Wed, Sep 28, 2016 at 2:45 PM, Stefan Hajnoczi >> > wrote: >> >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mi

[Qemu-devel] [PATCH v3 for-2.9 2/3] hw/isa/lpc_ich9: add SMI feature negotiation via APM_STS

2016-11-18 Thread Laszlo Ersek
Define and implement non-standard feature control for SMI handling via the APM_STS register, such that it remains compatible with SeaBIOS's current access pattern, and enables OVMF to negotiate features. Cc: "Kevin O'Connor" Cc: "Michael S. Tsirkin" Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-o

[Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-18 Thread Laszlo Ersek
This is v3 of the series, with updates based on the v2 discussion: . I've added feature negotiation via the APM_STS ("scratchpad") register. A new spec file called "docs/specs/q35-apm-sts.txt" is included. Tested with new OVMF

[Qemu-devel] [PATCH v3 for-2.9 3/3] hw/isa/lpc_ich9: ICH9_APM_STS_F_BROADCAST_SMI: inject SMI on all VCPUs

2016-11-18 Thread Laszlo Ersek
The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in the following ways: (1) If Trigger() is executed by the BSP (which is guaranteed before ExitBootS

[Qemu-devel] [PATCH v3 for-2.9 1/3] hw/isa/apm: introduce callback for APM_STS_IOPORT writes

2016-11-18 Thread Laszlo Ersek
In the following patches we'll add custom handling for when APM_STS_IOPORT is written. Introduce a dedicated callback similar to the one that is now called for APM_CNT_IOPORT writes. Cc: "Kevin O'Connor" Cc: "Michael S. Tsirkin" Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support

2016-11-18 Thread Vincent Palatin
On Thu, Nov 17, 2016 at 12:09 PM, Vincent Palatin wrote: > On Mon, Nov 14, 2016 at 2:09 PM, Vincent Palatin > wrote: >> On Mon, Nov 14, 2016 at 1:36 PM, Stefan Weil wrote: >>> Am 11.11.2016 um 12:28 schrieb Vincent Palatin: >>> [...] I have tested the end result on a Windows 10 Pro machine

Re: [Qemu-devel] [PATCH v2] HACKING: document #include order

2016-11-18 Thread Stefan Hajnoczi
On Wed, Nov 16, 2016 at 02:39:21PM +, Stefan Hajnoczi wrote: > It was not obvious to me why "qemu/osdep.h" must be the first #include. > This documents the rationale and the overall #include order. > > Cc: Fam Zheng > Cc: Markus Armbruster > Cc: Eric Blake > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v2 0/4] aio: experimental virtio-blk polling mode

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 08:15:11AM -0600, Karl Rister wrote: > I think these results look a bit more in line with expectations on the > quick sniff test: > > QEMU_AIO_POLL_MAX_NS IOPs >unset26,299 >125,929 >225,753 >

Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 01:24:47PM +0100, Cornelia Huck wrote: > On Thu, 17 Nov 2016 10:58:30 + > Stefan Hajnoczi wrote: > > > On Thu, Nov 17, 2016 at 09:31:18AM +0100, Cornelia Huck wrote: > > > On Wed, 16 Nov 2016 21:53:07 + > > > Stefan Hajnoczi wrote: > > > > > > > virtio_queue_noti

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Ketan Nilangekar
On 11/18/16, 3:32 PM, "Stefan Hajnoczi" wrote: >On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: >> * Daniel pointed out that there is no authentication method for taking to a >> remote server. This seems a bit scary. Maybe all that is needed here is >> some clarification of

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 07:38:45PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 01:27:49PM +, Stefan Hajnoczi wrote: > > On Thu, Nov 17, 2016 at 12:17:57AM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 16, 2016 at 09:53:06PM +, Stefan Hajnoczi wrote: > > > > Disabling not

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-18 Thread David Gibson
On Thu, Nov 17, 2016 at 01:02:57PM +1100, Alexey Kardashevskiy wrote: > On 16/11/16 01:02, Andrea Bolognani wrote: > > On Tue, 2016-11-01 at 13:46 +1100, David Gibson wrote: > >> On Mon, Oct 31, 2016 at 03:10:23PM +1100, Alexey Kardashevskiy wrote: > >>> > >>> On 31/10/16 13:53, David Gibson wrot

Re: [Qemu-devel] [PATCH for-2.8 0/3] spapr: fix breakage of memory unplug after migration

2016-11-18 Thread David Gibson
On Thu, Nov 17, 2016 at 07:40:24PM -0600, Michael Roth wrote: > These patches are based on David's ppc-for-2.8 tree, and are also > available from: > > https://github.com/mdroth/qemu/commits/spapr-cas-migration > > Currently, memory hotplugged to a pseries guest cannot be removed after > the gu

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 12:01:30PM +0100, Christian Borntraeger wrote: > On 11/16/2016 10:53 PM, Stefan Hajnoczi wrote: > > Disabling notifications during virtqueue processing reduces the number of > > exits. The virtio-net device already uses virtio_queue_set_notifications() > > but > > virtio-b

[Qemu-devel] [PATCH for-2.9] numa: make -numa parser dynamically allocate CPUs masks

2016-11-18 Thread Igor Mammedov
so it won't impose an additional limits on max_cpus limits supported by different targets. It removes global MAX_CPUMASK_BITS constant and need to bump it up whenever max_cpus is being increased for a target above MAX_CPUMASK_BITS value. Use runtime max_cpus value instead to allocate sufficiently

Re: [Qemu-devel] [PATCH] ppc: BOOK3E: nothing should be done when MSR:PR is set

2016-11-18 Thread David Gibson
On Thu, Nov 17, 2016 at 02:49:48PM +0100, Vladimir Svoboda wrote: > The server architecture (BOOK3S) specifies that any instruction that > sets MSR:PR will also set MSR:EE, IR and DR. > However there is no such behavior specification for the embedded > architecture (BOOK3E). > > Signed-off-by: Vla

Re: [Qemu-devel] [PATCH for-2.8 2/3] migration: spapr_drc: defined VMStateDescription struct

2016-11-18 Thread David Gibson
On Thu, Nov 17, 2016 at 07:40:26PM -0600, Michael Roth wrote: > From: Jianjun Duan > > To manage hotplug/unplug of dynamic resources such as PCI cards, > memory, and CPU on sPAPR guests, a firmware abstraction known as > a Dynamic Resource Connector (DRC) is used to assign a particular > dynamic

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Daniel P. Berrange
On Fri, Nov 18, 2016 at 10:57:00AM +, Ketan Nilangekar wrote: > > > > > > On 11/18/16, 3:32 PM, "Stefan Hajnoczi" wrote: > > >On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: > >> * Daniel pointed out that there is no authentication method for taking to a > >> remote server.

Re: [Qemu-devel] [PULL 0/1] Trivial patches patches

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 11:20:15AM +0100, Laurent Vivier wrote: > The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: > > Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) > > are available in the git repository at: > > git://github.com/vivier/qemu.gi

Re: [Qemu-devel] [PATCH] trace: fix generated code build break

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 02:59:13PM +0100, Greg Kurz wrote: > If the QEMU source dir is > > /var/tmp/aaa-qemu-clone > > and the build dir is > > /var/tmp/qemu-aio-poll-v2 > > Then I get an error as: > > trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events" > on inte

Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-18 Thread Paolo Bonzini
On 18/11/2016 10:51, Alberto Garcia wrote: > >>> >> Honestly I don't see the point. It seems easier, more practical and >>> >> more effective to convert bdrv_aio_* to byte ranges, especially since >>> >> QED would be basically a rewrite. >> > >> > Well, it's an RFC for a reason, I want people t

Re: [Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread ChristianEhrhardt
On Fri, Nov 18, 2016 at 11:21 AM, Rafael David Tinoco < rafael.tin...@canonical.com> wrote: > With customers using vhost-user that might > still cause migration problems, but, likely, those are the vast > minority. > It is and has migration issues in general atm anyway - see: https://lists.gnu.or

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Ketan Nilangekar
On 11/18/16, 3:32 PM, "Stefan Hajnoczi" wrote: >On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: >> * Daniel pointed out that there is no authentication method for taking to a >> remote server. This seems a bit scary. Maybe all that is needed here is >> some clarification of

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-18 Thread Christian Borntraeger
On 11/18/2016 12:02 PM, Stefan Hajnoczi wrote: > On Thu, Nov 17, 2016 at 12:01:30PM +0100, Christian Borntraeger wrote: >> On 11/16/2016 10:53 PM, Stefan Hajnoczi wrote: >>> Disabling notifications during virtqueue processing reduces the number of >>> exits. The virtio-net device already uses virt

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread Rafael David Tinoco
** Changed in: cloud-archive Status: New => In Progress ** Changed in: cloud-archive Assignee: (unassigned) => Rafael David Tinoco (inaddy) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Daniel P. Berrange
On Fri, Nov 18, 2016 at 11:36:02AM +, Ketan Nilangekar wrote: > > > > > > On 11/18/16, 3:32 PM, "Stefan Hajnoczi" wrote: > > >On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: > >> * Daniel pointed out that there is no authentication method for taking to a > >> remote server.

Re: [Qemu-devel] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

2016-11-18 Thread Kevin Wolf
Am 17.11.2016 um 15:54 hat Alberto Garcia geschrieben: > On Thu 10 Nov 2016 06:19:07 PM CET, Kevin Wolf wrote: > > +static void quorum_rewrite_entry(void *opaque) > > +{ > > +QuorumCo *co = opaque; > > +QuorumAIOCB *acb = co->acb; > > +BDRVQuorumState *s = acb->bs->opaque; > > +int

Re: [Qemu-devel] [PATCH v5 17/17] build-sys: add qapi doc generation targets

2016-11-18 Thread Markus Armbruster
Marc-André Lureau writes: > Generate and install the man and html version of QAPI documentation. > > Add it also to optional pdf/dvi/info targets. > > Also support plain-text targets docs/qemu-ga-ref.txt & docs/qemu-qmp-ref.txt. > > Signed-off-by: Marc-André Lureau > --- > Makefile |

Re: [Qemu-devel] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

2016-11-18 Thread Alberto Garcia
On Fri 18 Nov 2016 01:21:12 PM CET, Kevin Wolf wrote: >> > +/* one less rewrite to do */ >> > +acb->rewrite_count--; >> > +qemu_coroutine_enter_if_inactive(acb->co); >> >> I think you should only enter acb->co when acb->rewrite_count reaches >> zero. >> >> In all other cases the main

Re: [Qemu-devel] [PATCH 16/25] tcg/i386: Handle ctz and clz opcodes

2016-11-18 Thread Bastian Koppelmann
On 11/18/2016 12:03 AM, Richard Henderson wrote: > On 11/17/2016 11:09 PM, Bastian Koppelmann wrote: >> On 11/17/2016 08:59 PM, Richard Henderson wrote: >>> On 11/17/2016 08:53 PM, Richard Henderson wrote: On 11/17/2016 05:50 PM, Bastian Koppelmann wrote: > On 11/16/2016 08:25 PM, Richard

Re: [Qemu-devel] [PATCH v5 16/17] docs: add qemu logo

2016-11-18 Thread Markus Armbruster
Marc-André Lureau writes: > The pdf (needed by texi2pdf for vectorized images) was generated thanks > to inkscape, from the pc-bios/qemu_logo.svg file. Since we don't want to build-depend on inkscape, we need to commit the .pdf. Not that bad, as the .svg is unlikely to change. But let's explai

Re: [Qemu-devel] [PATCH] tests/postcopy: Use KVM on ppc64 only if it is KVM-HV

2016-11-18 Thread Greg Kurz
Hi Laurent, On Thu, 17 Nov 2016 21:22:33 +0100 Laurent Vivier wrote: > On 16/11/2016 15:17, Greg Kurz wrote: > > On Wed, 16 Nov 2016 14:17:47 +0100 > > Thomas Huth wrote: > > > >> On 16.11.2016 13:37, Greg Kurz wrote: > >>> On Wed, 16 Nov 2016 12:24:50 + > >>> "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

2016-11-18 Thread Alexander Graf
Juan, It looks like Lai is waiting for a reply from you on this email :). Alex On 08/30/2016 06:11 AM, Lai Jiangshan wrote: On Wed, Aug 10, 2016 at 5:03 PM, Juan Quintela wrote: Lai Jiangshan wrote: Hi First of all, I like a lot the patchset, but I would preffer to split it to find "poss

Re: [Qemu-devel] [PATCH] tests/postcopy: Use KVM on ppc64 only if it is KVM-HV

2016-11-18 Thread Laurent Vivier
On 18/11/2016 13:53, Greg Kurz wrote: > Hi Laurent, Hi Greg, > On Thu, 17 Nov 2016 21:22:33 +0100 > Laurent Vivier wrote: > >> On 16/11/2016 15:17, Greg Kurz wrote: >>> On Wed, 16 Nov 2016 14:17:47 +0100 >>> Thomas Huth wrote: >>> On 16.11.2016 13:37, Greg Kurz wrote: > On Wed,

Re: [Qemu-devel] [kvm-unit-tests PATCH 1/4] arm/arm64: GIC: basic GICv2 MMIO tests

2016-11-18 Thread Andrew Jones
Hi Andre, I'm so pleased to see this series. Thank you! On Thu, Nov 17, 2016 at 05:57:49PM +, Andre Przywara wrote: > This adds an MMIO subtest to the GIC test. > It accesses some generic GICv2 registers and does some sanity tests, > like checking for some of them being read-only. > > Signed

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Ketan Nilangekar
> On Nov 18, 2016, at 5:25 PM, Daniel P. Berrange wrote: > >> On Fri, Nov 18, 2016 at 11:36:02AM +, Ketan Nilangekar wrote: >> >> >> >> >> >>> On 11/18/16, 3:32 PM, "Stefan Hajnoczi" wrote: >>> On Fri, Nov 18, 2016 at 02:26:21AM -0500, Jeff Cody wrote: * Daniel pointed out

[Qemu-devel] [RFC Design Doc v2] Enable Shared Virtual Memory feature in pass-through scenarios

2016-11-18 Thread Liu, Yi L
What's changed from v1: a) Solution changed: Switch to extend the existing QEMU vIOMMU emulator to support virtual SVM for pass-through devices. Take use of VFIO to do data propagation. b) A SVM Virtualization Architecture diagram is added. Content ===

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Daniel P. Berrange
On Fri, Nov 18, 2016 at 01:25:43PM +, Ketan Nilangekar wrote: > > > > On Nov 18, 2016, at 5:25 PM, Daniel P. Berrange wrote: > > > >> On Fri, Nov 18, 2016 at 11:36:02AM +, Ketan Nilangekar wrote: > >> > >> > >> > >> > >> > >>> On 11/18/16, 3:32 PM, "Stefan Hajnoczi" wrote: > >>>

Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Eric Blake
On 11/18/2016 04:24 AM, Olaf Hering wrote: > The guest sends discard requests as u64 sector/count pairs, but the > block layer operates internally with s64/s32 pairs. The conversion > leads to IO errors in the guest, the discard request is not processed. Doesn't the block layer already split disca

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/4] arm/arm64: GICv2: add GICD_IPRIORITYR testing

2016-11-18 Thread Andrew Jones
On Thu, Nov 17, 2016 at 05:57:50PM +, Andre Przywara wrote: > Some tests for the IPRIORITY registers. The significant number of bits > is IMPLEMENTATION DEFINED, but should be the same for every IRQ. > Also these registers must be byte-accessible. > Check that accesses beyond the implemented IR

Re: [Qemu-devel] [kvm-unit-tests PATCH 1/4] arm/arm64: GIC: basic GICv2 MMIO tests

2016-11-18 Thread Andre Przywara
Hi Drew, On 18/11/16 13:06, Andrew Jones wrote: > Hi Andre, > > I'm so pleased to see this series. Thank you! > > On Thu, Nov 17, 2016 at 05:57:49PM +, Andre Przywara wrote: >> This adds an MMIO subtest to the GIC test. >> It accesses some generic GICv2 registers and does some sanity tests,

Re: [Qemu-devel] [PATCH v5 03/17] qga/schema: improve guest-set-vcpus Returns: section

2016-11-18 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > The documentation parser we are going to add finishes a section after an >> > empty line. >> >> Is this still true? > > No longer true, the parser only breaks on argument empty line, as explain

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-18 Thread Michael S. Tsirkin
On Fri, Nov 18, 2016 at 11:36:56AM +0100, Laszlo Ersek wrote: > This is v3 of the series, with updates based on the v2 discussion: > . > > I've added feature negotiation via the APM_STS ("scratchpad") register. > A new spec fil

Re: [Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

2016-11-18 Thread Paolo Bonzini
On 17/11/2016 22:10, Max Reitz wrote: > On 17.11.2016 21:13, Eric Blake wrote: >> Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, >> but forgot to inform the block layer that FUA unmapping of zeroes is >> supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, >> the

Re: [Qemu-devel] [PATCH v5 12/17] qapi: rename QAPIExprError/QAPILineError

2016-11-18 Thread Markus Armbruster
Marc-André Lureau writes: > - Original Message - >> Make the summary line "qapi: Rename QAPIExprError to QAPILineError". >> > > ok > >> Marc-André Lureau writes: >> >> > There is nothing specific about expressions in this exception, >> > the following patch will use it without expressi

Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
Am 18. November 2016 14:43:18 MEZ, schrieb Eric Blake : >On 11/18/2016 04:24 AM, Olaf Hering wrote: >> The guest sends discard requests as u64 sector/count pairs, but the >> block layer operates internally with s64/s32 pairs. The conversion >> leads to IO errors in the guest, the discard request is

Re: [Qemu-devel] [kvm-unit-tests PATCH 3/4] arm/arm64: GICv2: add GICD_ITARGETSR testing

2016-11-18 Thread Andrew Jones
On Thu, Nov 17, 2016 at 05:57:51PM +, Andre Przywara wrote: > Some tests for the ITARGETS registers. > Bits corresponding to non-existent CPUs must be RAZ/WI. > These registers must be byte-accessible, also check that accesses beyond > the implemented IRQ limit are actually read-as-zero/write-i

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-18 Thread Michael S. Tsirkin
On Fri, Nov 18, 2016 at 10:58:47AM +, Stefan Hajnoczi wrote: > On Thu, Nov 17, 2016 at 07:38:45PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 17, 2016 at 01:27:49PM +, Stefan Hajnoczi wrote: > > > On Thu, Nov 17, 2016 at 12:17:57AM +0200, Michael S. Tsirkin wrote: > > > > On Wed, Nov 1

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-18 Thread Michael S. Tsirkin
On Fri, Nov 18, 2016 at 09:15:32AM +0100, Christian Borntraeger wrote: > On 11/16/2016 07:05 PM, Paolo Bonzini wrote: > > Following the recent refactoring of virtio notifiers [1], more specifically > > the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to > > start/stop ioeventfd") that

[Qemu-devel] [PATCH v3 for-2.8 0/3] virtio fixes

2016-11-18 Thread Paolo Bonzini
Patch 1 fixes vhost, patches 2-3 fix Windows hibernation. v3 only adds more comments to patches 2 and 3. Paolo Paolo Bonzini (3): virtio: introduce grab/release_ioeventfd to fix vhost virtio: access ISR atomically virtio: set ISR on dataplane notifications hw/block/dataplane/virtio-blk.c

[Qemu-devel] [PATCH v3 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-18 Thread Paolo Bonzini
Following the recent refactoring of virtio notifiers [1], more specifically the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] by default, core virtio code requires 'ioeventfd_started' to be set to true/false when the

[Qemu-devel] [PATCH v3 2/3] virtio: access ISR atomically

2016-11-18 Thread Paolo Bonzini
This will be needed once dataplane will be able to set it outside the big QEMU lock. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-mmio.c | 6 +++--- hw/virtio/virtio-pci.c | 9 +++-- hw/virtio/virtio.c | 22 +- 3 files changed, 23 insertions(+), 14 deletions(

[Qemu-devel] [PATCH v3 3/3] virtio: set ISR on dataplane notifications

2016-11-18 Thread Paolo Bonzini
Dataplane has been omitting forever the step of setting ISR when an interrupt is raised. This caused little breakage, because the specification actually says that ISR may not be updated in MSI mode. Some versions of the Windows drivers however didn't clear MSI mode correctly, and proceeded using

Re: [Qemu-devel] [RFC v2 1/3] vhost-user: Add new protocol feature MTU

2016-11-18 Thread Aaron Conole
Maxime Coquelin writes: > This patch adds VHOST_USER_PROTOCOL_F_MTU protocol feature. > > If supported, QEMU sends VHOST_USER_GET_MTU request to the client, > and expects a u64 reply containing the MTU advised for the guest. > > Cc: Michael S. Tsirkin > Cc: Aaron Conole > Signed-off-by: Maxime

Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Eric Blake
On 11/18/2016 08:19 AM, Olaf Hering wrote: > Am 18. November 2016 14:43:18 MEZ, schrieb Eric Blake : >> On 11/18/2016 04:24 AM, Olaf Hering wrote: >>> The guest sends discard requests as u64 sector/count pairs, but the >>> block layer operates internally with s64/s32 pairs. The conversion >>> leads

Re: [Qemu-devel] [kvm-unit-tests PATCH 4/4] arm/arm64: GICv3: add TYPER test

2016-11-18 Thread Andrew Jones
On Thu, Nov 17, 2016 at 05:57:52PM +, Andre Przywara wrote: > Add a simple test for the GICv3 TYPER test, which does only one basic > check to ensure we have actually enough interrupt IDs if we support > LPIs. > Allow a GICv3 guest to do the common MMIO checks as well, where the > register sema

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-18 Thread Markus Armbruster
Ketan Nilangekar writes: > On 11/18/16, 12:56 PM, "Jeff Cody" wrote: [...] >>* Daniel pointed out that there is no authentication method for taking to a >> remote server. This seems a bit scary. Maybe all that is needed here is >> some clarification of the security scheme for authentication?

Re: [Qemu-devel] [PULL 0/1] ivshmem fix for 2.8

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 07:26:12PM +0400, Marc-André Lureau wrote: > The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: > > Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) > > are available in the git repository at: > > g...@github.com:elmarco/qemu

Re: [Qemu-devel] [PULL 0/1] ivshmem fix for 2.8

2016-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 07:26:12PM +0400, Marc-André Lureau wrote: > The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: > > Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) > > are available in the git repository at: > > g...@github.com:elmarco/qemu

[Qemu-devel] [PULL 1/1] trace: fix generated code build break

2016-11-18 Thread Stefan Hajnoczi
From: Greg Kurz If the QEMU source dir is /var/tmp/aaa-qemu-clone and the build dir is /var/tmp/qemu-aio-poll-v2 Then I get an error as: trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events" on integer constant TraceEvent *2_trace_events[] = { ^ tra

Re: [Qemu-devel] [PULL 0/1] ivshmem fix for 2.8

2016-11-18 Thread Marc-André Lureau
Hi On Fri, Nov 18, 2016 at 6:57 PM Stefan Hajnoczi wrote: > On Thu, Nov 17, 2016 at 07:26:12PM +0400, Marc-André Lureau wrote: > > The following changes since commit > b0bcc86d2a87456f5a276f941dc775b265b309cf: > > > > Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) > > > > ar

Re: [Qemu-devel] [RFCv2 01/12] pseries: Always use core objects for CPU construction

2016-11-18 Thread Greg Kurz
On Wed, 16 Nov 2016 09:17:44 +1100 David Gibson wrote: > Currently the pseries machine has two paths for constructing CPUs. On > newer machine type versions, which support cpu hotplug, it constructs > cpu core objects, which in turn construct CPU threads. For older machine > versions it individ

[Qemu-devel] [PULL 0/1] Tracing patches

2016-11-18 Thread Stefan Hajnoczi
The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to d4f7ca5901783578

Re: [Qemu-devel] [kvm-unit-tests PATCH 0/4] kvm-unit-tests: add first GIC MMIO tests

2016-11-18 Thread Itaru Kitayama
Hi Andre, I've verified tests you proposed to the lists finish without an issue with the kvm-arm-for-4.9-rc6 kernel. Itaru

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-18 Thread Billy Olsen
** Also affects: cloud-archive Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title: QEMU memfd_create fallback mechanism change for security driv

Re: [Qemu-devel] [PATCH 0/3] virtio: disable notifications in blk and scsi

2016-11-18 Thread Stefan Hajnoczi
On Fri, Nov 18, 2016 at 04:21:33PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 18, 2016 at 10:58:47AM +, Stefan Hajnoczi wrote: > > On Thu, Nov 17, 2016 at 07:38:45PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 17, 2016 at 01:27:49PM +, Stefan Hajnoczi wrote: > > > > On Thu, Nov 1

Re: [Qemu-devel] [PATCH v3] ivshmem: Fix 64 bit memory bar configuration

2016-11-18 Thread Michael S. Tsirkin
On Thu, Nov 17, 2016 at 08:31:03PM +0800, Zhuangyanying wrote: > From: Zhuang Yanying > > Device ivshmem property use64=0 is designed to make the device > expose a 32 bit shared memory BAR instead of 64 bit one. The > default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit >

Re: [Qemu-devel] [PATCH v3] ivshmem: Fix 64 bit memory bar configuration

2016-11-18 Thread Michael S. Tsirkin
On Fri, Nov 18, 2016 at 05:27:41PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 08:31:03PM +0800, Zhuangyanying wrote: > > From: Zhuang Yanying > > > > Device ivshmem property use64=0 is designed to make the device > > expose a 32 bit shared memory BAR instead of 64 bit one.

Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Kevin Wolf
Am 18.11.2016 um 15:35 hat Eric Blake geschrieben: > On 11/18/2016 08:19 AM, Olaf Hering wrote: > > Am 18. November 2016 14:43:18 MEZ, schrieb Eric Blake : > >> On 11/18/2016 04:24 AM, Olaf Hering wrote: > >>> The guest sends discard requests as u64 sector/count pairs, but the > >>> block layer ope

Re: [Qemu-devel] [PATCH v14 00/22] Add Mediated device support

2016-11-18 Thread Alex Williamson
On Fri, 18 Nov 2016 17:16:32 +0800 Zhenyu Wang wrote: > On 2016.11.17 16:51:45 -0700, Alex Williamson wrote: > > On Thu, 17 Nov 2016 23:29:38 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > > Sent: Friday, November 18, 2016 5:25 AM >

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2016-11-18 Thread Stefan Hajnoczi
On Fri, Nov 18, 2016 at 03:01:28PM +, Stefan Hajnoczi wrote: > The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: > > Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu

Re: [Qemu-devel] [PATCH] hw/pci: disable pci-bridge's shpc by default

2016-11-18 Thread Andrew Jones
On Wed, Nov 16, 2016 at 07:05:25PM +0200, Marcel Apfelbaum wrote: > On 11/16/2016 06:44 PM, Andrew Jones wrote: > > On Sat, Nov 05, 2016 at 06:46:34PM +0200, Marcel Apfelbaum wrote: > > > On 11/03/2016 09:40 PM, Michael S. Tsirkin wrote: > > > > On Thu, Nov 03, 2016 at 01:05:44PM +0200, Marcel Apfe

[Qemu-devel] [PULL 3/7] virtio: access ISR atomically

2016-11-18 Thread Michael S. Tsirkin
From: Paolo Bonzini This will be needed once dataplane will be able to set it outside the big QEMU lock. Reviewed-by: Stefan Hajnoczi Tested-by: Farhan Ali Tested-by: Alex Williamson Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virt

[Qemu-devel] [PATCH 5/5] sheepdog: reorganize check for overlapping requests

2016-11-18 Thread Paolo Bonzini
Wrap the code that was copied repeatedly in the two functions, sd_aio_setup and sd_aio_complete. Cc: Hitoshi Mitake Cc: Liu Yuan Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 66 ++-- 1 file changed, 30 insertions(+), 36 deletions(-) d

  1   2   >