>>> +/** >>> + * Initialize the device >>> + * @param i2c the i2c device instance >>> + */ >>> +static int rx8900_init(I2CSlave *i2c) >>> +{ >>> + TRACE(*i2c, "Initialized"); >>> + >>> + return 0; >>> +} >> >> you can remove this routine. >> > > I don't think I can, core.c:i2c_slave_qdev_init() calls it without a > guard.
ah yes. So may be, we should add a test in i2c_slave_qdev_init() and kill these : ds1338_init pxa2xx_i2c_slave_init aer915_init tosa_dac_init it looks like a good cleanup. Thanks, C.