[Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread Ashish Mittal
This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Sample command line using JSON syntax: ./qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us -vg

Re: [Qemu-devel] [PATCH V6 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-23 Thread Peter Lieven
Am 22.08.2016 um 17:19 schrieb Richard Henderson: On 08/22/2016 06:04 AM, Peter Lieven wrote: +static size_t adjust_stack_size(size_t sz) +{ +#ifdef _SC_THREAD_STACK_MIN +/* avoid stacks smaller than _SC_THREAD_STACK_MIN */ +sz = MAX(MAX(sysconf(_SC_THREAD_STACK_MIN), 0), sz); +#endif

[Qemu-devel] A question about this commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2

2016-08-23 Thread Gaohaifeng (A)
Hi Daniel & Paolo, Commit 9894dc0c "char: convert from GIOChannel to QIOChannel", about the below code segment: -static gboolean tcp_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque) +static gboolean tcp_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque) { CharDriverState

[Qemu-devel] [PATCH v5 1/2] trace: Remove 'trace_events_dstate_init'

2016-08-23 Thread Lluís Vilanova
Removes the event state array used for early initialization. Since only events with the "vcpu" property need a late initialization fixup, threats their initialization specially. Assumes that the user won't touch the state of "vcpu" events between early and late initialization (e.g., through QMP).

[Qemu-devel] [PATCH v5 0/2] trace: Simplify late initialization

2016-08-23 Thread Lluís Vilanova
Removes the need for 'trace_events_dstate_init' and does a little cleanup in how state values are modified (to avoid implicit conversions from bool). Changes in v2 = * Fix late-init state value [Daniel P. Berrange]. Changes in v3 = * Avoid implicit conversions from bool

[Qemu-devel] [PATCH v5 2/2] trace: Avoid implicit bool->integer conversions

2016-08-23 Thread Lluís Vilanova
An explicit if/else is clearer than arithmetic assuming #true is 1, while the compiler should be able to generate just as optimal code. Signed-off-by: Lluís Vilanova --- stubs/trace-control.c | 17 +++-- trace/control-target.c | 31 ++- 2 files change

[Qemu-devel] [PATCH v2 2/5] msix: Follow CODING_STYLE

2016-08-23 Thread Cao jin
CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/pci/msix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 384a29d..0aadc0c 100644 --- a/hw/pci/msix.c +++ b/hw/pci/msix.c @@ -445,8 +

[Qemu-devel] [PATCH v2 0/5] Convert msix_init() to error

2016-08-23 Thread Cao jin
v2 changelog: 1. Separate one patch out: "e1000e: remove internal interrupt flag" 2. Separate coding style related code into patch 2 3. Add commit message body for patch 1 3. Add function comment for msix_init() in patch 3 4. Convert msix_init_exclusive_bar() to error 5. Other minor changes to pat

[Qemu-devel] [PATCH v2 5/5] megasas: undo the overwrites of user configuration

2016-08-23 Thread Cao jin
Commit afea4e14 seems forgetting to undo the overwrites, which is unsuitable. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/scsi/megasas.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) di

[Qemu-devel] [PATCH v2 4/5] megasas: remove unnecessary megasas_use_msix()

2016-08-23 Thread Cao jin
megasas overwrites user configuration when msix_init() fail, to indicate internal msi state, which is unsuitable. And megasa_use_msix() is unnecessary, so remove it. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin

[Qemu-devel] [PATCH v2 3/5] pci: Convert msix_init() to Error and fix callers to check it

2016-08-23 Thread Cao jin
msix_init() reports errors with error_report(), which is wrong when it's used in realize(). The same issue was fixed for msi_init() in commit 1108b2f. For some devices like e1000e & vmxnet3 who won't fail because of msi_init's failure, suppress the error report by passing NULL error object. CC:

[Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-08-23 Thread Cao jin
The input parameters is used for creating the msix capable device, so they must obey the PCI spec, or else, it should be programming error. CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/pci/msix.c | 6 ++ 1 file changed, 2 insertions(+), 4

[Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again

2016-08-23 Thread Marc-André Lureau
Since commit 7e8449594c929, the socket connect code is blocking, because calling socket_connect() without callback is blocking. Make it non-blocking by adding a callback. Unfortunately, the callback needs many local variables that are not easy to get rid of (it can't easily create the qemu_new_net_

[Qemu-devel] [PATCH for-2.7 1/2] net: fix socket connect

2016-08-23 Thread Marc-André Lureau
Commit 7e8449594c929 changed net socket code to use socket_*() functions from include/qemu/sockets.h. However, the change broke the connection part, because socket_connect() returns a connected socket that is being ignored. Use socket_connect() return value appropriately and fix leaks on error path

[Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions

2016-08-23 Thread Marc-André Lureau
Hi, Commit 7e8449594c929 introduced multiple regressions. The most important is that the socket is actually not the one connected, due to wrong usage of socket_connect(). I fixed that along with some leak fixes, that could eventually be splitted. Secondly, connect is no longer non-blocking. The s

[Qemu-devel] [PATCH] target-arm: Add VBAR support to ARM1176 CPUs

2016-08-23 Thread Cédric Le Goater
ARM1176 CPUs support the Vector Base Address Register but currently, qemu only supports VBAR on ARMv7 CPUs. Fix this by adding a new feature ARM_FEATURE_VBAR which is used for ARMv7 and ARM1176 CPUs. Signed-off-by: Cédric Le Goater --- target-arm/cpu.c|2 ++ target-arm/cpu.h|1 +

Re: [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again

2016-08-23 Thread Cao jin
Hi, I just noticed you still using the old-style non-blocking connect(which will still block when query DNS), which will be removed (suggested by Daniel), but the patch is still on the way. So I guess maybe you should switch to QIOChannel way. FYI: http://lists.nongnu.org/archive/html/qemu-de

[Qemu-devel] [PATCH] Fix remainder field for TR_SETUP completion event

2016-08-23 Thread Hans Petter Selasky
Hi, Patch is also attached. --HPS Fix remainder field for TR_SETUP completion event. Previously the code would incorrectly report the remainder as 8 bytes. A remainder of 0 bytes should be reported when the SETUP packet is successfully transferred. Found using FreeBSD's XHCI driver. Signe

Re: [Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

2016-08-23 Thread Sascha Silbe
Dear Max, Max Reitz writes: [tests/qemu-iotests/162] [...] > +# (We need to set up a server here, because the error message for "Connection > +# refused" does not contain the destination port) > +$QEMU_NBD -p 42424 -f raw null-co:// & > +sleep 0.5 > +$QEMU_IMG info 'json:{"driver": "nbd", "host

Re: [Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

2016-08-23 Thread Max Reitz
On 2016-08-23 at 07:44, Sascha Silbe wrote: Dear Max, Max Reitz writes: [tests/qemu-iotests/162] [...] +# (We need to set up a server here, because the error message for "Connection +# refused" does not contain the destination port) +$QEMU_NBD -p 42424 -f raw null-co:// & +sleep 0.5 +$QEMU_I

Re: [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again

2016-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2016 at 06:43:54PM +0800, Cao jin wrote: > Hi, > I just noticed you still using the old-style non-blocking connect(which will > still block when query DNS), which will be removed (suggested by Daniel), > but the patch is still on the way. So I guess maybe you should switch to > QIOC

Re: [Qemu-devel] [PATCH v5 0/4] ADB improvements

2016-08-23 Thread David Gibson
On Wed, Aug 17, 2016 at 07:37:16PM -0700, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Message-id: 1471487270-1490-1-git-send-email-programmingk...@gmail.com > Subject: [Qemu-devel] [PATCH v5 0/4] ADB impr

Re: [Qemu-devel] [PATCH v2 1/2] glib: add compatibility implementation for g_dir_make_tmp()

2016-08-23 Thread Sascha Silbe
Dear Peter, Peter Maydell writes: [...] >> +#if !GLIB_CHECK_VERSION(2, 30, 0) >> +/* Not a 100% compatible implementation, but good enough for most >> + * cases. Placeholders are only supported at the end of the >> + * template. */ >> +static inline gchar *qemu_g_dir_make_tmp(gchar const *tmpl,

Re: [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again

2016-08-23 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Aug 23, 2016 at 06:43:54PM +0800, Cao jin wrote: > > Hi, > > I just noticed you still using the old-style non-blocking connect(which > > will > > still block when query DNS), which will be removed (suggested by Daniel), > > but the patch is still on the wa

[Qemu-devel] [PATCH v3] tcg: Optimize fence instructions

2016-08-23 Thread Pranith Kumar
This commit optimizes fence instructions. Two optimizations are currently implemented. These are: 1. Unnecessary duplicate fence instructions If the same fence instruction is detected consecutively, we remove one instance of it. ex: mb; mb => mb, strl; strl => strl 2. Merging weaker fe

Re: [Qemu-devel] [PATCH 0/3] docker tests fixes

2016-08-23 Thread Sascha Silbe
Dear Alex, Alex Bennée writes: > Sascha Silbe writes: > >> A couple of fixes for issues encountered while trying out the new >> docker test support. The debian-bootstrap image still doesn't build >> for me, but that's a problem for another day. > > Can you offer any details? What host OS and wh

[Qemu-devel] [PATCH V7 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-08-23 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/

[Qemu-devel] [PATCH V7 0/6] coroutine: mmap stack memory and stack size

2016-08-23 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

Re: [Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

2016-08-23 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 2016-08-23 at 07:44, Sascha Silbe wrote: >> Max Reitz writes: [tests/qemu-iotests/162] >> Using a fixed port number means multiple users won't be able to run this >> in parallel. That it's only open for a short time actually makes the >> issue a bit worse as it'

[Qemu-devel] [PATCH V7 6/6] coroutine: reduce stack size to 64kB

2016-08-23 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added i

[Qemu-devel] [PATCH V7 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-08-23 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/corouti

[Qemu-devel] [PATCH V7 2/6] coroutine: add a macro for the coroutine stack size

2016-08-23 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --

[Qemu-devel] [Bug 1615212] Re: SDL UI switching to monitor half-broken and scrolling broken

2016-08-23 Thread Cole Robinson
This is described a bit more here: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00946.html But basically it's a libsdl bug: https://bugzilla.libsdl.org/show_bug.cgi?id=3287 ** Bug watch added: bugzilla.libsdl.org/ #3287 http://bugzilla.libsdl.org/show_bug.cgi?id=3287 -- You

[Qemu-devel] [PATCH V7 5/6] oslib-posix: add a configure switch to debug stack usage

2016-08-23 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini --- configure | 19 +++ util/oslib-posix.c | 36 2 files changed, 55 insertions(+) diff

[Qemu-devel] [PATCH V7 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-23 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. The memory for the guard page is deductated from stack memory

Re: [Qemu-devel] [PATCH V7 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-23 Thread Richard Henderson
On 08/23/2016 07:21 AM, Peter Lieven wrote: > the allocated stack will be adjusted to the minimum supported stack size > by the OS and rounded up to be a multiple of the system pagesize. > Additionally an architecture dependent guard page is added to the stack > to catch stack overflows. The memory

[Qemu-devel] [PATCH] qemu-iotests: Log QMP traffic in debug mode

2016-08-23 Thread Kevin Wolf
Python tests are already annoying enough to debug. With QMP traffic available it's a little bit easier at least. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py inde

Re: [Qemu-devel] [PATCH v3 1/5] target-ppc: add vector insert instructions

2016-08-23 Thread David Gibson
On Fri, Aug 19, 2016 at 11:16:03AM +0530, Rajalakshmi Srinivasaraghavan wrote: > > > On 08/16/2016 09:48 AM, David Gibson wrote: > > On Thu, Aug 11, 2016 at 01:06:44PM +0530, Rajalakshmi Srinivasaraghavan > > wrote: > > > The following vector insert instructions are added from ISA 3.0. > > > >

Re: [Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

2016-08-23 Thread Max Reitz
On 2016-08-23 at 10:17, Sascha Silbe wrote: Dear Max, Max Reitz writes: On 2016-08-23 at 07:44, Sascha Silbe wrote: Max Reitz writes: [tests/qemu-iotests/162] Using a fixed port number means multiple users won't be able to run this in parallel. That it's only open for a short time actuall

Re: [Qemu-devel] [RFC/PATCHSET 0/3] virtio: Implement virtio pstore device (v3)

2016-08-23 Thread Namhyung Kim
Hi Joel, On Tue, Aug 23, 2016 at 7:25 PM, Joel Fernandes wrote: > From: Namhyung Kim > >> Hello, >> >> This is another iteration of the virtio-pstore work. In this patchset >> I addressed most of feedbacks from previous version and drooped the >> support for PSTORE_TYPE_CONSOLE for simplicity.

[Qemu-devel] Adding a custom monitoring device to virt machine

2016-08-23 Thread Nassim Corteggiani
Hi all, This is the first time I am playing with QEmu. I made a custom qemu device in oder to monitor all memory accesses (sdram, flash, peripherals, gpio, ...). The device is parent of TYPE_SYS_BUS_DEVICE and implements a MemoryRegionOps with read/write functions. The device is part of v

[Qemu-devel] [PULL 0/2] virtio: fixes

2016-08-23 Thread Michael S. Tsirkin
The following changes since commit 60ac136102098a70b97ab0c07bc7bf53131c: target-arm: Fix warn about implicit conversion (2016-08-12 11:12:24 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [PULL 1/2] virtio: recalculate vq->inuse after migration

2016-08-23 Thread Michael S. Tsirkin
From: Stefan Hajnoczi The vq->inuse field is not migrated. Many devices don't hold VirtQueueElements across migration so it doesn't matter that vq->inuse starts at 0 on the destination QEMU. At least virtio-serial, virtio-blk, and virtio-balloon migrate while holding VirtQueueElements. For the

[Qemu-devel] [PULL 2/2] virtio: decrement vq->inuse in virtqueue_discard()

2016-08-23 Thread Michael S. Tsirkin
From: Stefan Hajnoczi virtqueue_discard() moves vq->last_avail_idx back so the element can be popped again. It's necessary to decrement vq->inuse to avoid "leaking" the element count. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Cornel

[Qemu-devel] [PATCH 03/11] qemu-iotests/071: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/071 | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/0

[Qemu-devel] [PATCH 00/11] block: Remove BB interface from blockdev-add/del

2016-08-23 Thread Kevin Wolf
This series makes the next step towards a QAPI interface that doesn't require clients to know about BlockBackends. By removing the support for 'id' from blockdev-add, it becomes a command that always only creates a BDS (with a node name). Existing interfaces have already been changed to accept node

[Qemu-devel] [PATCH 04/11] qemu-iotests/081: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/081 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/081 b/tests/qemu-iotests/081 index

[Qemu-devel] [PATCH 02/11] qemu-iotests/067: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. In order to keep the test meaningful, some instances of query-block that want to check whether the node still exists and would now turn up empty must be converted to query-name

[Qemu-devel] [PATCH 07/11] qemu-iotests/118: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/118 | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118

[Qemu-devel] [PATCH 08/11] qemu-iotests/124: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/124 | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qem

[Qemu-devel] [PATCH 06/11] qemu-iotests/117: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/117 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/117 b/tests/qemu-iotests/117 i

[Qemu-devel] [PATCH 10/11] qemu-iotests/141: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/141 | 24 ++-- tests/qemu-iotests/141.out | 24 2 files changed, 26 insertio

[Qemu-devel] [PATCH 05/11] qemu-iotests/087: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. The test cases that test conflicts between the 'id' option to blockdev-add and existing block devices or the 'node-name' of the same command can be removed because it won't be

[Qemu-devel] [PATCH 09/11] qemu-iotests/139: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/139 | 178 +++-- tests/qemu-iotests/139.out | 4 +- 2 files changed, 59 inserti

[Qemu-devel] [PATCH 01/11] qemu-iotests/041: Avoid blockdev-add with id

2016-08-23 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 71 +++--- 1 file changed, 32 insertions(+), 39 deletions(-) diff --git a/

[Qemu-devel] [PATCH 11/11] block: Remove BB interface from blockdev-add/del

2016-08-23 Thread Kevin Wolf
With this patch, blockdev-add always works on a node level, i.e. it creates a BDS, but no BB. Consequently, x-blockdev-del doesn't need the 'device' option any more, but 'node-name' becomes mandatory. Signed-off-by: Kevin Wolf --- blockdev.c | 127 +++---

[Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)

2016-08-23 Thread Stefan Weil
Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which does not compile for Windows. Signed-off-by: Stefan Weil --- include/glib-compat.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index 8d5a7f3..3e025ca 100644 --- a/include

Re: [Qemu-devel] [PATCH] qemu-iotests: Log QMP traffic in debug mode

2016-08-23 Thread Eric Blake
On 08/23/2016 09:46 AM, Kevin Wolf wrote: > Python tests are already annoying enough to debug. With QMP traffic > available it's a little bit easier at least. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/

Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)

2016-08-23 Thread Sascha Silbe
Dear Stefan, Stefan Weil writes: > Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which > does not compile for Windows. [...] [include/glib-compat.h] > @@ -48,6 +48,7 @@ static inline gint64 qemu_g_get_monotonic_time(void) > gint g_poll_fixed(GPollFD *fds, guint nfds, gint time

Re: [Qemu-devel] [PATCH] virtio-balloon: stats vq migration spec compliance

2016-08-23 Thread Michael S. Tsirkin
On Tue, Aug 16, 2016 at 11:30:16AM +0100, Stefan Hajnoczi wrote: > On Tue, Aug 16, 2016 at 12:32:55AM +0300, Michael S. Tsirkin wrote: > > virtio spec says that devices must not touch VQs > > before DRIVER_OK is set. > > > > Additionally, balloon must not touch stats VQ > > unless the stats featur

Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-23 Thread Amit Shah
On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote: > From: Cao jin > > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC: Jason Wan

Re: [Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

2016-08-23 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 2016-08-23 at 10:17, Sascha Silbe wrote: >> Max Reitz writes: [tests/qemu-iotests/162] >>> Good idea. We can just let the script generate a random port; >>> $(($RANDOM+32768)) should do the trick. >> >> Which will fail just the same as the original version if an

Re: [Qemu-devel] [PATCH v5 0/4] ADB improvements

2016-08-23 Thread Programmingkid
On Aug 23, 2016, at 8:19 AM, David Gibson wrote: > On Wed, Aug 17, 2016 at 07:37:16PM -0700, no-re...@patchew.org wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output below for >> more information: >> >> Message-id: 1471487270-1490-1-git-send-email-programmingk..

Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)

2016-08-23 Thread Stefan Weil
Hi Sascha, On 08/23/16 21:00, Sascha Silbe wrote: Dear Stefan, Stefan Weil writes: Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which does not compile for Windows. [...] [include/glib-compat.h] @@ -48,6 +48,7 @@ static inline gint64 qemu_g_get_monotonic_time(void) gint

Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)

2016-08-23 Thread Sascha Silbe
Dear Stefan, Stefan Weil writes: > On 08/23/16 21:00, Sascha Silbe wrote: >> Stefan Weil writes: >> >>> Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which >>> does not compile for Windows. >> [...] >> This worked fine in my cross-build environment (mingw32-* on Fedora 22) >> a

Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-23 Thread Michael S. Tsirkin
On Mon, Aug 22, 2016 at 04:09:27PM +0800, Jason Wang wrote: > From: Cao jin > > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC:

[Qemu-devel] [PATCH 1/2] SDL2: only show consoles by shortcuts and not hide.

2016-08-23 Thread Andrei Karas
This fix issue with stuck keys in SDL2 if press one of shortcuts for show/hide consoles. For close any consoles except main window can be used default WM/DE action for close window. Signed-off-by: Andrei Karas --- ui/sdl2.c | 27 +-- 1 file changed, 17 insertions(+), 10 d

[Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.

2016-08-23 Thread Andrei Karas
Signed-off-by: Andrei Karas --- ui/sdl2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 4441e99..9523f64 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev) } break; case SDL_WINDOWEVEN

[Qemu-devel] [PATCH 1/2] SDL2: only show consoles by shortcuts and not hide.

2016-08-23 Thread Andrei Karas
This fix issue with stuck keys in SDL2 if press one of shortcuts for show/hide consoles. For close any consoles except main window can be used default WM/DE action for close window. Signed-off-by: Andrei Karas --- ui/sdl2.c | 27 +-- 1 file changed, 17 insertions(+), 10 d

[Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.

2016-08-23 Thread Andrei Karas
Signed-off-by: Andrei Karas --- ui/sdl2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 4441e99..9523f64 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev) } break; case SDL_WINDOWEVEN

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-23 Thread Stefan Hajnoczi
On Sun, Aug 21, 2016 at 02:15:31PM +0200, Lluís Vilanova wrote: > > Can this approach be made thread-safe? > > > If not then it would be good to consider the problem right away and > > switch to something that is thread-safe, even if it depends on the > > target architecture. > > Kind of. The eas

Re: [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow

2016-08-23 Thread Stefan Hajnoczi
On Fri, Aug 19, 2016 at 04:39:20PM +0300, Roman Kagan wrote: > Make sure that ->inuse counter on virtqueue never goes negative. > > This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, > "virtio: error out if guest exceeds virtqueue size", which, due to > signed ->inuse comparison aga

Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-23 Thread Markus Armbruster
Amit Shah writes: > On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote: >> From: Cao jin >> >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, >> E1000E_USE_MSIX >> is not necessary too, remove it now. And interrupt flag field intr_state also >> can be removed now. >> >> CC: Dm

Re: [Qemu-devel] [Qemu-stable] [PATCH 0/2] virtio: fix VirtQueue->inuse field

2016-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2016 at 08:49:35AM +0200, Peter Lieven wrote: > Am 17.08.2016 um 15:58 schrieb Stefan Hajnoczi: > > On Mon, Aug 15, 2016 at 01:54:14PM +0100, Stefan Hajnoczi wrote: > > > The VirtQueue->inuse field is not always updated correctly. These > > > patches fix > > > it. > > > > > > Ori

Re: [Qemu-devel] [PATCH 3/7] qemu-img: add more conv= conversions to dd

2016-08-23 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 04:02:30PM +0200, Reda Sallahi wrote: > On Mon, Aug 22, 2016 at 09:35:26AM -0400, Stefan Hajnoczi wrote: > > On Mon, Aug 22, 2016 at 09:55:13AM +0200, Reda Sallahi wrote: > > > @@ -4325,20 +4388,43 @@ static int img_dd(int argc, char **argv) > > > > > > for (out_pos =

Re: [Qemu-devel] [PATCH v5 0/2] trace: Simplify late initialization

2016-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2016 at 10:58:45AM +0200, Lluís Vilanova wrote: > Removes the need for 'trace_events_dstate_init' and does a little cleanup in > how > state values are modified (to avoid implicit conversions from bool). > > Changes in v2 > = > > * Fix late-init state value [Daniel P.

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-23 Thread Stefan Hajnoczi
On Sun, Aug 21, 2016 at 02:32:34PM +0200, Lluís Vilanova wrote: > Unfortuntely, I've been unable to to make dtrace recognise QEMU's events (I'm > only able to see the host kernel events). If someone with more experience on > it > can help me use dtrace with QEMU's events, I'll also add the support

[Qemu-devel] [PATCH v2] iotests: Do not rely on unavailable domains in 162

2016-08-23 Thread Max Reitz
There are some (mostly ISP-specific) name servers who will redirect non-existing domains to special hosts. In this case, we will get a different error message when trying to connect to such a host, which breaks test 162. 162 needed this specific error message so it can confirm that qemu was indeed

Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2016 at 11:12:21PM +0200, Markus Armbruster wrote: > Amit Shah writes: > > > On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote: > >> From: Cao jin > >> > >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > >> E1000E_USE_MSIX > >> is not necessary too, remove it

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread Stefan Hajnoczi
On Sat, Aug 20, 2016 at 11:42:22AM -0700, ashish mittal wrote: > I'm trying to understand how I can parse a json command line having > multiple server list (InetSocketAddressList) without the QemuOpts -> > QDict -> QAPI conversion that I am currently doing. > > block/nbd.c has been suggested, but

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread ashish mittal
Thanks Stefan, I will look at block/quorum.c. I have sent V4 of the patch with a reworked parsing logic for both JSON and URI. Both of them are quite compact now. URI parsing now follows the suggestion given by Kevin. // However, you should use the proper interfaces to implement t

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread ashish mittal
Hi Daniel, In V4 of the patch: On Mon, Aug 15, 2016 at 3:20 AM, Daniel P. Berrange wrote: >> + * Convert the json formatted command line into qapi. >> +*/ >> + >> +static int vxhs_parse_json(BlockdevOptionsVxHS *conf, >> + QDict *options, Error **errp) >> +{ >>

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread ashish mittal
Hi Kevin, Changed per your suggestion in V4 patch. Please review when you get some time. Thanks, Ashish On Mon, Aug 15, 2016 at 3:47 AM, Kevin Wolf wrote: > Am 15.08.2016 um 12:20 hat Daniel P. Berrange geschrieben: >> On Sat, Aug 13, 2016 at 09:35:12PM -0700, Ashish Mittal wrote: >> > +/* >> >

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-23 Thread Kevin Zhao
Great ~ Thanks for your valuable information~ I will try with the xml and any update I will post here. On 18 August 2016 at 21:51, Andrea Bolognani wrote: > On Thu, 2016-08-18 at 20:43 +0800, Kevin Zhao wrote: > > What's the minimum version of Qemu that support virito-1.0? > > Does Qemu 2.6 wor

Re: [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow

2016-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2016 at 05:03:32PM -0400, Stefan Hajnoczi wrote: > On Fri, Aug 19, 2016 at 04:39:20PM +0300, Roman Kagan wrote: > > Make sure that ->inuse counter on virtqueue never goes negative. > > > > This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, > > "virtio: error out if g

[Qemu-devel] igd-passthrough with Intel Core i3-6100U failed

2016-08-23 Thread 杨福来
Hello, I have realized the IGD passthrough with Intel(R) Core(TM) i7-4770 CPU,but when I change the platform with the Intel Core i3-6100U,it doesn’t have any VGA output and windows7 refuses to boot with black screen. I want to know if the igd-passthrough has other cpu restriction except the

[Qemu-devel] [PATCH 4/7] cutils: Add generic prefetch

2016-08-23 Thread Richard Henderson
There's no real knowledge of the cacheline size, just prefetching one loop ahead. Signed-off-by: Richard Henderson --- util/cutils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/cutils.c b/util/cutils.c index 4d2edd6..0f1ce1d 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -17

[Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-23 Thread Richard Henderson
Patches 1-3 remove the use of ifunc from the implementation. Patch 5 adjusts the x86 implementation a bit more to take advantage of ptest (in sse4.1) and unaligned accesses (in avx1). Patches 2 and 6 are the result of my conversation with Vijaya Kumar with respect to ThunderX. Patch 7 is the res

[Qemu-devel] [PATCH 3/7] cutils: Rearrange buffer_is_zero acceleration

2016-08-23 Thread Richard Henderson
Allow selection of several acceleration functions based on the size and alignment of the buffer. Do not require ifunc support for AVX2 acceleration. Signed-off-by: Richard Henderson --- configure | 21 +--- util/cutils.c | 357 +++--- 2 fi

[Qemu-devel] [PATCH 1/7] cutils: Remove SPLAT macro

2016-08-23 Thread Richard Henderson
This is unused and complicates the vector interface. Signed-off-by: Richard Henderson --- util/cutils.c | 4 1 file changed, 4 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index 7505fda..1c8635c 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -172,7 +172,6 @@ int qemu_fdatasyn

[Qemu-devel] [PATCH 2/7] cutils: Export only buffer_is_zero

2016-08-23 Thread Richard Henderson
Since the two users don't make use of the returned offset, beyond ensuring that the entire buffer is zero, consider the can_use_buffer_find_nonzero_offset and buffer_find_nonzero_offset functions internal. Signed-off-by: Richard Henderson --- include/qemu/cutils.h | 2 -- migration/ram.c |

[Qemu-devel] [PATCH 7/7] cutils: Rewrite ppc buffer zero checking

2016-08-23 Thread Richard Henderson
GCC versions through 6 do a poor job with the indexed addressing, and (for ppc64le) issues unnecessary xxswapd insns. Cc: qemu-...@nongnu.org Cc: David Gibson Signed-off-by: Richard Henderson --- util/cutils.c | 41 +++-- 1 file changed, 39 insertions(+), 2 d

[Qemu-devel] [PATCH 6/7] cutils: Rewrite aarch64 buffer zero checking

2016-08-23 Thread Richard Henderson
Provide 64-byte and 128-byte versions. Use dczid_el0 as a proxy for the cacheline size. Signed-off-by: Richard Henderson --- util/cutils.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index ec4bd78..fe860e8 100644

[Qemu-devel] [PATCH 5/7] cutils: Rewrite x86 buffer zero checking

2016-08-23 Thread Richard Henderson
Use unaligned load operations. Add prefetches for the next loop iteration. Add versions for avx1 and sse4.1. Signed-off-by: Richard Henderson --- util/cutils.c | 169 +- 1 file changed, 145 insertions(+), 24 deletions(-) diff --git a/util/

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-23 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1472012279-20581-1-git-send-email-...@twiddle.net Subject: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git lo

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-23 Thread Paolo Bonzini
On 24/08/2016 06:30, no-re...@patchew.org wrote: > ERROR: Use of volatile is usually wrong: see > Documentation/volatile-considered-harmful.txt > #44: FILE: util/cutils.c:289: > +__asm volatile("vmovdqu -0x80(%1),%0\n\t" Other errors can be ignored, but please use __asm__ __volatile__ h