Amit Shah <amit.s...@redhat.com> writes: > On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote: >> From: Cao jin <caoj.f...@cn.fujitsu.com> >> >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, >> E1000E_USE_MSIX >> is not necessary too, remove it now. And interrupt flag field intr_state also >> can be removed now. >> >> CC: Dmitry Fleytman <dmi...@daynix.com> >> CC: Jason Wang <jasow...@redhat.com> >> CC: Markus Armbruster <arm...@redhat.com> >> CC: Marcel Apfelbaum <mar...@redhat.com> >> CC: Michael S. Tsirkin <m...@redhat.com> >> CC: Paolo Bonzini <pbonz...@redhat.com> >> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> >> Reviewed-by: Markus Armbruster <arm...@redhat.com> >> Acked-by: Dmitry Fleytman <dmi...@daynix.com> >> Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> >> Signed-off-by: Jason Wang <jasow...@redhat.com> >> --- >> hw/net/e1000e.c | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-) > > >> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = { >> VMSTATE_MSIX(parent_obj, E1000EState), >> >> VMSTATE_UINT32(ioaddr, E1000EState), >> - VMSTATE_UINT32(intr_state, E1000EState), >> VMSTATE_UINT32(core.rxbuf_min_shift, E1000EState), >> VMSTATE_UINT8(core.rx_desc_len, E1000EState), >> VMSTATE_UINT32_ARRAY(core.rxbuf_sizes, E1000EState, > > This breaks migration - please mark that field 'unused'.
Does it matter? The device hasn't been in any released version of QEMU...