On Tue, Aug 23, 2016 at 05:03:32PM -0400, Stefan Hajnoczi wrote: > On Fri, Aug 19, 2016 at 04:39:20PM +0300, Roman Kagan wrote: > > Make sure that ->inuse counter on virtqueue never goes negative. > > > > This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, > > "virtio: error out if guest exceeds virtqueue size", which, due to > > signed ->inuse comparison against unsigned ->vring.num, manifested a bug > > in virtio-balloon where virtqueue_push() was called before the matching > > virtqueu_pop(). [That problem will be addressed in followup patches]. > > > > Signed-off-by: Roman Kagan <rka...@virtuozzo.com> > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > > Cc: Ladi Prosek <lpro...@redhat.com> > > Cc: Stefan Hajnoczi <stefa...@redhat.com> > > --- > > hw/virtio/virtio.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
I'm not merging any asserts before 2.7. Please resubmit when 2.7 is out.
