Re: [Qemu-devel] [PATCH v2] qom: object_property_add() performance improvement

2015-06-15 Thread Pavel Fedin
Hello! > 10 secs is still pretty brutal for machine init. Got any clues for > where the rest of the time is going? Every property_add_XXX() verifies that there are no duplicates. With this number of CPUs we still have thousands of properties on GIC object, so every new property still once wal

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-15 Thread Christian Borntraeger
Am 13.06.2015 um 22:10 schrieb Michael S. Tsirkin: > On Fri, Jun 12, 2015 at 01:56:37PM +0200, Christian Borntraeger wrote: >> Am 10.06.2015 um 15:13 schrieb Michael S. Tsirkin: >>> On Wed, Jun 10, 2015 at 03:02:21PM +0300, Denis V. Lunev wrote: On 09/06/15 13:37, Christian Borntraeger wrote:

Re: [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest

2015-06-15 Thread Denis V. Lunev
On 08/06/15 09:43, Denis V. Lunev wrote: On 02/05/15 13:13, Denis V. Lunev wrote: Functionality match with Linux. Patches 1 and 2 are very useful for consistent backups of Windows guests. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Michael Roth PING, 1 week till soft fre

Re: [Qemu-devel] [PATCH v3 0/6] qemu: guest agent: implement guest-exec command

2015-06-15 Thread Denis V. Lunev
On 08/06/15 09:42, Denis V. Lunev wrote: On 21/05/15 08:49, Denis V. Lunev wrote: These patches for guest-agent add the functionality to execute commands on a guest UNIX machine. These patches add the following interfaces: guest-pipe-open guest-exec guest-exec-status With these interfaces it

Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr

2015-06-15 Thread Pavel Fedin
Hello! > > +int arm_cpus_per_cluster = 8; > > This doesn't need to be global, it doesn't need to be exposed in > a header file, and it definitely doesn't need to be non-constant. > I suggest > #define ARM_CPUS_PER_CLUSTER 8 It was a #define in v3, but i decided to change this in order to allow

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Aurelien Jarno
On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > This patch fixes exception handling in MIPS. > > > MIPS instructions generate several types of exceptions. > > > When exception is generated, it br

Re: [Qemu-devel] [PATCH v2 6/9] target-microblaze: Convert pvr-full to a CPU property

2015-06-15 Thread Alistair Francis
On Mon, Jun 15, 2015 at 12:41 PM, Peter Crosthwaite wrote: > On Thu, Jun 4, 2015 at 11:42 PM, Alistair Francis > wrote: >> Originally the pvr-full PVR bits were manually set for each machine. This >> is a hassle and difficult to read, instead set them based on the CPU >> properties. >> >> Signed-

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-06-15 Thread Liviu Ionescu
> On 15 Jun 2015, at 01:36, Peter Crosthwaite > wrote: > > Liviu recently brought up a desire for arguments to QOM constructors. P8 > would probably be cleaner if this feature existed, as the number of CPUs > could be set as a constructor argument. There is no flexibility on when > this has to

Re: [Qemu-devel] [PATCH v4 2/6] target-arm: Add CNTHCTL_EL2

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 02:03, Edgar E. Iglesias wrote: > On Fri, Jun 12, 2015 at 05:51:55PM +0100, Peter Maydell wrote: >> On 5 June 2015 at 11:33, Edgar E. Iglesias wrote: >> > +{ .name = "CNTHCTL_EL2", .state = ARM_CP_STATE_BOTH, >> > + .opc0 = 3, .opc1 = 4, .crn = 14, .crm = 1, .opc2 = 0,

Re: [Qemu-devel] [PATCH] target-arm: Split cp helper API to new C file

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 03:21, Peter Crosthwaite wrote: > Move the ARM coprocessor API to a new C file. helper.c is huge and > splitting off this self contained piece increases modularity. > > Signed-off-by: Peter Crosthwaite > --- > I also need this for multi-arch where, this file needs to remain obj

Re: [Qemu-devel] [RFC] QOM design - add instance data to Object (-> add constructors)

2015-06-15 Thread Liviu Ionescu
> On 14 Jun 2015, at 15:43, Liviu Ionescu wrote: > > in practical terms this means that realize() should be called right after > creation, immediately after setting the properties: > > DeviceState *mcu = qdev_create(NULL, TYPE_STM32F103RB); > { > qdev_prop_set_uint32(mcu, "hse-freq-h

Re: [Qemu-devel] [PATCH 3/5] arm: Support thumb in set_pc routines

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 04:48, Peter Crosthwaite wrote: > ARM program counters are always at least 16b aligned with the LSB > being only used the indicate thumb mode in exchange situations. Mask > this bit off in set_pc to ignore the exchange semantic (which must > still be managed by the caller). > >

Re: [Qemu-devel] [PATCH 4/5] arm: boot: Use cpu_set_pc

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 04:48, Peter Crosthwaite wrote: > Use cpu_set_pc across the board for setting program counters. This > removes instances of system level code having to reach into the CPU > env. > > Signed-off-by: Peter Crosthwaite > --- > hw/arm/boot.c | 16 > 1 file changed,

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > > This patch fixes exception handling in MIPS. > > > > MIPS instructions generate severa

Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 08:13, Pavel Fedin wrote: > Hello! > >> > +int arm_cpus_per_cluster = 8; >> >> This doesn't need to be global, it doesn't need to be exposed in >> a header file, and it definitely doesn't need to be non-constant. >> I suggest >> #define ARM_CPUS_PER_CLUSTER 8 > > It was a #def

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-15 Thread Jason Wang
On 06/12/2015 10:28 PM, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2015 at 03:55:33PM +0800, Jason Wang wrote: >> >> On 06/11/2015 08:13 PM, Michael S. Tsirkin wrote: >>> On Thu, Jun 11, 2015 at 02:10:48PM +0200, Thibaut Collet wrote: I am not sure to understand your remark: > It n

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > > This patch fixes exception handling in MIPS. > > > > MIPS instructions generate severa

Re: [Qemu-devel] [PATCH v2 4/9] target-microblaze: Convert endi to a CPU property

2015-06-15 Thread Alistair Francis
On Mon, Jun 15, 2015 at 12:31 PM, Peter Crosthwaite wrote: > On Thu, Jun 4, 2015 at 11:41 PM, Alistair Francis > wrote: >> Originally the endi PVR bits were manually set for each machine. This >> is a hassle and difficult to read, instead set them based on the CPU >> properties. >> >> Signed-off-

Re: [Qemu-devel] [RFC PATCH v1 3/4] numa: Store boot memory address range in node_info

2015-06-15 Thread David Gibson
On Fri, Jun 12, 2015 at 02:30:27PM +0530, Bharata B Rao wrote: > Store memory address range information of boot memory in address > range list of numa_info. > > This helps to have a common NUMA node lookup by address function that > works for both boot time memory and hotplugged memory. > > Sign

Re: [Qemu-devel] [PATCH v4 3/8] cpus: Add a macro to walk CPUs in reverse

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 11:39:18PM +0900, Andreas Färber wrote: > Am 05.06.2015 um 13:25 schrieb Bharata B Rao: > > Add CPU_FOREACH_REVERSE that walks CPUs in reverse. > > > > Needed for PowerPC CPU device tree reorganization. > > > > Signed-off-by: Bharata B Rao > > Cc: Andreas Färber > > ---

Re: [Qemu-devel] [RFC PATCH v1 2/4] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-15 Thread David Gibson
On Fri, Jun 12, 2015 at 02:30:26PM +0530, Bharata B Rao wrote: > Start storing the (start_addr, size, nodeid) of the pc-dimm memory > in numa_info so that this information can be used to lookup > node by address. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson -- David Gibson

Re: [Qemu-devel] [PATCH v4 2/8] spapr: Support ibm, lrdr-capacity device tree property

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 09:55:52AM +0530, Bharata B Rao wrote: > Add support for ibm,lrdr-capacity since this is needed by the guest > kernel to know about the possible hot-pluggable CPUs and Memory. With > this, pseries kernels will start reporting correct maxcpus in > /sys/devices/system/cpu/poss

Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 05:55:20PM +1000, Alexey Kardashevskiy wrote: > On 06/05/2015 05:06 PM, Bharata B Rao wrote: > >On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote: > >>> > >>>-ret = fdt_setprop(fdt, offset, "ibm,pft-size", > >>>- pft_size_p

[Qemu-devel] [PATCH v7 0/2] monitor: add memory search commands s, sp

2015-06-15 Thread hw . claudio
From: Claudio Fontana Note: this series is rebased on Peter Crosthwaite's series: "[PATCH v2 0/2] monitor+disas: Remove uses of ENV_GET_CPU" http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg04736.html This is the latest iteration of the monitor memory search patch. The previous versi

Re: [Qemu-devel] [RFC PATCH v1 1/4] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-15 Thread David Gibson
On Fri, Jun 12, 2015 at 02:30:25PM +0530, Bharata B Rao wrote: > pc_dimm_plug() has code that will be needed for memory plug handlers > in other archs too. Extract code from pc_dimm_plug() into a generic > routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also > correspondingly refactor re-u

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > Factor out bits of sPAPR specific CPU initialization code into > a separate routine so that it can be called from CPU hotplug > path too. > > While at this, use MSR_EP define instead of using 6 directly. Don't do this please. MSR[E

Re: [Qemu-devel] [PATCH v4 8/8] xics_kvm: Add cpu_destroy method to XICS

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 02:45:59PM +0530, Bharata B Rao wrote: > On Fri, Jun 05, 2015 at 06:09:38PM +1000, Alexey Kardashevskiy wrote: > > On 06/05/2015 02:25 PM, Bharata B Rao wrote: > > >XICS is setup for each CPU during initialization. Provide a routine > > >to undo the same when CPU is unplugge

Re: [Qemu-devel] [PATCH v4 7/8] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 09:55:57AM +0530, Bharata B Rao wrote: > When supporting CPU hot removal by parking the vCPU fd and reusing > it during hotplug again, there can be cases where we try to reenable > KVM_CAP_IRQ_XICS CAP for the vCPU for which it was already enabled. > Introduce a boolean memb

Re: [Qemu-devel] [RFC PATCH v1 4/4] numa: API to lookup NUMA node by address

2015-06-15 Thread David Gibson
On Fri, Jun 12, 2015 at 02:30:28PM +0530, Bharata B Rao wrote: > Introduce an API numa_get_node(ram_addr_t addr, Error **errp) that > returns the NUMA node to which the given address belongs to. This > API works uniformly for both boot time as well as hotplugged memory. > > This API is needed by s

[Qemu-devel] [PATCH v7 1/2] util: add memmem replacement function

2015-06-15 Thread hw . claudio
From: Claudio Fontana if the memmem function is missing, provide a trivial replacement. Signed-off-by: Claudio Fontana Reviewed-by: Eric Blake Acked-by: Luiz Capitulino --- configure| 15 + include/qemu/osdep.h | 4 util/Makefile.objs | 1 + util/memmem.c

Re: [Qemu-devel] [PATCH v4 1/8] spapr: Consider max_cpus during xics initialization

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 06:01:53PM +1000, Alexey Kardashevskiy wrote: > On 06/05/2015 05:07 PM, Bharata B Rao wrote: > >On Fri, Jun 05, 2015 at 03:30:24PM +1000, Alexey Kardashevskiy wrote: > >>On 06/05/2015 02:25 PM, Bharata B Rao wrote: > >>>Use max_cpus instead of smp_cpus when intializating xic

[Qemu-devel] [PATCH v7 2/2] monitor: add memory search commands s, sp

2015-06-15 Thread hw . claudio
From: Claudio Fontana usage is similar to the commands x, xp. Example with string: looking for "ELF" header in memory: (qemu) s/100cb 0x40001000 "ELF" searching memory area [40001000-400f5240] 40090001 (qemu) x/20b 0x4009 4009: '\x7f' 'E' 'L' 'F' '\x0

Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr

2015-06-15 Thread Pavel Fedin
Hello! > For machine models to specify topology we would need a property > or properties on the QOM object for the machine model to set, On which object? There's no single object inside a machine model. Of course you can expose MP IDs of CPU objects as properties and set them, but isn't it mo

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-15 Thread Thomas Huth
On Mon, 15 Jun 2015 16:59:08 +1000 David Gibson wrote: > On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > > Factor out bits of sPAPR specific CPU initialization code into > > a separate routine so that it can be called from CPU hotplug > > path too. > > > > While at this, use MSR

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 12:50:08PM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2015-06-14 at 17:59 -0400, Kevin O'Connor wrote: > > There are x86 systems with multiple separate PCI root buses where one > > can access the pci config space of all the buses using the same 0x0cf8 > > IO space. Duri

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Aurelien Jarno
On 2015-06-15 10:39, Pavel Dovgaluk wrote: > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > > > This patch fixes exception handli

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Aurelien Jarno
On 2015-06-15 10:48, Pavel Dovgaluk wrote: > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > > > This patch fixes exception handli

Re: [Qemu-devel] [PATCH 08/12] qapi: support nested structs in OptsVisitor

2015-06-15 Thread Gerd Hoffmann
Hi, Adding qapi maintainers to Cc, full for them quote below, please review. For your next patch submission: There is a "MAINTAINERS" file with the people listed. There is a scripts/get_maintainer.pl scripts which will do the lookup for you (accepts patch as input, prints maintainers). You c

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 03:43:13PM +0800, Jason Wang wrote: > > > On 06/12/2015 10:28 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 12, 2015 at 03:55:33PM +0800, Jason Wang wrote: > >> > >> On 06/11/2015 08:13 PM, Michael S. Tsirkin wrote: > >>> On Thu, Jun 11, 2015 at 02:10:48PM +0200, Thibaut C

Re: [Qemu-devel] [PATCH 00/12] -audiodev option

2015-06-15 Thread Gerd Hoffmann
Hi, > This series of patches adds a new -audiodev command line option to specify > audio > subsytem parameters instead of environment variables. This will later allow us > to specify multiple audio backends. The syntax is something like this: > -audiodev driver_name,property=value,... > like:

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-15 Thread Marcel Apfelbaum
On 06/15/2015 09:50 AM, Gerd Hoffmann wrote: Hi, I'm wondering whenever things become easier if we add config registers to the pxb, where the firmware can program the bus number range and we can use the config register base as a way to specify which pxb we are referring to ? ... and, while

Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr

2015-06-15 Thread Igor Mammedov
On Mon, 15 Jun 2015 11:13:52 +0300 Pavel Fedin wrote: > Hello! > > > For machine models to specify topology we would need a property > > or properties on the QOM object for the machine model to set, > > On which object? There's no single object inside a machine model. Of course > you can exp

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 09:01:53AM +0200, Christian Borntraeger wrote: > Am 13.06.2015 um 22:10 schrieb Michael S. Tsirkin: > > On Fri, Jun 12, 2015 at 01:56:37PM +0200, Christian Borntraeger wrote: > >> Am 10.06.2015 um 15:13 schrieb Michael S. Tsirkin: > >>> On Wed, Jun 10, 2015 at 03:02:21PM +03

Re: [Qemu-devel] CPU hot unplug support for x86_64

2015-06-15 Thread Igor Mammedov
On Thu, 11 Jun 2015 10:39:05 +0300 Fahri Cihan Demirci wrote: > On Tue, Jun 09, 2015 at 05:44:15PM +0200, Eduardo Otubo wrote: > > Hello all, > > > > I'm a little confused by all the email traffic I've seen on this list > > lately so I guess asking doesn't hurt: How's the current status > > rega

Re: [Qemu-devel] RFC Multi-threaded TCG design document

2015-06-15 Thread Frederic Konrad
On 12/06/2015 18:37, Alex Bennée wrote: Hi, Hi Alex, I've completed some of the points below. We will also work on a design decisions document to add to this one. We probably want to merge that with what we did on the wiki? http://wiki.qemu.org/Features/tcg-multithread One thing that Pete

Re: [Qemu-devel] [RFC PATCH v1 2/4] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-15 Thread Igor Mammedov
On Fri, 12 Jun 2015 14:30:26 +0530 Bharata B Rao wrote: > Start storing the (start_addr, size, nodeid) of the pc-dimm memory > in numa_info so that this information can be used to lookup > node by address. > > Signed-off-by: Bharata B Rao > --- > hw/mem/pc-dimm.c | 4 > include/syse

Re: [Qemu-devel] [PULL 00/10] Block patches

2015-06-15 Thread Peter Maydell
On 12 June 2015 at 15:57, Stefan Hajnoczi wrote: > The following changes since commit d8e3b729cf452d2689c8669f1ec18158db29fd5a: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-06-11 15:33:38 +0100) > > are available in the git repository at: > > git://git

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 08:01:08AM +0200, Gerd Hoffmann wrote: > On Fr, 2015-06-12 at 09:23 -0400, Kevin O'Connor wrote: > > On Fri, Jun 12, 2015 at 03:17:27PM +0300, Marcel Apfelbaum wrote: > > > On 06/12/2015 09:00 AM, Gerd Hoffmann wrote: > > > >>On each boot, coreboot might decide to assign a d

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-15 Thread Christian Borntraeger
Am 15.06.2015 um 11:06 schrieb Michael S. Tsirkin: >>> AFAIK management tools depend on balloon not deflating >>> below host-specified threshold to avoid OOM on the host. >>> So I don't think we can make this a default, >>> management needs to enable this explicitly. >> >> If the ballooning is req

Re: [Qemu-devel] RFC Multi-threaded TCG design document

2015-06-15 Thread Alex Bennée
Frederic Konrad writes: > On 12/06/2015 18:37, Alex Bennée wrote: >> Hi, > > Hi Alex, > > I've completed some of the points below. We will also work on a design > decisions > document to add to this one. > > We probably want to merge that with what we did on the wiki? > http://wiki.qemu.org/Fea

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 11:59:05AM +0200, Christian Borntraeger wrote: > Am 15.06.2015 um 11:06 schrieb Michael S. Tsirkin: > > >>> AFAIK management tools depend on balloon not deflating > >>> below host-specified threshold to avoid OOM on the host. > >>> So I don't think we can make this a defaul

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-15 Thread Gerd Hoffmann
Hi, > > I'm wondering whenever things become easier if we add config registers > > to the pxb, where the firmware can program the bus number range and we > > can use the config register base as a way to specify which pxb we are > > referring to ? > But then we'll need a bunch of fw cfg entries

[Qemu-devel] [PATCH] s390/bios: build with -fdelete-null-pointer-checks

2015-06-15 Thread Aurelien Jarno
Starting with version 4.9, GCC assumes it can't safely dereference null pointers, and uses this for some optimizations. On s390, the lowcore memory is located at address 0, so this assumption is wrong and breaks the s390-ccw firmware. Pass -fdelete-null-pointer-checks to avoid that. Cc: Cornelia H

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-15 Thread Michael S. Tsirkin
On Mon, Jun 15, 2015 at 12:18:16PM +0200, Gerd Hoffmann wrote: > Hi, > > > > I'm wondering whenever things become easier if we add config registers > > > to the pxb, where the firmware can program the bus number range and we > > > can use the config register base as a way to specify which pxb we

[Qemu-devel] [PATCH v7 0/1] balloon: add a feature bit to let Guest OS deflate

2015-06-15 Thread Denis V. Lunev
Excessive virtio_balloon inflation can cause invocation of OOM-killer, when Linux is under severe memory pressure. Various mechanisms are responsible for correct virtio_balloon memory management. Nevertheless it is often the case that these control tools does not have enough time to react on fast c

[Qemu-devel] [RFC] QDev explicit constructors & destructors

2015-06-15 Thread Liviu Ionescu
The .instance_init construction method available in the current QOM provides an equivalent of the C++ default constructor, that works just fine as long as there is no need to pass additional data to the construction logic. One natural solution would be to add an explicit constructor, like in C++

[Qemu-devel] [PATCH v7 0/1] balloon: add a feature bit to let Guest OS deflate

2015-06-15 Thread Denis V. Lunev
Excessive virtio_balloon inflation can cause invocation of OOM-killer, when Linux is under severe memory pressure. Various mechanisms are responsible for correct virtio_balloon memory management. Nevertheless it is often the case that these control tools does not have enough time to react on fast c

[Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-15 Thread Denis V. Lunev
Excessive virtio_balloon inflation can cause invocation of OOM-killer, when Linux is under severe memory pressure. Various mechanisms are responsible for correct virtio_balloon memory management. Nevertheless it is often the case that these control tools does not have enough time to react on fast c

Re: [Qemu-devel] RFC Multi-threaded TCG design document

2015-06-15 Thread Mark Burton
I think we SHOUDL use the wiki - and keep it current. A lot of what you have is in the wiki too, but I’d like to see the wiki updated. We will add our stuff there too… Cheers Mark. > On 15 Jun 2015, at 12:06, Alex Bennée wrote: > > > Frederic Konrad writes: > >> On 12/06/2015 18:37, Alex

Re: [Qemu-devel] [PATCH v4 1/6] target-arm: Add CNTVOFF_EL2

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 01:52, Edgar E. Iglesias wrote: > On Fri, Jun 12, 2015 at 05:44:24PM +0100, Peter Maydell wrote: >> On 5 June 2015 at 11:33, Edgar E. Iglesias wrote: >> > +int istatus = (int64_t) (count - offset - gt->cval) >= 0; >> >> This is wrong. Consider the case where: >> count

Re: [Qemu-devel] [PATCH] s390/bios: build with -fdelete-null-pointer-checks

2015-06-15 Thread Christian Borntraeger
Am 15.06.2015 um 12:24 schrieb Aurelien Jarno: > Starting with version 4.9, GCC assumes it can't safely dereference null > pointers, and uses this for some optimizations. On s390, the lowcore > memory is located at address 0, so this assumption is wrong and breaks > the s390-ccw firmware. Pass -fde

Re: [Qemu-devel] Runtime-modified DIMMs and live migration issue

2015-06-15 Thread Andrey Korolyov
> > Please find the full cli args and two guest logs for DIMM > initalization attached. As you can see, the freshly populated DIMMs > are probably misplaced in SRAT ('already populated' messages), despite > the fact that the initialized ranges are looking correct at a glance. > When VM is migrated

Re: [Qemu-devel] [RFC] QDev explicit constructors & destructors

2015-06-15 Thread Liviu Ionescu
> On 15 Jun 2015, at 13:48, Liviu Ionescu wrote: > > ... add an explicit constructor, like in C++. > ... the DeviceClass structure ... qdev_construct() ... For more generality, the new construct/destruct pointers can be added directly to the QOM ObjectClass, and the functions implemented as:

Re: [Qemu-devel] [PATCH 01/13] target-mips: fix {D, W}RGPR in microMIPS

2015-06-15 Thread Aurelien Jarno
On 2015-06-12 15:02, Yongbok Kim wrote: > rt, rs were swapped > > Signed-off-by: Yongbok Kim > --- > target-mips/translate.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index f6ae0d3..d4a530d 100644 > --- a

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-15 Thread Christian Borntraeger
Am 15.06.2015 um 12:10 schrieb Michael S. Tsirkin: > On Mon, Jun 15, 2015 at 11:59:05AM +0200, Christian Borntraeger wrote: >> Am 15.06.2015 um 11:06 schrieb Michael S. Tsirkin: >> > AFAIK management tools depend on balloon not deflating > below host-specified threshold to avoid OOM on the

Re: [Qemu-devel] [PATCH 03/13] target-mips: refactor {D}LSA, {D}ALIGN, {D}BITSWAP

2015-06-15 Thread Leon Alrae
On 12/06/2015 15:02, Yongbok Kim wrote: > Refactor those instructions in order to reuse them for microMIPS32 > Release 6. > > Signed-off-by: Yongbok Kim > --- > target-mips/translate.c | 164 +- > 1 files changed, 103 insertions(+), 61 deletions(-) >

Re: [Qemu-devel] [PATCH V2] Target-arm: Add the THUMB_DSP feature

2015-06-15 Thread Peter Maydell
On 14 June 2015 at 20:49, Aurelio C. Remonda wrote: > Created an ARM_FEATURE_THUMB_DSP to be added to any non-M > thumb2-compatible CPU that uses DSP instructions. There are 85 DSP > instructions (all of them thumb2). On disas_thumb2_insn the DSP feature is > tested before the instruction is gener

[Qemu-devel] [RFC v2 4/7] softmmu: Add helpers for a new slow-path

2015-06-15 Thread Alvise Rigo
The new helpers rely on the legacy ones to perform the actual read/write. The StoreConditional helper (helper_le_stcond_name) returns 1 if the store has to fail due to a concurrent access to the same page by another vCPU. A 'concurrent access' can be a store made by *any* vCPU (although, some imp

[Qemu-devel] [RFC v2 0/7] Slow-path for atomic instruction translation

2015-06-15 Thread Alvise Rigo
This is the second iteration of the patch series. The relevant changes from the v1 are at the bottom of this cover letter. This patch series provides an infrastructure for atomic instruction implementation in QEMU, paving the way for TCG multi-threading. The adopted design does not rely on host at

[Qemu-devel] [RFC v2 2/7] exec: Add new exclusive bitmap to ram_list

2015-06-15 Thread Alvise Rigo
The purpose of this new bitmap is to flag the memory pages that are in the middle of LL/SC operations (after a LL, before a SC). For all these pages, the corresponding TLB entries will be generated in such a way to force the slow-path. When the system starts, the whole memory is dirty (all the bitm

[Qemu-devel] [RFC v2 1/7] bitmap: Add bitmap_one_extend operation

2015-06-15 Thread Alvise Rigo
Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- include/qemu/bitmap.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 86dd9cd..c59e8e7 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/

[Qemu-devel] [RFC v2 3/7] Add new TLB_EXCL flag

2015-06-15 Thread Alvise Rigo
Add a new flag for the TLB entries to force all the accesses made to a page to follow the slow-path. In the case we remove a TLB entry marked as EXCL, we unset the corresponding exclusive bit in the bitmap. Mark the accessed page as dirty to invalidate any pending operation of LL/SC only if a vCP

Re: [Qemu-devel] [PATCH 02/13] target-mips: add microMIPS TLBINV, TLBINVF

2015-06-15 Thread Aurelien Jarno
On 2015-06-12 15:02, Yongbok Kim wrote: > add microMIPS TLBINV, TLBINVF > > Signed-off-by: Yongbok Kim > --- > target-mips/translate.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index d4a530d..b8c7164

[Qemu-devel] [RFC v2 5/7] tcg-op: create new TCG qemu_ldlink and qemu_stcond instructions

2015-06-15 Thread Alvise Rigo
Create a new pair of instructions that implement a LoadLink/StoreConditional mechanism. It has not been possible to completely include the two new opcodes in the plain variants, since the StoreConditional will always require one more argument to store the success of the operation. Suggested-by: J

[Qemu-devel] [RFC v2 6/7] target-arm: translate: implement qemu_ldlink and qemu_stcond ops

2015-06-15 Thread Alvise Rigo
Implement strex and ldrex instruction relying on TCG's qemu_ldlink and qemu_stcond. For the time being only the 32bit instructions are supported. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- target-arm/translate.c | 87 +

[Qemu-devel] [RFC v2 7/7] target-i386: translate: implement qemu_ldlink and qemu_stcond ops

2015-06-15 Thread Alvise Rigo
Implement strex and ldrex instruction relying on TCG's qemu_ldlink and qemu_stcond. For the time being only 32bit configurations are supported. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- tcg/i386/tcg-target.c | 136

[Qemu-devel] [PULL 1/7] watchdog: change option wording to allow for more watchdogs

2015-06-15 Thread Christian Borntraeger
From: Xu Wang We will introduce a new watchdog for s390x. Lets adopt qemu-options.hx to allow more watchdog devices. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger [split out qemu-option.hx base changes] --- qemu-options.hx | 23 ++-

[Qemu-devel] [PULL 5/7] nmi: Implement inject_nmi() for non-monitor context use

2015-06-15 Thread Christian Borntraeger
From: Xu Wang Let's introduce a general "inject_nmi()" function that doesn't rely on the cpu index of the monitor, but uses cpu index 0 as default (except for x86). This function can then later be used from a non-monitor context. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand CC: Alexey

[Qemu-devel] [PULL 7/7] s390/bios: build with -fdelete-null-pointer-checks

2015-06-15 Thread Christian Borntraeger
From: Aurelien Jarno Starting with version 4.9, GCC assumes it can't safely dereference null pointers, and uses this for some optimizations. On s390, the lowcore memory is located at address 0, so this assumption is wrong and breaks the s390-ccw firmware. Pass -fdelete-null-pointer-checks to avoi

[Qemu-devel] [PULL 4/7] s390x/watchdog: diag288 migration support

2015-06-15 Thread Christian Borntraeger
From: Xu Wang Add vmstate structure to keep state and data during migration. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- hw/watchdog/wdt_diag288.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/watchdog/wdt_diag288.c b/

[Qemu-devel] [PULL 3/7] s390x/kvm: diag288 instruction interception and handling

2015-06-15 Thread Christian Borntraeger
From: Xu Wang Intercept the diag288 requests from kvm guests, and hand the requested command to the diag288 watchdog device for further handling. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- target-s390x/cpu.h | 1 + target-s390x/kvm

[Qemu-devel] [PULL 6/7] watchdog: Add new Virtual Watchdog action INJECT-NMI

2015-06-15 Thread Christian Borntraeger
From: Mao Chuan Li This patch allows QEMU to inject a NMI into a guest when the watchdog expires. Signed-off-by: Mao Chuan Li Reviewed-by: David Hildenbrand CC: Eric Blake CC: Markus Armbruster Signed-off-by: Christian Borntraeger --- hw/watchdog/watchdog.c | 10 ++ qapi-schema.jso

[Qemu-devel] [PULL 0/7] s390x/kvm/bios/watchdog

2015-06-15 Thread Christian Borntraeger
u.git tags/s390x-20150615 for you to fetch changes up to 8369e339d24f365750da456588e742674c153437: s390/bios: build with -fdelete-null-pointer-checks (2015-06-15 13:31:33 +0200) s390x/kvm/watchdog 1. Implement a diag288 based watch

[Qemu-devel] [PULL 2/7] s390x/watchdog: introduce diag288 watchdog device

2015-06-15 Thread Christian Borntraeger
From: Xu Wang This patch introduces a new diag288 watchdog device that will, just like other watchdogs, monitor a guest and take corresponding actions when it detects that the guest is not responding. diag288 is s390x specific. The wiring to s390x KVM will be done in separate patches. Signed-of

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-15 Thread Thibaut Collet
After a resume operation the guest always kicks the backend for each virtual queues. A live migration does a suspend operation on the old host and a resume operation on the new host. So the backend has a kick after migration. I have checked this point with a legacy guest (redhat 6-5 with kernel ve

[Qemu-devel] [PULL 5/6] linux-user: use __get_user and __put_user in cmsg conversions

2015-06-15 Thread riku . voipio
From: Peter Maydell The target payloads in cmsg conversions may not have the alignment required by the host. Using the get_user and put_user functions is the easiest way to handle this and also do the byte-swapping we require. (Note that prior to this commit target_to_host_cmsg was incorrectly u

[Qemu-devel] [PULL 2/6] linux-user: Use abi_ulong for TARGET_ELF_PAGESTART

2015-06-15 Thread riku . voipio
From: Yongbok Kim TARGET_ELF_PAGESTART is required to use abi_ulong to correctly handle addresses for different target bits width. This patch fixes a problem when running a 64-bit user mode application on 32-bit host machines. Signed-off-by: Yongbok Kim Reviewed-by: Peter Maydell Signed-off-by

[Qemu-devel] [PULL 6/6] linux-user: fix the breakpoint inheritance in spawned threads

2015-06-15 Thread riku . voipio
From: Thierry Bultel When a thread is spawned, cpu_copy re-initializes the bp & wp lists of current thread, instead of the ones of the new thread. The effect is that breakpoints are no longer hit. Signed-off-by: Thierry Bultel Signed-off-by: Riku Voipio --- linux-user/main.c | 4 ++-- 1 file

Re: [Qemu-devel] [PATCH 3/3] block: Let bdrv_drain_all() to call aio_poll() for each AioContext

2015-06-15 Thread Christian Borntraeger
Am 10.06.2015 um 13:38 schrieb Alexander Yarygin: > After the commit 9b536adc ("block: acquire AioContext in > bdrv_drain_all()") the aio_poll() function got called for every > BlockDriverState, in assumption that every device may have its own > AioContext. If we have thousands of disks attached, t

Re: [Qemu-devel] [PULL 00/25] Block layer core and image format patches

2015-06-15 Thread Peter Maydell
On 12 June 2015 at 17:23, Kevin Wolf wrote: > The following changes since commit 4cb618abc1818586c08011ff0a84a015787b1672: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150612' into > staging (2015-06-12 12:49:40 +0100) > > are available in the git repository at: > > > git://re

[Qemu-devel] [PULL 1/6] linux-user: Allocate thunk size dynamically

2015-06-15 Thread riku . voipio
From: Alexander Graf We store all struct types in an array of static size without ever checking whether we overrun it. Of course some day someone (like me in another, ancient ALSA enabling patch set) will run into the limit without realizing it. So let's make the allocation dynamic. We already k

[Qemu-devel] [PULL 3/6] linux-user: ioctl() command type is int

2015-06-15 Thread riku . voipio
From: Laurent Vivier When executing a 64bit target chroot on 64bit host, the ioctl() command can mismatch. It seems the previous commit doesn't solve the problem in my case: 9c6bf9c7 linux-user: Fix ioctl cmd type mismatch on 64-bit targets For example, a ppc64 chroot on an x86_64 host

[Qemu-devel] [PULL 0/6] linux-user patches for 2.4 softfreeze

2015-06-15 Thread riku . voipio
iku.voipio/qemu.git tags/pull-linux-user-20150615 for you to fetch changes up to d2897da1f1e97d684f80ff62d473c31b79bc643a: linux-user: fix the breakpoint inheritance in spawned threads (2015-06-15 11:36:59 +0300) linux-user patch

[Qemu-devel] [PULL 04/20] only enable dsound in case the header file is present

2015-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ccf8dc7..222694f 100755 --- a/configure +++ b/configure @@ -435,6 +435,14 @@ EOF compile_object } +check_include() { +cat > $TMPC < +int

[Qemu-devel] [PULL 10/20] paaudio: fix possible resource leak

2015-06-15 Thread Gerd Hoffmann
From: Kővágó, Zoltán qpa_audio_init did not clean up resources properly if the initialization failed. This hopefully fixes it. Signed-off-by: Kővágó, Zoltán Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.

[Qemu-devel] [PULL 13/20] sdlaudio: do not allow multiple instances

2015-06-15 Thread Gerd Hoffmann
From: Kővágó, Zoltán Since SDL uses a lot of global data, we can't create independent instances of sdl audio backend. Signed-off-by: Kővágó, Zoltán Signed-off-by: Gerd Hoffmann --- audio/sdlaudio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c

[Qemu-devel] [PULL 00/20] audio patch queue

2015-06-15 Thread Gerd Hoffmann
ing branch 'remotes/stefanha/tags/net-pull-request' into staging (2015-06-12 15:39:05 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-audio-20150615-1 for you to fetch changes up to d95d7d802c33f6277c9fb967c14ae0cc99aeb072: ossaudio: use trace eve

[Qemu-devel] [PULL 14/20] MAINTAINERS: remove malc from audio

2015-06-15 Thread Gerd Hoffmann
email bounces, with a appearently permanent error: "av1...@comtv.ru mail receiving disabled, rejecting" Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e728d3a..7ba2079 100644 --- a/MAINTAINERS

[Qemu-devel] [PULL 15/20] audio: remove LOG_TO_MONITOR along with default_mon

2015-06-15 Thread Gerd Hoffmann
From: Kővágó, Zoltán Setting QEMU_AUDIO_LOG_TO_MONITOR=1 can crash qemu (if qemu tries to log to the monitor before it's being initialized), and also nothing else in qemu logs to the monitor. This log to monitor feature was the last thing that used the default_mon variable, so I removed it too (

[Qemu-devel] [PULL 12/20] coreaudio: do not use global variables where possible

2015-06-15 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Signed-off-by: Gerd Hoffmann --- audio/coreaudio.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 20346bc..6dfd63e 100644 --- a/audi

  1   2   3   4   >