On Fri, Jun 05, 2015 at 02:45:59PM +0530, Bharata B Rao wrote: > On Fri, Jun 05, 2015 at 06:09:38PM +1000, Alexey Kardashevskiy wrote: > > On 06/05/2015 02:25 PM, Bharata B Rao wrote: > > >XICS is setup for each CPU during initialization. Provide a routine > > >to undo the same when CPU is unplugged. Also ensure xics reset doesn't set > > >irq for CPUs that are already unplugged. > > > > > >This allows reboot of a VM that has undergone CPU hotplug and unplug > > >to work correctly. > > > > > >Signed-off-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> > > >--- > > > hw/intc/xics.c | 14 ++++++++++++++ > > > hw/intc/xics_kvm.c | 15 +++++++++++++-- > > > include/hw/ppc/xics.h | 2 ++ > > > 3 files changed, 29 insertions(+), 2 deletions(-) > > > > > >diff --git a/hw/intc/xics.c b/hw/intc/xics.c > > >index 924b1ae..3f87f82 100644 > > >--- a/hw/intc/xics.c > > >+++ b/hw/intc/xics.c > > >@@ -44,6 +44,20 @@ static int get_cpu_index_by_dt_id(int cpu_dt_id) > > > return -1; > > > } > > > > > >+void xics_cpu_destroy(XICSState *icp, PowerPCCPU *cpu) > > > > > > xics_cpu_destroy() is not used by anything, may be push it later with the > > stuff which needs it? > > Yeah it is not used in this patchset, will leave to David/agraf > to see if they want this dropped from this series.
Drop it for now, please. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
pgpLS5Q2TTipt.pgp
Description: PGP signature