On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > Factor out bits of sPAPR specific CPU initialization code into > a separate routine so that it can be called from CPU hotplug > path too. > > While at this, use MSR_EP define instead of using 6 directly.
Don't do this please. MSR[EP] is an obsolete flag from 601. The
MSR[IP] flag that we're controlling here just happened to re-use the
same bit position, so using the existing MSR_EP define is misleading.
A symbolic name is good, but you should create a new one for MSR[IP]
instead.
Or you could just drop this change and do the cleanup of the hardcoded
6 some other time.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpOqaWecSOym.pgp
Description: PGP signature
