On 15 June 2015 at 08:13, Pavel Fedin <p.fe...@samsung.com> wrote: > Hello! > >> > +int arm_cpus_per_cluster = 8; >> >> This doesn't need to be global, it doesn't need to be exposed in >> a header file, and it definitely doesn't need to be non-constant. >> I suggest >> #define ARM_CPUS_PER_CLUSTER 8 > > It was a #define in v3, but i decided to change this in order to > allow machine models to request different topology as Igor suggested.
For machine models to specify topology we would need a property or properties on the QOM object for the machine model to set, not a global. (And we'd need to have the code to see if KVM supported setting arbitrary MPIDR values, and fail if not.) thanks -- PMM
