On Fri, Jun 05, 2015 at 05:55:20PM +1000, Alexey Kardashevskiy wrote:
> On 06/05/2015 05:06 PM, Bharata B Rao wrote:
> >On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote:
> >>>
> >>>- ret = fdt_setprop(fdt, offset, "ibm,pft-size",
> >>>- pft_size_prop, sizeof(pft_size_prop));
> >>
> >>You broke formatting here, above 8 lines should not be in the patch.
> >
> >You mean above 80 chars ? It is not above 80 chars.
>
> The chunk is:
>
> + ret = fdt_setprop(fdt, offset, "ibm,pft-size",
> + pft_size_prop, sizeof(pft_size_prop));
> + if (ret < 0) {
> + return ret;
> }
>
> - ret = fdt_setprop(fdt, offset, "ibm,pft-size",
> - pft_size_prop, sizeof(pft_size_prop));
>
>
>
> pft_size_prop was under "fdt", now it is not, and this is the only change.
>
>
>
> >
> >>>+ _FDT((fdt_setprop_cell(fdt, offset, "d-cache-block-size",
> >>>+ env->dcache_line_size)));
> >>
> >>Wrong indent.
> >
> >checkpatch.pl doesn't complain, but should we start the second line
> >below ( of the first line ?
>
> Below "(" plus 1 char right.
>
> set expandtab, set tabstop=4, set shiftwidth=4, set cino=:0,(0 - this is
> what I use for QEMU.
Again, not a big deal, but I'd like a v2 of the series to address a
couple of other things, so you might as well correct the formatting at
the same time.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpTBFj5MgoRB.pgp
Description: PGP signature
