Re: [Qemu-devel] [PATCH v6 for 2.1 06/10] block: extend block-commit to accept a string for the backing file

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:54PM -0400, Jeff Cody wrote: > On some image chains, QEMU may not always be able to resolve the > filenames properly, when updating the backing file of an image > after a block commit. > > For instance, certain relative pathnames may fail, or drives may > have been sp

Re: [Qemu-devel] [PATCH 2.1 30/36] qapi event: clean up

2014-06-19 Thread Paolo Bonzini
Il 19/06/2014 06:17, Eric Blake ha scritto: I'll resume my review tomorrow on Paolo's thread-safety patches, but if Luiz is ready to pull these into his staging tree, then other patches that are pending on the qapi events (such as Igor's proposal to add ACPI_DEVICE_OST) will have something to reb

Re: [Qemu-devel] [PATCH v6 for 2.1 07/10] block: add ability for block-stream to use node-name

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:55PM -0400, Jeff Cody wrote: > This adds the ability for block-stream to use node-name arguments > for base, to specify the backing image to stream from. > > Both 'base' and 'base-node-name' are optional, but mutually exclusive. > Either can be specified, but not both

Re: [Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option to block-stream

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:56PM -0400, Jeff Cody wrote: > On some image chains, QEMU may not always be able to resolve the > filenames properly, when updating the backing file of an image > after a block job. > > For instance, certain relative pathnames may fail, or drives may > have been speci

Re: [Qemu-devel] [PATCH v6 for 2.1 09/10] block: Add QMP documentation for block-stream

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:57PM -0400, Jeff Cody wrote: > The QMP command 'block-stream' was missing QMP documentation. Add > that documentation. > > Reviewed-by: Eric Blake > Reviewed-by: Benoit Canet > Signed-off-by: Jeff Cody > --- > qmp-commands.hx | 58 > +

[Qemu-devel] [PATCH] virtio-scsi: define dummy handle_output for vhost-scsi vqs

2014-06-19 Thread Ming Lei
vhost userspace needn't to handle vq's notification from guest, so define dummy handle_output callback for all vqs of vhost-scsi. In some corner cases(such as when handling vq's reset from VM), virtio-pci still trys to handle pending virtio-scsi events, then object check failure inside virtio_scsi

Re: [Qemu-devel] [PATCH] virtio-scsi: define dummy handle_output for vhost-scsi vqs

2014-06-19 Thread Paolo Bonzini
Il 19/06/2014 10:12, Ming Lei ha scritto: vhost userspace needn't to handle vq's notification from guest, so define dummy handle_output callback for all vqs of vhost-scsi. In some corner cases(such as when handling vq's reset from VM), virtio-pci still trys to handle pending virtio-scsi events,

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-19 Thread David Marchand
On 06/18/2014 05:01 PM, Andreas Färber wrote: late onto this thread: SUSE Security team has just recently done a thorough review of QEMU ivshmem code because a customer has requested this be supported in SLES12. Multiple security-related patches were submitted by Stefan Hajnoczi and Sebastian Kra

Re: [Qemu-devel] [PATCH] bitops: provide an inline implementation of find_first_bit

2014-06-19 Thread Paolo Bonzini
Il 22/12/2013 12:32, Aurelien Jarno ha scritto: find_first_bit has started to be used heavily in TCG code. The current implementation based on find_next_bit is not optimal and can't be optimized be the compiler if the bit array has a fixed size, which is the case most of the time. If you mean b

Re: [Qemu-devel] [PATCH v6 for 2.1 10/10] block: add QAPI command to allow live backing file change

2014-06-19 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 03:15:07PM +0200, Benoît Canet wrote: > Could you provide an example script of how these backing file manipulation > are suposed to be done ? I agree. Jeff: Please send a qemu-iotests test case. Stefan pgpw3xnetIz_C.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH v6 for 2.1 10/10] block: add QAPI command to allow live backing file change

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:58PM -0400, Jeff Cody wrote: > This allows a user to make a live change to the backing file recorded in > an open image. > > The image file to modify can be specified 2 ways: > > 1) image filename > 2) image node-name > > Note: this does not cause the backing file i

Re: [Qemu-devel] monitor/mwait support for X86_64

2014-06-19 Thread Paolo Bonzini
Il 19/06/2014 03:46, yan cui ha scritto: We want to use QEMU to test some OS features on x86_64 systems. This feature requires the monitor and mwait instructions on x86, but we do not know whether QEMU currently support this. I got a QEMU copy from http://git.qemu.org/qemu.git, and grep "mon

Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()

2014-06-19 Thread Paolo Bonzini
Il 18/06/2014 21:06, Max Reitz ha scritto: +static void nbd_set_handlers(NBDClient *client) +{ +if (client->exp && client->exp->ctx) { +aio_set_fd_handler(client->exp->ctx, client->sock, + client->can_read ? nbd_read : NULL, + client

[Qemu-devel] [Bug 1331932] Re: qemu crash in x86 reload

2014-06-19 Thread Paolo Bonzini
You are using QEMU 1.3.0 or older, since that's the last release that used qemu_bh_delete in qemu_chr_be_generic_open_bh. Please upgrade to a newer release, thanks! ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation

2014-06-19 Thread Peter Maydell
On 28 May 2014 16:42, Stefan Weil wrote: > Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a > performance degradation caused by bad handling of small timeouts > in the original implementation of g_poll. > > Since that commit, hard disk I/O no longer works. > > Instead of rewriting th

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: > Currently, node_name is only filled in when done so explicitly by the > user. If no node_name is specified, then the node name field is not > populated. > > If node_names are automatically generated when not specified, that means > that

Re: [Qemu-devel] where can I find the latest memory hot plugging patch for Qemu?

2014-06-19 Thread Kolk, G. van der
Hi Igor, I’m trying the memory hot plug. But I have trouble getting it to work. This is what happens. I tried some tested guest OSes and some untested. I tried three flavours of linux with automatic or manual memory hot plug support: CentOS 6 cpu hotplug: works memory hotplug: Kernel sees memor

Re: [Qemu-devel] [PATCH block v1 2/2] block: m25p80: Support read only bdrvs.

2014-06-19 Thread Paolo Bonzini
static void bdrv_sync_complete(void *opaque, int ret) { /* do nothing. Masters do not directly interact with the backing store, * only the working copy so no mutexing required. */ } static void flash_sync_page(Flash *s, int page) { if (s->bdrv) { int bdrv_sector, nb_sect

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > Changes from v5->v6: > > * Check for attempt to commit an image to itself (Eric) > * Add a comment to the bdrv_find for block-commit, indicating > that libvirt uses the error case for probing (Eric) > * Added Benoit's R-b's > > Change

Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-19 Thread Stefan Hajnoczi
On Mon, Jun 16, 2014 at 12:00:56PM +0200, Benoît Canet wrote: > +BlockDriverState *check_to_replace_node(const char *node_name, Error **errp) > +{ > +BlockDriverState *to_replace_bs = bdrv_find_node(node_name); > +if (!to_replace_bs) { > +error_setg(errp, "Node name '%s' not found",

Re: [Qemu-devel] where can I find the latest memory hot plugging patch for Qemu?

2014-06-19 Thread Kolk, G. van der
Oops, RTFM! :) PS: Windows guest requires SRAT table for hotplug to work so add an extra option: -numa node to QEMU command line. So status is, windows works. linux does not. See attachment for more info Regards, Gerrit On 19 Jun 2014, at 11:07 , Kolk, G. van der mailto:g.vander.k..

Re: [Qemu-devel] [qom-cpu PATCH 3/3] target-i386: Don't enable nested VMX by default

2014-06-19 Thread Paolo Bonzini
Il 18/06/2014 21:55, Eduardo Habkost ha scritto: TCG doesn't support VMX, and nested VMX is not enabled by default on the KVM kernel module. So, there's no reason to have VMX enabled by default on the core2duo and coreduo CPU models, today. Even the newer Intel CPU model definitions don't have i

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-19 Thread Gerd Hoffmann
On Mi, 2014-06-18 at 23:03 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2014-06-18 at 13:18 +0200, Gerd Hoffmann wrote: > > The dispi interface has a versioned id too (VBE_DISPI_IDx) which we > > could use too. Which makes sense IMO if we add the register to the > > bochs dispi registers. > > >

Re: [Qemu-devel] [PATCHv2] usb: Fix usb-bt-dongle initialization.

2014-06-19 Thread Gerd Hoffmann
On Mi, 2014-06-18 at 00:23 +0100, Hani Benhabiles wrote: > Due to an incomplete initialization, adding a usb-bt-dongle device through HMP > or QMP will cause a segmentation fault. Added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] sheepdog: fix NULL dereference in sd_create

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 01:45:35PM +0800, Liu Yuan wrote: > Following command > > qemu-img create -f qcow2 sheepdog:test 20g > > will cause core dump because aio_context is NULL in sd_create. We should > initialize it by qemu_get_aio_context() to avoid NULL dereference. > > Cc: qemu-devel@nongnu

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-19 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 02:35:21PM +0200, Greg Kurz wrote: > On Wed, 18 Jun 2014 18:38:14 +0800 > Stefan Hajnoczi wrote: > > > On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote: > > > > > > On 17.06.14 09:36, Stefan Hajnoczi wrote: > > > >On Fri, Jun 13, 2014 at 01:18:00PM +0200, Gr

[Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-19 Thread Tiejun Chen
Originally the reason to probe ISA bridge instead of Dev31:Fun0 is to make graphics device passthrough work easy for VMM, that only need to expose ISA bridge to let driver know the real hardware underneath. This is a requirement from virtualization team. Especially in that virtualized environments,

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gerd Hoffmann
Hi, > Gonglei (5): > tests: add OHCI qtest > tests: add UHCI qtest > tests: add xHCI qtest > usb-hcd-ehci-test: change ehci qtest more expansively > usb-hcd-ehci-test: add ehci hotplug/unplug qtest I'd prefer to leave the usb-hcd-ehci-test alone. Maybe rename to "usb-hcd-ehci-compani

Re: [Qemu-devel] where can I find the latest memory hot plugging patch for Qemu?

2014-06-19 Thread Kolk, G. van der
This is probably more helpful: Hotplug Mem Device init_memory_mapping: 0001-00014000 01 - 014000 page 2M [ea000380-ea00039f] PMD -> [88000cc0-88000cdf] on node 0 [ea0003a0-ea0003bf] PMD -> [88000c80-880

Re: [Qemu-devel] dataplane performance on s390

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 10, 2014 at 09:40:38AM +0800, Fam Zheng wrote: > On Mon, 06/09 15:43, Karl Rister wrote: > > Hi All > > > > I was asked by our development team to do a performance sniff test of the > > latest dataplane code on s390 and compare it against qemu.git. Here is a > > brief description of t

Re: [Qemu-devel] [PATCH v8 01/20] virtio-serial: don't migrate the config space

2014-06-19 Thread Amit Shah
On (Fri) 13 Jun 2014 [13:18:42], Greg Kurz wrote: > The device configuration is set at realize time and never changes. It > should not be migrated as it is done today. For the sake of compatibility, > let's just skip them at load time. > > Signed-off-by: Alexander Graf The author field should al

Re: [Qemu-devel] [PATCH v2] add input-send-event command

2014-06-19 Thread Gerd Hoffmann
On Di, 2014-06-17 at 13:22 -0300, Marcelo Tosatti wrote: > Which allows specification of absolute/relative, > up/down and console parameters. > > Suggested by Gerd Hoffman. > > Signed-off-by: Marcelo Tosatti Added to input patch queue. thanks, Gerd

[Qemu-devel] [PULL 2/3] vnc: Drop superfluous conditionals around g_strdup()

2014-06-19 Thread Gerd Hoffmann
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index d771a2c..6c9d4f3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3009,10 +3009,7 @@ int vnc_display_pass

[Qemu-devel] [PULL 0/3] vnc: cleanups and fixes

2014-06-19 Thread Gerd Hoffmann
://git.kraxel.org/qemu tags/pull-vnc-20140619-1 for you to fetch changes up to eb214ff8ef6cceec348f3ad1643b39443fe07910: vnc: fix screen updates (2014-06-19 12:48:07 +0200) vnc: cleanups and fixes

[Qemu-devel] [PULL 1/3] vnc: Drop superfluous conditionals around g_free()

2014-06-19 Thread Gerd Hoffmann
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc-tls.c | 6 ++ ui/vnc.c | 12 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c index 50275de..6392326 100644 --- a/ui/vnc-tls.c +++ b

[Qemu-devel] [PULL 3/3] vnc: fix screen updates

2014-06-19 Thread Gerd Hoffmann
Bug was added by 38ee14f4f33f8836fc0e209ca59c6ae8c6edf380. vnc_jobs_join call is missing in one code path. Reported-by: Anthony PERARD Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 6c9d4f3..aac93f0 100644 --- a/ui/vnc.

Re: [Qemu-devel] [PATCH v8 01/20] virtio-serial: don't migrate the config space

2014-06-19 Thread Greg Kurz
On Thu, 19 Jun 2014 16:10:15 +0530 Amit Shah wrote: > On (Fri) 13 Jun 2014 [13:18:42], Greg Kurz wrote: > > The device configuration is set at realize time and never changes. It > > should not be migrated as it is done today. For the sake of compatibility, > > let's just skip them at load time. >

Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation

2014-06-19 Thread Stefan Weil
Am 19.06.2014 10:55, schrieb Peter Maydell: > On 28 May 2014 16:42, Stefan Weil wrote: >> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a >> performance degradation caused by bad handling of small timeouts >> in the original implementation of g_poll. >> >> Since that commit, hard di

Re: [Qemu-devel] [PATCH v8 01/20] virtio-serial: don't migrate the config space

2014-06-19 Thread Michael S. Tsirkin
On Fri, Jun 13, 2014 at 01:18:42PM +0200, Greg Kurz wrote: > The device configuration is set at realize time and never changes. It > should not be migrated as it is done today. For the sake of compatibility, > let's just skip them at load time. > > Signed-off-by: Alexander Graf > [ added missing

Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc

2014-06-19 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > The next patch will modify this function to initialize state that is > common to all backends. > > Reviewed-by: Fam Zheng > Signed-off-by: Paolo Bonzini > --- > backends/baum.c | 2 +- > backends/msmouse.c| 2 +- > include/sysemu/char.h

Re: [Qemu-devel] [PATCH 2.1 04/36] qapi script: add event support

2014-06-19 Thread Eric Blake
On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia > > qapi-event.py will parse the schema and generate qapi-event.c, then > the API in qapi-event.c can be used to handle events in qemu code. > All API have prefix "qapi_event". > > The script mainly includes two parts: generate API

Re: [Qemu-devel] where can I find the latest memory hot plugging patch for Qemu?

2014-06-19 Thread Igor Mammedov
On Thu, 19 Jun 2014 10:28:41 + "Kolk, G. van der" wrote: > This is probably more helpful: > > Hotplug Mem Device > init_memory_mapping: 0001-00014000 > 01 - 014000 page 2M > [ea000380-ea00039f] PMD -> > [88000cc0-88000cdf] on

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 19, 2014 6:05 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; stefa...@redhat.com; > ebl...@redhat.com; ak...@redhat.com; Huangweidong (C); Luonengjun > Subject: Re: [PATCH 0/

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Andreas Färber
Hi Gerd, Am 19.06.2014 12:05, schrieb Gerd Hoffmann: >> Gonglei (5): >> tests: add OHCI qtest >> tests: add UHCI qtest >> tests: add xHCI qtest >> usb-hcd-ehci-test: change ehci qtest more expansively >> usb-hcd-ehci-test: add ehci hotplug/unplug qtest > > I'd prefer to leave the usb-hc

Re: [Qemu-devel] where can I find the latest memory hot plugging patch for Qemu?

2014-06-19 Thread Kolk, G. van der
Hi Igor, Thanks for your reply. I guess I have it working right now. I was using an old patch, not the newest one. with v11 it’s working. Didn’t know how git and the branching stuff was working. now it works when booting with just 256MB of memory and extend it to what is necessary with the defa

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-19 Thread Jeff Cody
On Thu, Jun 19, 2014 at 04:55:02PM +0800, Stefan Hajnoczi wrote: > On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: > > Currently, node_name is only filled in when done so explicitly by the > > user. If no node_name is specified, then the node name field is not > > populated. > > > > If

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-19 Thread Gerd Hoffmann
On Di, 2014-06-17 at 12:42 +0100, Peter Maydell wrote: > On 17 June 2014 12:24, Gerd Hoffmann wrote: > > pl110 looks easy enough, so maybe I should just go convert it (and > > sprinkle in comments) so there actually is a good example to follow. > > Which arm board has one? Suggestions on how to t

Re: [Qemu-devel] [PATCH 1/5] tests: add OHCI qtest

2014-06-19 Thread Andreas Färber
Am 17.06.2014 10:03, schrieb arei.gong...@huawei.com: > From: Gonglei > > add ohci controller hotplug/unplug qtest > > Signed-off-by: Gonglei > --- > MAINTAINERS | 2 +- > tests/Makefile| 3 +++ > tests/usb-hcd-ohci-test.c | 41 ++

Re: [Qemu-devel] [PATCH 3/5] tests: add xHCI qtest

2014-06-19 Thread Andreas Färber
Am 17.06.2014 10:04, schrieb arei.gong...@huawei.com: > From: Gonglei > > add xhci controller hotplug/unplug qtest > > Signed-off-by: Gonglei > --- > tests/Makefile| 3 +++ > tests/usb-hcd-xhci-test.c | 42 ++ > 2 files changed, 45 insertion

Re: [Qemu-devel] [PATCH 2/5] tests: add UHCI qtest

2014-06-19 Thread Andreas Färber
Am 17.06.2014 10:04, schrieb arei.gong...@huawei.com: > From: Gonglei > > add uhci controller hotplug/unplug qtest > > Signed-off-by: Gonglei > --- > tests/Makefile| 3 +++ > tests/usb-hcd-uhci-test.c | 42 ++ > 2 files changed, 45 insertion

Re: [Qemu-devel] [PATCH 0/2] pc: memory hotplug fixes

2014-06-19 Thread Vasilis Liaskovitis
On Mon, Jun 09, 2014 at 07:27:59PM +0200, Igor Mammedov wrote: > Series is build on mst/pci tree that includes memory hotplug bits. > > patch 2/2, fixes incorrect address auto-allocation caused by wrong > sorting order due to overflow in pc_dimm_addr_sort() comparator. > thanks for the fixes. Fo

Re: [Qemu-devel] [PATCH v2 00/26] Merge ppc32/ppc64 tcg backends

2014-06-19 Thread Tom Musta
On 5/27/2014 4:42 PM, Tom Musta wrote: > On 5/27/2014 4:26 PM, Richard Henderson wrote: >> Please review, and if you've got an ELFv2 system (nudge nudge), please >> give it a try and make sure it works. > > Tested-by: Tom Musta > Will this series get into 2.1? The ELFv2 support is of particula

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gerd Hoffmann
On Do, 2014-06-19 at 14:24 +0200, Andreas Färber wrote: > Hi Gerd, > > Am 19.06.2014 12:05, schrieb Gerd Hoffmann: > >> Gonglei (5): > >> tests: add OHCI qtest > >> tests: add UHCI qtest > >> tests: add xHCI qtest > >> usb-hcd-ehci-test: change ehci qtest more expansively > >> usb-hcd-eh

Re: [Qemu-devel] [PATCH 1/5] tests: add OHCI qtest

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 1/5] te

Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc

2014-06-19 Thread Paolo Bonzini
Il 19/06/2014 14:03, Eric Blake ha scritto: On 06/18/2014 12:43 AM, Paolo Bonzini wrote: The next patch will modify this function to initialize state that is common to all backends. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- backends/baum.c | 2 +- backends/msmouse.c|

Re: [Qemu-devel] [PATCH 4/5] usb-hcd-ehci-test: change ehci qtest more expansively

2014-06-19 Thread Andreas Färber
Am 17.06.2014 10:04, schrieb arei.gong...@huawei.com: > From: Gonglei > > For simply add a new subtest in usb-hcd-ehci-test.c, > remove qtest_start and qtest_end to an absolute method > from main function. > > Signed-off-by: Gonglei > --- > tests/usb-hcd-ehci-test.c | 38 ++

Re: [Qemu-devel] [PATCH 3/5] tests: add xHCI qtest

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:38 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 3/5] te

Re: [Qemu-devel] [PATCH 2/5] tests: add UHCI qtest

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:41 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 2/5] te

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-19 Thread Paolo Bonzini
Il 19/06/2014 14:33, Gerd Hoffmann ha scritto: I'm thinking about splitting the conversion (for truecolor modes, still need to think about how to do paletted modes best) into two steps: First byteswap to bring the data into a format pixman can handle, then feed into pixman for further conversion

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Andreas Färber
Am 19.06.2014 14:47, schrieb Gerd Hoffmann: > Maybe it makes sense to have a usb-hcd-hotplug-test.c file and collect > hotplug testing for all usb hcds we have there. For code sharing > that'll be better for sure as the basic code flow is the same for all > hcd types. Ah yes, seeing that there is

[Qemu-devel] [PATCH] configure: put gprof config in host config file

2014-06-19 Thread Sergey Fedorov
The only use for GPROF_CFLAGS is in main makefile, but this variable put only to taget config file which is not included to the main makefile. Lets put gprof config variables to host config file. Signed-off-by: Sergey Fedorov --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 9:07 PM > To: Gerd Hoffmann > Cc: Gonglei (Arei); qemu-devel@nongnu.org; stefa...@redhat.com; > ebl...@redhat.com; ak...@redhat.com; Huangweidong (C); Luonengjun > Subject: Re: [PATCH 0/5]

Re: [Qemu-devel] [Qemu-ppc] Help needed testing on ppc

2014-06-19 Thread BALATON Zoltan
On Wed, 18 Jun 2014, Tom Musta wrote: On 6/17/2014 10:17 AM, BALATON Zoltan wrote: On Tue, 17 Jun 2014, Tom Musta wrote: I am looking at the test case source code and do not see how you are setting the reserved bit. Maybe I am missing some cleverness in how the test is built? Probably I sho

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Andreas Färber
Hi Gonglei, Am 19.06.2014 15:19, schrieb Gonglei (Arei): >> -Original Message- >> From: Andreas Färber [mailto:afaer...@suse.de] >> Sent: Thursday, June 19, 2014 9:07 PM >> To: Gerd Hoffmann >> Cc: Gonglei (Arei); qemu-devel@nongnu.org; stefa...@redhat.com; >> ebl...@redhat.com; ak...@redh

[Qemu-devel] [PATCH 0/2] win32 fixes for NUMA merge

2014-06-19 Thread Paolo Bonzini
Patch 1 adds a Win32 implementation of preallocation. Patch 2 fixes an initialization issue where the ram_list mutex was used before initialization. On Win32 this results in a deadlock. Paolo Paolo Bonzini (2): fixup! memory: move preallocation code out of exec.c fixup! numa: add -numa node

[Qemu-devel] [PATCH 1/2] fixup! memory: move preallocation code out of exec.c

2014-06-19 Thread Paolo Bonzini
Since we need the page size for efficiency, move code to compute it out of translate-all.c and into util/oslib-win32.c. Signed-off-by: Paolo Bonzini --- include/sysemu/os-win32.h | 2 ++ translate-all.c | 7 --- util/oslib-win32.c| 19 +++ 3 files changed,

[Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' with memory backend

2014-06-19 Thread Igor Mammedov
fixup documentation comments and HMP message/help text Signed-off-by: Igor Mammedov --- PS: based on PCI tree --- hmp.c| 2 +- monitor.c| 2 +- qapi-schema.json | 11 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hmp.c b/hmp.c index 41006f5..e1

Re: [Qemu-devel] [PATCH v3] bsd-user: Add patches to fix AES_* link errors

2014-06-19 Thread Sean Bruno
On Tue, 2014-06-17 at 09:48 -0700, Sean Bruno wrote: > On Mon, 2014-06-16 at 08:02 -0700, Sean Bruno wrote: > > v3 > > Drop patch1 as it has been superceeded > > Drop patch3 as it doesn't belong in this patchset > > > > v2 > > Correct email address for Ed Maste > > > > Redefine functions as QE

Re: [Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' with memory backend

2014-06-19 Thread Eric Blake
On 06/19/2014 07:37 AM, Igor Mammedov wrote: > fixup documentation comments and HMP message/help text > > Signed-off-by: Igor Mammedov > --- > PS: based on PCI tree > --- > hmp.c| 2 +- > monitor.c| 2 +- > qapi-schema.json | 11 ++- > 3 files changed, 8 insertions

Re: [Qemu-devel] [PATCH 0/2] win32 fixes for NUMA merge

2014-06-19 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 03:35:42PM +0200, Paolo Bonzini wrote: > Patch 1 adds a Win32 implementation of preallocation. Patch 2 fixes > an initialization issue where the ram_list mutex was used before > initialization. On Win32 this results in a deadlock. > > Paolo Applied, thanks a lot. > Paol

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gerd Hoffmann
Hi, > Can't tell what Gerd had in mind for hcd hotplug sharing, something like: usb_hcd_hotplug(char *hcd) { /* here: device_add $hcd,id=testhcd device_add usb-tablet,bus=testhcd.0 device_del testhcd */ } uhci_hotplug_test() { usb_hcd_hotplug("piix4-usb-uhci

[Qemu-devel] [PATCH 2/2] fixup! numa: add -numa node, memdev= option

2014-06-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- vl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 317b436..54b4627 100644 --- a/vl.c +++ b/vl.c @@ -3959,6 +3959,8 @@ int main(int argc, char **argv, char **envp) exit(1); } +cpu_exec_init_all(); +

[Qemu-devel] [PATCH] hw/pci: reserve IO and mem for pci express downstream ports with no devices attached

2014-06-19 Thread Marcel Apfelbaum
commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830 hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached introduced support for hot-plugging devices behind pci-2-pci bridges. Extend hotplug support also for pci express downstream ports. Signed-off-by: Marcel Apfelbaum --- s

[Qemu-devel] [PATCH 1/3] hw/pcie: corrected a debug message

2014-06-19 Thread Marcel Apfelbaum
Trivial issue, discovered while debugging. Signed-off-by: Marcel Apfelbaum --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 02cde6f..ae92f00 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -224,7 +224,7 @@ static void pci

[Qemu-devel] [PATCH 3/3] hw/pcie: better hotplug/hotunplug support

2014-06-19 Thread Marcel Apfelbaum
Hotplug triggers both 'present detect change' and 'attention button pressed'. Hotunplug starts by triggering 'attention button pressed', then waits for the OS to power off the device and only then detaches it. Signed-off-by: Marcel Apfelbaum --- hw/pci/pcie.c | 20 +++- 1 file c

[Qemu-devel] [PATCH 0/3] hw/pcie: better hotplug/hotunplug support

2014-06-19 Thread Marcel Apfelbaum
Hotplug triggers both 'present detect change' and 'attention button pressed'. Hotunplug starts by triggering 'attention button pressed', then waits for the OS to power off the device and only then detaches it. patch 1/3: trivial debug message fix patch 2/3: enable 'power controller' to receive po

[Qemu-devel] [PATCH 2/3] hw/pcie: implement power controller functionality

2014-06-19 Thread Marcel Apfelbaum
It is needed by hot-unplug in order to get an indication from the OS when the device can be physically detached. Signed-off-by: Marcel Apfelbaum --- hw/pci/pcie.c | 15 ++- include/hw/pci/pcie_regs.h | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-19 Thread Michael S. Tsirkin
On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote: > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: > > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). >

Re: [Qemu-devel] [PATCH v3 8/9] vmstate: Add preallocation for migrating arrays (VMS_ALLOC flag)

2014-06-19 Thread Alexey Kardashevskiy
On 06/13/2014 02:57 AM, Alexander Graf wrote: > On 06/12/2014 05:02 PM, Alexey Kardashevskiy wrote: >> On 06/08/2014 09:59 AM, Alexey Kardashevskiy wrote: >>> On 06/03/2014 11:19 PM, Alexey Kardashevskiy wrote: On 05/30/2014 07:34 PM, Alexey Kardashevskiy wrote: > There are few helpers alr

Re: [Qemu-devel] [PATCH v9 3/4] spapr_pci_vfio: Add spapr-pci-vfio-host-bridge to support vfio

2014-06-19 Thread Alexey Kardashevskiy
On 06/10/2014 03:39 PM, Alexey Kardashevskiy wrote: > The patch adds a spapr-pci-vfio-host-bridge device type > which is a PCI Host Bridge with VFIO support. The new device > inherits from the spapr-pci-host-bridge device and adds an "iommu" > property which is an IOMMU id. This ID represents a min

Re: [Qemu-devel] [PATCH v1 1/3] e1000: emulate auto-negotiation during external link status change

2014-06-19 Thread Michael S. Tsirkin
On Mon, Jun 16, 2014 at 01:29:09PM -0400, Gabriel L. Somlo wrote: > This patch emulates auto-negotiation when the network link status > is modified externally (i.e. via "set_link off/on"). > > Also, a couple of cleanup items regarding the PHY status register: > - unset AUTONEG_COMPLETE during l

[Qemu-devel] [PATCH v2] qapi/hmp: use 'backend' instead of 'device' with memory backend

2014-06-19 Thread Igor Mammedov
fixup documentation comments and HMP message/help text Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake --- v2: - add "##" above "# @PCDIMMDeviceInfo:" PS: based on PCI tree --- hmp.c| 2 +- monitor.c| 2 +- qapi-schema.json | 12 +++- 3 files changed, 9 ins

Re: [Qemu-devel] [PATCH] net: fix vhost-user mingw compilation

2014-06-19 Thread Nikolay Nikolaev
Hello, On Wed, Jun 18, 2014 at 11:45 PM, Nikolay Nikolaev < n.nikol...@virtualopensystems.com> wrote: > Make net.o linkage expect net_init_vhost_user only when > CONFIG_VHOST_NET is defined. > > Signed-off-by: Nikolay Nikolaev > --- > net/net.c |4 > 1 file changed, 4 insertions(+) >

Re: [Qemu-devel] [PATCH] hw/pci: reserve IO and mem for pci express downstream ports with no devices attached

2014-06-19 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 04:52:17PM +0300, Marcel Apfelbaum wrote: > commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830 > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached > > introduced support for hot-plugging devices behind pci-2-pci bridges. > Extend hotplug support als

Re: [Qemu-devel] [PATCH] net: fix vhost-user mingw compilation

2014-06-19 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 05:16:44PM +0300, Nikolay Nikolaev wrote: > Hello, > > > On Wed, Jun 18, 2014 at 11:45 PM, Nikolay Nikolaev < > n.nikol...@virtualopensystems.com> wrote: > > Make net.o linkage expect net_init_vhost_user only when > CONFIG_VHOST_NET is defined. > > Signed-off

Re: [Qemu-devel] [PATCH] hw/pci: reserve IO and mem for pci express downstream ports with no devices attached

2014-06-19 Thread Marcel Apfelbaum
On Thu, 2014-06-19 at 17:21 +0300, Michael S. Tsirkin wrote: > On Thu, Jun 19, 2014 at 04:52:17PM +0300, Marcel Apfelbaum wrote: > > commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830 > > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices > > attached > > > > introduced support for

Re: [Qemu-devel] [PATCH] net: fix vhost-user mingw compilation

2014-06-19 Thread Nikolay Nikolaev
Hello, On Thu, Jun 19, 2014 at 5:24 PM, Michael S. Tsirkin wrote: > On Thu, Jun 19, 2014 at 05:16:44PM +0300, Nikolay Nikolaev wrote: > > Hello, > > > > > > On Wed, Jun 18, 2014 at 11:45 PM, Nikolay Nikolaev < > > n.nikol...@virtualopensystems.com> wrote: > > > > Make net.o linkage expect n

[Qemu-devel] [PATCH 2/2] audio: fmopl: drop INLINE macro

2014-06-19 Thread Luiz Capitulino
This commit expands all uses of the INLINE macro and drop it. The reason for this is to avoid clashes with external libraries with bad name conventions and also because renaming keywords is not a good practice. Signed-off-by: Luiz Capitulino --- hw/audio/fmopl.c | 31 +++

[Qemu-devel] [PATCH 1/2] fpu: softfloat: drop INLINE macro

2014-06-19 Thread Luiz Capitulino
This commit expands all uses of the INLINE macro and drop it. The reason for this is to avoid clashes with external libraries with bad name conventions and also because renaming keywords is not a good practice. Signed-off-by: Luiz Capitulino --- fpu/softfloat-macros.h | 38 +--

Re: [Qemu-devel] [PATCH 2/3] hw/pcie: implement power controller functionality

2014-06-19 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 04:52:20PM +0300, Marcel Apfelbaum wrote: > It is needed by hot-unplug in order to get an indication > from the OS when the device can be physically detached. > > Signed-off-by: Marcel Apfelbaum > --- > hw/pci/pcie.c | 15 ++- > include/hw/pci/pci

Re: [Qemu-devel] [PATCH 3/3] hw/pcie: better hotplug/hotunplug support

2014-06-19 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 04:52:21PM +0300, Marcel Apfelbaum wrote: > Hotplug triggers both 'present detect change' and > 'attention button pressed'. > > Hotunplug starts by triggering 'attention button pressed', > then waits for the OS to power off the device and only > then detaches it. > Pls no

[Qemu-devel] [PATCH for-2.1 0/2] drop INLINE macro from the tree

2014-06-19 Thread Luiz Capitulino
This series fixes the following build breakage: """ In file included from /usr/include/spice-server/spice.h:25:0, from /home/lcapitulino/work/src/upstream/qemu/include/ui/qemu-spice.h:25, from /home/lcapitulino/work/src/upstream/qemu/qemu-char.c:84: /usr/include/

Re: [Qemu-devel] [PATCH] net: fix vhost-user mingw compilation

2014-06-19 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 05:33:02PM +0300, Nikolay Nikolaev wrote: > Hello, > > > On Thu, Jun 19, 2014 at 5:24 PM, Michael S. Tsirkin wrote: > > On Thu, Jun 19, 2014 at 05:16:44PM +0300, Nikolay Nikolaev wrote: > > Hello, > > > > > > On Wed, Jun 18, 2014 at 11:45 PM, Nikolay

[Qemu-devel] [PATCH 00/12] implement features required in MIPS64 Release 6

2014-06-19 Thread Leon Alrae
This patch series implement set of features whose presence became mandatory in MIPS64R6: - KScratch registers, - Read-Inhibit and Execute-Inhibit page protection bits, - TLB Invalidate (TLBINV and TLBINVF instructions), - BadInstr and BadInstrP. The last patch in the series enables them in MIPS64R6

[Qemu-devel] [PATCH 01/12] target-mips: add KScratch registers

2014-06-19 Thread Leon Alrae
KScratch Registers (CP0 Register 31, Selects 2 to 7) The KScratch registers are read/write registers available for scratch pad storage by kernel mode software. They are 32-bits in width for 32-bit processors and 64-bits for 64-bit processors. CP0Config4.KScrExist[2:7] bits indicate presence of CP

[Qemu-devel] [PATCH 04/12] target-mips: add RI and XI fields to TLB entry

2014-06-19 Thread Leon Alrae
In Revision 3 of the architecture, the RI and XI bits were added to the TLB to enable more secure access of memory pages. These bits (along with the Dirty bit) allow the implementation of read-only, write-only, no-execute access policies for mapped pages. Signed-off-by: Leon Alrae --- target-mip

[Qemu-devel] [PATCH 08/12] target-mips: add BadInstr and BadInstrP support

2014-06-19 Thread Leon Alrae
BadInstr Register (CP0 Register 8, Select 1) The BadInstr register is a read-only register that capture the most recent instruction which caused an exception. BadInstrP Register (CP0 Register 8, Select 2) The BadInstrP register contains the prior branch instruction, when the faulting instruction i

[Qemu-devel] [PATCH 06/12] target-mips: add new Read-Inhibit and Execute-Inhibit exceptions

2014-06-19 Thread Leon Alrae
An Execute-Inhibit exception occurs when the virtual address of an instruction fetch matches a TLB entry whose XI bit is set. This exception type can only occur if the XI bit is implemented within the TLB and is enabled, this is denoted by the PageGrain XIE bit. An Read-Inhibit exception occurs wh

[Qemu-devel] [PATCH 03/12] target-mips: distinguish between data load and instruction fetch

2014-06-19 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/helper.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/target-mips/helper.c b/target-mips/helper.c index 064622c..b59ac13 100644 --- a/target-mips/helper.c +++ b/target-mips/helper.c @@ -26,6 +26,12

[Qemu-devel] [PATCH 07/12] target-mips: add TLBINV support

2014-06-19 Thread Leon Alrae
For Standard TLB configuration (Config.MT=1): TLBINV invalidates a set of TLB entries based on ASID. The virtual address is ignored in the entry match. TLB entries which have their G bit set to 1 are not modified. TLBINVF causes all entries to be invalidated. Note that this commit introduces sup

  1   2   3   4   >