Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

Il 25/06/2013 08:32, liu ping fan ha scritto: > On Tue, Jun 25, 2013 at 2:24 PM, Paolo Bonzini wrote: >> Il 25/06/2013 19:38, Liu Ping Fan ha scritto: >>> This series relies on refcnt of object used by bh callback to run against >>> unplug. >>> >>> Open issue: >>> Another choice may be rcu, but I

Re: [Qemu-devel] [PATCH v4 01/10] configure: Support configuring c++ compiler

On 06/06/13 17:06, Tomoki Sekiyama wrote: > Add configuration for c++ compiler (${cross_prefix}g++ as default) in > configure and Makefiles. > > Currently, usage of c++ language is only for access to Windows VSS > using COM+ services in qemu-guest-agent for Windows. > > Signed-off-by: Tomoki Seki

Re: [Qemu-devel] [PATCH v4 02/10] Add c++ keywords to QAPI helper script

On 06/06/13 17:06, Tomoki Sekiyama wrote: > Add c++ keywords to avoid errors in compiling with c++ compiler. > This also renames class member of PciDeviceInfo to q_class. > > Signed-off-by: Tomoki Sekiyama > --- > hmp.c |2 +- > hw/pci/pci.c|2 +- > scripts/qapi.py | 12 +

Re: [Qemu-devel] [PATCH v4 03/10] checkpatch.pl: check .cpp files

On 06/06/13 17:06, Tomoki Sekiyama wrote: > Enable checkpatch.pl to apply the same checks as C source files for > C++ files with .cpp extensions. It also adds some exceptions for C++ > sources to suppress errors for: > - <> used in C++ template arguments (e.g. template ) > - :: used to represen

Re: [Qemu-devel] [PATCH] linux-user: Fix sys_utimensat (would not compile on old glibc)

On Thu, Jun 20, 2013 at 5:57 PM, Peter Maydell wrote: > Commit c0d472b12e accidentally dropped the definition of > __NR_SYS_utimensat even though its use is guarded by > CONFIG_UTIMENSAT, not CONFIG_ATFILE. Some older glibc don't > have utimensat() (even if they have the other *at() functions). >

Re: [Qemu-devel] [PATCH v4 04/10] Add a script to extract VSS SDK headers on POSIX system

On 06/06/13 17:06, Tomoki Sekiyama wrote: > +tmpdir=$(mktemp -d) > +trap "rm -fr $tmpdir vsssdk.msi; exit 1" HUP INT QUIT ALRM TERM "mktemp" keys off TMPDIR, so I would prefer something like (note the single quotes -- $tmpdir is expanded at trap execution time): trap 'rm -fr -- "$tmpdir"' but

Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant

On Wed, Jun 26, 2013 at 01:26:25AM +0800, Liu Ping Fan wrote: > BH will be used outside big lock, so introduce lock to protect > between the writers, ie, bh's adders and deleter. The lock only > affects the writers and bh's callback does not take this extra lock. > Note that for the same AioContext

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

Il 14/06/2013 12:09, Alexey Kardashevskiy ha scritto: > Hi. > > Ok. Back to the bug with this patch. The initial problem with this patch is > that "make check" fails. > > Please help with subpages. > > It turned out that tests use MALLOC_PERTURB_ which is normally off. Who > does not know - this

Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert

On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote: If I understand correctly, you have a backing chain with internal snapshots: > imageA(sn0)->imageB(sn0,sn1)->imageC(sn0) And you want to convert this to a chain of external snapshots: > imageA_sn0.qcow2-->imageA.qcow2-->imageB_sn0.qco

Re: [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

On Fri, Jun 21, 2013 at 06:37:18PM -0700, Ronnie Sahlberg wrote: Looks fine except these whitespace issues: > @@ -727,14 +730,36 @@ static BlockDriverAIOCB > *iscsi_aio_ioctl(BlockDriverState *bs, > memcpy(&acb->task->cdb[0], acb->ioh->cmdp, acb->ioh->cmd_len); > acb->task->expxferlen

Re: [Qemu-devel] [PATCH v11 02/15] rdma: introduce qemu_update_position()

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > RDMA writes happen asynchronously, and thus the performance accounting > also needs to be able to occur asynchronously. This allows anybody > to call into savevm.c to update both f->pos as well as into arch_init.c > to update the acc

Re: [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

On Mon, Jun 24, 2013 at 04:40:11PM +0200, Paolo Bonzini wrote: > Il 23/06/2013 17:07, Ronnie Sahlberg ha scritto: > > Don't assume that SG_IO is always invoked with a simple buffer, > > check the iovec_count and if it is >= 1 then we need to pass an array > > of iovectors to libiscsi instead of jus

Re: [Qemu-devel] [PATCH v11 03/15] rdma: export yield_until_fd_readable()

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > The RDMA event channel can be made non-blocking just like a TCP > socket. Exporting this function allows us to yield so that the > QEMU monitor remains available. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-b

Re: [Qemu-devel] [PATCH v11 04/15] rdma: export throughput w/ MigrationStats QMP

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This exposes throughput (in megabits/sec) through QMP. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod > Tested-by: Michael R. Hines > Signed-off-by: Michael R. Hines > @@ -154,8 +154,10 @@ voi

Re: [Qemu-devel] [PATCH v11 05/15] rdma: introduce qemu_file_mode_is_not_valid()

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > QEMUFileRDMA also has read and write modes. This function is now > shared to reduce code duplication. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod > Tested-by: Michael R. Hines > Signed-off-b

Re: [Qemu-devel] [PATCH v11 08/15] rdma: introduce qemu_ram_foreach_block()

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This is used during RDMA initialization in order to > transmit a description of all the RAM blocks to the > peer for later dynamic chunk registration purposes. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by:

Re: [Qemu-devel] [PATCH v11 10/15] rdma: introduce capability x-rdma-pin-all

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This capability allows you to disable dynamic chunk registration > for better throughput on high-performance links. > > For example, using an 8GB RAM virtual machine with all 8GB of memory in > active use and the VM itself is complet

Re: [Qemu-devel] [PATCH v11 06/15] rdma: export qemu_fflush()

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > RDMA uses this to flush the control channel before sending its > own message to handle page registrations. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod > Tested-by: Michael R. Hines > Signed-

Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant

Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben: > BH will be used outside big lock, so introduce lock to protect > between the writers, ie, bh's adders and deleter. The lock only > affects the writers and bh's callback does not take this extra lock. > Note that for the same AioContext, aio_bh_

Re: [Qemu-devel] [PATCH v11 13/15] rdma: allow state transitions between other states besides ACTIVE

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This patch is in preparation for the next ones: Until now the MIG_STATE_SETUP > state was not really a 'formal' state. It has been used as a 'zero' state > and QEMU has been unconditionally transitioning into this state when > the QM

Re: [Qemu-devel] arm_gic emulation

On 25 June 2013 05:16, Christoffer Dall wrote: > Hi Peter, > > Can you help me understand arm_vgic.c, specifically, see the quoted code > below and my question: (arm_gic.c; also, cc'd qemu-devel.) >> /* Process a change in an external IRQ input. */ >> static void gic_set_irq(void *opaque, int i

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As described in the previous patch, until now, the MIG_STATE_SETUP > state was not really a 'formal' state. It has been used as a 'zero' state > (what we're calling 'NONE' here) and QEMU has been unconditionally > transitioning > in

Re: [Qemu-devel] [PATCH v11 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Using the previous patches, we're now able to timestamp the SETUP > state. Once we have this time, let the user know about it in the > schema. > > Signed-off-by: Michael R. Hines Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v11 07/15] rdma: introduce ram_handle_compressed()

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This gives RDMA shared access to madvise() on the destination side > when an entire chunk is found to be zero. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod > Tested-by: Michael R. Hines > Sig

Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant

Il 25/06/2013 11:40, Kevin Wolf ha scritto: > Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben: >> BH will be used outside big lock, so introduce lock to protect >> between the writers, ie, bh's adders and deleter. The lock only >> affects the writers and bh's callback does not take this extra l

[Qemu-devel] [PATCH] console: Hook QemuConsoles into qom tree

Put them named "console[$index]" below "/backend", so you can list & inspect them via QMP. Signed-off-by: Gerd Hoffmann --- ui/console.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/console.c b/ui/console.c index 28bba6d..e3e8297 100644 --- a/ui/console.c +++ b/ui/console

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

Il 25/06/2013 11:49, Juan Quintela ha scritto: > mrhi...@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> As described in the previous patch, until now, the MIG_STATE_SETUP >> state was not really a 'formal' state. It has been used as a 'zero' state >> (what we're calling 'NONE' here) a

[Qemu-devel] [PATCH v3] s390: Implement dump-guest-memory support for target s390x

With this patch dump-guest-memory on s390 produces an ELF formatted, crash-readable dump. In order to implement this, the arch-specific part of dump-guest-memory was added: target-s390x/arch_dump.c contains the whole set of function for writing Elf note sections of all types for s390x. Signed-off-

Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

ping From: Petar Jovanovic Sent: Tuesday, June 18, 2013 12:39 AM To: Petar Jovanovic; qemu-devel@nongnu.org Cc: aurel...@aurel32.net Subject: RE: [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round ping From: Petar

Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15

ping From: Petar Jovanovic Sent: Tuesday, June 18, 2013 12:40 AM To: Petar Jovanovic; qemu-devel@nongnu.org Cc: aurel...@aurel32.net Subject: RE: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 ping ___

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

Hi, > Maybe we really should do a proper QMP jobs API. Using a BH makes sense > for the screenshot case but is orthogonal to the QMP job API. I'll drop that from my todo list for now. No way I can finish this off before my family summer vacation. I'm also hoping that someone who knows qapi +

[Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU related -- they are specific to the TLS ABI for a a particular OS. Move them into the linux-user/ tree where they belong. Signed-off-by: Peter Maydell --- The recent bsd-user patch series reminded me what a mess the current NPTL/

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

On 06/14/13 02:41, Evgeny Budilovsky wrote: On Fri, Jun 14, 2013 at 12:15 AM, Don Slutz > wrote: On 06/12/13 03:08, Evgeny Budilovsky wrote: The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be gen

Re: [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

Il 25/06/2013 11:24, Stefan Hajnoczi ha scritto: > On Mon, Jun 24, 2013 at 04:40:11PM +0200, Paolo Bonzini wrote: >> Il 23/06/2013 17:07, Ronnie Sahlberg ha scritto: >>> Don't assume that SG_IO is always invoked with a simple buffer, >>> check the iovec_count and if it is >= 1 then we need to pass

[Qemu-devel] [PATCH] gtk: add support for surface conversion

Also use CAIRO_FORMAT_RGB24 unconditionally. DisplaySurfaces will never ever see 8bpp surfaces. And using CAIRO_FORMAT_RGB16_565 for the 16bpp case doesn't seem to be a good idea too. * @CAIRO_FORMAT_RGB16_565: This format value is deprecated. It has * never been properly implemented in cai

Re: [Qemu-devel] [PATCH] tls.h: Enable TLS on FreeBSD

On 24 June 2013 22:15, Paolo Bonzini wrote: > I and Stefan Hajnoczi have almost the same idea implemented in QEMU > (except that get_foo() returns a pointer to the variable). But > pthread_get/setspecific would be too slow for cpu_single_env, so we're > just switching to __thread for cpu_single_e

Re: [Qemu-devel] [PATCH] tls.h: Enable TLS on FreeBSD

Il 25/06/2013 12:56, Peter Maydell ha scritto: > On 24 June 2013 22:15, Paolo Bonzini wrote: >> I and Stefan Hajnoczi have almost the same idea implemented in QEMU >> (except that get_foo() returns a pointer to the variable). But >> pthread_get/setspecific would be too slow for cpu_single_env, so

[Qemu-devel] [PATCH 02/11] memory: destroy phys_sections one by one

phys_sections_clear is invoked after the dispatch tree has been destroyed. This leaves a window where phys_sections_nb > 0 but the subpages are not valid anymore, which is a recipe for use-after-free bugs. Move the destruction of subpages in phys_sections_clear. Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 03/11] exec: simplify destruction of the phys map

Do not bother visiting the radix tree when an address space is destroyed. The fields are cleared anyway in phys_map_node_alloc. Signed-off-by: Paolo Bonzini --- exec.c | 34 +- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/exec.c b/exec.c index 33a

[Qemu-devel] [PATCH 00/11] Memory patches, part 4: region ownership

This series, split out of the previous attempt to set owners for memory regions, adds reference counting operations to memory regions and uses them. As requested by Peter, I'm adding an argument for the owner to all memory region creation functions. The big patches to actually add the owners will

[Qemu-devel] [PATCH 06/11] memory: add ref/unref calls

Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside the BQL (including in Xen or KVM). - memory_region_find callsites - creation of aliases and containers (only the aliased/contained region gets a reference to avoid loops) -

[Qemu-devel] [PATCH 04/11] memory: add getter for owner

Whenever memory regions are accessed outside the BQL, they need to be preserved against hot-unplug. MemoryRegions actually do not have their own reference count; they piggyback on a QOM object, their "owner". The owner is set at creation time, and there is a function to retrieve the owner. Signed

[Qemu-devel] [PATCH 07/11] exec: add a reference to the region returned by address_space_translate

Once address_space_translate will only be protected by RCU, the returned MemoryRegion can disappear as soon as the RCU read-side critical section ends. Avoid this by adding a reference to the region, and dropping it in the caller of address_space_translate. Signed-off-by: Paolo Bonzini --- exec

[Qemu-devel] [PATCH 09/11] exec: move qemu_ram_addr_from_host_nofail to cputlb.c

After the next patch it would not be used elsewhere anyway. Also, the _nofail and the standard versions of this function return different things, which is confusing. Removing the function from the public headers limits the confusion. Signed-off-by: Paolo Bonzini --- cputlb.c |

[Qemu-devel] [PATCH 08/11] exec: check MRU in qemu_ram_addr_from_host

This function is not used outside the iothread mutex, so it can use ram_list.mru_block. Signed-off-by: Paolo Bonzini --- exec.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index b7f032d..fb12588 100644 --- a/exec.c +++ b/exec.c @@ -1409,18 +1

Re: [Qemu-devel] [PATCH v4 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

On 06/06/13 17:06, Tomoki Sekiyama wrote: > To enable VSS support in qemu-ga for Windows, header files included in > VSS SDK are required. > The VSS support is enabled by the configure option like below: > ./configure --with-vss-sdk="/path/to/VSS SDK" > > If the path is omitted, it tries to sear

[Qemu-devel] [PATCH 10/11] memory: return MemoryRegion from qemu_ram_addr_from_host

It will be needed in the next patch. Signed-off-by: Paolo Bonzini --- cputlb.c | 2 +- exec.c| 33 - include/exec/cpu-common.h | 2 +- target-i386/kvm.c | 4 ++-- 4 files changed, 24 insertions(+), 17 deletions(-) d

[Qemu-devel] [PATCH 4/4] configure: Enable threading for unicore32-linux-user

unicore32-linux-user provides cpu_set_tls(), so the failure to enable target_nptl was presumably an oversight. Enable it. Signed-off-by: Peter Maydell --- configure |1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index e8f9b6a..54e46ed 100755 --- a/configure +++ b/con

[Qemu-devel] [PATCH 05/11] memory: add ref/unref

Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 30 ++ memory.c | 14 ++ 2 files changed, 44 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 763297e..c842d48 100644 --- a/include/exec/memory.h +++ b/incl

[Qemu-devel] block: Review of .has_zero_init use

Hi all, while discussing some iscsi patches with Peter, we came to have a look at which block drivers implement has_zero_init() to return 0, and which don't (returning 1 is the default). The meaning of this value is that if has_zero_init != 0, after bdrv_create() one can assume that the whole ima

[Qemu-devel] [PATCH 11/11] memory: ref/unref memory across address_space_map/unmap

The iothread mutex might be released between map and unmap, so the mapped region might disappear. Signed-off-by: Paolo Bonzini --- exec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 62c2f90..db91f87 100644 --- a/exec.c +++ b/exec.c @@

Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

Am 25.06.2013 12:35, schrieb Peter Maydell: > The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU > related -- they are specific to the TLS ABI for a a particular OS. > Move them into the linux-user/ tree where they belong. > > Signed-off-by: Peter Maydell > --- > The recent bsd-u

Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert

于 2013-6-25 17:13, Stefan Hajnoczi 写道: On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote: If I understand correctly, you have a backing chain with internal snapshots: imageA(sn0)->imageB(sn0,sn1)->imageC(sn0) And you want to convert this to a chain of external snapshots: What i

Re: [Qemu-devel] [PATCH v11 09/15] rdma: new QEMUFileOps hooks

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > These are the prototypes and implementation of new hooks that > RDMA takes advantage of to perform dynamic page registration. > > An optional hook is also introduced for a custom function > to be able to override the default save_pag

[Qemu-devel] [PATCH 0/4] configure: don't disable nptl where not needed

This patchset cleans up configure's target_nptl setting by making the default be "threading supported" rather than "not supported". We then enable threading in some cases which were very likely accidental failure to specifically enable it under the old default (64 bit MIPS and PPC, and Unicore32),

[Qemu-devel] [PATCH 3/4] configure: Enable threading on all ppc and mips linux-user targets

Though threading (target_nptl) was enabled on the base PPC and MIPS targets, it wasn't enabled for the variants mipsn32, mipsn32el, mips64, mips64el, ppc64 or ppc46abi32 (probably an oversight). Enable threading consistently on all these targets. Signed-off-by: Peter Maydell --- configure |4

[Qemu-devel] [PATCH 2/4] configure: Don't say target_nptl="no" if there is no linux-user target

For architectures with no linux-user target, don't claim no NPTL support. This has no behavioural change, but it means that we won't accidentally add a new linux-user target without threading support in future (because attempting to do so would be a compile failure rather than a silent lack of supp

[Qemu-devel] [PATCH 1/4] configure: Flip default of target_nptl

Most targets either (a) support threading or (b) don't have a linux-user/bsd-user target, so make it default to 'yes', with those targets that don't support threading having to specifically say so. This is a mechanical no-behaviour-change commit; some of the "no" entries it adds will be taken out

Re: [Qemu-devel] [PATCH v11 01/15] rdma: add documentation

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > docs/rdma.txt contains full documentation, > wiki links, github url and contact information. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod > Tested-by: Michael R. Hines > Signed-off-by: Michae

Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

On Tue, Jun 25, 2013 at 11:35:44AM +0100, Peter Maydell wrote: > The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU > related -- they are specific to the TLS ABI for a a particular OS. > Move them into the linux-user/ tree where they belong. Hi Peter, Makes sense to me. Maybe the

Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

On 25 June 2013 12:55, Edgar E. Iglesias wrote: > On Tue, Jun 25, 2013 at 11:35:44AM +0100, Peter Maydell wrote: > Makes sense to me. Maybe there could be a better name than target_cpu.h > but I don't have a better suggestion. Yeah, the name isn't fantastic but I didn't want to use plain cpu.h (r

Re: [Qemu-devel] block: Review of .has_zero_init use

On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > * ssh - currently has_zero_init = 1 (is this correct?) [...] > It might be possible that the correct value depends on the backend on > the server side for some protocols - for example, I think for SSH it > depends on whether yo

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Code that does need to be visible is kept > well contained inside this file and this is the only > new additional file to the entire patch. > > This file includes the entire protocol and interfaces > required to perform RDMA migratio

Re: [Qemu-devel] [Xen-devel] [PATCH 1/2] Allow use of pc machine type (accel=xen) for Xen HVM domains.

On Tue, 18 Jun 2013, Paul Durrant wrote: > Xen HVM domains normally spawn QEMU with a dedicated xenfv machine type. The > initialization code for this machine type can easily be pulled into the > generic pc initialization code and guarded with a test for whether the xen > accelerator options is spe

Re: [Qemu-devel] [target-mips] How to use smp?

On Mon, Jun 24, 2013 at 03:52:52PM +0800, Dongxue Zhang wrote: > Hello everybody, i want to use mips target with smp support.  When use  > command without smp, then the log stopped at "kernel panic", when - > smp 2 > added, it stoppted at "NR_IRQS:256". > > I use the git qemu at 576156ffed72ab4feb

[Qemu-devel] [PATCH] block: add drive_backup HMP command

Make "drive_backup" available on the HMP monitor: drive_backup [-n] [-f] device target [format] The -n flag requests QEMU to reuse the image found in new-image-file, instead of recreating it from scratch. The -f flag requests QEMU to copy the whole disk, so that the result does not need a back

[Qemu-devel] [PULL 0/3] Xen fixes and enhancements

The following changes since commit baf8673ca802cb3ea2cdbe94813441d23bde223b: Merge remote-tracking branch 'stefanha/block' into staging (2013-06-24 14:33:17 -0500) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-20130625 Paul

[Qemu-devel] [PULL 1/3] Revert "xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)"

This reverts commit 9f24a8030a70ea4954b5b8c48f606012f086f65f. The start of the PCI hole is actually set to 0xf000 by hvmloader. In order to retain ABI compatibility with Xen we leave the start of the PCI hole at 0xf000 in QEMU (for Xen) too. Signed-off-by: Stefano Stabellini --- hw/i386

[Qemu-devel] [PULL 3/3] Move hardcoded initialization of xen-platform device.

From: Paul Durrant Creation of the xen-platform device is currently hardcoded into machine type pc's initialization code, guarded by a test for the whether the xen accelerator is enabled. This patch moves the creation of xen-platform into the initialization code of the xenfv machine type. This ma

Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote: > > v2: remove unnecessary runstate_is_running() usage (Paolo) > > -- > > kvmclock should not count while vm is paused, because: > > 1) if the vm is paused for long periods, timekeeping > math can overflow while converting the (la

[Qemu-devel] [PULL 2/3] Allow use of pc machine type (accel=xen) for Xen HVM domains.

From: Paul Durrant Xen HVM domains normally spawn QEMU with a dedicated xenfv machine type. The initialization code for this machine type can easily be pulled into the generic pc initialization code and guarded with a test for whether the xen accelerator options is specified, which is more consis

Re: [Qemu-devel] block: Review of .has_zero_init use

Am 25.06.2013 um 14:05 hat Richard W.M. Jones geschrieben: > On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > > * ssh - currently has_zero_init = 1 (is this correct?) > [...] > > It might be possible that the correct value depends on the backend on > > the server side for som

Re: [Qemu-devel] [Xen-devel] [PATCH 1/2] Allow use of pc machine type (accel=xen) for Xen HVM domains.

> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 25 June 2013 13:02 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH 1/2] Allow use of pc machine type > (accel=xen) for Xen HVM domains.

Re: [Qemu-devel] [PATCH v6 03/12] block: add basic backup support to block driver

Am 24.06.2013 um 17:13 hat Stefan Hajnoczi geschrieben: > From: Dietmar Maurer > > backup_start() creates a block job that copies a point-in-time snapshot > of a block device to a target block device. > > We call backup_do_cow() for each write during backup. That function > reads the original da

Re: [Qemu-devel] block: Review of .has_zero_init use

At Tue, 25 Jun 2013 13:39:11 +0200, Kevin Wolf wrote: > > Hi all, > > while discussing some iscsi patches with Peter, we came to have a look > at which block drivers implement has_zero_init() to return 0, and which > don't (returning 1 is the default). > > The meaning of this value is that if ha

[Qemu-devel] [PATCH] block: Make BlockJobTypes const

Signed-off-by: Kevin Wolf --- block/commit.c | 2 +- block/mirror.c | 2 +- block/stream.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/commit.c b/block/commit.c index 553447e..2227fc2 100644 --- a/block/commit.c +++ b/block/commit.c @@ -173,7 +173,7 @@ static void

Re: [Qemu-devel] [PATCH v6 00/12] block: drive-backup live backup command

Am 24.06.2013 um 17:13 hat Stefan Hajnoczi geschrieben: > Note: These patches apply to kevin/block. You can also grab the code from git > here: > git://github.com/stefanha/qemu.git block-backup-core > > This series adds a new QMP command, drive-backup, which takes a point-in-time > snapshot of a

Re: [Qemu-devel] block: Review of .has_zero_init use

Am 25.06.2013 um 15:11 hat MORITA Kazutaka geschrieben: > At Tue, 25 Jun 2013 13:39:11 +0200, > Kevin Wolf wrote: > > > > Hi all, > > > > while discussing some iscsi patches with Peter, we came to have a look > > at which block drivers implement has_zero_init() to return 0, and which > > don't (r

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

Am 25.06.2013 um 14:23 hat Stefan Hajnoczi geschrieben: > Make "drive_backup" available on the HMP monitor: > > drive_backup [-n] [-f] device target [format] > > The -n flag requests QEMU to reuse the image found in new-image-file, > instead of recreating it from scratch. > > The -f flag reque

Re: [Qemu-devel] [PATCH v11 04/15] rdma: export throughput w/ MigrationStats QMP

On 06/25/2013 05:27 AM, Juan Quintela wrote: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. H

Re: [Qemu-devel] [PATCH v11 09/15] rdma: new QEMUFileOps hooks

On 06/25/2013 07:51 AM, Juan Quintela wrote: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be a

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

On 06/25/2013 05:49 AM, Juan Quintela wrote: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state (what we're calling 'NONE' here) and QEMU has bee

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

On 06/25/2013 08:05 AM, Juan Quintela wrote: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch. This file includes the entire protocol and interfaces

Re: [Qemu-devel] block: Review of .has_zero_init use

At Tue, 25 Jun 2013 15:20:18 +0200, Kevin Wolf wrote: > > Am 25.06.2013 um 15:11 hat MORITA Kazutaka geschrieben: > > At Tue, 25 Jun 2013 13:39:11 +0200, > > Kevin Wolf wrote: > > > > > > Hi all, > > > > > > while discussing some iscsi patches with Peter, we came to have a look > > > at which bl

Re: [Qemu-devel] block: Review of .has_zero_init use

Am 25.06.2013 um 15:42 hat MORITA Kazutaka geschrieben: > At Tue, 25 Jun 2013 15:20:18 +0200, > Kevin Wolf wrote: > > > > Am 25.06.2013 um 15:11 hat MORITA Kazutaka geschrieben: > > > At Tue, 25 Jun 2013 13:39:11 +0200, > > > Kevin Wolf wrote: > > > > > > > > Hi all, > > > > > > > > while discus

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

On 06/25/2013 06:13 AM, Paolo Bonzini wrote: Il 25/06/2013 11:49, Juan Quintela ha scritto: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state (

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

Il 25/06/2013 15:26, Kevin Wolf ha scritto: >> > +if (!full) { >> > +error_setg(&errp, "-f is not yet implemented"); >> > +hmp_handle_error(mon, &errp); >> > +return; >> > +} > Then why make it a valid option and confuse users in the help text by > describing options

Re: [Qemu-devel] KVM call agenda for 2013-06-25

On Tue, 11 Jun 2013 17:52:53 +0200 Juan Quintela wrote: > > Hi > > Now we have moved to one call each other week. > Please, send any topic that you are interested in covering. > > Thanks, Juan. > > PD. If you want to attend and you don't have the call details, > contact me. > Using s

Re: [Qemu-devel] [PATCH v11 09/15] rdma: new QEMUFileOps hooks

Il 25/06/2013 15:38, Michael R. Hines ha scritto: > On 06/25/2013 07:51 AM, Juan Quintela wrote: >> mrhi...@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> These are the prototypes and implementation of new hooks that >>> RDMA takes advantage of to perform dynamic page registration.

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

Il 25/06/2013 15:44, Michael R. Hines ha scritto: >>> >> I don't like the three-arguments migrate_set_state, but I don't have any >> better idea. >> >> With Juan's modification, it is fine (but not reviewed-by me :)). While >> you resend, the first 13 patches of v10 can be merged (pull request). >

Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

On 06/25/2013 03:35 AM, Peter Maydell wrote: > (and maybe even actually get all targets > up to having NPTL enabled, since it's mostly just implementing > the two functions being moved here for x86, sparc, openrisc. There's far more to it than that for x86. You've got to add support for all of th

Re: [Qemu-devel] KVM call agenda for 2013-06-25

On 22.06.2013, at 03:01, Alexander Graf wrote: > > On 20.06.2013, at 14:47, Michael S. Tsirkin wrote: > >> Please, send any topic that you are interested in covering. > > VFIO with platform devices A few notes ahead of the discussion: -problem we are trying to solve is: 1. how the kernel

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > Il 25/06/2013 15:26, Kevin Wolf ha scritto: > >> > +if (!full) { > >> > +error_setg(&errp, "-f is not yet implemented"); > >> > +hmp_handle_error(mon, &errp); > >> > +return; > >> > +} > > Then why make it a val

Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

On 25 June 2013 14:56, Richard Henderson wrote: > On 06/25/2013 03:35 AM, Peter Maydell wrote: >> (and maybe even actually get all targets >> up to having NPTL enabled, since it's mostly just implementing >> the two functions being moved here for x86, sparc, openrisc. > > There's far more to it th

[Qemu-devel] [PATCH 04/24] vga: pass owner to cirrus_init_common

Signed-off-by: Paolo Bonzini --- hw/display/cirrus_vga.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 80510ac..3d579e2 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -280

[Qemu-devel] [PATCH 02/24] vga: pass owner to vga_init

Signed-off-by: Paolo Bonzini --- hw/display/qxl.c| 3 ++- hw/display/vga-pci.c| 3 ++- hw/display/vga.c| 2 +- hw/display/vga_int.h| 2 +- hw/display/vmware_vga.c | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c ind

[Qemu-devel] [PATCH 07/24] vga: set owner in vga_update_memory_access

Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 7a6e935..1657356 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -198,7 +198,8 @@ static void vga_update_memory_access(VGACommo

[Qemu-devel] [PATCH 03/24] vga: pass owner to vga_common_init

Signed-off-by: Paolo Bonzini --- hw/display/cirrus_vga.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vga-isa-mm.c | 2 +- hw/display/vga-isa.c| 2 +- hw/display/vga-pci.c| 2 +- hw/display/vga.c| 4 ++-- hw/display/vga_int.h| 2 +- hw/display/vmware_vga.c | 2 +- 8 fi

[Qemu-devel] [PATCH 11/24] pam: pass device to init_pam and use it to set owner

Signed-off-by: Paolo Bonzini --- hw/pci-host/pam.c | 16 +--- hw/pci-host/piix.c| 4 ++-- hw/pci-host/q35.c | 4 ++-- include/hw/pci-host/pam.h | 4 ++-- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/pci-host/pam.c b/hw/pci-host/pam.c i

[Qemu-devel] [PATCH 08/24] ne2000: pass device to ne2000_setup_io, use it as owner

Signed-off-by: Paolo Bonzini --- hw/net/ne2000-isa.c | 2 +- hw/net/ne2000.c | 6 +++--- hw/net/ne2000.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/net/ne2000-isa.c b/hw/net/ne2000-isa.c index 9232abd..e3c8076 100644 --- a/hw/net/ne2000-isa.c +++ b/hw/net/ne

  1   2   3   >