Il 25/06/2013 11:40, Kevin Wolf ha scritto: > Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben: >> BH will be used outside big lock, so introduce lock to protect >> between the writers, ie, bh's adders and deleter. The lock only >> affects the writers and bh's callback does not take this extra lock. >> Note that for the same AioContext, aio_bh_poll() can not run in >> parallel yet. >> >> Signed-off-by: Liu Ping Fan <pingf...@linux.vnet.ibm.com> >> >> --------- > > Please use exactly three dashes so that 'git am' recognises it as the > end of the commit message. > > This doesn't compile yet because smp_read_barrier_depends() isn't merged > yet, so maybe there's still time for some nitpicking: Wouldn't using > atomic_set/get better document things and make them easier to read?
Good idea. But it'll be a while before I merge the atomics patch, so it's perhaps better to get it in via the block branch (same as TLS). Paolo > It should be correct anyway, so: > > Reviewed-by: Kevin Wolf <kw...@redhat.com> >
