Il 25/06/2013 15:44, Michael R. Hines ha scritto: >>> >> I don't like the three-arguments migrate_set_state, but I don't have any >> better idea. >> >> With Juan's modification, it is fine (but not reviewed-by me :)). While >> you resend, the first 13 patches of v10 can be merged (pull request). >> You can then rebase the last three on top. > > So, I should send a v11 before Juan applies and generates the pull request? > > Did I understand correctly?
Juan found another small nit, so please do send a v12. He liked (with the small change in cancellation) your last three patches, so there is no need to split out patch 13 (as you had it in v10). >> Michael, did you look at the "debugging/getting the protocol ready" mode >> where all pages are unpinned? > > We did not come up with a design on how such a mode would be > exposed to the user. Implementing this in migration-rdma.c is > just a few lines of code, but without a clear use case in this patch > series, I've not chosen expose it to the user yet without some kind > of agreement with you guys. Do those few lines of code change the protocol? If yes, I'll go against all my previous recommendations and suggest a #define. If no, it is fine to leave it for later, but I would still suggest posting the patch on the list just for information. Paolo
