Il 25/06/2013 11:24, Stefan Hajnoczi ha scritto:
> On Mon, Jun 24, 2013 at 04:40:11PM +0200, Paolo Bonzini wrote:
>> Il 23/06/2013 17:07, Ronnie Sahlberg ha scritto:
>>> Don't assume that SG_IO is always invoked with a simple buffer,
>>> check the iovec_count and if it is >= 1 then we need to pass an array
>>> of iovectors to libiscsi instead of just a plain buffer.
>>>
>>> Signed-off-by: Ronnie Sahlberg <ronniesahlb...@gmail.com>
>>> ---
>>> block/iscsi.c | 56
>>> +++++++++++++++++++++++++++++++++++++++++++++++++-------
>>> 1 files changed, 49 insertions(+), 7 deletions(-)
>>
>> Cc: qemu-sta...@nongnu.org
>>
>> Will apply to scsi-next in the next few days.
>
> Paolo, there are small whitespace issues that you might like to fix when
> merging:
Yup, will do.
Paolo
>>> + } else {
>>> +#if defined(LIBISCSI_FEATURE_IOVECTOR)
>>> + scsi_task_set_iov_out(acb->task,
>>> + (struct scsi_iovec *) acb->ioh->dxferp,
>>> + acb->ioh->iovec_count);
>
> Should be 4-space indentation.
>
>>> + #else
>
> Space before #else?
>
