Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-09-11 Thread Zhang, Yang Z
how about the following patch: diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index d63554f..30bbbe6 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -556,14 +556,14 @@ static void rtc_set_cmos(RTCState *s, const struct tm *tm) static void rtc_update_time(RTCState *s) { -struct tm

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-09-11 Thread Paolo Bonzini
Il 11/09/2012 09:05, Zhang, Yang Z ha scritto: > how about the following patch: > > diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c > index d63554f..30bbbe6 100644 > --- a/hw/mc146818rtc.c > +++ b/hw/mc146818rtc.c > @@ -556,14 +556,14 @@ static void rtc_set_cmos(RTCState *s, const struct tm > *t

[Qemu-devel] [PATCH] qxl: better cleanup for surface destroy

2012-09-11 Thread Uri Lublin
Add back a call to qxl_spice_destroy_surface_wait_complete() in qxl_spice_destroy_surface_wait(), that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf It is needed to complete surface-removal cleanup, for non async. For async, qxl_spice_destroy_surface_wait_complete is called upon

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-09-11 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2012-09-11: > Il 11/09/2012 09:05, Zhang, Yang Z ha scritto: >> how about the following patch: >> >> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index d63554f..30bbbe6 >> 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -556,14 +556,14 >> @@ static void rtc_set_c

Re: [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy

2012-09-11 Thread Alon Levy
> Add back a call to qxl_spice_destroy_surface_wait_complete() in > qxl_spice_destroy_surface_wait(), > that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf > > It is needed to complete surface-removal cleanup, for non async. > For async, qxl_spice_destroy_surface_wait_complete is c

[Qemu-devel] [PATCH] win32: provide gmtime_r emulation

2012-09-11 Thread Paolo Bonzini
Windows has _s functions from C99 instead of _r functions from POSIX. Add an emulation shim. Signed-off-by: Paolo Bonzini --- Not tested beyond compilation. os-win32.c | 12 qemu-os-win32.h | 1 + 2 file modificati, 13 inserzioni(+) diff --git a/os-win32.c b/os-win32

[Qemu-devel] [Bug 996303] Re: does not work with clang

2012-09-11 Thread Paolo Bonzini
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/996303 Title: does not work with clang Status in QEMU: Fix Committed Bug description: Fro

[Qemu-devel] [PATCH] migration: address handling cleanup

2012-09-11 Thread Amos Kong
From: Michael S. Tsirkin getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this, refactor address resolution

Re: [Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-11 Thread Gleb Natapov
On Mon, Sep 10, 2012 at 10:24:51PM -, Till Schäfer wrote: > i started trace-cmd as suggested on http://www.linux- > kvm.org/page/Tracing and started the vm. after the panic i aborted > trace-cmd and here is the trace file > > ** Attachment added: "trace from trace-cmd" > > https://bugs.lau

[Qemu-devel] [PATCH V3 0/10] prepare unplug out of protection of global lock

2012-09-11 Thread Liu Ping Fan
v1: https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03312.html v2: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01275.html changes v2->v3 --remove refcnt on MemroyRegion --add ref/unref for MemoryRegionOps --make memory view protected by mem_map_lock, delay to adopt rcu styl

[Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan If out of global lock, we will be challenged by SMP in low level, so need atomic ops. This file is a wrapper of GCC atomic builtin. Signed-off-by: Liu Ping Fan --- include/qemu/atomic.h | 63 + 1 files changed, 63 insertions

[Qemu-devel] [PATCH V3 11/11] vcpu: push mmio dispatcher out of big lock

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- kvm-all.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 34b02c1..ef7cd5f 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1562,10 +1562,13 @@ int kvm_cpu_exec(CPUArchState *env) br

[Qemu-devel] [PATCH V3 02/11] qom: apply atomic on object's refcount

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- include/qemu/object.h |3 ++- qom/object.c | 11 +-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index cc75fee..0c02614 100644 --- a/include/qemu/object.h +

[Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan DeviceState will be protected by refcnt from disappearing during dispatching. But when refcnt comes down to zero, DeviceState may be still in use by iohandler, timer etc in main loop, we just delay its free untill no reader. This patch aim to build this delay reclaimer. Signe

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > If out of global lock, we will be challenged by SMP in low level, > so need atomic ops. > > This file is a wrapper of GCC atomic builtin. > > Signed-off-by: Liu Ping Fan > --- > include/qemu/atomic.h | 63 > ++

Re: [Qemu-devel] [PATCH V3 05/11] memory: introduce ref, unref interface for MemoryRegionOps

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > This pair of interface help to decide when dispatching, whether > we can pin mr without big lock or not. > > --- a/memory.h > +++ b/memory.h > @@ -25,6 +25,7 @@ > #include "iorange.h" > #include "ioport.h" > #include "int128

[Qemu-devel] [PATCH V3 05/11] memory: introduce ref, unref interface for MemoryRegionOps

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan This pair of interface help to decide when dispatching, whether we can pin mr without big lock or not. Signed-off-by: Liu Ping Fan --- memory.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/memory.h b/memory.h index bd1bbae..9039411 100644 --- a/

Re: [Qemu-devel] [PATCH 0/4] linux framebuffer display driver

2012-09-11 Thread Alon Levy
> Hi, > > Undusting an pretty old patch series, rebasing it, testing it, fixing > a bug or two, fixing codestyle issues: Qemu can run on the linux > framebuffer console as graphical display now. Patch 4 doesn't apply (hmp.h), missing SoB on a few patches. Tested with Seabios. Works as advertis

[Qemu-devel] [PATCH V3 07/11] memory: implement e1000's MemoryRegionOps ref/unref

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan With this, e1000 show to memory core that it can be protected by refcnt. Signed-off-by: Liu Ping Fan --- hw/e1000.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index ae8a6c5..df3a349 100644 --- a/hw/e1000.

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-11 Thread Laurent COUSTET
I had exactly the same problem using custom kernel on Debian GNU/Linux / qemu-kvm 1.1.1 or 1.2.0. CPU: Intel(R) Xeon(R) CPU E5-2667 0 @ 2.90GHz stepping 7 microcode 0x70b I have two solutions: (VERY UGGLY) patch the kernel to remove intel perf events (hardware events): --- ../linux-3.4.10-fai-se

[Qemu-devel] [PATCH V3 03/11] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan When device unplug has been ack by guest, we first remove it from memory to prevent incoming access from dispatcher. Then we isolate it from device composition tree Signed-off-by: Liu Ping Fan --- hw/qdev.c | 26 ++ hw/qdev.h |3 ++- 2 files cha

Re: [Qemu-devel] [PATCH V3 01/11] atomic: introduce atomic operations

2012-09-11 Thread Peter Maydell
On 11 September 2012 08:51, Liu Ping Fan wrote: > + > +/** > + * * atomic_inc - increment atomic variable > + * * @v: pointer of type Atomic > + ** > + * * Atomically increments @v by 1. > + * */ Your editor has done something weird with these comments. -- PMM

[Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan The func call chain can suffer from recursively hold qemu_mutex_lock_iothread. We introduce lockmap to record the lock depth. Signed-off-by: Liu Ping Fan --- cpus.c | 18 ++ qemu-thread-posix.c | 23 +++ qemu-thread-posix.

Re: [Qemu-devel] [PATCH V3 06/11] memory: make mmio dispatch able to be out of biglock

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Without biglock, we try to protect the mr by increase refcnt. > If we can inc refcnt, go backward and resort to biglock. > > Another point is memory radix-tree can be flushed by another > thread, so we should get the copy of te

[Qemu-devel] [PATCH v1] Make inet_parse() non-static

2012-09-11 Thread Bharata B Rao
From: Bharata B Rao Make inet_parse() non static. - Make inet_parse() non-static so that other subsystems like gluster can use it to parse inet addresses. As a pre-requisite, define and globalize the qemu_inet_opts. - Extend inet_parse() to parse just 'address' also in addition to 'address:

[Qemu-devel] [PATCH V3 04/11] pci: remove pci device from mem view when unplug

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- hw/acpi_piix4.c |2 +- hw/pci.c| 13 - hw/pci.h|1 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index c56220b..a78b0e3 100644 --- a/hw/acpi_piix4.c +++

[Qemu-devel] [PATCH V3 09/11] vcpu: make QemuThread as tls to store thread-self info

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan We store the thread self info in QemuThread. Signed-off-by: Liu Ping Fan --- cpus.c |1 + qemu-thread-posix.c |7 +++ qemu-thread-posix.h |2 ++ qemu-thread.h |1 + vl.c|4 5 files changed, 15 insertions(+), 0 d

Re: [Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > DeviceState will be protected by refcnt from disappearing during > dispatching. But when refcnt comes down to zero, DeviceState may > be still in use by iohandler, timer etc in main loop, we just delay > its free untill no reade

[Qemu-devel] [PATCH V3 06/11] memory: make mmio dispatch able to be out of biglock

2012-09-11 Thread Liu Ping Fan
From: Liu Ping Fan Without biglock, we try to protect the mr by increase refcnt. If we can inc refcnt, go backward and resort to biglock. Another point is memory radix-tree can be flushed by another thread, so we should get the copy of terminal mr to survive from such issue. Signed-off-by: Liu

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > The func call chain can suffer from recursively hold > qemu_mutex_lock_iothread. We introduce lockmap to record the > lock depth. What is the root cause? io handlers initiating I/O? Perhaps we can have a solution that is loca

Re: [Qemu-devel] [PATCH V3 07/11] memory: implement e1000's MemoryRegionOps ref/unref

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > With this, e1000 show to memory core that it can be protected by > refcnt. > > diff --git a/hw/e1000.c b/hw/e1000.c > index ae8a6c5..df3a349 100644 > --- a/hw/e1000.c > +++ b/hw/e1000.c > @@ -1037,9 +1037,26 @@ e1000_mmio_read(

Re: [Qemu-devel] [PATCH] migration: address handling cleanup

2012-09-11 Thread Orit Wasserman
On 09/11/2012 10:33 AM, Amos Kong wrote: > From: Michael S. Tsirkin > > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actuall

Re: [Qemu-devel] [PATCH V12 4/6] rename qcow2-cache.c to block-cache.c

2012-09-11 Thread Kevin Wolf
Am 10.08.2012 17:39, schrieb Dong Xu Wang: > add-cow and qcow2 file format will share the same cache code, so rename > block-cache.c to block-cache.c. And related structure and qcow2 code also > are changed. > > Signed-off-by: Dong Xu Wang > --- > block.h|3 + > block/Makefil

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Gerd Hoffmann
On 09/11/12 08:56, Alon Levy wrote: > Until now we used only the agent to change the monitor count and each > monitor resolution. This patch introduces the qemu part of using the > device as the mediator instead of the agent via virtio-serial. > > Spice (>=0.11.5) calls the new QXLInterface::clien

Re: [Qemu-devel] [PATCH V3 06/11] memory: make mmio dispatch able to be out of biglock

2012-09-11 Thread Avi Kivity
On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Without biglock, we try to protect the mr by increase refcnt. > If we can inc refcnt, go backward and resort to biglock. > > Another point is memory radix-tree can be flushed by another > thread, so we should get the copy of te

Re: [Qemu-devel] [PULL] KVM updates

2012-09-11 Thread Avi Kivity
On 09/11/2012 02:03 AM, Anthony Liguori wrote: > Avi Kivity writes: > >> Please pull from: >> >> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >> >> to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device >> assignment. With this there are no significant cha

Re: [Qemu-devel] [PATCH 0/4] linux framebuffer display driver

2012-09-11 Thread Gerd Hoffmann
On 09/11/12 10:09, Alon Levy wrote: >> Hi, >> >> Undusting an pretty old patch series, rebasing it, testing it, >> fixing a bug or two, fixing codestyle issues: Qemu can run on the >> linux framebuffer console as graphical display now. > > Patch 4 doesn't apply (hmp.h), missing SoB on a few patc

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-11 Thread Jan Kiszka
On 2012-09-11 02:49, Maciej W. Rozycki wrote: > On Sun, 9 Sep 2012, Matthew Ogilvie wrote: > >> This bug manifested itself when the guest was Microport UNIX >> System V/386 v2.1 (ca. 1987), because it would sometimes mask >> off IRQ14 in the slave IMR after it had already been asserted. >> The mas

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-11 Thread Jan Kiszka
On 2012-09-11 06:32, Matthew Ogilvie wrote: > On Mon, Sep 10, 2012 at 11:09:27AM +0200, Jan Kiszka wrote: >> On 2012-09-10 10:56, Avi Kivity wrote: >>> On 09/10/2012 04:27 AM, Matthew Ogilvie wrote: Intel's definition of "edge triggered" means: "asserted with a low-to-high transition at t

Re: [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration

2012-09-11 Thread Avi Kivity
On 09/04/2012 06:13 PM, Julien Grall wrote: > This is the nineth version of patch series about ioport registration. > > Some part of QEMU still use register_ioport* functions to register ioport. > These functions doesn't allow to use Memory Listener on it. Thanks, applied all (w/ updated patch 4)

Re: [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration

2012-09-11 Thread Avi Kivity
On 09/11/2012 12:15 PM, Avi Kivity wrote: > On 09/04/2012 06:13 PM, Julien Grall wrote: >> This is the nineth version of patch series about ioport registration. >> >> Some part of QEMU still use register_ioport* functions to register ioport. >> These functions doesn't allow to use Memory Listener

Re: [Qemu-devel] [PULL] KVM updates

2012-09-11 Thread Jan Kiszka
On 2012-09-11 10:50, Avi Kivity wrote: > On 09/11/2012 02:03 AM, Anthony Liguori wrote: >> Avi Kivity writes: >> >>> Please pull from: >>> >>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master >>> >>> to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device >>> ass

Re: [Qemu-devel] [PATCH 4/4] fbdev: add monitor command to enable/disable

2012-09-11 Thread Markus Armbruster
Gerd Hoffmann writes: > This patch adds a fbdev monitor command to enable/disable > the fbdev display at runtime to both qmp and hmp. > > qmp: fbdev enable=on|off > hmp: fbdev on|off > --- > hmp-commands.hx | 15 +++ > hmp.c|9 + > hmp.h|1 +

Re: [Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-11 Thread liu ping fan
On Tue, Sep 11, 2012 at 4:32 PM, Avi Kivity wrote: > On 09/11/2012 10:51 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> DeviceState will be protected by refcnt from disappearing during >> dispatching. But when refcnt comes down to zero, DeviceState may >> be still in use by iohandler, timer

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
> On 09/11/12 08:56, Alon Levy wrote: > > Until now we used only the agent to change the monitor count and > > each > > monitor resolution. This patch introduces the qemu part of using > > the > > device as the mediator instead of the agent via virtio-serial. > > > > Spice (>=0.11.5) calls the new

Re: [Qemu-devel] [PATCH V3 08/11] qom: introduce reclaimer to release obj in async

2012-09-11 Thread Avi Kivity
On 09/11/2012 12:32 PM, liu ping fan wrote: > On Tue, Sep 11, 2012 at 4:32 PM, Avi Kivity wrote: >> On 09/11/2012 10:51 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> DeviceState will be protected by refcnt from disappearing during >>> dispatching. But when refcnt comes down to zero, Devi

Re: [Qemu-devel] [PATCH V12 5/6] add-cow file format

2012-09-11 Thread Kevin Wolf
Am 10.08.2012 17:39, schrieb Dong Xu Wang: > add-cow file format core code. It use block-cache.c as cache code. > > Signed-off-by: Dong Xu Wang > --- > block/Makefile.objs |1 + > block/add-cow.c | 613 > +++ > block/add-cow.h | 85

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread liu ping fan
On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: > On 09/11/2012 10:51 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> The func call chain can suffer from recursively hold >> qemu_mutex_lock_iothread. We introduce lockmap to record the >> lock depth. > > What is the root cause? io handlers

Re: [Qemu-devel] [PATCH V12 5/6] add-cow file format

2012-09-11 Thread Kevin Wolf
Am 10.09.2012 04:25, schrieb Dong Xu Wang: > On Fri, Sep 7, 2012 at 4:19 AM, Michael Roth > wrote: >> On Fri, Aug 10, 2012 at 11:39:44PM +0800, Dong Xu Wang wrote: >>> +typedef struct AddCowHeader { >>> +uint64_tmagic; >>> +uint32_tversion; >>> + >>> +uint32_tb

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 12:44 PM, liu ping fan wrote: > On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: >> On 09/11/2012 10:51 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> The func call chain can suffer from recursively hold >>> qemu_mutex_lock_iothread. We introduce lockmap to record the >>>

Re: [Qemu-devel] [PATCH V12 6/6] add-cow: add qemu-iotests support

2012-09-11 Thread Kevin Wolf
Am 10.08.2012 17:39, schrieb Dong Xu Wang: > Add qemu-iotests support for add-cow. > > Signed-off-by: Dong Xu Wang > --- > tests/qemu-iotests/017 |2 +- > tests/qemu-iotests/020 |2 +- > tests/qemu-iotests/check |4 ++-- > tests/qemu-iotests/common|6 ++ >

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 11:44, liu ping fan wrote: > On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: >> On 09/11/2012 10:51 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> The func call chain can suffer from recursively hold >>> qemu_mutex_lock_iothread. We introduce lockmap to record the >>> loc

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 11:54, Avi Kivity wrote: > On 09/11/2012 12:44 PM, liu ping fan wrote: >> On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: >>> On 09/11/2012 10:51 AM, Liu Ping Fan wrote: From: Liu Ping Fan The func call chain can suffer from recursively hold qemu_mutex_lock_io

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-11 Thread Kevin Wolf
Am 05.09.2012 15:26, schrieb riegama...@gmail.com: > From: Dunrong Huang > > The caller would not delete temporary file after failed get_tmp_filename(). > > Signed-off-by: Dunrong Huang Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] Implementing qxl-virtio on QEMU

2012-09-11 Thread Gerd Hoffmann
On 08/27/12 08:08, Gerd Hoffmann wrote: > On 08/24/12 21:14, Erlon Cruz wrote: >> The following patches makes provides video support to non PCI architectures, >> please review! > > Can you give an overview on the virtio-qxl virtual hardware design? Self-reply-ing. There is a paper on it (got li

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-11 Thread Till Schäfer
changing the guest config to enable paravirt seems to do the trick! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1037675 Title: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1 Status in

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 01:04 PM, Jan Kiszka wrote: >> DMA is inherently asynchronous, so we already drop the lock between >> initiation and completion; we need to find a way to make it easy to use >> the API without taking the lock while the transfer takes place. > > We will have to review/rework device m

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Gerd Hoffmann
Hi, >> I don't think an explicit handshake via >> QXL_IO_CLIENT_MONITORS_CONFIG_DONE is a good idea. > > Why? I don't see the below as being better - it just moves the checking to > the guest, and racily. It is more robust. We don't have to keep state in qxl for the handshake, one less oppor

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 13:03, Avi Kivity wrote: > On 09/11/2012 01:04 PM, Jan Kiszka wrote: > >>> DMA is inherently asynchronous, so we already drop the lock between >>> initiation and completion; we need to find a way to make it easy to use >>> the API without taking the lock while the transfer takes plac

Re: [Qemu-devel] [PATCH 3/4] fbdev: add linux framebuffer display driver.

2012-09-11 Thread Markus Armbruster
Gerd Hoffmann writes: > Display works, requires truecolor framebuffer with 16 or 32 bpp on the > host. 32bpp is recommended. The framebuffer is used as-is, qemu > doesn't try to switch modes. With LCD displays mode switching is pretty > pointless IMHO, also it wouldn't work anyway with the mos

Re: [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration

2012-09-11 Thread Julien Grall
On 09/11/2012 10:25 AM, Avi Kivity wrote: On 09/11/2012 12:15 PM, Avi Kivity wrote: On 09/04/2012 06:13 PM, Julien Grall wrote: This is the nineth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These funct

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
> Hi, > > >> I don't think an explicit handshake via > >> QXL_IO_CLIENT_MONITORS_CONFIG_DONE is a good idea. > > > > Why? I don't see the below as being better - it just moves the > > checking to the guest, and racily. > > It is more robust. I suggested a way for it to be as robust - I take rob

Re: [Qemu-devel] [PATCH for-1.2 v2 0/5] target-ppc: MAINTAINERS additions

2012-09-11 Thread Alexander Graf
On 08/22/2012 05:48 PM, Andreas Färber wrote: Hi Alex, Here's an updated and squashed series adding some MAINTAINERS sections for ppc machines and their devices. Based on Peter's suggestion the machines are no longer grouped by ppc4xx chipset but ordered alphabetically, and the shared devices b

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-11 Thread Alexander Graf
On 09/07/2012 08:58 PM, Scott Wood wrote: On 09/07/2012 03:08 AM, Alexander Graf wrote: On 07.09.2012, at 01:15, Scott Wood wrote: On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Wednesday, August 15, 2012 6:59 AM To: Bhushan B

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Hans de Goede
Hi, Sorry for top posting, but trying to summarize this thread here. I must say I like Gerd's approach, as it unifies code paths mostly, instead of having yet another interface where we do 2 way capabilities negotiation, with all the extra test matrix entries that would entice for full testing,

Re: [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration

2012-09-11 Thread Jan Kiszka
On 2012-09-11 13:27, Julien Grall wrote: > On 09/11/2012 10:25 AM, Avi Kivity wrote: >> On 09/11/2012 12:15 PM, Avi Kivity wrote: >> >>> On 09/04/2012 06:13 PM, Julien Grall wrote: >>> This is the nineth version of patch series about ioport registration. Some part of QEMU s

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-11 Thread Maciej W. Rozycki
On Mon, 10 Sep 2012, Matthew Ogilvie wrote: > > > This bug manifested itself when the guest was Microport UNIX > > > System V/386 v2.1 (ca. 1987), because it would sometimes mask > > > off IRQ14 in the slave IMR after it had already been asserted. > > > The master would still try to deliver an int

[Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Jan Kiszka
On 2012-09-11 13:48, Jan Kiszka wrote: > On 2012-09-11 13:27, Julien Grall wrote: >> On 09/11/2012 10:25 AM, Avi Kivity wrote: >>> On 09/11/2012 12:15 PM, Avi Kivity wrote: >>> On 09/04/2012 06:13 PM, Julien Grall wrote: > This is the nineth version of patch series about iop

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
> Hi, > > Sorry for top posting, but trying to summarize this thread here. > > I must say I like Gerd's approach, as it unifies code paths mostly, > instead of having yet another interface where we do 2 way > capabilities > negotiation, with all the extra test matrix entries that would entice > f

Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter

2012-09-11 Thread Luiz Capitulino
On Tue, 11 Sep 2012 09:57:12 +0800 Dong Xu Wang wrote: > >> > > >> > -set_option_parameter_int(options, BLOCK_OPT_SIZE, total_size); > >> > -set_option_parameter(options, BLOCK_OPT_BACKING_FILE, > >> > backing_filename); > >> > +snprintf(buf_total_size, sizeof(buf_total_s

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Gerd Hoffmann
On 09/11/12 13:29, Alon Levy wrote: >> Hi, >> I don't think an explicit handshake via QXL_IO_CLIENT_MONITORS_CONFIG_DONE is a good idea. >>> >>> Why? I don't see the below as being better - it just moves the >>> checking to the guest, and racily. >> >> It is more robust. > > I sugge

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
> > Hi, > > > > Sorry for top posting, but trying to summarize this thread here. > > > > I must say I like Gerd's approach, as it unifies code paths mostly, > > instead of having yet another interface where we do 2 way > > capabilities > > negotiation, with all the extra test matrix entries that

Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Julien Grall
On 09/11/2012 12:57 PM, Jan Kiszka wrote: > On 2012-09-11 13:48, Jan Kiszka wrote: >> On 2012-09-11 13:27, Julien Grall wrote: >>> On 09/11/2012 10:25 AM, Avi Kivity wrote: On 09/11/2012 12:15 PM, Avi Kivity wrote: > On 09/04/2012 06:13 PM, Julien Grall wrote: > >>

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Hans de Goede
Hi, On 09/11/2012 02:03 PM, Alon Levy wrote: Hi, Sorry for top posting, but trying to summarize this thread here. I must say I like Gerd's approach, as it unifies code paths mostly, instead of having yet another interface where we do 2 way capabilities negotiation, with all the extra test matr

Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:14, Julien Grall wrote: > On 09/11/2012 12:57 PM, Jan Kiszka wrote: > >> On 2012-09-11 13:48, Jan Kiszka wrote: >>> On 2012-09-11 13:27, Julien Grall wrote: On 09/11/2012 10:25 AM, Avi Kivity wrote: > On 09/11/2012 12:15 PM, Avi Kivity wrote: > >> On 09/04/201

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 02:08 PM, Jan Kiszka wrote: > On 2012-09-11 13:03, Avi Kivity wrote: >> On 09/11/2012 01:04 PM, Jan Kiszka wrote: >> DMA is inherently asynchronous, so we already drop the lock between initiation and completion; we need to find a way to make it easy to use the API with

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Gerd Hoffmann
Hi, > This will need spice-server <-> qemu/hw/qxl.c coordination, but I assume we > will need some changes there anyway to set > QXL_INTERRUPT_CLIENT_MONITORS_CONFIG, > the qemu/hw/qxl.c function patching the MonitorsConfig into the romspace, > and setting the irq in int_pending, could return wh

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-11 Thread Andreas Färber
Am 07.09.2012 20:58, schrieb Scott Wood: > On 09/07/2012 03:08 AM, Alexander Graf wrote: >> >> On 07.09.2012, at 01:15, Scott Wood wrote: >> >>> On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: Can we somehow pass this via qdev/varargs from machine emulation code (hw/ppc/e500.c)

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 12:57 PM, Jan Kiszka wrote: > On 2012-09-11 11:44, liu ping fan wrote: >> On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: >>> On 09/11/2012 10:51 AM, Liu Ping Fan wrote: From: Liu Ping Fan The func call chain can suffer from recursively hold qemu_mutex_lock_io

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:20, Avi Kivity wrote: > On 09/11/2012 02:08 PM, Jan Kiszka wrote: >> On 2012-09-11 13:03, Avi Kivity wrote: >>> On 09/11/2012 01:04 PM, Jan Kiszka wrote: >>> > DMA is inherently asynchronous, so we already drop the lock between > initiation and completion; we need to find a

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-11 Thread Alexander Graf
On 09/11/2012 02:23 PM, Andreas Färber wrote: Am 07.09.2012 20:58, schrieb Scott Wood: On 09/07/2012 03:08 AM, Alexander Graf wrote: On 07.09.2012, at 01:15, Scott Wood wrote: On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: Can we somehow pass this via qdev/varargs from machine emulati

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 03:25 PM, Jan Kiszka wrote: Most DMA today happens without the big qemu lock. We only need to convert the paths that actually access memory, these are the block and network layers (for the respective devices). >>> >>> ...and the devices themselves, of course. >>

Re: [Qemu-devel] [PATCH v1] Make inet_parse() non-static

2012-09-11 Thread Markus Armbruster
Bharata B Rao writes: > From: Bharata B Rao > > Make inet_parse() non static. > > - Make inet_parse() non-static so that other subsystems like gluster > can use it to parse inet addresses. As a pre-requisite, define and > globalize the qemu_inet_opts. Please repost this as part of a series

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:30, Avi Kivity wrote: >> The other option is to keep DMA requests issued by devices synchronous >> but let them fail if we are about to lock up. Still requires changes, >> but is probably more comprehensible for device model developers. > > How do you handle fai

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
> Hi, > > > This will need spice-server <-> qemu/hw/qxl.c coordination, but I > > assume we > > will need some changes there anyway to set > > QXL_INTERRUPT_CLIENT_MONITORS_CONFIG, > > the qemu/hw/qxl.c function patching the MonitorsConfig into the > > romspace, > > and setting the irq in int_pend

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 03:35 PM, Jan Kiszka wrote: > On 2012-09-11 14:30, Avi Kivity wrote: >>> The other option is to keep DMA requests issued by devices synchronous >>> but let them fail if we are about to lock up. Still requires changes, >>> but is probably more comprehensible for device mode

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Avi Kivity
On 09/11/2012 03:24 PM, Avi Kivity wrote: > On 09/11/2012 12:57 PM, Jan Kiszka wrote: >> On 2012-09-11 11:44, liu ping fan wrote: >>> On Tue, Sep 11, 2012 at 4:35 PM, Avi Kivity wrote: On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > The func call chain can su

Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Avi Kivity
On 09/11/2012 02:57 PM, Jan Kiszka wrote: > Only listen on debug ports when we also handle them. They are better > handled by debugcon these days which is runtime configurable. > > Signed-off-by: Jan Kiszka > --- > hw/pc.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > d

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-11 Thread Avi Kivity
On 09/10/2012 04:09 PM, Maciej W. Rozycki wrote: > >> > No, this is about the PIC, not the CPU interrupt inputs. >> >> I see, the interrupt is still sent to the processor; but IRR reflects >> that status of the input line, not a "pending interrupt" status. > > Not really, this is still a "pendi

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-11 Thread Avi Kivity
On 09/11/2012 12:05 PM, Jan Kiszka wrote: > I think this is convincing, maybe worth documenting in the related > changelogs of QEMU and KVM. Avi, doubts remaining? > Nope, I think I've understood it finally. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-11 Thread Andreas Färber
Am 11.09.2012 14:27, schrieb Alexander Graf: > On 09/11/2012 02:23 PM, Andreas Färber wrote: >> For a reference to another object a QOM link<> property would be >> preferred over a static qdev property. > > How does that work? Can we do RPC to other objects to access its CCSR > and/or enumerate th

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Gerd Hoffmann
> ok, I'm missing something here. (and trying to catch up via Vol 3A is taking > too long). > I thought the order is: > (1) qemu raises interrupt > (2) qemu calls kvm ioctl > (3) guest interrupt handler > (4) guest clears interrupt by writing ~0 to qxl ram_header->int_mask. > (5) qemu detects this

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
> > ok, I'm missing something here. (and trying to catch up via Vol 3A > > is taking too long). > > I thought the order is: > > (1) qemu raises interrupt > > (2) qemu calls kvm ioctl > > (3) guest interrupt handler > > (4) guest clears interrupt by writing ~0 to qxl > > ram_header->int_mask. > > (5

Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info

2012-09-11 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Extract it out of the implementation of "info block". > > Signed-off-by: Paolo Bonzini > --- > block.c | 104 > +++ > block.h |1 + > 2 files changed, 53 insertions(+), 52 deletions(-)

Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info

2012-09-11 Thread Paolo Bonzini
- Messaggio originale - > Da: "Kevin Wolf" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, ebl...@redhat.com, jc...@redhat.com, > stefa...@linux.vnet.ibm.com > Inviato: Martedì, 11 settembre 2012 15:07:05 > Oggetto: Re: [PATCH 19/47] block: add bdrv_query_info > > Am 24.07.2012 13:0

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Hans de Goede
Hi, On 09/11/2012 03:05 PM, Alon Levy wrote: ok, I'm missing something here. (and trying to catch up via Vol 3A is taking too long). I thought the order is: (1) qemu raises interrupt (2) qemu calls kvm ioctl (3) guest interrupt handler (4) guest clears interrupt by writing ~0 to qxl ram_header->

Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Mirroring runs without the backing file so that it can be copied outside > QEMU. However, we need to add it at the time the job is completed and > QEMU switches to the target. Factor out the common bits of opening an > image and completing a mirroring

Re: [Qemu-devel] [PATCH 22/47] block: make device optional in BlockInfo

2012-09-11 Thread Kevin Wolf
Am 24.07.2012 13:04, schrieb Paolo Bonzini: > Targets of a mirroring operation will not have a device. Once we have > -blockdev or equivalent, "detached" block devices and non-anonymous > backing files also will not have a device. > > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json |5

Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Paolo Bonzini
> Once again, combining code motion and code changes in one patch makes > it harder to review. bdrv_ensure_backing_file() is a new standalone function that happens to be usable in bdrv_open as well. But I can separate the changes/fixes to a separate patch. In particular it is can be used after

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-11 Thread Anthony Liguori
On 09/10/2012 01:24 AM, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote: Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: Cc: Stefan

  1   2   3   >