On 09/11/2012 10:51 AM, Liu Ping Fan wrote: > From: Liu Ping Fan <pingf...@linux.vnet.ibm.com> > > This pair of interface help to decide when dispatching, whether > we can pin mr without big lock or not. > > --- a/memory.h > +++ b/memory.h > @@ -25,6 +25,7 @@ > #include "iorange.h" > #include "ioport.h" > #include "int128.h" > +#include "qemu/object.h"
Not needed. > > typedef struct MemoryRegionOps MemoryRegionOps; > typedef struct MemoryRegion MemoryRegion; > @@ -66,6 +67,8 @@ struct MemoryRegionOps { > target_phys_addr_t addr, > uint64_t data, > unsigned size); > + int (*ref)(MemoryRegion *mr); > + void (*unref)(MemoryRegion *mr); > Please add documentation, esp. that the operations are optional. -- error compiling committee.c: too many arguments to function