On Tue, 11 Sep 2012 09:57:12 +0800 Dong Xu Wang <wdon...@linux.vnet.ibm.com> wrote:
> >> > > >> > - set_option_parameter_int(options, BLOCK_OPT_SIZE, total_size); > >> > - set_option_parameter(options, BLOCK_OPT_BACKING_FILE, > >> > backing_filename); > >> > + snprintf(buf_total_size, sizeof(buf_total_size), > >> > + "%" PRId64, total_size); > >> > + qemu_opt_set(options, BLOCK_OPT_SIZE, buf_total_size); > >> > >> This is a bit awkward. > >> > >> We could have qemu_opt_set_number(), like qemu_opt_set_bool(). Except > >> qemu_opt_set_bool() has issues. Luiz's fix is discussed here: > >> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html > >> > >> Luiz, do you plan to respin? > > > > I'm not going to respin the whole series, but the patch you mention > > and the following two seem worth it to have on master. > > > > Dong, do you want me to respin or can you add them to this series? > > I can add them to this series, thank you Luiz. I just don't remember if there's anything to be addressed, so it's a good idea to re-read the thread.
