Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-19 Thread Wen Congyang
At 03/08/2012 03:57 PM, Wen Congyang Wrote: > We can know the guest is paniced when the guest runs on xen. > But we do not have such feature on kvm. > > Another purpose of this feature is: management app(for example: > libvirt) can do auto dump when the guest is crashed. If management > app does n

Re: [Qemu-devel] [PATCH] virtio-spec: split virtio-net device status filed into ro and rw byte

2012-03-19 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 11:09:24AM +0800, Jason Wang wrote: > On 03/18/2012 08:22 PM, Michael S. Tsirkin wrote: > >On Fri, Mar 16, 2012 at 11:20:26PM +0800, Jason Wang wrote: > >>This patch splits the device status field of virtio-net into ro and rw > >>byte. This would simplify the implementation

Re: [Qemu-devel] [PATCH 0/2] acpi: robust notifications

2012-03-19 Thread Gleb Natapov
On Sun, Mar 18, 2012 at 07:06:23PM +0200, Michael S. Tsirkin wrote: > acpi currently clears up/down registers on each hotplug > request. This loses events if they are done quickly. > It's easy to clear down on ej write. > To detect that guest was notified of device addition, > we track configuratio

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-19 Thread Wen Congyang
At 03/19/2012 10:28 AM, Wen Congyang Wrote: > At 03/15/2012 01:18 AM, Luiz Capitulino Wrote: >> On Wed, 14 Mar 2012 10:11:35 +0800 >> Wen Congyang wrote: >> >>> The command's usage: >>>dump [-p] file >>> file should be start with "file:"(the file's path) or "fd:"(the fd's name). >>> >>> Note:

Re: [Qemu-devel] [PATCH] monitor: fix client_migrate_info error handling

2012-03-19 Thread Alon Levy
On Sun, Mar 18, 2012 at 09:42:39AM +0200, Yonit Halperin wrote: > Report QERR_INVALID_PARAMETER when port is missing. Otherwise > QERR_UNDEFINED_ERROR will occur. > > rhbz #795652 > Reviewed-by: Alon Levy > Signed-off-by: Yonit Halperin > --- > monitor.c |5 + > 1 files changed, 5 in

Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

2012-03-19 Thread Avi Kivity
On 03/19/2012 06:52 AM, TeLeMan wrote: > > static bool memory_region_wrong_endianness(MemoryRegion *mr) > > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr, > > mr->opaque = opaque; > > mr->terminates = true; > > mr->destructor = memory_region_destructor_iomem; > > -

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-03-19 Thread Vadim Rozenfeld
On Monday, March 19, 2012 08:29:41 AM Charles.Tsai-蔡清海-研究發展部 wrote: > Hi Vadim, > > We recently encountered with many issues with new Windows Virio driver > running on Qemu 1.0 and Qemu 1.0.50. My initial investigation was found > that the new Viro driver could not be installed before Qemu

[Qemu-devel] [PATCH] use bdrv_aio functions in fdc.c

2012-03-19 Thread Li Zhi Hui
Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c. Signed-off-by: Li Zhi Hui --- hw/fdc.c | 265 ++ 1 files changed, 196 insertions(+), 69 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index a0236b7..11d2a5c 100644 --- a/hw/

[Qemu-devel] [PULL] Memory core regression fixes

2012-03-19 Thread Avi Kivity
The last memory core pull introduced a couple of regressions; here are the fixes. Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent Avi Kivity (2): exec: fix write tlb entry misused as iotlb

Re: [Qemu-devel] Breakage

2012-03-19 Thread Avi Kivity
On 03/19/2012 06:34 AM, Roy Tam wrote: > But I get "*** stack smashing detected ***: terminated" and crash > when booting BeOS 5. > Is that a regression? From what commit? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] coroutine-gthread.c: Avoid threading APIs deprecated in GLib 2.31

2012-03-19 Thread Stefan Hajnoczi
On Thu, Mar 15, 2012 at 09:55:02PM +, Peter Maydell wrote: > On 15 March 2012 11:21, Stefan Hajnoczi wrote: > > It's ugly but it won't cause larger scale problems, so we should > > probably pick this up. > > > > I was wondering if this is a legitimate case to override warnings - > > because th

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-19 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 04:59:35PM +0800, Amos Kong wrote: > On 14/03/12 19:46, Stefan Hajnoczi wrote: > >On Wed, Mar 14, 2012 at 10:46 AM, Avi Kivity wrote: > >>On 03/14/2012 12:39 PM, Stefan Hajnoczi wrote: > >>>On Wed, Mar 14, 2012 at 10:05 AM, Avi Kivity wrote: > On 03/14/2012 11:59 AM, S

Re: [Qemu-devel] [Qemu-trivial] [REPOST PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 11:19:57AM +0800, Jason Wang wrote: > ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument > 3 has type ‘uint64_t’ > > Signed-off-by: Jason Wang > --- > hw/ioapic.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to

Re: [Qemu-devel] [REPOST PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-19 Thread Andreas Färber
Am 19.03.2012 04:19, schrieb Jason Wang: > ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument > 3 has type ‘uint64_t’ > > Signed-off-by: Jason Wang Reviewed-by: Andreas Färber Thanks, Andreas > --- > hw/ioapic.c |2 +- > 1 files changed, 1 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd

2012-03-19 Thread Avi Kivity
On 03/16/2012 10:59 AM, Amos Kong wrote: > > Can you give some detail about this? I'm not familiar with Memory API. Well there's a huge amount of detail needed here. The idea is that memory_region_add_eventfd() will always work, with or without kvm, and even if kvm is enabled but we run out of io

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-03-19 Thread Christophe Fergeau
Hey, On Mon, Mar 19, 2012 at 02:29:41PM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: > 3. When we disable and enable the new VirtIO driver several times > on either Qemu 1.0 or Qemu 1.0.50, VirtIo driver failed to work > after enabling the new VirtIO driver. For what it's worth, Alon Le

Re: [Qemu-devel] [Qemu-trivial] [PATCH] .gitignore update

2012-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 03:58:45PM +1100, David Gibson wrote: > This adds a few previously missing generated files to .gitignore: the > qemu-bridge-helper binary, and more generated versions of the > linuxboot, multiboot and kvmvapic roms from pc-bios/optionrom. > > Signed-off-by: David Gibson >

Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function

2012-03-19 Thread Andreas Färber
Hello Stefan, Am 17.03.2012 13:00, schrieb Stefan Weil: > Function set_HILO is not needed anywhere. Does this cause any warnings? Given the state mips is currently in (TCG patches queuing), I'd suggest to hold this off for a bit, but I don't really mind either way. Commit message does not mentio

Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

2012-03-19 Thread TeLeMan
On Mon, Mar 19, 2012 at 17:16, Avi Kivity wrote: > On 03/19/2012 06:52 AM, TeLeMan wrote: >> >  static bool memory_region_wrong_endianness(MemoryRegion *mr) >> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr, >> >     mr->opaque = opaque; >> >     mr->terminates = true; >> >    

Re: [Qemu-devel] [PATCH 1/3] Add support for target helper functions which don't return

2012-03-19 Thread Andreas Färber
Am 18.03.2012 23:16, schrieb Stefan Weil: > Most functions which handle exceptions don't return. > > With a compiler attribute (added by QEMU_NORETURN), > gcc can optimize the code. Do you have any numbers? > > Signed-off-by: Stefan Weil Seems like a sensible optimization, Reviewed-by: Andre

Re: [Qemu-devel] [PATCH 2/3] target-mips: Add compiler attribute to some functions which don't return

2012-03-19 Thread Andreas Färber
Am 18.03.2012 23:16, schrieb Stefan Weil: > helper_raise_exception_err does not return, nor do helper_raise_exception > and do_unaligned_access. > > Cc: Aurelien Jarno > Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()

2012-03-19 Thread Avi Kivity
On 03/19/2012 12:37 PM, TeLeMan wrote: > On Mon, Mar 19, 2012 at 17:16, Avi Kivity wrote: > > On 03/19/2012 06:52 AM, TeLeMan wrote: > >> > static bool memory_region_wrong_endianness(MemoryRegion *mr) > >> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr, > >> > mr->opaque =

Re: [Qemu-devel] [PATCH] kvm: Fix dirty tracking with large kernel page size

2012-03-19 Thread Andreas Färber
Am 19.03.2012 05:57, schrieb David Gibson: > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tossatti > > Signed-off-by: Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH v4 7/7] RTC:Allow to migrate from old version

2012-03-19 Thread Avi Kivity
On 03/19/2012 08:14 AM, Zhang, Yang Z wrote: > The new logic is compatible with old. So it should not block migrate from old > version. But new version cannot migrate to old. > > +static int rtc_load_old(QEMUFile *f, void *opaque, int version_id) > +{ > +RTCState *s = opaque; > + > +if (ve

Re: [Qemu-devel] [PATCH] qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write()

2012-03-19 Thread Stefan Hajnoczi
On Thu, Mar 15, 2012 at 02:26:18PM -0400, Jeff Cody wrote: > In the function ga_channel_write(), the handle ov.hEvent is created > by the call to CreateEvent(). However, the handle is not closed > prior to the function return. > > This patch closes the handle before the return of the function. >

Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.

2012-03-19 Thread Andreas Färber
Am 17.03.2012 20:30, schrieb Richard Henderson: > Ping. This is linux-user, so cc'ing Riku. Code looks sane at first sight although I have no clue of the constants' meaning and effect. ;) Commit message doesn't mention it but I guess this fixes some bug? How does it round before the patch? Andr

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Remove unused inline function

2012-03-19 Thread Stefan Hajnoczi
On Sat, Mar 17, 2012 at 01:00:51PM +0100, Stefan Weil wrote: > Function set_HILO is not needed anywhere. > > Signed-off-by: Stefan Weil > --- > target-mips/op_helper.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-) Thanks, applied to the trivial patches tree: https://github.c

Re: [Qemu-devel] [PATCH 1/6] i82378/i82374: do not create DMA controller twice

2012-03-19 Thread Andreas Färber
Am 17.03.2012 15:39, schrieb Hervé Poussineau: > This fixes a crash in PReP emulation when using DMA controller to access > floppy drive. > > Signed-off-by: Hervé Poussineau Reviewed-by: Andreas Färber Andreas > --- > hw/i82374.c |5 - > hw/i82378.c |5 +++-- > 2 files changed,

Re: [Qemu-devel] [PATCH 1/3] Add support for target helper functions which don't return

2012-03-19 Thread Stefan Weil
Am 19.03.2012 11:45, schrieb Andreas Färber: Am 18.03.2012 23:16, schrieb Stefan Weil: Most functions which handle exceptions don't return. With a compiler attribute (added by QEMU_NORETURN), gcc can optimize the code. Do you have any numbers? Yes, of course: for (;;) { printf("%ld\n", rand

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] i82378/i82374: do not create DMA controller twice

2012-03-19 Thread Alexander Graf
On 19.03.2012, at 12:03, Andreas Färber wrote: > Am 17.03.2012 15:39, schrieb Hervé Poussineau: >> This fixes a crash in PReP emulation when using DMA controller to access >> floppy drive. >> >> Signed-off-by: Hervé Poussineau > > Reviewed-by: Andreas Färber Why only reviewed? You're the PR

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Fix creation of symbolic links for MinGW toolchain

2012-03-19 Thread Stefan Hajnoczi
On Sat, Mar 17, 2012 at 05:24:08PM +, Peter Maydell wrote: > On 17 March 2012 15:59, Stefan Weil wrote: > > Am 17.03.2012 16:49, schrieb Peter Maydell: > >> Where do we symlink directories? (I exclude the setting up > >> of the linux headers because that will only happen on Linux > >> hosts wh

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 03:59:23PM +1100, David Gibson wrote: > Currently the virtio balloon device, when using the virtio-pci interface > advertises itself with PCI class code MEMORY_RAM. This is wrong; the > balloon is vaguely related to memory, but is nothing like a PCI memory > device in the m

[Qemu-devel] [PATCH v8 0/6] save/restore on Xen

2012-03-19 Thread Stefano Stabellini
Hi all, this is the seventh version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http://marc.info/?l=qemu-devel&m=132346828427314&w=2 http://marc.info/?l=qemu-devel&m=132377734605464&w=2 Please review the second patch: Intro

[Qemu-devel] [PATCH v8 1/6] cirrus_vga: do not reset videoram

2012-03-19 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini Reviewed-by: Avi Kivity --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 4edcb94..a

[Qemu-devel] [PATCH v8 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-03-19 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 972cffd..10d53d1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -190,6 +190,14 @@ void xen_r

[Qemu-devel] [PATCH v8 3/6] Set runstate to INMIGRATE earlier

2012-03-19 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini Acked-by: Luiz Capitulino --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 1d4c350..918177a 100644 --- a/vl.c +++ b/vl.c @@ -3099,6 +3099,7 @@ i

[Qemu-devel] [PATCH v8 5/6] xen mapcache: check if memory region has moved.

2012-03-19 Thread Stefano Stabellini
From: Anthony PERARD This patch changes the xen_map_cache behavior. Before trying to map a guest addr, mapcache will look into the list of range of address that have been moved (physmap/set_memory). There is currently one memory space like this, the vram, "moved" from were it's allocated to were

[Qemu-devel] [PATCH v8 4/6] xen: record physmap changes to xenstore

2012-03-19 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH v8 2/6] Introduce "xen-save-devices-state"

2012-03-19 Thread Stefano Stabellini
- add an "is_ram" flag to SaveStateEntry; - register_savevm_live sets is_ram for live_savevm devices; - introduce a "xen-save-devices-state" QAPI command that can be used to save the state of all devices, but not the RAM or the block devices of the VM. Changes in v8: - rename save-devices-state

Re: [Qemu-devel] [PATCH v7 2/6] Introduce "save-devices-state"

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Eric Blake wrote: > On 03/16/2012 09:58 AM, Anthony Liguori wrote: > > >>> +These operations are normally used with migration (see migration.txt), > >>> +however it is also possible to save the state of all devices to file, > >>> +without saving the RAM or the block devices of

Re: [Qemu-devel] [PATCH V8 RESEND 1/8] pci_ids: Add INTEL_82599_VF id.

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > hw/pci_ids.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_ids.h b/hw/pci_ids.h > index e8235a7..943106a 100644 > --- a/hw/pci_ids.h > +++ b/hw/pci_ids.h > @@ -118,6 +118,7 @

Re: [Qemu-devel] [PATCH V8 RESEND 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD ack > configure | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index afe7395..1d1204a 100755 > --- a/configure > +++ b/configure > @@ -136,

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-03-19 Thread Vadim Rozenfeld
On Monday, March 19, 2012 12:12:59 PM Christophe Fergeau wrote: > Hey, > > On Mon, Mar 19, 2012 at 02:29:41PM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: > > 3. When we disable and enable the new VirtIO driver several times > > on either Qemu 1.0 or Qemu 1.0.50, VirtIo driver failed to work > >

Re: [Qemu-devel] VDI patches

2012-03-19 Thread Kevin Wolf
Am 17.03.2012 08:10, schrieb Stefan Weil: > Am 17.03.2012 04:11, schrieb q...@buildbot.b1-systems.de: >> The Buildbot has detected a new failure on builder >> block_i386_debian_6_0 while building qemu. >> Full details are available at: >> http://buildbot.b1-systems.de/qemu/builders/block_i386_debi

Re: [Qemu-devel] [PATCH V8 RESEND 3/8] Introduce HostPCIDevice to access a pci device on the host.

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD ack > Makefile.target |3 + > hw/host-pci-device.c | 278 > ++ > hw/host-pci-device.h | 75 ++ > 3 files changed, 356 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH V8 RESEND 4/8] pci.c: Add pci_check_bar_overlap

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Yuji Shimada > > This function helps Xen PCI Passthrough device to check for overlap. > > Signed-off-by: Yuji Shimada > Signed-off-by: Anthony PERARD It is probably worth mentioning that the function as it is cannot handle bridges in the comm

Re: [Qemu-devel] [PATCH V8 RESEND 5/8] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Allen Kay > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Allen Kay > Signed-off-by: Guy Zana > Signed-off-by: Anthony PERARD Such a large patch is obviously hard to revie

Re: [Qemu-devel] [PATCH V8 RESEND 6/8] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Allen Kay > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Allen Kay > Signed-off-by: Guy Zana > Signed-off-by: Anthony PERARD ack

Re: [Qemu-devel] [PATCH V8 RESEND 7/8] Introduce apic-msidef.h

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > This patch move the msi definition from apic.c to apic-msidef.h. So it can be > used also by other .c files. > Ack

Re: [Qemu-devel] [PATCH V8 RESEND 8/8] Introduce Xen PCI Passthrough, MSI (3/3)

2012-03-19 Thread Stefano Stabellini
On Fri, 16 Mar 2012, Anthony PERARD wrote: > From: Jiang Yunhong > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Jiang Yunhong > Signed-off-by: Shan Haitao > Signed-off-by: Anthony PERARD ack

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-03-19 Thread Christophe Fergeau
On Mon, Mar 19, 2012 at 01:42:21PM +0200, Vadim Rozenfeld wrote: > On Monday, March 19, 2012 12:12:59 PM Christophe Fergeau wrote: > > Hey, > > > > On Mon, Mar 19, 2012 at 02:29:41PM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: > > > 3. When we disable and enable the new VirtIO driver several times > >

Re: [Qemu-devel] [PATCH] monitor: fix client_migrate_info error handling

2012-03-19 Thread Gerd Hoffmann
On 03/18/12 08:42, Yonit Halperin wrote: > Report QERR_INVALID_PARAMETER when port is missing. Otherwise > +qerror_report(QERR_MISSING_PARAMETER, "port/tls-port"); Fixed commit message & added to spice patch queue. thanks, Gerd

[Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()?

2012-03-19 Thread Avi Kivity
void HELPER(wsr_ibreaka)(uint32_t i, uint32_t v) { if (env->sregs[IBREAKENABLE] & (1 << i) && env->sregs[IBREAKA + i] != v) { tb_invalidate_phys_page_range( env->sregs[IBREAKA + i], env->sregs[IBREAKA + i] + 1, 0); tb_invalidate_phys_page_range(v, v + 1, 0);

Re: [Qemu-devel] [PATCH v4 0/3] qxl trace events

2012-03-19 Thread Gerd Hoffmann
On 03/18/12 13:46, Alon Levy wrote: > Alon Levy (3): > qxl: init_pipe_signaling: exit on failure > qxl: switch qxl.c to trace-events > qxl/qxl_render.c: add trace events Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: > Signed-off-by: Lee Essen > > --- > >  scripts/tracetool |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) I'm going to spend some time today reviewing recent tracing patches. I'd prefer to move to a Python version of tracetool rath

Re: [Qemu-devel] [PATCH] hw/qxl.c: Fix compilation failures on 32 bit hosts

2012-03-19 Thread Gerd Hoffmann
On 03/16/12 14:50, Peter Maydell wrote: > Fix compilation failures on 32 bit hosts (cast from pointer to > integer of different size; %ld expects 'long int' not uint64_t). Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-03-19 Thread Vadim Rozenfeld
On Monday, March 19, 2012 01:16:56 PM Charles.Tsai-蔡清海-研究發展部 wrote: > Vadim, > > What do you mean "qemu configuration string"? Is it the build configuration > or command line option? Please let me know it. Thanks. > > Sorry, that was ambiguous. I need the command line in order to reproduce the p

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Lee Essen
On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: >> Signed-off-by: Lee Essen >> >> --- >> >> scripts/tracetool |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > I'm going to spend some time today reviewing recent tracing p

Re: [Qemu-devel] [PATCH important] spice: fix broken initialization

2012-03-19 Thread Gerd Hoffmann
On 03/14/12 19:33, Alon Levy wrote: > Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to > way before MODULE_INIT_MACHINE, thereby breaking assumptions made in > spice-core.c which registered both a type initializer and a machine > intializer. > > This fix removes the type re

Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function

2012-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber wrote: > Hello Stefan, > > Am 17.03.2012 13:00, schrieb Stefan Weil: >> Function set_HILO is not needed anywhere. > > Does this cause any warnings? Given the state mips is currently in (TCG > patches queuing), I'd suggest to hold this off for a bit,

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-03-19 Thread Vadim Rozenfeld
On Monday, March 19, 2012 01:56:03 PM Christophe Fergeau wrote: > On Mon, Mar 19, 2012 at 01:42:21PM +0200, Vadim Rozenfeld wrote: > > On Monday, March 19, 2012 12:12:59 PM Christophe Fergeau wrote: > > > Hey, > > > > > > On Mon, Mar 19, 2012 at 02:29:41PM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] i82378/i82374: do not create DMA controller twice

2012-03-19 Thread Andreas Färber
Am 19.03.2012 12:23, schrieb Alexander Graf: > > On 19.03.2012, at 12:03, Andreas Färber wrote: > >> Am 17.03.2012 15:39, schrieb Hervé Poussineau: >>> This fixes a crash in PReP emulation when using DMA controller to access >>> floppy drive. >>> >>> Signed-off-by: Hervé Poussineau >> >> Review

[Qemu-devel] [PATCH v2] configure: Fix creation of symbolic links for MinGW toolchain

2012-03-19 Thread Stefan Weil
The MinGW toolchain on w32/w64 hosts does not create symbolic links, but implements 'ln -s' similar to 'cp -r'. In incremental out of tree builds, this resulted in files which were not updated when their counterparts in the QEMU source tree changed. Especially for Makefile* this happened very ofte

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] i82378/i82374: do not create DMA controller twice

2012-03-19 Thread Alexander Graf
On 19.03.2012, at 13:19, Andreas Färber wrote: > Am 19.03.2012 12:23, schrieb Alexander Graf: >> >> On 19.03.2012, at 12:03, Andreas Färber wrote: >> >>> Am 17.03.2012 15:39, schrieb Hervé Poussineau: This fixes a crash in PReP emulation when using DMA controller to access floppy dri

[Qemu-devel] [PULL 0/8] Trivial patches for 8 to 19 March 2012

2012-03-19 Thread Stefan Hajnoczi
The following changes since commit 5bd33de6635577744b3c10dd3913bfe8c5ffaf40: tcg: fix sparc host for AREG0 free operation (2012-03-18 19:15:32 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to b71706d122838d9656e

[Qemu-devel] [PATCH 3/8] ds1338: Add missing break statement

2012-03-19 Thread Stefan Hajnoczi
From: Stefan Weil Without the break statement, case 5 sets month and year from the same data. This does not look correct. The missing break was reported by splint. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- hw/ds1338

[Qemu-devel] [PATCH 4/8] monitor: Remove unused bool field 'qapi' in mon_cmd_t struct

2012-03-19 Thread Stefan Hajnoczi
From: Jeff Cody Some minor code cleanup: the 'qapi' bool field in mon_cmd_t is unused, and can be removed. Signed-off-by: Jeff Cody Acked-by: Luiz Capitulino Signed-off-by: Stefan Hajnoczi --- monitor.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/monitor.c b/moni

Re: [Qemu-devel] [PATCH] Makefile.target: code stp dependency on trace-events

2012-03-19 Thread Stefan Hajnoczi
On Sun, Mar 18, 2012 at 08:47:15AM +0100, Alon Levy wrote: > Signed-off-by: Alon Levy > --- > Makefile.target |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Nice catch, thanks! Applied to the tracing patches tree: https://github.com/stefanha/qemu/commits/tracing Stefan

[Qemu-devel] [PATCH 8/8] qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write()

2012-03-19 Thread Stefan Hajnoczi
From: Jeff Cody In the function ga_channel_write(), the handle ov.hEvent is created by the call to CreateEvent(). However, the handle is not closed prior to the function return. This patch closes the handle before the return of the function. Kudos to Paolo Bonzini for spotting this bug. Signed

Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function

2012-03-19 Thread Stefan Weil
Am 19.03.2012 13:17, schrieb Stefan Hajnoczi: On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber wrote: Hello Stefan, Am 17.03.2012 13:00, schrieb Stefan Weil: Function set_HILO is not needed anywhere. Does this cause any warnings? Given the state mips is currently in (TCG patches queuing), I

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 12:05 PM, Lee Essen wrote: > On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > >> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen >> wrote: >>> Signed-off-by: Lee Essen >>> >>> --- >>> >>>  scripts/tracetool |    2 +- >>>  1 files changed, 1 insertions(+), 1 deletions(-) >>

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Andreas Färber
Am 19.03.2012 13:05, schrieb Lee Essen: > On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > >> I'm going to spend some time today reviewing recent tracing patches. >> I'd prefer to move to a Python version of tracetool rather than worry >> about the shell quirks across all host platforms. >> >> If

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Stefan Weil
Am 19.03.2012 13:05, schrieb Lee Essen: On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: Signed-off-by: Lee Essen --- scripts/tracetool | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I'm going to spend some time today reviewing

[Qemu-devel] [PATCH 7/8] ioapic: fix build with DEBUG_IOAPIC

2012-03-19 Thread Stefan Hajnoczi
From: Jason Wang ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ Signed-off-by: Jason Wang Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- hw/ioapic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function

2012-03-19 Thread Andreas Färber
Am 19.03.2012 13:31, schrieb Stefan Weil: > Am 19.03.2012 13:17, schrieb Stefan Hajnoczi: >> On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber >> wrote: >>> Am 17.03.2012 13:00, schrieb Stefan Weil: Function set_HILO is not needed anywhere. >>> >>> Does this cause any warnings? Given the state

[Qemu-devel] [PATCH 5/8] cleanup obsolete typedef

2012-03-19 Thread Stefan Hajnoczi
From: Joshua Housh There are no users of i2c_slave. Signed-off-by: Joshua Housh Signed-off-by: Mark Langsdorf Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- qemu-common.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-common.h b/qemu-common.h in

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Andreas Färber
Am 19.03.2012 13:40, schrieb Stefan Weil: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen >>> wrote: Signed-off-by: Lee Essen --- scripts/tracetool | 2 +- 1 files changed

[Qemu-devel] [PATCH 2/8] vnc: Fix packed boolean struct members

2012-03-19 Thread Stefan Hajnoczi
From: Stefan Weil This patch fixes warnings reported by splint: For variables which are packed in a single bit, a signed data type like 'int' does not make much sense. There is no obvious reason why the two values should be packed, so I removed the packing and changed the data type to bool beca

Re: [Qemu-devel] [PATCH 2/6] prep: change default cpu to '7448'

2012-03-19 Thread Andreas Färber
Am 17.03.2012 15:39, schrieb Hervé Poussineau: > In b37fc148bb81b5b022846156a6cba266e6c23962, PReP default cpu was changed from > 'default' to '602'. However, '7448' is closer of 'default' than '602'. > > This repairs following command line, which is available in some tutorials: > qemu-system-ppc

[Qemu-devel] [PATCH 1/8] Remove type field in ModuleEntry as it's not used

2012-03-19 Thread Stefan Hajnoczi
From: Chen Yufei Signed-off-by: Chen Yufei Acked-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- module.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/module.c b/module.c index 106a969..c3a6da7 100644 --- a/module.c +++ b/module.c @@ -19,7 +19,6 @@ typedef

Re: [Qemu-devel] [PATCH] hw/qxl.c: Fix compilation failures on 32 bit hosts

2012-03-19 Thread Gerd Hoffmann
On 03/19/12 13:02, Gerd Hoffmann wrote: > On 03/16/12 14:50, Peter Maydell wrote: >> Fix compilation failures on 32 bit hosts (cast from pointer to >> integer of different size; %ld expects 'long int' not uint64_t). > > Acked-by: Gerd Hoffmann Oops, scratch that, should have been "added to spice

[Qemu-devel] [PATCH 6/8] .gitignore: add qemu-bridge-helper and option rom build products

2012-03-19 Thread Stefan Hajnoczi
From: David Gibson This adds a few previously missing generated files to .gitignore: the qemu-bridge-helper binary, and more generated versions of the linuxboot, multiboot and kvmvapic roms from pc-bios/optionrom. Signed-off-by: David Gibson Signed-off-by: Stefan Hajnoczi --- .gitignore |

Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function

2012-03-19 Thread Stefan Weil
Am 19.03.2012 13:43, schrieb Andreas Färber: Am 19.03.2012 13:31, schrieb Stefan Weil: Am 19.03.2012 13:17, schrieb Stefan Hajnoczi: On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber wrote: Am 17.03.2012 13:00, schrieb Stefan Weil: Function set_HILO is not needed anywhere. Does this cause a

Re: [Qemu-devel] [PATCH V8 RESEND 4/8] pci.c: Add pci_check_bar_overlap

2012-03-19 Thread Michael S. Tsirkin
On Fri, Mar 16, 2012 at 04:54:18PM +, Anthony PERARD wrote: > From: Yuji Shimada > > This function helps Xen PCI Passthrough device to check for overlap. > > Signed-off-by: Yuji Shimada > Signed-off-by: Anthony PERARD It seems that what's called for here really is using the new memory reg

Re: [Qemu-devel] [PATCH 5/6] prep: add pc87312 Super I/O emulation

2012-03-19 Thread Andreas Färber
Am 17.03.2012 15:39, schrieb Hervé Poussineau: > This provides floppy and IDE controllers as well as serial and parallel ports. > However, dynamic configuration of devices is not yet supported. > > Cc: Andreas Färber > Signed-off-by: Hervé Poussineau > --- > Makefile.objs |1 + > hw/pc87312

Re: [Qemu-devel] [PATCH v2 2/2] memory: print aliased IO ranges in info mtree

2012-03-19 Thread Avi Kivity
On 03/18/2012 02:05 PM, Blue Swirl wrote: > Print also I/O ports behind bridges and other aliases. > Thanks, both applied. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory

2012-03-19 Thread Luiz Capitulino
On Mon, 19 Mar 2012 10:28:17 +0800 Wen Congyang wrote: > > 'dump' is too generic, please call this dump-guest-memory-vmcore or > > something > > more descriptive. > > Hmm, dump-guest-memory-vmcore is too long. What about dump-guest-memory or > dump-memory? dump-guest-memory is acceptable, but

Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.

2012-03-19 Thread Richard Henderson
On 03/19/12 04:01, Andreas Färber wrote: > Am 17.03.2012 20:30, schrieb Richard Henderson: >> Ping. > > This is linux-user, so cc'ing Riku. > > Code looks sane at first sight although I have no clue of the constants' > meaning and effect. ;) > > Commit message doesn't mention it but I guess this

[Qemu-devel] [PULL 0/7] spice patch queue

2012-03-19 Thread Gerd Hoffmann
Hi, This patch series brings tracing support for qxl and a bunch of bugfixes, most notably the one for the recent spice initialization breakage. please pull, Gerd The following changes since commit 5bd33de6635577744b3c10dd3913bfe8c5ffaf40: tcg: fix sparc host for AREG0 free operation (2

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Lee Essen
On 19 Mar 2012, at 12:32, Andreas Färber wrote: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> I'm going to spend some time today reviewing recent tracing patches. >>> I'd prefer to move to a Python version of tracetool rather than worry >>> a

[Qemu-devel] [PULL 0/2] update seabios to 1.6.3.2

2012-03-19 Thread Gerd Hoffmann
Hi, Second try, no changes, just rebased and this time including the tree to pull from in the cover letter ... cheers, Gerd The following changes since commit 5bd33de6635577744b3c10dd3913bfe8c5ffaf40: tcg: fix sparc host for AREG0 free operation (2012-03-18 19:15:32 +) are available

[Qemu-devel] [PATCH 2/2] Update seabios to 1.6.3.2

2012-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/bios.bin | Bin 131072 -> 131072 bytes roms/seabios |2 +- 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pc-bios/bios.bin b/pc-bios/bios.bin index 41e2b38ea24e009baa58739ead6eaecb8dbe6611..e1f3923681492bbd6a005924f5becf2f948d61e0

[Qemu-devel] [PATCH 1/2] Add seabios build scripts to roms/

2012-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile | 10 ++ roms/config.seabios |1 + roms/configure-seabios.sh |5 + 3 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 roms/Makefile create mode 100644 roms/config.seabios create mode 100755

[Qemu-devel] [PATCH 7/7] spice: fix broken initialization

2012-03-19 Thread Gerd Hoffmann
From: Alon Levy Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to way before MODULE_INIT_MACHINE, thereby breaking assumptions made in spice-core.c which registered both a type initializer and a machine intializer. This fix removes the type registration, and replaces it wi

Re: [Qemu-devel] [PATCH 1/2] Add seabios build scripts to roms/

2012-03-19 Thread Peter Maydell
On 19 March 2012 13:37, Gerd Hoffmann wrote: > +default: > +       @echo "nothing is build by default" A very trivial nit, but this should say "built"... -- PMM

[Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-19 Thread Zhang, Yang Z
Changes in v4: Rebase to latest head. Changing in patch 6: Set the timer to one second earlier before target alarm when AF bit is clear. In version 3, in order to solve the async between UF, AF and UIP, the timer will keep running when UF or AF are clear. This is a little ugly, especial

[Qemu-devel] [PATCH v4 3/7] RTC: Add UIP(update in progress) check logic

2012-03-19 Thread Zhang, Yang Z
The UIP(update in progress) is set when RTC is updating. And the update cycle begins 244us later after UIP is set. And it is cleared when update end. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/mc14

[Qemu-devel] [PATCH v4 4/7] RTC: Set internal millisecond register to 500ms when reset divider

2012-03-19 Thread Zhang, Yang Z
The first update cycle begins one - half seconds later when divider reset is removing. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 38 +- 1 files changed, 33 insertions(+), 5 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 6ebb8f6.

[Qemu-devel] [PATCH v4 6/7] RTC:Add alarm support

2012-03-19 Thread Zhang, Yang Z
Changing in this patch: Set the timer to one second earlier before target alarm when AF bit is clear. In version 3, in order to solve the async between UF, AF and UIP, the timer will keep running when UF or AF are clear. This is a little ugly, especially when a userspace program is usin

Re: [Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()?

2012-03-19 Thread Max Filippov
> void HELPER(wsr_ibreaka)(uint32_t i, uint32_t v) > { >    if (env->sregs[IBREAKENABLE] & (1 << i) && env->sregs[IBREAKA + i] > != v) { >        tb_invalidate_phys_page_range( >                env->sregs[IBREAKA + i], env->sregs[IBREAKA + i] + 1, 0); >        tb_invalidate_phys_page_range(v, v + 1

  1   2   3   4   >