Am 19.03.2012 13:40, schrieb Stefan Weil: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen >>> <lee.es...@nowonline.co.uk> wrote: >>>> Signed-off-by: Lee Essen <lee.es...@nowonline.co.uk> >>>> >>>> --- >>>> >>>> scripts/tracetool | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> I'm going to spend some time today reviewing recent tracing patches. >>> I'd prefer to move to a Python version of tracetool rather than worry >>> about the shell quirks across all host platforms. >>> >>> If the Python rewrite cannot be merged for 1.1 then it makes sense to >>> go with shell portability fix. >> >> Hi Stefan, >> >> While you are looking at this, there are a couple of other related >> issues worth having in the back of your mind: >> >> 1. "self" is a reserved word in Solaris/Illumos trace, and it's used >> in a few trace calls. >> 2. "bool" isn't recognised by default, again used in a couple of >> traces ... could be fixed by typedef, but switching to int is >> probably better (imho) > > No. The correct solution is including stdbool.h which is provided by the > compiler (gcc) and which defines bool and its values false and true. AFAIU the issue is not with C code but with D code:
http://docs.oracle.com/cd/E19253-01/817-6223/chp-typeopexpr-2/index.html Andreas > > > More boolean variables should use bool instead of int, because that > improves > readability of the code and saves memory in structures. > > Regards, > Stefan W. >
