From: Stefan Weil <s...@weilnetz.de> Without the break statement, case 5 sets month and year from the same data. This does not look correct.
The missing break was reported by splint. Signed-off-by: Stefan Weil <s...@weilnetz.de> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Andreas Färber <afaer...@suse.de> Signed-off-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> --- hw/ds1338.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index 6397f0a..d590d9c 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -100,6 +100,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data) break; case 5: s->now.tm_mon = from_bcd(data & 0x1f) - 1; + break; case 6: s->now.tm_year = from_bcd(data) + 100; break; -- 1.7.9.1