On Sat, Mar 17, 2012 at 05:24:08PM +0000, Peter Maydell wrote: > On 17 March 2012 15:59, Stefan Weil <s...@weilnetz.de> wrote: > > Am 17.03.2012 16:49, schrieb Peter Maydell: > >> Where do we symlink directories? (I exclude the setting up > >> of the linux headers because that will only happen on Linux > >> hosts where we know we have working symlinks.) > > > pc-bios/keymaps > > Oh yes, missed that one (since it's a directory name cunningly > hidden in a variable named FILES :-)). > > I'm just a little wary of 'rm -rf', especially here where > we're nuking whatever was passed as an argument and we > aren't getting the shell quoting right. In theory we could > use a wildcard for the keymaps the same way we do for a > bunch of the other pc-bios files; I'm not sure if it's worth > the effort, though.
Yes, I'm not comfortable with the 'rm -rf' either. Please use "$2" so that the path is at least quoted. Stefan
