Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-18 Thread Paolo Bonzini
On 09/18/2011 07:49 AM, Stefan Weil wrote: Is there really any difference in the generated code? gcc already uses a jump table internally to handle the switch cases. You typically save something on range checks, and it enables a lot more tricks for use later (e.g. using multiple jump tables to

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-18 Thread Paolo Bonzini
On 09/17/2011 09:08 PM, Laurent Vivier wrote: > The NBD protocol supports multiple named exports, just not QEMU's > implementation. Named exports are supported since commit 1d45f8b542f6b80b24c44533ef0dd9e1a3b17ea5 Yes, not in the qemu-nbd server though. Paolo

Re: [Qemu-devel] windows XP fail to enter standby mode

2011-09-18 Thread Alon Levy
On Fri, Sep 16, 2011 at 02:28:05PM +0800, hkran wrote: > On 09/15/2011 06:42 PM, Alon Levy wrote: > >On Thu, Sep 15, 2011 at 05:23:01PM +0800, hkran wrote: > >>Hi, > >> > >>If I select to let my guest XP enter standby mode by clicking the button > >>manually. qemu will exit with the following messa

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-18 Thread Avi Kivity
On 09/15/2011 11:52 PM, Anthony Liguori wrote: Also, NE2000 methods have to call ISA_NE2000 and PCI_NE2000 methods, yes? I don't think so. The NE2k would export an IRQ and the ISA_NE2K and PCI_NE2k would have to route that IRQ. But I think that's the extent of the communication in that dir

Re: [Qemu-devel] [PATCH] spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993

2011-09-18 Thread Alon Levy
On Mon, Sep 05, 2011 at 05:39:50PM +0300, Yonit Halperin wrote: > If qxl->ssd.running=true is set after telling spice to start, the spice server > thread can call qxl_send_events while qxl->ssd.running is still false. This > leads to > assert(d->ssd.running). > Looks good. Acked-by: Alon Levy

[Qemu-devel] [PATCH 0/4] Set of patches for chrooted environment

2011-09-18 Thread Laurent Vivier
This set of patches helps to use qemu-linux-user in a chrooted environment. It mostly allows to define the default cpu model as we can't use '-cpu' argument. The last one defines enviromnent variables to be able to use log file and gdb server ('-d' and '-g' arguments). [PATCH 1/4] linux-user:

[Qemu-devel] [PATCH 2/4] linux-user: specify the cpu model during configure

2011-09-18 Thread Laurent Vivier
From: Laurent Vivier This patch allows to set the default cpu model for a given architecture, for instance: configure --target-list=m68k-linux-user --m68k-default-cpu=m68040 Signed-off-by: Laurent Vivier --- configure |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff -

Re: [Qemu-devel] [PATCH 7/8] tcg: Add tcg interpreter to configure / make

2011-09-18 Thread Blue Swirl
On Sat, Sep 17, 2011 at 8:00 PM, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- >  Makefile.target |    1 + >  configure       |   30 -- >  2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/Makefile.target b/Makefile.target > index 88d2f1f..a2c3

[Qemu-devel] [PATCH 3/4] linux-user,m68k: display default cpu

2011-09-18 Thread Laurent Vivier
From: Laurent Vivier Signed-off-by: Laurent Vivier --- target-m68k/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index 674c8e6..ede5180 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -57,6 +57,1

[Qemu-devel] [PATCH 1/4] linux-user: define default cpu model in configure instead of linux-user/main.c

2011-09-18 Thread Laurent Vivier
From: Laurent Vivier Signed-off-by: Laurent Vivier --- configure | 14 ++ linux-user/main.c | 34 +- 2 files changed, 15 insertions(+), 33 deletions(-) diff --git a/configure b/configure index ad924c4..5e10055 100755 --- a/configure +++ b

[Qemu-devel] [PATCH 4/4] linux-user: define new environment variables

2011-09-18 Thread Laurent Vivier
From: Laurent Vivier QEMU_GDB=port allows to define gdb server port to wait on. QEMU_DEBUG=options allows to activate log file (like -d options) Signed-off-by: Laurent Vivier --- linux-user/main.c | 14 +++--- qemu-doc.texi |4 2 files changed, 15 insertions(+), 3 deleti

Re: [Qemu-devel] [PATCH 7/8] tcg: Add tcg interpreter to configure / make

2011-09-18 Thread Stefan Weil
Am 18.09.2011 11:37, schrieb Blue Swirl: On Sat, Sep 17, 2011 at 8:00 PM, Stefan Weil wrote: Signed-off-by: Stefan Weil --- Makefile.target |1 + configure | 30 -- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefi

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Blue Swirl
On Sat, Sep 17, 2011 at 7:59 PM, Stefan Weil wrote: > Hello, > > these patches add a new code generator (TCG target) to qemu. > > Unlike other tcg target code generators, this one does not generate > machine code for some cpu. It generates machine independent bytecode > which is interpreted later.

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread malc
On Sun, 18 Sep 2011, Blue Swirl wrote: > On Sat, Sep 17, 2011 at 7:59 PM, Stefan Weil wrote: > > Hello, > > > > these patches add a new code generator (TCG target) to qemu. > > > > Unlike other tcg target code generators, this one does not generate > > machine code for some cpu. It generates mach

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-18 Thread Avi Kivity
On 09/18/2011 12:40 AM, Blue Swirl wrote: On Thu, Sep 15, 2011 at 11:31 AM, Avi Kivity wrote: > On 09/15/2011 01:01 PM, Benjamin Herrenschmidt wrote: >> >> >Sure :). So the problem is that when emulating the G3 Beige machine in >> >QEMU (default ppc32 target) we also add a PCI VGA ada

Re: [Qemu-devel] [PATCH] sun4u: don't set up isa_mem_base

2011-09-18 Thread Avi Kivity
On 09/17/2011 10:28 PM, Blue Swirl wrote: Since we use memory API in sun4u.c, after 71579cae30b53c910cd6c47ab4e683f647d36519, setting up isa_mem_base puts vga.chain4 outside of the physical address space. Fix by removing obsolete isa_mem_base set up. Signed-off-by: Blue Swirl --- hw/sun4u.c |

Re: [Qemu-devel] [PATCH] memory: fix subregion collision warning

2011-09-18 Thread Avi Kivity
On 09/16/2011 12:16 AM, Michael Walle wrote: Instead of the offset property use the proper addr property to calculate the offsets. Additionally, be a little more verbose on the warning and print the subregion name. Thanks, applied to memory/core. -- error compiling committee.c: too many arg

Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization

2011-09-18 Thread Avi Kivity
On 09/14/2011 11:52 PM, Edgar E. Iglesias wrote: On Wed, Sep 14, 2011 at 11:17:54PM +0300, Avi Kivity wrote: > On 09/14/2011 07:19 PM, Andreas Färber wrote: > >> > >> Can this please be reviewed? It's in the front of the memory queue > >> logjam. > > > >With or without this patch, the

Re: [Qemu-devel] [PATCH] sun4u: don't set up isa_mem_base

2011-09-18 Thread Blue Swirl
On Sun, Sep 18, 2011 at 11:30 AM, Avi Kivity wrote: > On 09/17/2011 10:28 PM, Blue Swirl wrote: >> >> Since we use memory API in sun4u.c, after >> 71579cae30b53c910cd6c47ab4e683f647d36519, setting up isa_mem_base >> puts vga.chain4 outside of the physical address space. >> >> Fix by removing obsol

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Blue Swirl
On Sun, Sep 18, 2011 at 10:49 AM, malc wrote: > On Sun, 18 Sep 2011, Blue Swirl wrote: > >> On Sat, Sep 17, 2011 at 7:59 PM, Stefan Weil wrote: >> > Hello, >> > >> > these patches add a new code generator (TCG target) to qemu. >> > >> > Unlike other tcg target code generators, this one does not g

[Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Jan Kiszka
From: Jan Kiszka As we register old portio regions via ioport_register, we are also responsible for providing the word access wrapper. Signed-off-by: Jan Kiszka --- memory.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/memory.c b/memory.c index b3ee232..f7

[Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Jan Kiszka
From: Jan Kiszka Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. Signed-off-by: Jan Kiszka --- This and the previous patch unbreaks VGA over memory/master. hw/vga.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/vga.c b/hw/vga.c ind

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread malc
On Sun, 18 Sep 2011, Blue Swirl wrote: > On Sun, Sep 18, 2011 at 10:49 AM, malc wrote: > > On Sun, 18 Sep 2011, Blue Swirl wrote: > > > >> On Sat, Sep 17, 2011 at 7:59 PM, Stefan Weil wrote: > >> > Hello, > >> > > >> > these patches add a new code generator (TCG target) to qemu. > >> > > >> > Un

[Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Jan Kiszka
From: Jan Kiszka As we register old portio regions via ioport_register, we are also responsible for providing the word access wrapper. Signed-off-by: Jan Kiszka --- Oops, was lacking a shift for word reads. memory.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff -

[Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Jan Kiszka
From: Jan Kiszka We can express the offset of old portio completely via MemoryRegionPortio::offset by splitting up regions of different offsets and adjusting those offsets appropriately. Signed-off-by: Jan Kiszka --- Will write a patch to remove MemoryRegion::offset now. hw/isa-bus.c | 28

Re: [Qemu-devel] [PATCH v2] memory: simple memory tree printer

2011-09-18 Thread Jan Kiszka
On 2011-09-17 21:27, Blue Swirl wrote: > Add a monitor command 'info mtree' to show the memory hierarchy > much like /proc/iomem in Linux. > > Signed-off-by: Blue Swirl > --- > v1->v2: use /proc/iomem format. > --- > memory.c | 27 +++ > memory.h |2 ++ > monitor.

[Qemu-devel] [PATCH] irq: introduce qemu_irq_proxy()

2011-09-18 Thread Avi Kivity
In some cases we have a circular dependency involving irqs - the irq controller depends on a bus, which in turn depends on the irq controller. Add qemu_irq_proxy() which acts as a passthrough, except that the target irq may be set later on. Signed-off-by: Avi Kivity --- Turns out the circular de

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Blue Swirl
On Sun, Sep 18, 2011 at 12:46 PM, malc wrote: > On Sun, 18 Sep 2011, Blue Swirl wrote: > >> On Sun, Sep 18, 2011 at 10:49 AM, malc wrote: >> > On Sun, 18 Sep 2011, Blue Swirl wrote: >> > >> >> On Sat, Sep 17, 2011 at 7:59 PM, Stefan Weil wrote: >> >> > Hello, >> >> > >> >> > these patches add a

[Qemu-devel] [PATCH] memory: Eliminate region offset

2011-09-18 Thread Jan Kiszka
From: Jan Kiszka Before anything makes use of this legacy mechanism again, remove it. This will enforce proper conversion of device models while they are ported over the memory API. Signed-off-by: Jan Kiszka --- memory.c | 14 -- memory.h |9 - 2 files changed, 4 inse

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread malc
On Sun, 18 Sep 2011, Blue Swirl wrote: > On Sun, Sep 18, 2011 at 12:46 PM, malc wrote: > > On Sun, 18 Sep 2011, Blue Swirl wrote: > > [..snip..] > > "All the files in this directory and subdirectories are released under > a BSD like license (see header in each file). No other license is > acce

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Blue Swirl
On Sun, Sep 18, 2011 at 1:13 PM, malc wrote: > On Sun, 18 Sep 2011, Blue Swirl wrote: > >> On Sun, Sep 18, 2011 at 12:46 PM, malc wrote: >> > On Sun, 18 Sep 2011, Blue Swirl wrote: >> > > > [..snip..] > >> >> "All the files in this directory and subdirectories are released under >> a BSD like lic

Re: [Qemu-devel] [PATCH] irq: introduce qemu_irq_proxy()

2011-09-18 Thread Avi Kivity
On 09/18/2011 03:58 PM, Avi Kivity wrote: In some cases we have a circular dependency involving irqs - the irq controller depends on a bus, which in turn depends on the irq controller. Add qemu_irq_proxy() which acts as a passthrough, except that the target irq may be set later on. Signed-off-by

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 08/24/2011 03:13 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson Breaks qemu-system-ppc -M mac99 +/* Used by both ISA and PCI */ MemoryRegion *vga_init_io(VGACommonState *s) { MemoryRegion *vga_mem; -register_ioport_write(0x3c0, 16, 1, vga_ioport_write, s); - -

Re: [Qemu-devel] [PATCH v2] memory: simple memory tree printer

2011-09-18 Thread Avi Kivity
On 09/17/2011 10:27 PM, Blue Swirl wrote: Add a monitor command 'info mtree' to show the memory hierarchy much like /proc/iomem in Linux. Still missing alias support. PCI would be invisible on a PC (or any machine which has PCI holes implemented properly). Maybe we need to dump both the m

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-18 Thread Avi Kivity
On 09/18/2011 10:56 AM, Avi Kivity wrote: On 09/15/2011 11:52 PM, Anthony Liguori wrote: Also, NE2000 methods have to call ISA_NE2000 and PCI_NE2000 methods, yes? I don't think so. The NE2k would export an IRQ and the ISA_NE2K and PCI_NE2k would have to route that IRQ. But I think that's t

Re: [Qemu-devel] [PATCH v2] memory: simple memory tree printer

2011-09-18 Thread Blue Swirl
On Sun, Sep 18, 2011 at 1:53 PM, Avi Kivity wrote: > On 09/17/2011 10:27 PM, Blue Swirl wrote: >> >> Add a monitor command 'info mtree' to show the memory hierarchy >> much like /proc/iomem in Linux. >> >> > > Still missing alias support.  PCI would be invisible on a PC (or any machine > which has

[Qemu-devel] [PATCH 00/13] Memory API conversion, batch 8

2011-09-18 Thread Avi Kivity
Batch 7 has some issues due to the ISA conversion, so I reordered some patches and am posting this for your review and testing. It should be straightforward but this stuff never is. Also available on git://github.com/avikivity/qemu.git memory/batch Avi Kivity (13): mips_jazz: convert to memory

[Qemu-devel] [PATCH 02/13] mips_malta: convert to memory API

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_malta.c | 53 ++--- 1 files changed, 26 insertions(+), 27 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index e7cdf20..0110daa 100644 --- a/hw/mips_malta.c +++ b/hw/mips_malta.c @@ -57,6 +57,9 @

[Qemu-devel] [PATCH 11/13] omap_lcdc: remove imif, emiff from structure

2011-09-18 Thread Avi Kivity
Not used. Signed-off-by: Avi Kivity --- hw/omap.h |3 +-- hw/omap1.c |3 +-- hw/omap_lcdc.c |7 +-- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index 25d10f3..de83452 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -744,8 +744,7 @@ voi

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Richard Henderson
On 09/18/2011 06:45 AM, Avi Kivity wrote: >> +/* The PCI-ISA bridge should have been configured properly such that >> + this works for PCI devices as well. This only supports one bridge, >> + but "secondary" VGA cards are generally accessed by MMIO only >> anyway. */ >> +isa_

Re: [Qemu-devel] [PATCH] irq: introduce qemu_irq_proxy()

2011-09-18 Thread Richard Henderson
On 09/18/2011 05:58 AM, Avi Kivity wrote: > In some cases we have a circular dependency involving irqs - the irq > controller depends on a bus, which in turn depends on the irq controller. > Add qemu_irq_proxy() which acts as a passthrough, except that the target > irq may be set later on. > > Sig

Re: [Qemu-devel] [PATCH v2] memory: simple memory tree printer

2011-09-18 Thread Avi Kivity
On 09/18/2011 05:07 PM, Blue Swirl wrote: On Sun, Sep 18, 2011 at 1:53 PM, Avi Kivity wrote: > On 09/17/2011 10:27 PM, Blue Swirl wrote: >> >> Add a monitor command 'info mtree' to show the memory hierarchy >> much like /proc/iomem in Linux. >> >> > > Still missing alias support. PCI would

[Qemu-devel] [PATCH] adlib: remove write-only variable

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/adlib.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/adlib.c b/hw/adlib.c index d98aebc..66db797 100644 --- a/hw/adlib.c +++ b/hw/adlib.c @@ -119,7 +119,6 @@ static IO_WRITE_PROTO (adlib_write) { AdlibState *s = opaq

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 09/18/2011 05:16 PM, Richard Henderson wrote: On 09/18/2011 06:45 AM, Avi Kivity wrote: >> +/* The PCI-ISA bridge should have been configured properly such that >> + this works for PCI devices as well. This only supports one bridge, >> + but "secondary" VGA cards are genera

Re: [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Richard Henderson
On 09/18/2011 05:44 AM, Jan Kiszka wrote: > +*data = mrp->read(mr->opaque, offset + mr->offset) | > +mrp->read(mr->opaque, offset + mr->offset + 1); Missing shift. Also, a comment about the fact that the legacy interface doesn't handle size 4 would also be welcome.

[Qemu-devel] [PATCH 01/13] mips_jazz: convert to memory API

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_jazz.c | 90 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index f3c9f93..7cac5da 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c @@ -52,44 +52,42 @

[Qemu-devel] [PATCH 00/11] ISA bus improvements

2011-09-18 Thread Hervé Poussineau
Following patches aim to change ISA bus to a first-citizen class in Qemu. They add ISA bus ops, like for scsi and usb buses. Current ISA bridges (PIIX3, PIIX4, EBUS and VT82C686) are converted to this new API, and a simple 'isabus-bridge' device is added. isa_address_space() operation can probab

[Qemu-devel] [PATCH 01/11] isa: rename isa_bus_new to isa_bus_bridge_init

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c |2 +- hw/isa.h |2 +- hw/mips_jazz.c |2 +- hw/mips_r4k.c |2 +- hw/pc_piix.c |2 +- hw/piix4.c |2 +- hw/piix_pci.c |2 +- hw/ppc_prep.c |2 +- hw/sun4u.c |2 +- hw/vt82c686.c |2 +-

[Qemu-devel] [PATCH 02/11] isa: rework ISA bus internals, and add ISA bus ops structure

2011-09-18 Thread Hervé Poussineau
This allows future implementations of real pci-isa bridges Signed-off-by: Hervé Poussineau --- Makefile.objs |2 +- hw/isa-bridge.c | 71 +++ hw/isa-bus.c| 69 ++--- hw/isa.h

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 09/18/2011 05:27 PM, Avi Kivity wrote: On 09/18/2011 05:16 PM, Richard Henderson wrote: On 09/18/2011 06:45 AM, Avi Kivity wrote: >> +/* The PCI-ISA bridge should have been configured properly such that >> + this works for PCI devices as well. This only supports one bridge, >>

[Qemu-devel] [PATCH 05/13] musicpal: convert to memory API

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/musicpal.c | 243 +++-- 1 files changed, 99 insertions(+), 144 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index ade5a91..9b1f380 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -19,6 +19,7 @@ #i

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Mulyadi Santosa
Hi :) On Sun, Sep 18, 2011 at 02:59, Stefan Weil wrote: > Hello, > > these patches add a new code generator (TCG target) to qemu. I personally congrats you for your hard work. So, here's a question from who are not so keen with Qemu internals: what is the biggest advantage of using TCI instead o

[Qemu-devel] [PATCH 05/11] pc: improve bus implementation of PIIX3 bridge

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pc.h |2 +- hw/pc_piix.c |3 ++- hw/piix_pci.c | 38 +- 3 files changed, 36 insertions(+), 7 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index c3e85e9..5489039 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -181,

[Qemu-devel] [PATCH 04/11] audio: give ISA bus to sound cards, instead of PIC

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- arch_init.c| 10 +- arch_init.h|2 +- hw/adlib.c |2 +- hw/audiodev.h |8 hw/cs4231a.c |2 +- hw/gus.c |2 +- hw/mips_jazz.c |5 +++-- hw/pc.h|2 +- hw/pc_piix.c |4 ++-- hw/pcsp

[Qemu-devel] [PATCH 03/11] isa: implement isa_address_space() as a method of ISA bus

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bridge.c |6 ++ hw/isa-bus.c| 11 ++- hw/isa.h|1 + 3 files changed, 17 insertions(+), 1 deletions(-) diff --git a/hw/isa-bridge.c b/hw/isa-bridge.c index 49fa033..bb2d8b0 100644 --- a/hw/isa-bridge.c +++ b/hw/isa-brid

[Qemu-devel] [PATCH 08/11] malta: improve bus implementation of PIIX4 bridge

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips_malta.c |3 +-- hw/pc.h |2 +- hw/piix4.c | 23 +-- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index e7cdf20..65e5915 100644 --- a/hw/mips_malta.c +++ b/h

[Qemu-devel] [PATCH 08/13] omap1: convert to memory API (part III)

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/omap.h |8 ++- hw/omap1.c | 209 +-- 2 files changed, 123 insertions(+), 94 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index cb3b524..059b48f 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -692,7 +692,

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Stefan Weil
Am 18.09.2011 17:02, schrieb Mulyadi Santosa: Hi :) On Sun, Sep 18, 2011 at 02:59, Stefan Weil wrote: Hello, these patches add a new code generator (TCG target) to qemu. I personally congrats you for your hard work. So, here's a question from who are not so keen with Qemu internals: what is

[Qemu-devel] [PATCH 13/13] omap1: convert to memory API (part VI)

2011-09-18 Thread Avi Kivity
Easy RAM stuff. Signed-off-by: Avi Kivity --- hw/omap.h|2 ++ hw/omap1.c | 17 +++-- hw/soc_dma.h |2 ++ 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index de83452..0260cc0 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -841,6 +841

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Richard Henderson
On 09/18/2011 07:56 AM, Avi Kivity wrote: > It's also wrong for cirrus. Even though it is a legacy address, it's > not an ISA address, it's on the PCI bus (though not mapped by a BAR). Huh? How do define that as not an ISA address? Especially since all that's called from isa_cirrus_vga_init? r

[Qemu-devel] [PATCH 09/13] omap1: convert to memory API (part IV)

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/omap.h |1 + hw/omap1.c | 81 ++- 2 files changed, 48 insertions(+), 34 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index 059b48f..25d10f3 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -841,6 +841,7 @

[Qemu-devel] [PATCH 04/13] mips_r4k: convert to memory API

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_r4k.c | 39 +++ 1 files changed, 15 insertions(+), 24 deletions(-) diff --git a/hw/mips_r4k.c b/hw/mips_r4k.c index 5d002c5..805d02a 100644 --- a/hw/mips_r4k.c +++ b/hw/mips_r4k.c @@ -42,8 +42,8 @@ const char *initr

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 09/18/2011 06:15 PM, Richard Henderson wrote: On 09/18/2011 07:56 AM, Avi Kivity wrote: > It's also wrong for cirrus. Even though it is a legacy address, it's > not an ISA address, it's on the PCI bus (though not mapped by a BAR). Huh? How do define that as not an ISA address? Especially

[Qemu-devel] [PATCH 10/13] omap1: convert to memory API (part V)

2011-09-18 Thread Avi Kivity
Tricky aliases. Signed-off-by: Avi Kivity --- hw/omap1.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/omap1.c b/hw/omap1.c index df5d68b..f48aa8a 100644 --- a/hw/omap1.c +++ b/hw/omap1.c @@ -3708,14 +3708,16 @@ static void omap1_mpu_reset(void *opaque)

[Qemu-devel] [PATCH 09/11] isa: remove unused parameter to isa_bus_bridge_init()

2011-09-18 Thread Hervé Poussineau
Remove code which is now dead Signed-off-by: Hervé Poussineau --- hw/isa-bus.c | 43 +-- hw/isa.h |2 +- hw/mips_jazz.c |2 +- hw/mips_r4k.c |2 +- hw/pc_piix.c |2 +- hw/ppc_prep.c |2 +- 6 files changed, 10 insertions(+)

[Qemu-devel] [PATCH 11/11] isa: remove limitation of only one ISA bus

2011-09-18 Thread Hervé Poussineau
Default ISA bus will be the first created Signed-off-by: Hervé Poussineau --- hw/isa-bus.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index b697f65..9e668ef 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -45,12 +45,11 @@ ISABus *is

[Qemu-devel] [PATCH 07/11] sun4u: improve bus implementation of EBus bridge

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/sun4u.c | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index cdd9497..211a9bd 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -93,6 +93,8 @@ struct hwdef { typedef struct EbusState {

[Qemu-devel] [PATCH 06/13] omap1: convert to memory API (part I)

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/omap.h | 11 ++- hw/omap1.c| 338 +++- hw/omap_sx1.c |4 +- hw/palm.c |4 +- 4 files changed, 203 insertions(+), 154 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index d9ab006..eec8f04

[Qemu-devel] [PATCH 06/11] fulong2e: move pic initialization + ISA bus creation to south bridge

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips_fulong2e.c |9 ++--- hw/vt82c686.c | 24 ++-- hw/vt82c686.h |2 +- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index f52b8c5..3034a9c 100644 --- a/

[Qemu-devel] [PATCH 12/13] soc_dma: drop soc_dma_port_add_mem_ram()

2011-09-18 Thread Avi Kivity
It's a trivial wrapper for soc_dma_port_add_mem(), which makes the memory API conversion more difficult because it takes a ram addr_t. Drop. Signed-off-by: Avi Kivity --- hw/omap1.c |8 hw/omap2.c |6 -- hw/soc_dma.h |6 -- 3 files changed, 8 insertions(+), 12 d

[Qemu-devel] [PATCH 03/13] mips_mipssim: convert to memory API

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/mips_mipssim.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c index ac6..7407158 100644 --- a/hw/mips_mipssim.c +++ b/hw/mips_mipssim.c @@ -137,8 +137,9 @@ static void mipsnet_init(i

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Avi Kivity
On 09/18/2011 03:51 PM, Jan Kiszka wrote: From: Jan Kiszka As we register old portio regions via ioport_register, we are also responsible for providing the word access wrapper. Signed-off-by: Jan Kiszka --- Oops, was lacking a shift for word reads. memory.c | 10 ++ 1 files chang

[Qemu-devel] [PATCH 10/11] isa: give bus to isa_create() methods

2011-09-18 Thread Hervé Poussineau
This allows to create a device on requested ISA bus. If argument is not provided, 'default' ISA bus is used. Signed-off-by: Hervé Poussineau --- hw/cs4231a.c |2 +- hw/fdc.h |2 +- hw/gus.c |2 +- hw/ide/isa.c |2 +- hw/isa-bus.c | 30 +

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Jan Kiszka
On 2011-09-18 17:37, Avi Kivity wrote: > On 09/18/2011 03:51 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> As we register old portio regions via ioport_register, we are also >> responsible for providing the word access wrapper. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Oops, was lacking a shif

[Qemu-devel] [PATCH 07/13] omap1: convert to memory API (part II)

2011-09-18 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/omap.h |7 ++- hw/omap1.c | 195 2 files changed, 111 insertions(+), 91 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index eec8f04..cb3b524 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -678,7 +678

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Avi Kivity
On 09/18/2011 06:43 PM, Jan Kiszka wrote: On 2011-09-18 17:37, Avi Kivity wrote: > On 09/18/2011 03:51 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> As we register old portio regions via ioport_register, we are also >> responsible for providing the word access wrapper. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Avi Kivity
On 09/18/2011 03:44 PM, Jan Kiszka wrote: From: Jan Kiszka Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. Signed-off-by: Jan Kiszka --- #ifdef CONFIG_BOCHS_VBE static const MemoryRegionPortio vbe_portio_list[] = { -# ifdef TARGET_I386 { 0, 1, 2, .read = vbe_io

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Avi Kivity
On 09/18/2011 03:54 PM, Jan Kiszka wrote: From: Jan Kiszka We can express the offset of old portio completely via MemoryRegionPortio::offset by splitting up regions of different offsets and adjusting those offsets appropriately. Please split into two patches - core and isa. +/* Copy the

[Qemu-devel] [PATCH] isapc: give system address space when pci is disabled

2011-09-18 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pc_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index da6fa55..c0b8a3a 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -121,7 +121,7 @@ static void pc_init1(MemoryRegion *system_memory,

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Jan Kiszka
On 2011-09-18 17:45, Avi Kivity wrote: > On 09/18/2011 06:43 PM, Jan Kiszka wrote: >> On 2011-09-18 17:37, Avi Kivity wrote: >> > On 09/18/2011 03:51 PM, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> >> >> As we register old portio regions via ioport_register, we are also >> >> responsible for

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Jan Kiszka
On 2011-09-18 17:51, Avi Kivity wrote: > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. >> >> Signed-off-by: Jan Kiszka >> --- >> >> #ifdef CONFIG_BOCHS_VBE >> static const MemoryRegionPortio vbe_portio_

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Jan Kiszka
On 2011-09-18 17:57, Avi Kivity wrote: > On 09/18/2011 03:54 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> We can express the offset of old portio completely via >> MemoryRegionPortio::offset by splitting up regions of different offsets >> and adjusting those offsets appropriately. > > Please sp

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Mulyadi Santosa
Hi Stefan... On Sun, Sep 18, 2011 at 22:13, Stefan Weil wrote: > Its primary purpose was support of new hosts without a native > TCG. Thanks for the explanation, I got better picture now. However, still, an interpreter must be ready to grab the bytecode and execute it, right? So, that interpret

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Avi Kivity
On 09/18/2011 07:29 PM, Jan Kiszka wrote: On 2011-09-18 17:57, Avi Kivity wrote: > On 09/18/2011 03:54 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> We can express the offset of old portio completely via >> MemoryRegionPortio::offset by splitting up regions of different offsets >> and adju

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Richard Henderson
On 09/18/2011 05:54 AM, Jan Kiszka wrote: > @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion > *mr, uint64_t offset, > const MemoryRegionPortio *mrp; > > for (mrp = mr->ops->old_portio; mrp->size; ++mrp) { > -if (offset >= mrp->offset && offset < mr

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Avi Kivity
On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> >> This is PIO, limited by the x86 address space to 16 bit. Will add a >> comment. > > x86 PIO is not limited to 16 bits, just ISA, which memory.c knows > nothing about. Confused address and data, the former is limited 16, the latter can be 32 as

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Avi Kivity
On 09/18/2011 07:28 PM, Jan Kiszka wrote: On 2011-09-18 17:51, Avi Kivity wrote: > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE ranges. >> >> Signed-off-by: Jan Kiszka >> --- >> >>#ifdef CONFIG_BOCHS_VB

Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

2011-09-18 Thread Avi Kivity
On 09/18/2011 10:22 AM, Paolo Bonzini wrote: On 09/18/2011 07:49 AM, Stefan Weil wrote: Is there really any difference in the generated code? gcc already uses a jump table internally to handle the switch cases. You typically save something on range checks, and it enables a lot more tricks for

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Avi Kivity
On 09/17/2011 10:59 PM, Stefan Weil wrote: Hello, these patches add a new code generator (TCG target) to qemu. Unlike other tcg target code generators, this one does not generate machine code for some cpu. It generates machine independent bytecode which is interpreted later. That's why I called

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Jan Kiszka
On 2011-09-18 18:46, Avi Kivity wrote: > On 09/18/2011 07:29 PM, Jan Kiszka wrote: >> On 2011-09-18 17:57, Avi Kivity wrote: >> > On 09/18/2011 03:54 PM, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> >> >> We can express the offset of old portio completely via >> >> MemoryRegionPortio::offset

Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses

2011-09-18 Thread Jan Kiszka
On 2011-09-18 18:49, Avi Kivity wrote: > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> >> >> >> This is PIO, limited by the x86 address space to 16 bit. Will add a >> >> comment. >> > >> > x86 PIO is not limited to 16 bits, just ISA, which memory.c knows >> > nothing about. >> >> Confused addres

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

2011-09-18 Thread Jan Kiszka
On 2011-09-18 18:51, Avi Kivity wrote: > On 09/18/2011 07:28 PM, Jan Kiszka wrote: >> On 2011-09-18 17:51, Avi Kivity wrote: >> > On 09/18/2011 03:44 PM, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> >> >> Fix copy&paste errors and reduce duplications of the BOCHS VBE >> ranges. >> >> >> >> Si

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

2011-09-18 Thread Jan Kiszka
On 2011-09-18 18:49, Richard Henderson wrote: > On 09/18/2011 05:54 AM, Jan Kiszka wrote: >> @@ -375,8 +375,7 @@ static const MemoryRegionPortio >> *find_portio(MemoryRegion *mr, uint64_t offset, >> const MemoryRegionPortio *mrp; >> >> for (mrp = mr->ops->old_portio; mrp->size; ++mrp)

Re: [Qemu-devel] [PATCH 00/11] ISA bus improvements

2011-09-18 Thread Jan Kiszka
On 2011-09-18 16:56, Hervé Poussineau wrote: > Following patches aim to change ISA bus to a first-citizen class in Qemu. > > They add ISA bus ops, like for scsi and usb buses. > > Current ISA bridges (PIIX3, PIIX4, EBUS and VT82C686) are converted > to this new API, and a simple 'isabus-bridge' d

Re: [Qemu-devel] [PATCH 00/11] ISA bus improvements

2011-09-18 Thread Hervé Poussineau
Jan Kiszka a écrit : On 2011-09-18 16:56, Hervé Poussineau wrote: Following patches aim to change ISA bus to a first-citizen class in Qemu. They add ISA bus ops, like for scsi and usb buses. Current ISA bridges (PIIX3, PIIX4, EBUS and VT82C686) are converted to this new API, and a simple 'isab

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-18 Thread Juan Quintela
malc wrote: > On Fri, 16 Sep 2011, Anthony Liguori wrote: > >> Reviewed-by: Anthony Liguori >> >> malc, please Ack. >> > > I don't like the commit message. Can you be more specific? Can you say what you will preffer? >> On 09/13/2011 07:52 AM, Juan Quintela wrote: >> > Hi >> > >> > QEMUFil

Re: [Qemu-devel] [PATCH 0/8] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2011-09-18 Thread Stefan Weil
Am 18.09.2011 18:39, schrieb Mulyadi Santosa: Hi Stefan... On Sun, Sep 18, 2011 at 22:13, Stefan Weil wrote: Its primary purpose was support of new hosts without a native TCG. Thanks for the explanation, I got better picture now. However, still, an interpreter must be ready to grab the bytec

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-18 Thread malc
On Sun, 18 Sep 2011, Juan Quintela wrote: > malc wrote: > > On Fri, 16 Sep 2011, Anthony Liguori wrote: > > > >> Reviewed-by: Anthony Liguori > >> > >> malc, please Ack. > >> > > > > I don't like the commit message. > > Can you be more specific? QEMUFile predates migration by a few years so

[Qemu-devel] [PATCH] VMDK: fix leak of extent_file

2011-09-18 Thread Fam Zheng
Release extent_file on error in vmdk_parse_extents. Added closing files in freeing extents. Signed-off-by: Fam Zheng --- block/vmdk.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 6c8edfc..5d16ec4 100644 --- a/block/vmdk.

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-18 Thread TeLeMan
On Thu, Sep 15, 2011 at 21:40, Gerd Hoffmann wrote: > On 09/14/11 09:59, Paolo Bonzini wrote: >> >> On 09/14/2011 09:40 AM, TeLeMan wrote: > > >> > >> The commit "usb/hid: add hid_pointer_activate, use it" used > >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so > >>

  1   2   >