Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio

[Richard Henderson]

On 09/18/2011 05:54 AM, Jan Kiszka wrote:
> @@ -375,8 +375,7 @@ static const MemoryRegionPortio *find_portio(MemoryRegion 
> *mr, uint64_t offset,
>      const MemoryRegionPortio *mrp;
>  
>      for (mrp = mr->ops->old_portio; mrp->size; ++mrp) {
> -        if (offset >= mrp->offset && offset < mrp->offset + mrp->len
> -            && width == mrp->size
> +        if (offset < mrp->len && width == mrp->size

This change looks broken to me.  How, exactly, are you 
disambiguating different entries?



r~