Remove code which is now dead Signed-off-by: Hervé Poussineau <hpous...@reactos.org> --- hw/isa-bus.c | 43 +++++-------------------------------------- hw/isa.h | 2 +- hw/mips_jazz.c | 2 +- hw/mips_r4k.c | 2 +- hw/pc_piix.c | 2 +- hw/ppc_prep.c | 2 +- 6 files changed, 10 insertions(+), 43 deletions(-)
diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 03e7381..37642b7 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -24,7 +24,6 @@ static ISABus *isabus; target_phys_addr_t isa_mem_base = 0; -static qemu_irq *isa_bus_default_irqs; static void isabus_dev_print(Monitor *mon, DeviceState *dev, int indent); static char *isabus_get_fw_dev_path(DeviceState *dev); @@ -36,44 +35,12 @@ static struct BusInfo isa_bus_info = { .get_fw_dev_path = isabus_get_fw_dev_path, }; -static void isa_bus_default_set_irqs(ISABus *bus, qemu_irq *irqs) +ISABus *isa_bus_bridge_init(void) { - isa_bus_default_irqs = irqs; -} - -static qemu_irq isa_bus_default_get_irq(ISABus *bus, int isairq) -{ - if (isairq < 0 || isairq > 15) { - hw_error("isa irq %d invalid", isairq); - } - return isa_bus_default_irqs[isairq]; -} - -static MemoryRegion *isa_bus_default_get_address_space(ISABus *bus) -{ - return get_system_memory(); -} - -static ISABusOps isa_bus_default_ops = { - .set_irqs = isa_bus_default_set_irqs, - .get_irq = isa_bus_default_get_irq, - .get_address_space = isa_bus_default_get_address_space, -}; - -ISABus *isa_bus_bridge_init(DeviceState *dev) -{ - if (isabus) { - fprintf(stderr, "Can't create a second ISA bus\n"); - return NULL; - } - if (NULL == dev) { - dev = qdev_create(NULL, "isabus-bridge"); - qdev_init_nofail(dev); - } else { - isabus = FROM_QBUS(ISABus, qbus_create(&isa_bus_info, dev, NULL)); - isabus->ops = &isa_bus_default_ops; - } - return isabus; + DeviceState *dev; + dev = qdev_create(NULL, "isabus-bridge"); + qdev_init_nofail(dev); + return FROM_QBUS(ISABus, QLIST_FIRST(&dev->child_bus)); } void isa_bus_new(ISABus *bus, ISABusOps *ops, DeviceState *host) diff --git a/hw/isa.h b/hw/isa.h index 22a2783..5219b98 100644 --- a/hw/isa.h +++ b/hw/isa.h @@ -38,7 +38,7 @@ struct ISABusOps { MemoryRegion *(*get_address_space)(ISABus *bus); }; -ISABus *isa_bus_bridge_init(DeviceState *dev); +ISABus *isa_bus_bridge_init(void); void isa_bus_new(ISABus *bus, ISABusOps *ops, DeviceState *host); void isa_bus_irqs(qemu_irq *irqs); diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index 3990c0d..98f8d82 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c @@ -182,7 +182,7 @@ void mips_jazz_init (ram_addr_t ram_size, /* ISA devices */ i8259 = i8259_init(env->irq[4]); - isa_bus = isa_bus_bridge_init(NULL); + isa_bus = isa_bus_bridge_init(); isa_bus_irqs(i8259); cpu_exit_irq = qemu_allocate_irqs(cpu_request_exit, NULL, 1); DMA_init(0, cpu_exit_irq); diff --git a/hw/mips_r4k.c b/hw/mips_r4k.c index d1a841b..aaa38b0 100644 --- a/hw/mips_r4k.c +++ b/hw/mips_r4k.c @@ -266,7 +266,7 @@ void mips_r4k_init (ram_addr_t ram_size, /* The PIC is attached to the MIPS CPU INT0 pin */ i8259 = i8259_init(env->irq[2]); - isa_bus_bridge_init(NULL); + isa_bus_bridge_init(); isa_bus_irqs(i8259); rtc_init(2000, NULL); diff --git a/hw/pc_piix.c b/hw/pc_piix.c index d554bd0..da6fa55 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -150,7 +150,7 @@ static void pc_init1(MemoryRegion *system_memory, } else { pci_bus = NULL; i440fx_state = NULL; - isa_bus = isa_bus_bridge_init(NULL); + isa_bus = isa_bus_bridge_init(); } isa_bus_irqs(isa_irq); diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c index ebcc6fe..5b313c8 100644 --- a/hw/ppc_prep.c +++ b/hw/ppc_prep.c @@ -651,7 +651,7 @@ static void ppc_prep_init (ram_addr_t ram_size, i8259 = i8259_init(first_cpu->irq_inputs[PPC6xx_INPUT_INT]); pci_bus = pci_prep_init(i8259, get_system_memory(), get_system_io()); /* Hmm, prep has no pci-isa bridge ??? */ - isa_bus_bridge_init(NULL); + isa_bus_bridge_init(); isa_bus_irqs(i8259); // pci_bus = i440fx_init(); /* Register 8 MB of ISA IO space (needed for non-contiguous map) */ -- 1.7.5.4