[PATCH] Fixes rtl8139 driver for old kernels.

Old linux kernel rtl8139 drivers (ex. debian 2.1) uses outb to set the rx mode for RxConfig. Unfortunatelly qemu does not support outb for RxConfig. Signed-off-by: Hans --- hw/net/rtl8139.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139

VIRTIO_GPU_CMD_SUBMIT_3D error feedback?

the shader code to the host. However, it's still possible that a shader object creation would fail. regards, Hans publickey - hans@keasigmadelta.com - 4293c311.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature

Re: QEMU Virtio GPU features status & roadmap?

s there any official documentation for VirGL, Venus, etc.? Or is that yet to be written? regards, Hans On 9/11/23 16:13, Huang Rui wrote: On Wed, Nov 08, 2023 at 07:07:43PM +0800, Marc-André Lureau wrote: Hi On Wed, Nov 8, 2023 at 1:04 PM Antonio Caggiano wrote: Hi Hans, +cc Gert and Dmitry On 17/10

[PATCH v3 3/3] hw/char/stm32f2xx_usart: Add more definitions for CR1 register

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Acked-by: Alistair Francis Signed-off-by: Hans-Erik Floryd --- include/hw/char/stm32f2xx_usart.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/hw/char/stm32f2xx_usart.h b/include/hw

[PATCH v3 2/3] hw/char/stm32f2xx_usart: Update IRQ when DR is written

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Hans-Erik Floryd --- hw/char/stm32f2xx_usart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c index 519d3461a3

[PATCH v3 0/3] stm32f2xx_usart: implement TX interrupts

Generate interrupt if either of the TXE, TC or RXNE bits are active and the corresponding interrupt enable bit is set. v3: - Drop patch "hw/char/stm32f2xx_usart: Update IRQ when SR is read" as it is not required Hans-Erik Floryd (3): hw/char/stm32f2xx_usart: Extract common IRQ u

[PATCH v3 1/3] hw/char/stm32f2xx_usart: Extract common IRQ update code to update_irq()

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Hans-Erik Floryd --- hw/char/stm32f2xx_usart.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/char/stm32f2xx_usart.c b/hw

Re: [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read

On Mon, 23 Oct 2023 at 03:37, Alistair Francis wrote: > > On Sat, Oct 21, 2023 at 4:12 AM Philippe Mathieu-Daudé > wrote: > > > > From: Hans-Erik Floryd > > > > Signed-off-by: Hans-Erik Floryd > > [PMD: Split from bigger patch] > > Signed-off-by

Re: [PATCH 1/1] stm32f2xx_usart: implement TX interrupts

Hi Phil, On Fri, 20 Oct 2023 at 14:42, Philippe Mathieu-Daudé wrote: > > Hi Hans-Erik, > > On 20/10/23 13:14, Hans-Erik Floryd wrote: > > Generate interrupt if either of the TXE, TC or RXNE bits are active > > and the corresponding interrupt enable bit is set. > >

[PATCH 1/1] stm32f2xx_usart: implement TX interrupts

Generate interrupt if either of the TXE, TC or RXNE bits are active and the corresponding interrupt enable bit is set. Signed-off-by: Hans-Erik Floryd --- hw/char/stm32f2xx_usart.c | 29 + include/hw/char/stm32f2xx_usart.h | 10 ++ 2 files changed, 23

QEMU Virtio GPU features status & roadmap?

ps. That's clearly not possible without blob resources, or shared memory (not entirely sure what the shared memory feature is for). This is why I want to know what features are stable or coming soon. regards, Hans publickey - hans@keasigmadelta.com - 4293c311.asc Description: appli

[Bug 1878413] [NEW] /proc/sys/fs/binfmt_misc/ empty even though binfmt_misc is loaded

Public bug reported: _apksigner_ uses binfmt to execute via _jarwrapper_, since it is a JAR. We have a test suite that relies on _apksigner_ working. It was running fine in Ubuntu/bionic. Since it was pegged to LTS, it got upgraded to Ubuntu/focal and it stopped working. This is likely because

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

I removed in "/usr/lib/python3/dist-packages" the file "apport_python_hook.py" so the output of # PYTHONDEVMODE=1 virt-manager --no-fork is now: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/libvirt.py", line 24, in import cygvirtmod as libvirtmod ModuleNotFoundE

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

@ Christian, I delete all files in /var/crash and run virt-manager again in terminal... Segmentation fault is present. I did this, too: # sudo su # PYTHONDEVMODE=1 virt-manager --no-fork Fatal Python error: Segmentation fault Current thread 0x7f2309805740 (most recent call first): File

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

** Attachment added: "Crash.log of python3.7" https://bugs.launchpad.net/qemu/+bug/1838312/+attachment/528/+files/crash.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1838312 Title: Qemu

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

I found crash-report from python 3.7 similiar to this error: kernel: [ 2003.888116] virt-manager[16014]: segfault at 32d0 ip 32d0 sp 7ffeb09ac658 error 14 in python3.7[40+21000] kernel: [ 2003.888124] Code: Bad RIP value. look here: ProblemType: Crash Date: Fri Jul 26 15:03

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

@ Christian Ehrhardt, I'm on Ubuntu Mate 19.04. Machine: AMD, 64 bit I done no configuration of 'libvirt' yet. I don't wanna install apport. I add installed package-list at attachment. I hope it will helps. ** Attachment added: "Installed package-list" https://bugs.launchpad.net/qemu/+bu

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

syslog: kernel: [ 2003.888116] virt-manager[16014]: segfault at 32d0 ip 32d0 sp 7ffeb09ac658 error 14 in python3.7[40+21000] kernel: [ 2003.888124] Code: Bad RIP value. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

[Qemu-devel] [Bug 1838312] [NEW] Qemu virt-manager Segmentation fault

Public bug reported: Hi! I installed all these packages: sudo apt install qemu sudo apt install ipxe-qemu-256k-compat-efi-roms libspice-server1 libbluetooth3 sudo apt install libbrlapi0.6 libcacard0 libfdt1 libusbredirparser1 libvirglrenderer0 libxen-4.9 libxenstore3.0 sudo apt install cpu-chec

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

Please note the updates on: https://bugzilla.redhat.com/show_bug.cgi?id=1701736 It turns out that you can reproduce the broken images on glusterfs fuse mounts by using: aio=native cache=none, write-cache=on I have a set of vms running here on my

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

I did some undocumented testing to circle the issue down: It seems to affect Files that are stored as sparsed files either raw or qcow2. There was a big event and I had the chance to find some people using glusterfs with qemu, too. the biggest difference as far as I could see was that they all whe

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

I will have to put more efford into that: The bug applies to oVirt 4.3 too which seems to use a fuse filesystem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793904 Title: files are randomly over

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

Hi John, As for your second question: ii glusterfs-comm 4.1.3-1 amd64GlusterFS common libraries and tr As for the other parts: I was playing with this one ealier, therefore this is not completely relieable: qemu-img check images/conesphere_internet_meeting1.qcow2 No errors w

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

** Tags added: qemu ** Tags added: glusterfs -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793904 Title: files are randomly overwritten by Zero Bytes Status in QEMU: New Bug description: He

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

Update: I do have changed all important vms to a fuserfs image mount. The problem seems to occur when you write a lot of smaller files in a short period of time on the VMs ext4 filesystem. The best way for me to reproduce that is by doing an "apt upgrade" (see attachment) This particular VM is co

[Qemu-devel] [Bug 1793904] [NEW] files are randomly overwritten by Zero Bytes

Public bug reported: Hello together, I am currently tracking down a "Hard to reproduce" bug on my systems that I first discovered during gitlab installation: Here is the Text from the Gitlab Bug https://gitlab.com/gitlab-org/gitlab-ce/issues/51023 --

Re: [Qemu-devel] [PATCH v3] sdhci: add i.MX SD Stable Clock bit

Den fre 17 aug 2018 19:51Peter Maydell skrev > (Your indentation was off-by-one -- we use 4-space indent -- but I fixed > that.) -- PMM > Thanks! I think i fixed that in a new patch so please ignore v3. /Hans-Erik Floryd >

[Qemu-devel] [PATCH v3] sdhci: add i.MX SD Stable Clock bit

Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 8 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] [PATCH v2] sdhci: add i.MX SD Stable Clock bit

Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 8 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] [PATCH] sdhci: add i.MX SD Stable Clock bit

Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a

[Qemu-devel] [PATCH] imx_serial: Generate interrupt on receive data ready if enabled

Generate an interrupt if USR2_RDR and UCR4_DREN are both set. Signed-off-by: Hans-Erik Floryd --- hw/char/imx_serial.c | 3 ++- include/hw/char/imx_serial.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index 0747db9

[Qemu-devel] [Bug 1784919] Re: native libgfapi glusterfs support for virtio 9p filesystem passthrough

,security_model=passthrough -device virtio-9p-pci,fsdev=test_dev,mount_tag=test_mount regards Hans To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1784919/+subscriptions

[Qemu-devel] [Bug 1784919] [NEW] native libgfapi glusterfs support for virtio 9p filesystem passthrough

=test_mount regards Hans ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1784919 Title: native libgfapi glusterfs support for

Re: [Qemu-devel] [PATCH] egl-helpers: Support newer MESA versions

u and send a proper patch after I got some testing feedback. Feel free to use this as a base for a v2 of your patch. Regards, Hans Wouldn't be easier to call the "old" eglGetDisplay if eglGetPlatformDisplayEXT returns EGL_NO_DISPLAY ? Kind of With libEGL you (unfortunately)

Re: [Qemu-devel] [PATCH] egl-helpers: Support newer MESA versions

sting feedback. Feel free to use this as a base for a v2 of your patch. Regards, Hans diff -up qemu-2.8.0/ui/egl-helpers.c~ qemu-2.8.0/ui/egl-helpers.c --- qemu-2.8.0/ui/egl-helpers.c~ 2016-12-20 21:16:54.0 +0100 +++ qemu-2.8.0/ui/egl-helpers.c 2017-03-13 08:56:32.402845087 +0100 @@ -17

Re: [Qemu-devel] [PATCH] egl-helpers: Support newer MESA versions

sting feedback. Feel free to use this as a base for a v2 of your patch. Regards, Hans diff -up qemu-2.8.0/ui/egl-helpers.c~ qemu-2.8.0/ui/egl-helpers.c --- qemu-2.8.0/ui/egl-helpers.c~ 2016-12-20 21:16:54.0 +0100 +++ qemu-2.8.0/ui/egl-helpers.c 2017-03-13 08:56:32.402845087 +0100 @@ -17

Re: [Qemu-devel] [PATCH 7/9] target-cris: ignore prefix insns in singlestep

> Date: Tue, 13 Sep 2016 00:49:51 +0200 > From: "Edgar E. Iglesias" > On Mon, Sep 05, 2016 at 01:54:10PM +0200, Rabin Vincent wrote: > > From: Hans-Peter Nilsson > > > > Don't count prefix instructions as separate when singlestepping. > >

Re: [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps

> Date: Tue, 13 Sep 2016 00:59:51 +0200 > From: "Edgar E. Iglesias" > > @@ -3336,12 +3336,20 @@ void cris_cpu_dump_state(CPUState *cs, FILE *f, > > fprintf_function cpu_fprintf, > > { > > CRISCPU *cpu = CRIS_CPU(cs); > > CPUCRISState *env = &cpu->env; > > +const char **regnames; >

[Qemu-devel] [PATCH] Fix remainder field for TR_SETUP completion event

river. Signed-off-by: Hans Petter Selasky --- hw/usb/hcd-xhci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 188f954..d996d7e 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1753,6 +1753,11 @@ static void xhci_xfer_report(XHCITransfer

[Qemu-devel] QEMU XHCI support (FreeBSD)

Hi, I'm currently testing QEMUs XHCI support with FreeBSD and found some bugs in FreeBSDs XHCI aswell as QEMUs XHCI. 1) QEMU falsely reports a remainder of 8 bytes on TR_SETUP. This patch fixes it. Can it be upstreamed? --- ./work/qemu-2.3.0/hw/usb/hcd-xhci.c.orig 2016-08-22 16:07:30.87758

Re: [Qemu-devel] [PATCH] ehci: clear suspend bit on detach

specs mention setting suspend with enable being unset is undefined behavior. So clearing them both looks reasonable, and it actually fixes the reported bug. https://bugzilla.redhat.com/show_bug.cgi?id=1268879 Cc: Hans de Goede Signed-off-by: Gerd Hoffmann Thanks for fixing this. Patch looks good

Re: [Qemu-devel] Revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling"

Hi, On 10-02-15 22:02, Dennis Ostermann wrote: Hello Hans, thanks for taking care. 09-02-15 09:09, Hans de Goede wrote: Hi, On 09-02-15 22:09, Dennis Ostermann wrote: Hi there, please revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling&q

Re: [Qemu-devel] Revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling"

AD and several libusb versions. Affects at least FTDI FT2232H and FTDI FT232R. Which versions of libusb have you tested exactly ? Regards, Hans

Re: [Qemu-devel] [PATCH v2] xhci: add property to turn on/off streams support

off support for streams in the xhci host controller > will work better as the guest can figure beforehand that streams are > not going to work. > > Signed-off-by: Gerd Hoffmann Looks good: Reviewed-by: Hans de Goede Regards, Hans > --- > hw/usb/hcd-xhci.c | 15 +++

Re: [Qemu-devel] [PATCH] xhci: add property to turn on/off streams support

Hi, On 10/21/2014 03:16 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Looks good: Acked-by: Hans de Goede Regards, Hans > --- > hw/usb/hcd-xhci.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/hcd-xhci.c b

Re: [Qemu-devel] boot arm fedora via u-boot in qemu

rc7.git1.1.fc22.armv7hl (mockbu...@arm02-builder06.arm.fedoraproject.org) (gcc version 4.9.1 20140717 (Red Hat 4.9.1-2) (GCC) ) #1 SMP Tue Jul 29 17:20:28 UTC 2014 Note how it is also actually reading the dtb from disk, where as in your case it is not, so that seems to be the culprit. Regards, Hans

Re: [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated when using streams"

; static void xhci_alloc_streams(XHCIEPContext *epctx, dma_addr_t base) > { > assert(epctx->pstreams == NULL); > -epctx->nr_pstreams = 2 << (epctx->max_pstreams + 1); > +epctx->nr_pstreams = 2 << epctx->max_pstreams; > epctx->pstreams =

[Qemu-devel] [Bug 1314667] Building a USB-Drive with EasyToBoot (E2B) and PMPrebUSB

Hello Steve, I had a lot of trouble over the weekend building a sufficiently working bootable "USB-Rescue-Drive". I summed it up in an attached Word-Dokument and I am sure, you have the knowledge to solve my problems. For your detailed help I will expect with lots of kind regards H.Ohlerth A

Re: [Qemu-devel] [Bug 1314667] Re: PMPrebUSB - appcrash of qemu in Win-7-64bit

Hello, thank you for answering very fast. But in Google is advertised /"//RMPrepUSB/ www.rmprepusb.com/‎Diese Seite übersetzen

[Qemu-devel] [Bug 1314667] [NEW] PMPrebUSB - appcrash of qemu in Win-7-64bit

Public bug reported: I am not sure if this issue is a bug of qemu or by Win-7. I want to test in advance with QEMU the ability if my USB-Rescue-Drive is booting correctly. I have Win-7-64 and run qemu v.o.15.1.0 out of the installed RMPrepUSB v.2.1.719 program. The settings for the preparation

Re: [Qemu-devel] [PATCH 1/2] xhci iso: fix time calculation

Hi, Looks good, ack series. Regards, Hans On 02/06/2014 12:42 PM, Gerd Hoffmann wrote: Frameid specifies frames not microframes, so we need to shift it to get the microframe index. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH] allwinner-a10: add config script support

believe likely covers everything the qemu emulation offers atm. For those interested, see: https://github.com/linux-sunxi/linux-sunxi/commits/sunxi-devel And the mailinglist reports about progress in that branch. From the linux-sunxi pov fex files are a legacy thing which will go away in the future. Regards, Hans

[Qemu-devel] [PATCH 2/3] usb-host-libusb: Add alloc / free streams ops

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0dd60b2..894875b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1280,6

[Qemu-devel] [PATCH 0/3] usb-host-libusb: streams support

Hi Gerd, Here is a new version of the 3 patches to add streams support to usb-host-libusb, with the error when building with an older libusbx fixed. Thanks & Regards, Hans

[Qemu-devel] [PATCH 1/3] usb-host-libusb: Fill in endpoint max_streams when available

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..0dd60b2 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -720,6 +720,9 @@ static void

[Qemu-devel] [PATCH 3/3] usb-host-libusb: Set stream id when submitting bulk-stream transfers

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 894875b..2277e1b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1214,10 +1214,23

[Qemu-devel] [PATCH 8/9] usb-redir: Add support for bulk streams

Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 137 -- 1 file changed, 132 insertions(+), 5 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 287a505..4c6187b 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c

[Qemu-devel] [PATCH 9/9] uas: s/ui/iu/

The various uas data structures are called IU-s, which is short for Information Unit, rather then UI-s. Signed-off-by: Hans de Goede --- hw/usb/dev-uas.c | 76 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/hw/usb/dev

[Qemu-devel] [PATCH 6/9] usb-host-libusb: Add alloc / free streams ops

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0dd60b2..894875b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1280,6

[Qemu-devel] [PATCH 7/9] usb-host-libusb: Set stream id when submitting bulk-stream transfers

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 894875b..3376b96 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1214,10 +1214,22

[Qemu-devel] [PATCH 3/9] xhci: Call usb_device_alloc/free_streams

stick to the kernel API. Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 117 ++ 1 file changed, 117 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index d84d510..9368348 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd

[Qemu-devel] [PATCH 5/9] usb-host-libusb: Fill in endpoint max_streams when available

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..0dd60b2 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -720,6 +720,9 @@ static void

[Qemu-devel] [PATCH 4/9] xhci: Add a few missing checks for disconnected devices

to also check dev->attached, and add an extra check in a path where a device check was completely missing. This fixes various crashes (asserts triggering) I've been seeing when xhci attached usb devices get disconnected at the wrong time. Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c

[Qemu-devel] [PATCH 0/9] usb: redirection streams support + small fixes

. Thanks & Regards, Hans

[Qemu-devel] [PATCH 1/9] usb: Add max_streams attribute to endpoint info

Signed-off-by: Hans de Goede --- hw/usb/core.c| 22 ++ hw/usb/desc.c| 2 ++ include/hw/usb.h | 3 +++ 3 files changed, 27 insertions(+) diff --git a/hw/usb/core.c b/hw/usb/core.c index cf59a1a..67ba7d6 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -623,6 +623,7

[Qemu-devel] [PATCH 2/9] usb: Add usb_device_alloc/free_streams

Signed-off-by: Hans de Goede --- hw/usb/bus.c | 18 ++ include/hw/usb.h | 12 2 files changed, 30 insertions(+) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index ca329be..09848c6 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -203,6 +203,24 @@ void

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

t the defaults closer to the actual needs of the device. hw/usb/redirect.c actually has some code for that, you could use that as a start for the host redirection code... Regards, Hans

[Qemu-devel] [PATCH] uas: Fix response iu struct definition

s the responce code for an invalid iu, which confirms that the response code is being reported in byte 7 of the response iu rather then in byte 6. Signed-off-by: Hans de Goede --- hw/usb/dev-uas.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/usb/dev-uas

[Qemu-devel] [PATCH 5/5] uas: Bounds check tags when using streams

Disallow the guest to cause us to address the data3 and status3 arrays out of bounds. Signed-off-by: Hans de Goede --- hw/usb/dev-uas.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 70f41d3..5884035 100644 --- a/hw/usb/dev-uas.c

[Qemu-devel] [PATCH 4/5] uas: Streams are numbered 1-y, rather then 0-x

It is easier to simply make the arrays one larger, rather then substracting one everywhere. Signed-off-by: Hans de Goede --- hw/usb/dev-uas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 12d79ef..70f41d3 100644 --- a/hw/usb

[Qemu-devel] [PATCH 2/5] uas: Only use report iu-s for task_mgmt status reporting

Regular scsi cmds should always report their status using a sense-iu, using the sense code to report any errors. Signed-off-by: Hans de Goede --- hw/usb/dev-uas.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev

[Qemu-devel] [PATCH 1/5] scsi: Add 2 new sense codes needed by uas

Signed-off-by: Hans de Goede --- hw/scsi/scsi-bus.c | 10 ++ include/hw/scsi/scsi.h | 4 2 files changed, 14 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 24ec52f..2414696 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -1293,6 +1293,11

[Qemu-devel] [PATCH 3/5] uas: Fix / cleanup usb_uas_task error handling

ned-off-by: Hans de Goede --- hw/usb/dev-uas.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 36a75b2..12d79ef 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -746,17 +746,14 @@ static void usb_uas_t

[Qemu-devel] [PATCH 0/5] uas emulation fixes

Hi Gerd et al, Here is a bunch of uas fixes, they are hopefully self explanatory... Regards, Hans

Re: [Qemu-devel] [PATCH 1/2] audio: honor QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second

Hi, On 9 Oct 2013, at 20:42, Hans de Goede wrote: Now that we no longer have MIN_REARM_TIMER_NS a bug in the audio subsys has clearly shown it self by trying to make a timer fire every nano second. Note we have a similar problem in 1.6, 1.5 and older but there MIN_REARM_TIMER_NS limits the

Re: [Qemu-devel] [PATCH 1/2] audio: honor QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second

Hi, On 10/10/2013 08:31 AM, Alex Bligh wrote: On 9 Oct 2013, at 20:42, Hans de Goede wrote: Now that we no longer have MIN_REARM_TIMER_NS a bug in the audio subsys has clearly shown it self by trying to make a timer fire every nano second. Note we have a similar problem in 1.6, 1.5 and

[Qemu-devel] [PATCH 1/2] audio: honor QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second

/ second. This still causes a host cpu load of 50 % for simply playing audio, where as with this patch git master is at 13%, so we should backport this to 1.5 and 1.6 too. Note this will not apply to 1.5 and 1.6 as is. Cc: qemu-sta...@nongnu.org Signed-off-by: Hans de Goede --- audio/audio.c | 3

[Qemu-devel] [PATCH 2/2] audio: Lower default wakeup rate to 100 times / second

This is more then plenty to keep audio card fifos filles / emptied. This drops host cpu-load for audio playback inside a linux vm from 13% to 9%. Signed-off-by: Hans de Goede --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/audio.c

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

Hi, On 10/09/2013 09:03 PM, Paolo Bonzini wrote: Il 09/10/2013 20:49, Hans de Goede ha scritto: I wonder whether it's meant to be 1 millisecond or 1 microsecond? Maybe once it was 1 ms, this code just exists to keep the buffers of a soundcard filled / emptied in time. 100 times / seco

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

I wonder whether it's meant to be 1 millisecond or 1 microsecond? Maybe once it was 1 ms, this code just exists to keep the buffers of a soundcard filled / emptied in time. 100 times / second is more then plenty for that, so that is what I'm going to use in the patch I'm about to su

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

Hi, On 10/09/2013 08:03 PM, Hans de Goede wrote: So I started looking for suspecious timers under audio/*.c and immediately found this in audio/audio.c : static void audio_reset_timer (AudioState *s) { if (audio_is_timer_needed ()) { timer_mod (s->ts, qemu_clock_get

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

Hi, On 10/09/2013 04:37 PM, Paolo Bonzini wrote: Il 09/10/2013 14:58, Hans de Goede ha scritto: I still think we should add my patch in some form, since the lock starvation caused by timers set to expire in the past could still happen in other cases, esp for timer users who take a time stamp

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

>ts, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1); } else { timer_del (s->ts); } } static void audio_timer (void *opaque) { audio_run ("timer"); audio_reset_timer (opaque); } Note how that is using a timer which expires every freaking nano second, I think it is very likely that is the culprit. Regards, Hans

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

until the weekend but I propose producing a timer debug patch which will instrument what is expiring constantly (unless the problem with spice is obvious to someone). I think Hans already debugged it to the (supposedly) 33 Hz timer that spice audio uses. Correction, I've been looking at

Re: [Qemu-devel] [PATCH 03/13] usb-host-libusb: Detach kernel drivers earlier

ghtweight device reset is done, but the guest always starts with a full device-reset, immediately following that with a lightweight reset has little value. I think we could and should to the same in host-libusb.c. Regards, Hans

Re: [Qemu-devel] [PATCH 03/13] usb-host-libusb: Detach kernel drivers earlier

Hi, On 10/09/2013 10:55 AM, Gerd Hoffmann wrote: On Di, 2013-10-08 at 21:58 +0200, Hans de Goede wrote: If we detach the kernel drivers on the first set_config, then they will be still attached when the device gets its initial reset. Causing the drivers to re-initialize the device after the

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

Hi, On 10/08/2013 10:50 PM, Paolo Bonzini wrote: Il 08/10/2013 22:16, Hans de Goede ha scritto: No, it is calling main_loop_wait with nonblocking set to 0, so normally the lock would get released. But timerlistgroup_deadline_ns(&main_loop_tlg) is returning 0, causing timeout_ns to be 0,

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

Hi, On 10/08/2013 09:48 PM, Alex Bligh wrote: On 8 Oct 2013, at 20:10, Hans de Goede wrote: I noticed today that current qemu master would hang as soon as Xorg starts in the guest when using qxl + a Linux guest. This message would be printed: main-loop: WARNING: I/O thread spun for 1000

[Qemu-devel] [PATCH 08/13] usb: Add max_streams attribute to endpoint info

Signed-off-by: Hans de Goede --- hw/usb/core.c| 22 ++ hw/usb/desc.c| 2 ++ include/hw/usb.h | 3 +++ 3 files changed, 27 insertions(+) diff --git a/hw/usb/core.c b/hw/usb/core.c index cf59a1a..67ba7d6 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -623,6 +623,7

[Qemu-devel] [PATCH 11/13] usb-host-libusb: Fill in endpoint max_streams when available

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..0dd60b2 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -720,6 +720,9 @@ static void

[Qemu-devel] [PATCH 07/13] usb-hcd-xhci: Update endpoint context dequeue pointer for streams too

(and things won't work): xhci_hcd :00:05.0: Mismatch between completed Set TR Deq Ptr command & xHCI internal state. xhci_hcd :00:05.0: ep deq seg = 8800366f0880, deq ptr = 8800366ec010 Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 10 -- 1 file c

[Qemu-devel] [PATCH 00/13] usb: Add support for bulk streams to usb-host-libusb

, so if you're afraid the API may still change you could consider delaying merging these, but I'm quite confident that there will be no further API changes. Regards, Hans

[Qemu-devel] [PATCH 09/13] usb: Add usb_device_alloc/free_streams

Signed-off-by: Hans de Goede --- hw/usb/bus.c | 18 ++ include/hw/usb.h | 12 2 files changed, 30 insertions(+) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 72d5b92..bba554c 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -203,6 +203,24 @@ void

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

t dropping the lock occasionally (and still using a zero timeout) might be better. Paolo probably has some better insights on this, but he seems to have called it a day for today, and I'm going to do the same :) So lets continue this tomorrow. Regards, Hans

[Qemu-devel] [PATCH 01/13] usb-host-libusb: Fix reset handling

it is treated by the host as a new device and our handle is invalid, so on reset failure we need to call usb_host_nodev(). Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c

[Qemu-devel] [PATCH 13/13] usb-host-libusb: Set stream id when submitting bulk-stream transfers

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 894875b..3376b96 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1214,10 +1214,22

[Qemu-devel] [PATCH 12/13] usb-host-libusb: Add alloc / free streams ops

Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0dd60b2..894875b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1280,6

[Qemu-devel] [PATCH 10/13] xhci: Call usb_device_alloc/free_streams

stick to the kernel API. Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 117 ++ 1 file changed, 117 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index fa27299..c5889a9 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd

[Qemu-devel] [PATCH 06/13] usb-hcd-xhci: Report completion of active transfer with CC_STOPPED on ep stop

As we should per the XHCI spec "4.6.9 Stop Endpoint". Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 7cf89ce..0131151 100644 --- a/hw/usb/

[Qemu-devel] [PATCH 03/13] usb-host-libusb: Detach kernel drivers earlier

If we detach the kernel drivers on the first set_config, then they will be still attached when the device gets its initial reset. Causing the drivers to re-initialize the device after the reset, dirtying the device state. Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 7 +-- 1 file

  1   2   3   4   5   6   7   8   9   >