Re: [Qemu-devel] [PATCH 1/2] xhci iso: fix time calculation

[Hans de Goede]

Hi,

Looks good, ack series.

Regards,

Hans


On 02/06/2014 12:42 PM, Gerd Hoffmann wrote:

Frameid specifies frames not microframes, so we
need to shift it to get the microframe index.

Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
  hw/usb/hcd-xhci.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 44964f4..2c54b86 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1974,8 +1974,8 @@ static void xhci_calc_iso_kick(XHCIState *xhci, 
XHCITransfer *xfer,
              xfer->mfindex_kick = asap;
          }
      } else {
-        xfer->mfindex_kick = (xfer->trbs[0].control >> TRB_TR_FRAMEID_SHIFT)
-            & TRB_TR_FRAMEID_MASK;
+        xfer->mfindex_kick = ((xfer->trbs[0].control >> TRB_TR_FRAMEID_SHIFT)
+                              & TRB_TR_FRAMEID_MASK) << 3;
          xfer->mfindex_kick |= mfindex & ~0x3fff;
          if (xfer->mfindex_kick < mfindex) {
              xfer->mfindex_kick += 0x4000;