Re: [PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Oct 01, 2020 at 04:41:52PM +0200, Philippe Mathieu-Daudé wrote: >> Only qemu-system-FOO and qemu-storage-daemon provide QMP >> monitors, therefore such declarations and definitions are >> irrelevant for user-mode emulation. >> >> Restricting the x86-specific com

Re: [PATCH] ppc/pnv: Increase max firware size

2020-10-01 Thread Cédric Le Goater
That was sent a bit fast. Can you please add in the commit log : Builds enabling GCOV can be bigger than 4MB and the limit on FSP systems is 16MB. Thanks C. On 10/2/20 8:13 AM, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/ppc/pnv.c | 2 +- > 1 file changed, 1 in

[PATCH] ppc/pnv: Increase max firware size

2020-10-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 6670967e26a9..d9e52873ea70 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -61,7 +61,7 @@ #define FW_FILE_NAME"skiboot.lid" #defin

[PATCH 1/1] vl: Add -no-panicstop option

2020-10-01 Thread Alejandro Jimenez
The current default action of pausing a guest after a panic event is received leaves the responsibility to resume guest execution to the management layer. The reasons for this behavior are discussed here: https://lore.kernel.org/qemu-devel/52148f88.5000...@redhat.com/ However, in instances like th

[PATCH 0/1] Do not stop guest when panic event is received

2020-10-01 Thread Alejandro Jimenez
The following patch adds an option to request that QEMU does not stop the VM when a panic event is received. This allows guests in cloud environments to report the panic condition to the control plane, but be able to proceed to collect a crash dump and automatically reboot, without waiting to re

Re: [PATCH 1/2] block/export: add vhost-user-blk multi-queue support

2020-10-01 Thread Markus Armbruster
Stefan Hajnoczi writes: > Allow the number of queues to be configured using --export > vhost-user-blk,num-queues=N. This setting should match the QEMU --device > vhost-user-blk-pci,num-queues=N setting but QEMU vhost-user-blk.c lowers > its own value if the vhost-user-blk backend offers fewer que

Re: [PATCH] elfload: use g_new instead of malloc

2020-10-01 Thread Thomas Huth
On 02/10/2020 07.05, Markus Armbruster wrote: > Elena Afanasova writes: > >> Signed-off-by: Elena Afanasova >> --- >> bsd-user/elfload.c | 92 +++--- >> 1 file changed, 30 insertions(+), 62 deletions(-) >> >> diff --git a/bsd-user/elfload.c b/bsd-user/elf

Re: [PATCH v2 1/2] doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c

2020-10-01 Thread Markus Armbruster
Yonggang Luo writes: > There is no texi document anymore > > Signed-off-by: Yonggang Luo > --- > qemu-img-cmds.hx | 2 +- > target/i386/cpu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx > index b89c019b76..cab8234235 100644 >

Re: [PATCH v2 11/13] block/export: convert vhost-user-blk server to block export API

2020-10-01 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Sep 30, 2020 at 04:33:18PM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > On Wed, Sep 30, 2020 at 07:28:58AM +0200, Markus Armbruster wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > Use the new QAPI block exports API instead of defining

Re: [PATCH v2] block/nvme: Add driver statistics for access alignment and hw errors

2020-10-01 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Keep statistics of some hardware errors, and number of > aligned/unaligned I/O accesses. > > QMP example booting a full RHEL 8.3 aarch64 guest: > > { "execute": "query-blockstats" } > { > "return": [ > { > "device": "", > "node-

Re: [PATCH 1/2] doc: more texi cleanup

2020-10-01 Thread Markus Armbruster
Yonggang Luo writes: > Signed-off-by: Yonggang Luo > --- > qemu-img-cmds.hx | 2 +- > target/i386/cpu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx > index b89c019b76..cab8234235 100644 > --- a/qemu-img-cmds.hx > +++ b/qemu-im

Re: [PATCH] gitlab: move linux-user plugins test across to gitlab

2020-10-01 Thread Thomas Huth
On 01/10/2020 23.51, Alex Bennée wrote: > Even with the recent split moving beefier plugins into contrib and > dropping them from the check-tcg tests we are still hitting time > limits. This possibly points to a slow down of --debug-tcg but seeing > as we are migrating stuff to gitlab we might as w

Re: [PATCH] elfload: use g_new instead of malloc

2020-10-01 Thread Markus Armbruster
Elena Afanasova writes: > Signed-off-by: Elena Afanasova > --- > bsd-user/elfload.c | 92 +++--- > 1 file changed, 30 insertions(+), 62 deletions(-) > > diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c > index 32378af7b2..e10ca54eb7 100644 > --- a/bsd

Re: [PATCH v3 5/5] specs/ppc-spapr-numa: update with new NUMA support

2020-10-01 Thread David Gibson
On Tue, Sep 29, 2020 at 10:38:17AM -0300, Daniel Henrique Barboza wrote: > This update provides more in depth information about the > choices and drawbacks of the new NUMA support for the > spapr machine. > > Signed-off-by: Daniel Henrique Barboza > --- > docs/specs/ppc-spapr-numa.rst | 206

RE: [PATCH] hw/block/nvme: update nsid when registered

2020-10-01 Thread Dmitry Fomichev
> -Original Message- > From: Qemu-devel bounces+dmitry.fomichev=wdc@nongnu.org> On Behalf Of Klaus > Jensen > Sent: Thursday, October 1, 2020 5:51 PM > To: qemu-devel@nongnu.org > Cc: Kevin Wolf ; qemu-bl...@nongnu.org; Klaus Jensen > ; Max Reitz ; Klaus Jensen > ; Keith Busch > Subje

Re: [PATCH] vhost-blk: set features before setting inflight feature

2020-10-01 Thread Raphael Norwitz
I see you're right - or rather even if a vhost-net backend negotiates the inflight feature, QEMU never sets/gets an inflight fd. That clears up all my concerns - I support the change. I don't like sending an additional VHOST_USER_SET_FEATURES message in vhost_dev_start() right after we've sent one

Re: [PATCH v3 4/5] spapr_numa: consider user input when defining associativity

2020-10-01 Thread David Gibson
On Tue, Sep 29, 2020 at 10:38:16AM -0300, Daniel Henrique Barboza wrote: > This patch puts all the pieces together to finally allow user > input when defining the NUMA topology of the spapr guest. > > For each NUMA node A, starting at node id 0, the new > spapr_numa_define_associativity_domains()

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-01 Thread Raphael Norwitz
On Mon, Sep 28, 2020 at 9:17 AM Jiajun Chen wrote: > > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is usefully

RE: [RFC PATCH v4 19/29] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree

2020-10-01 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Thursday, October 1, 2020 1:54 PM > To: Philippe Mathieu-Daudé ; Taylor Simpson > ; qemu-devel@nongnu.org > Cc: laur...@vivier.eu; riku.voi...@iki.fi; aleksandar.m.m...@gmail.com; > a...@rev.ng > Subject: Re: [RFC PATCH v4 19/29] Hex

RE: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Thursday, October 1, 2020 6:15 PM > To: Dmitry Fomichev > Cc: Keith Busch ; Klaus Jensen > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Maxim Levitsky > ; Fam Zheng ; Niklas Cassel > ; Damien Le Moal ; > qemu-bl...@nongnu.org; qemu-devel@nong

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable > detection for the NVM Command Se

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-10-01 Thread John Snow
On 10/1/20 4:41 PM, John Snow wrote: I realize this review comes well after you are no longer being paid to work on this, so I am offering my time to help polish your patches if you would like. Actually, I see now that you are adding your name to the MAINTAINERS file here, so I suspect you pr

[PATCH] hw/block/nvme: update nsid when registered

2020-10-01 Thread Klaus Jensen
From: Klaus Jensen If the user does not specify an nsid parameter on the nvme-ns device, nvme_register_namespace will find the first free namespace id and assign that. This fix makes sure the assigned id is saved. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 inser

[PATCH] gitlab: move linux-user plugins test across to gitlab

2020-10-01 Thread Alex Bennée
Even with the recent split moving beefier plugins into contrib and dropping them from the check-tcg tests we are still hitting time limits. This possibly points to a slow down of --debug-tcg but seeing as we are migrating stuff to gitlab we might as well take advantage of the ability to properly sp

Re: ARM semihosting issue

2020-10-01 Thread Bruno Prado
Thanks for the reply... I am attaching some code and output: #include int main() { char name[50] = "Nobody"; FILE* file = fopen("name", "r"); printf("What is your name?\n"); fprintf(stdout, "Reading from file...\n"); fscanf(file, "%s", name); fscanf(stdin

[PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver

2020-10-01 Thread Si-Wei Liu
Vendor driver may not support or implement config interrupt delivery for link status notifications. In this event, vendor driver is expected to NACK the feature, but guest will keep link always up. Signed-off-by: Si-Wei Liu --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [PULL 0/9] Ide patches

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 18:46, John Snow wrote: > > The following changes since commit 37a712a0f969ca2df7f01182409a6c4825cebfb5: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-10-01 12:23:19 +0100) > > are available in the Git repository at: > >

Re: [PATCH] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 19:21, Thomas Huth wrote: > > When compiling with -Werror=implicit-fallthrough, gcc complains about > missing fallthrough annotations in this file. Looking at the code, > the fallthrough is indeed wanted here, but instead of adding the > annotations, it can be done more effic

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-10-01 Thread John Snow
I realize this review comes well after you are no longer being paid to work on this, so I am offering my time to help polish your patches if you would like. On 8/28/20 6:40 AM, Ahmed Karaman wrote: - Apply pylint and flake8 formatting rules to the script. - Use 'tempfile' instead of '/tmp' for

Re: ARM semihosting issue

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 21:33, Bruno Prado wrote: > I was able to use stdout, stderr for output and files for > both input and output in qemu-system-arm, but stdin is not > working (always returns -1 from syscall). I found no > information and have already checked the code for possible hints. Rathe

Re: [PATCH] hw: wdt: implement sbsa watchdog

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 20:37, Maxim Uvarov wrote: > > Initial virtual driver matching linux kernel sbsa_gwdt > driver. Driver implements basic functionality and makes > watchdog works on virtual machine and allows to reboot > secure OS. I.e. atf->optee->efi/uboot->kernel. More > information about t

ARM semihosting issue

2020-10-01 Thread Bruno Prado
Hi, I was able to use stdout, stderr for output and files for both input and output in qemu-system-arm, but stdin is not working (always returns -1 from syscall). I found no information and have already checked the code for possible hints. I am on Arch Linux LTS + QEMU 5.1.0. Thanks, Bruno

Re: [RFC PATCH v4 19/29] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree

2020-10-01 Thread Richard Henderson
On 9/29/20 6:37 AM, Philippe Mathieu-Daudé wrote: > On 9/28/20 7:28 PM, Taylor Simpson wrote: >> Run the C preprocessor across the instruction definition and encoding >> files to expand macros and prepare the iset.py file. The resulting >> fill contains python data structures used to build the dec

[PATCH] hw: wdt: implement sbsa watchdog

2020-10-01 Thread Maxim Uvarov
Initial virtual driver matching linux kernel sbsa_gwdt driver. Driver implements basic functionality and makes watchdog works on virtual machine and allows to reboot secure OS. I.e. atf->optee->efi/uboot->kernel. More information about that device can be found under: ARM DEN0029B - Server Base Syst

Re: [PULL 29/86] meson: move libudev test

2020-10-01 Thread Paolo Bonzini
On 01/10/20 20:51, Peter Maydell wrote: > Yes, I have a lot of --disable-foo options. Ideally I wouldn't > need any, because our configure/build system would identify "there > isn't actually a static version of this dependency present" > rather than blindly trusting pkg-config when it lies to us. >

Re: [PULL 29/86] meson: move libudev test

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 17:55, Paolo Bonzini wrote: > On 01/10/20 18:19, Peter Maydell wrote: > > I'm not very confident about reading meson.build logic, but it > > looks like this trusts meson/pkg-config to tell it about > > whether it can do a static link against this library, > > which doesn't wo

Re: [PATCH 0/9] nvme qemu cleanups and fixes

2020-10-01 Thread Klaus Jensen
On Sep 30 15:04, Keith Busch wrote: > After going through the zns enabling, I notice the controller enabling > is not correct. Then I just continued maked more stuff. The series, I > think, contains some of the less controversial patches from the two > conflicting zns series, preceeded by some clea

Re: [PULL 00/18] target-arm queue

2020-10-01 Thread Peter Maydell
27; > into staging (2020-10-01 12:23:19 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20201001 > > for you to fetch changes up to cdfaa57dcb53ba012439765a1462247dfda8595d: > > h

Re: [PATCH v2 1/3] util/cutils: Introduce freq_to_str() to display Hertz units

2020-10-01 Thread Eduardo Habkost
On Thu, Oct 01, 2020 at 06:43:20PM +0200, Philippe Mathieu-Daudé wrote: > Introduce freq_to_str() to convert frequency values in human > friendly units using the SI units for Hertz. > > Suggested-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/cutils.h | 12 +

[PATCH v3 3/4] migration: Maintain postcopy faulted addresses

2020-10-01 Thread Peter Xu
Maintain a list of faulted addresses on the destination host for which we're waiting on. This is implemented using a GTree rather than a real list to make sure even there're plenty of vCPUs/threads that are faulting, the lookup will still be fast with O(log(N)) (because we'll do that after placing

[PATCH v3 4/4] migration: Sync requested pages after postcopy recovery

2020-10-01 Thread Peter Xu
We synchronize the requested pages right after a postcopy recovery happens. This helps to synchronize the prioritized pages on source so that the faulted threads can be served faster. Reported-by: Xiaohui Li Signed-off-by: Peter Xu --- migration/savevm.c | 57 +++

[PATCH v3 0/4] migration/postcopy: Sync faulted addresses after network recovered

2020-10-01 Thread Peter Xu
v3: - fix build on 32bit hosts & rebase - remove r-bs for the last 2 patches for Dave due to the changes v2: - add r-bs for Dave - add patch "migration: Properly destroy variables on incoming side" as patch 1 - destroy page_request_mutex in migration_incoming_state_destroy() too [Dave] - use WITH_

[PATCH v3 2/4] migration: Introduce migrate_send_rp_message_req_pages()

2020-10-01 Thread Peter Xu
This is another layer wrapper for sending a page request to the source VM. The new migrate_send_rp_message_req_pages() will be used elsewhere in coming patches. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 10 -- migration/migration.h | 2 ++

Re: [PATCH 1/9] hw/block/nvme: remove pointless rw indirection

2020-10-01 Thread Klaus Jensen
On Oct 1 06:05, Klaus Jensen wrote: > On Sep 30 15:04, Keith Busch wrote: > > The code switches on the opcode to invoke a function specific to that > > opcode. There's no point in consolidating back to a common function that > > just switches on that same opcode without any actual common code. > >

[PATCH v3 1/4] migration: Pass incoming state into qemu_ufd_copy_ioctl()

2020-10-01 Thread Peter Xu
It'll be used in follow up patches to access more fields out of it. Meanwhile fetch the userfaultfd inside the function. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/postcopy-ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migratio

[PULL 8/9] ide: clear interrupt on command write

2020-10-01 Thread John Snow
Not known to fix any bug, but I couldn't help but notice that ATA specifies that writing to this register should clear an interrupt. ATA7: Section 5.3.3 (Command register - Effect) ATA6: Section 7.4.4 (Command register - Effect) ATA5: Section 7.4.4 (Command register - Effect) ATA4: Section 7.4.4 (

[PULL 7/9] ide: remove magic constants from the device register

2020-10-01 Thread John Snow
(In QEMU, we call this the "select" register.) My memory isn't good enough to memorize what these magic runes do. Label them to prevent mixups from happening in the future. Side note: I assume it's safe to always set 0xA0 even though ATA2 claims these bits are reserved, because ATA3 immediately r

RE: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller

2020-10-01 Thread Vikram Garhwal
Hi Peter, I sent rebased V10 series three weeks back as there were some issues with meson build on v9. Would it possible for you to apply the patch series? Link for series: https://patchew.org/QEMU/1600121324-31337-1-git-send-email-fnu.vik...@xilinx.com/ Regards, Vikram > -Original Message

Re: [RFC PATCH v4 27/29] Hexagon (linux-user/hexagon) Linux user emulation

2020-10-01 Thread Laurent Vivier
Le 01/10/2020 à 17:40, Taylor Simpson a écrit : > > >> -Original Message- >> From: Laurent Vivier >> Sent: Thursday, October 1, 2020 1:53 AM >> To: Taylor Simpson ; qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; phi...@redhat.com; riku.voi...@iki.fi; >> aleksandar.m.m...@gmai

[PATCH] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-01 Thread Thomas Huth
When compiling with -Werror=implicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is indeed wanted here, but instead of adding the annotations, it can be done more efficiently by simply calculating the offset with a subtraction

Re: About 'qemu-security' mailing list

2020-10-01 Thread P J P
+-- On Thu, 1 Oct 2020, Darren Kenny wrote --+ | The storage of reproducers would indeed be good to have in something | like Gitlab - but that'd require someone to extract it and store it, but | under what naming would be another issue... But really that's behind the | scenes. Yes. | > Maybe w

Re: [PATCH v4 41/46] qapi/introspect.py: create a typed 'Node' data structure

2020-10-01 Thread John Snow
On 9/30/20 3:52 PM, Eduardo Habkost wrote: On Wed, Sep 30, 2020 at 02:58:04PM -0400, John Snow wrote: On 9/30/20 2:39 PM, Eduardo Habkost wrote: On Wed, Sep 30, 2020 at 12:31:45AM -0400, John Snow wrote: This replaces _make_tree with Node.__init__(), effectively. By creating it as a generic co

[PATCH v6 4/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

2020-10-01 Thread Yonggang Luo
We remove the CONFIG_LOCALTIME_R detection option in configure, and move the check existence of gmtime_r from configure into C header and source directly by using macro `_POSIX_THREAD_SAFE_FUNCTIONS`. Before this patch, the configure script are always assume the compiler doesn't define _POSIX_C_

[PATCH v6 3/4] curses: Fixes curses compiling errors.

2020-10-01 Thread Yonggang Luo
This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~

Re: [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include

2020-10-01 Thread Eduardo Habkost
On Thu, Oct 01, 2020 at 07:44:57PM +0200, Philippe Mathieu-Daudé wrote: > ping? > > On 9/8/20 2:34 PM, Philippe Mathieu-Daudé wrote: > > cpu_common_reset() uses tcg_flush_softmmu_tlb() which is > > declared in "exec/cpu-common.h". Add the missing header > > to avoid when refactoring other headers:

[PULL 5/9] ide: model HOB correctly

2020-10-01 Thread John Snow
I have been staring at this FIXME for years and I never knew what it meant. I finally stumbled across it! When writing to the command registers, the old value is shifted into a HOB copy of the register and the new value is written into the primary register. When reading registers, the value retrie

[PATCH v6 0/4] Fixes curses on msys2/mingw

2020-10-01 Thread Yonggang Luo
And also convert related configure script to meson. V5-V6 Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the= m to meson first. That need the meson 0.56 upstream to fixes the curses detection. Add * configure: fixes indent of $meson setup Yonggang Luo (4): configure: f

[PATCH v2] cpus: Do not dump CPU state when calling hw_error()

2020-10-01 Thread Philippe Mathieu-Daudé
Dumping the state of all CPUs is not helpful in any of the contexts where hw_error() is used. We already have cpu_abort() to dump CPU states and abort. Restrict hw_error() to peripheral errors, hoping we can completely remove it by proper functions from "error-report.h" in the future. Reviewed-by

[PULL 9/9] ide: cancel pending callbacks on SRST

2020-10-01 Thread John Snow
The SRST implementation did not keep up with the rest of IDE; it is possible to perform a weak reset on an IDE device to remove the BSY/DRQ bits, and then issue writes to the control/device registers which can cause chaos with the state machine. Fix that by actually performing a real reset. Repor

[PULL 4/9] ide: don't tamper with the device register

2020-10-01 Thread John Snow
In real ISA operation, register writes go out to an entire bus channel and all listening devices receive the write. The devices do not toggle the DEV bit based on their own configuration, nor does the HBA intermediate or tamper with that value. The reality of the matter is that DEV0/DEV1 according

[PULL 3/9] ide: rename cmd_write to ctrl_write

2020-10-01 Thread John Snow
It's the Control register, part of the Control block -- Command is misleading here. Rename all related functions and constants. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/ide/internal.h | 9 + hw/ide/core.c | 12 ++-- hw/ide/ioport.c

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-01 Thread Keith Busch
On Thu, Oct 01, 2020 at 07:18:37PM +0200, Klaus Jensen wrote: > OK, so I agree that it makes sense for it to be supported on a per > namespace basis, but I think the spec is just keeping the door open for > future namespace specific stuff in the log page - currently there is > none. > > Figure 94

[PULL 1/9] MAINTAINERS: Update my git address

2020-10-01 Thread John Snow
I am switching from github to gitlab. Signed-off-by: John Snow --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ade11002022..b76fb31861b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1577,7 +1577,7 @@ F: tests/qtest/ide-te

[PULL 6/9] ide: reorder set/get sector functions

2020-10-01 Thread John Snow
Reorder these just a pinch to make them more obvious at a glance what the addressing mode is. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/core.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/co

Re: [PATCH 4/5] target/riscv: Add V extention state description

2020-10-01 Thread Richard Henderson
On 9/28/20 9:03 PM, Yifei Jiang wrote: > In the case of supporting V extention, add V extention description > to vmstate_riscv_cpu. > > Signed-off-by: Yifei Jiang > Signed-off-by: Yipeng Yin > --- > target/riscv/machine.c | 25 + > 1 file changed, 25 insertions(+) Revie

[PULL 0/9] Ide patches

2020-10-01 Thread John Snow
The following changes since commit 37a712a0f969ca2df7f01182409a6c4825cebfb5: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-10-01 12:23:19 +0100) are available in the Git repository at: https://gitlab.com/jsnow/qemu.git tags/ide-pull-request for

[PULL 2/9] hw/ide/ahci: Do not dma_memory_unmap(NULL)

2020-10-01 Thread John Snow
From: Philippe Mathieu-Daudé libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none -qtest stdio outl 0xcf8 0x8000fa24 outl 0xcfc 0xe1068000 outl 0xcf8 0x8000fa04 outw 0xcfc 0x7 outl 0xcf8 0x8000fb20 writ

[PATCH v2 1/2] doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c

2020-10-01 Thread Yonggang Luo
There is no texi document anymore Signed-off-by: Yonggang Luo --- qemu-img-cmds.hx | 2 +- target/i386/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index b89c019b76..cab8234235 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.

Re: [PATCH 3/5] target/riscv: Add H extention state description

2020-10-01 Thread Richard Henderson
On 9/28/20 9:03 PM, Yifei Jiang wrote: > +VMSTATE_UINTTL(env.vsstatus, RISCVCPU), > +VMSTATE_UINTTL(env.vstvec, RISCVCPU), > +VMSTATE_UINTTL(env.vsscratch, RISCVCPU), > +VMSTATE_UINTTL(env.vsepc, RISCVCPU), > +VMSTATE_UINTTL(env.vscause, RISCVCPU), > +

Re: [PULL v2 13/15] hw/rx: Add RX GDB simulator

2020-10-01 Thread Philippe Mathieu-Daudé
On 9/9/20 7:56 PM, Philippe Mathieu-Daudé wrote: > Hi Yoshinori, > > On 9/7/20 3:13 PM, Peter Maydell wrote: >> On Mon, 22 Jun 2020 at 20:20, Philippe Mathieu-Daudé wrote: >>> >>> From: Yoshinori Sato >>> >>> Add the RX machine internally simulated in GDB. >> >> Hi; Coverity points out a memory

Re: [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include

2020-10-01 Thread Philippe Mathieu-Daudé
ping? On 9/8/20 2:34 PM, Philippe Mathieu-Daudé wrote: > cpu_common_reset() uses tcg_flush_softmmu_tlb() which is > declared in "exec/cpu-common.h". Add the missing header > to avoid when refactoring other headers: > > hw/core/cpu.c: In function ‘cpu_common_reset’: > hw/core/cpu.c:273:9: erro

[PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-01 Thread Yonggang Luo
msys2/mingw lacks the POSIX-required langinfo.h. gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include | ^~~~ compilation terminated. So we u

Re: [PATCH v1 02/20] s390x/tcg: Implement VECTOR BIT PERMUTE

2020-10-01 Thread David Hildenbrand
On 01.10.20 17:17, Richard Henderson wrote: > On 9/30/20 9:55 AM, David Hildenbrand wrote: >> +bit = !!(s390_vec_read_element8(v2, bit_nr / 8) & >> + (0x80 >> (bit_nr % 8))); > > I think this would be clearer as > > bit = (s390_vec_read_element8(v2, bit_nr / 8) >

Re: [PATCH v6 0/4] Fixes curses on msys2/mingw

2020-10-01 Thread Paolo Bonzini
On 01/10/20 19:32, Yonggang Luo wrote: > And also convert related configure script to meson. > V5-V6 > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the= > m to meson first. > That need the meson 0.56 upstream to fixes the curses detection. > Add > * configure: fixes ind

[PATCH v6 1/4] configure: fixes indent of $meson setup

2020-10-01 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index ca9b458ea0..8f7bdbfdd3 100755 --- a/configure +++ b/configure @@ -7843,10 +7843,10 @@ NINJA=${ninja:-$PWD/ninjato

[PATCH RESEND v2 13/16] dma: Let dma_memory_map() take MemTxAttrs argument

2020-10-01 Thread Philippe Mathieu-Daudé
Let devices specify transaction attributes when calling dma_memory_map(). Patch created mechanically using spatch with this script: @@ expression E1, E2, E3, E4; @@ - dma_memory_map(E1, E2, E3, E4) + dma_memory_map(E1, E2, E3, E4, MEMTXATTRS_UNSPECIFIED) Reviewed-by: Richard Henderson

[PATCH v2 0/2] Texi cleanup

2020-10-01 Thread Yonggang Luo
Texi cleanup V1-V2 Fixes with doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c Yonggang Luo (2): doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c doc: remove hxtool-conv.pl qemu-img-cmds.hx | 2 +- scripts/hxtool-conv.pl | 137 -

[PATCH RESEND v2 10/16] dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument

2020-10-01 Thread Philippe Mathieu-Daudé
We will add the MemTxAttrs argument to dma_memory_rw() in the next commit. Since dma_memory_rw_relaxed() is only used by dma_memory_rw(), modify it first in a separate commit to keep the next commit easier to review. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Igle

[PATCH RESEND v2 14/16] pci: Let pci_dma_rw() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
dma_memory_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/in

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-10-01 Thread Philippe Mathieu-Daudé
ping qemu-block or qemu-arm? On 9/15/20 7:16 PM, Philippe Mathieu-Daudé wrote: > This is the QEMU equivalent of this Linux commit (but 7 years later): > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f7025a43a9da2 > > The MTD subsystem has its own small museum o

[PATCH RESEND v2 09/16] dma: Let dma_memory_set() take MemTxAttrs argument

2020-10-01 Thread Philippe Mathieu-Daudé
Let devices specify transaction attributes when calling dma_memory_set(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/spapr_vio.h | 3 ++- include/sysemu/dma.h | 3 ++- dma-helpers.c

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-01 Thread Klaus Jensen
On Oct 1 10:30, Keith Busch wrote: > On Thu, Oct 01, 2020 at 07:18:37PM +0200, Klaus Jensen wrote: > > OK, so I agree that it makes sense for it to be supported on a per > > namespace basis, but I think the spec is just keeping the door open for > > future namespace specific stuff in the log page

[PATCH RESEND v2 16/16] pci: Let pci_dma_write() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/include

[PATCH RESEND v2 08/16] dma: Let dma_memory_valid() take MemTxAttrs argument

2020-10-01 Thread Philippe Mathieu-Daudé
Let devices specify transaction attributes when calling dma_memory_valid(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/spapr_vio.h | 2 +- include/sysemu/dma.h | 4 ++-- 2 files changed, 3

[PATCH RESEND v2 15/16] pci: Let pci_dma_read() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/include

Re: [PATCH qemu 4/4] iotests: add test for bitmap mirror

2020-10-01 Thread Max Reitz
On 22.09.20 11:14, Fabian Grünbichler wrote: > heavily based on/practically forked off iotest 257 for bitmap backups, > but: > > - no writes to filter node 'mirror-top' between completion and > finalization, as those seem to deadlock? > - no inclusion of not-yet-available full/top sync modes in co

[PATCH RESEND v2 07/16] dma: Let dma_memory_write() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
dma_memory_rw_relaxed() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/dma.h | 22 ++ 1 file changed, 18 in

Re: [PATCH v3 0/3] add MEMORY_FAILURE event

2020-10-01 Thread Paolo Bonzini
On 30/09/20 12:04, zhenwei pi wrote: > v2->v3: > Use g_strdup_printf instead of snprintf. > Declear memory failure event as 3 parts: 'recipient', 'action', 'flags'. > Wrapper function emit_guest_memory_failure&emit_hypervisor_memory_failure. Queued, thanks. I took the liberty of adding a fourth v

[PATCH RESEND v2 11/16] dma: Let dma_memory_rw() take MemTxAttrs argument

2020-10-01 Thread Philippe Mathieu-Daudé
Let devices specify transaction attributes when calling dma_memory_rw(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h | 3 ++- include/sysemu/dma.h | 11 ++- dma-helpers.c|

[PATCH RESEND v2 06/16] dma: Let dma_memory_read() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
dma_memory_rw_relaxed() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/dma.h | 21 + 1 file changed, 17 ins

Re: [PATCH v1 03/20] s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL

2020-10-01 Thread David Hildenbrand
On 01.10.20 17:26, Richard Henderson wrote: > On 9/30/20 9:55 AM, David Hildenbrand wrote: >> +/* Multipy both even elements from v2 and v3 */ >> +read_vec_element_i64(l1, get_field(s, v2), 0, ES_64); >> +read_vec_element_i64(h1, get_field(s, v3), 0, ES_64); >> +tcg_gen_mulu2_i64(l1

[PATCH RESEND v2 03/16] dma: Document address_space_map/address_space_unmap() prototypes

2020-10-01 Thread Philippe Mathieu-Daudé
Add documentation based on address_space_map / address_space_unmap. Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/dma.h | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/inc

[Bug 1898084] [NEW] Assertion failed: (buf_len != 0), function soread, file socket.c, line 183.

2020-10-01 Thread Ophir LOJKINE
Public bug reported: I have a virtual raspberry py that I am running qemu 5.1.0 for MacOS. Here is the command line I used: qemu-system-arm \ -M versatilepb \ -cpu arm1176 \ -m 256 \ -drive file=2020-08-20-raspios-buster-armhf-lite.img,if=none,index=0,media=disk,format=raw,id=disk0 \

[PATCH RESEND v2 12/16] dma: Let dma_memory_read/write() take MemTxAttrs argument

2020-10-01 Thread Philippe Mathieu-Daudé
Let devices specify transaction attributes when calling dma_memory_read() or dma_memory_write(). Patch created mechanically using spatch with this script: @@ expression E1, E2, E3, E4; @@ ( - dma_memory_read(E1, E2, E3, E4) + dma_memory_read(E1, E2, E3, E4, MEMTXATTRS_UNSPECIFIED) |

[PATCH RESEND v2 02/16] docs/devel/loads-stores: Add regexp for DMA functions

2020-10-01 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/loads-stores.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst index 9a944ef1af..5b20f907e4 100644 --- a/docs/deve

[PATCH RESEND v2 05/16] dma: Let dma_memory_rw() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
address_space_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/dma.h | 30 ++ 1 file changed, 22

[PATCH RESEND v2 04/16] dma: Let dma_memory_set() propagate MemTxResult

2020-10-01 Thread Philippe Mathieu-Daudé
address_space_write() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/dma.h | 15 ++- dma-helpers.c| 7

[PATCH RESEND v2 01/16] pci: pass along the return value of dma_memory_rw

2020-10-01 Thread Philippe Mathieu-Daudé
From: Klaus Jensen Some might actually care about the return value of dma_memory_rw. So let us pass it along instead of ignoring it. There are no existing users of the return value, so this patch should be safe. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mich

[PATCH v2 03/16] dma: Document address_space_map/address_space_unmap() prototypes

2020-10-01 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Add documentation based on address_space_map / address_space_unmap. Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/dma.h | 29 - 1 file changed, 28 insertions(+),

[PATCH v2 02/16] docs/devel/loads-stores: Add regexp for DMA functions

2020-10-01 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/loads-stores.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst index 9a944ef1af..5b

  1   2   3   4   >