On Thu, 1 Oct 2020 at 19:21, Thomas Huth <th...@redhat.com> wrote: > > When compiling with -Werror=implicit-fallthrough, gcc complains about > missing fallthrough annotations in this file. Looking at the code, > the fallthrough is indeed wanted here, but instead of adding the > annotations, it can be done more efficiently by simply calculating > the offset with a subtraction instead of increasing a local variable > one by one. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > hw/rtc/twl92230.c | 50 +++++++++++++++++++++++------------------------ > 1 file changed, 24 insertions(+), 26 deletions(-)
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM