On 01.10.20 17:17, Richard Henderson wrote: > On 9/30/20 9:55 AM, David Hildenbrand wrote: >> + bit = !!(s390_vec_read_element8(v2, bit_nr / 8) & >> + (0x80 >> (bit_nr % 8))); > > I think this would be clearer as > > bit = (s390_vec_read_element8(v2, bit_nr / 8) > >> (7 - (bit_nr % 8))) & 1;
Can do, thanks! > > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > > r~ > -- Thanks, David / dhildenb