Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-04-30 Thread Philippe Mathieu-Daudé
On 04/30/2018 10:49 AM, Edgar E. Iglesias wrote: > On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: >> On 13 February 2018 at 04:07, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >>> Reviewed-by: Alistair Francis >> >>> @@ -39,6 +45,7 @@ int sdbus_do_comma

Re: [Qemu-devel] [PATCH] net: Fix memory leak in net_param_nic()

2018-04-30 Thread Philippe Mathieu-Daudé
On 04/30/2018 04:26 AM, Thomas Huth wrote: > The early exits in case of errors leak the memory allocated for nd_id. > Fix it by using a "goto out" to the cleanup at the end of the function > instead. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > net/net.c | 6

Re: [Qemu-devel] [PATCH] trivial: Do not include pci.h if it is not necessary

2018-04-30 Thread Philippe Mathieu-Daudé
On 04/30/2018 04:32 AM, Thomas Huth wrote: > There is no need to include pci.h in these files. > > Signed-off-by: Thomas Huth > --- > include/hw/ppc/ppc4xx.h| 2 -- > include/hw/virtio/virtio-balloon.h | 1 - > include/hw/virtio/virtio-gpu.h | 1 - > 3 files changed, 4 deletions(

Re: [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587)

2018-04-30 Thread Philippe Mathieu-Daudé
On 04/30/2018 02:01 PM, Laurent Vivier wrote: > return the result of packFloatx80() instead of > dropping it. (missed in 4b5c65b8f02). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > target/m68k/softfloat.c | 3 ++- > 1 file changed, 2 insertions(+

Re: [Qemu-devel] [PATCH 2/7] hw/rdma: Fix possible usage of a NULL pointer

2018-04-30 Thread Philippe Mathieu-Daudé
On 04/30/2018 05:02 PM, Marcel Apfelbaum wrote: > Coverity CID 1390586; The cq handle is provided by the guest > and cannot be trusted to be previuosly allocated. > Fix it by exiting the completion flow. > > Reported-by: Peter Maydell > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Yuval Shaia

[Qemu-devel] [Bug 1762179] Re: Record and replay replay fails with: "ERROR:replay/replay-time.c:49:replay_read_clock: assertion failed"

2018-04-30 Thread Arnabjyoti Kalita
@Ciro, I hope this solves the problem for me too. Thanks for highlighting the patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1762179 Title: Record and replay replay fails with: "ERROR:replay

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread David Gibson
On Mon, Apr 30, 2018 at 08:28:35AM -0600, Alex Williamson wrote: > On Mon, 30 Apr 2018 14:35:20 +0100 > Peter Maydell wrote: > > > On 30 April 2018 at 14:08, Paolo Bonzini wrote: > > > On 30/04/2018 14:57, Peter Maydell wrote: > > >> On 30 April 2018 at 13:54, Paolo Bonzini wrote: > > >>> O

Re: [Qemu-devel] [RFC PATCH 2/7] avocado: Update python scripts to upstream codebase

2018-04-30 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > QEMUMachine arguments member is called '_args'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/qemu.py| 14 +++--- > tests/avocado/avocado_qemu/test.py | 12 ++-- > tests/qemu-iotests/iotests.p

Re: [Qemu-devel] [RFC PATCH 0/7] avocado: Add acceptance tests parsing the Linux boot console

2018-04-30 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > Hi, > > While previously working on a Super I/O refactor, I encountered some problems > at runtime, after building the codebase successfully and running qtests. > I had to manually start to boot different guests and check the bootlog. > >

Re: [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches

2018-04-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180430091037.13878-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 00/42] Linux user for 2.13 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log -

Re: [Qemu-devel] [PATCH v2 0/3] NBD export bitmaps

2018-04-30 Thread Eric Blake
On 04/13/2018 01:13 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all. This is a proposal and realization of new NBD meta context: qemu. (I hope to send corresponding proposal to NBD protocol soon) New possible queries will look like: qemu:dirty-bitmap: qapi/block.json | 23 + inc

Re: [Qemu-devel] [PATCH 7/7] hw/rdma: Fix possible out of bounds access to port GID index

2018-04-30 Thread Eric Blake
On 04/30/2018 03:02 PM, Marcel Apfelbaum wrote: Make sure the backend GID index is less then port's git table length. s/git/gid/ Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdm

[Qemu-devel] [PATCH] target/tricore: Fix QEMU crashing when using -singlestep

2018-04-30 Thread Bastian Koppelmann
when -singlestep is enabled we will actually return a tb->size of 0, even though we emit one instruction. This is because we do the update to ctx.pc after exiting the translation loop on the singlestep path. Therefore we substract pc_start from ctx.pc, aka pc_start. Signed-off-by: Bastian Koppelma

[Qemu-devel] [PATCH 7/7] hw/rdma: Fix possible out of bounds access to port GID index

2018-04-30 Thread Marcel Apfelbaum
Make sure the backend GID index is less then port's git table length. Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 5c7b3d8949..e9ced6f

[Qemu-devel] [PATCH 6/7] hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME

2018-04-30 Thread Marcel Apfelbaum
From: Yuval Shaia By a mistake this constant was defined twice - remove the duplication. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 2 -- hw/rdma/rdma_rm_defs.h | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/rdma/rdma_rm.

[Qemu-devel] [PATCH 2/7] hw/rdma: Fix possible usage of a NULL pointer

2018-04-30 Thread Marcel Apfelbaum
Coverity CID 1390586; The cq handle is provided by the guest and cannot be trusted to be previuosly allocated. Fix it by exiting the completion flow. Reported-by: Peter Maydell Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 1 + 1 file changed, 1 ins

[Qemu-devel] [PATCH 5/7] hw/rdma: Fix possible out of bounds access to regs array

2018-04-30 Thread Marcel Apfelbaum
From: Yuval Shaia Coverity (CID1390589, CID1390608). Array size is RDMA_BAR1_REGS_SIZE, let's make sure the given address is in range. While there also: 1. Adjust the size of this bar to reasonable size 2. Report the size of the array with sizeof(array) Reported-by: Peter Maydell Signed-off-by

[Qemu-devel] [PATCH 0/7] hw/rdma: coverity fixes

2018-04-30 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Various fixes that were found by coverity. (run by Peter, thanks!) Thanks, Marcel Marcel Apfelbaum (3): hw/rdma: Fix possible munmap call on a NULL pointer hw/rdma: Fix possible usage of a NULL pointer hw/rdma: Fix possible out of bounds access to port GID index Yu

[Qemu-devel] [PATCH 4/7] hw/rdma: Fix possible out of bounds access to GID table

2018-04-30 Thread Marcel Apfelbaum
From: Yuval Shaia Array size is MAX_PORT_GIDS, let's make sure the given index is in range. While there limit device table size to 1. Reported-by: Peter Maydell Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm_defs.h | 2 +- hw/rdma/vmw/pvrdma_cmd.c | 8 ++-

[Qemu-devel] [PATCH 1/7] hw/rdma: Fix possible munmap call on a NULL pointer

2018-04-30 Thread Marcel Apfelbaum
Coverity CID 1390620: we call munmap() on a NULL pointer. Reported-by: Peter Maydell Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c ind

[Qemu-devel] [PATCH 3/7] hw/rdma: Delete port's pkey table

2018-04-30 Thread Marcel Apfelbaum
From: Yuval Shaia Support for PKEY is not yet implemented. Removing the unneeded table until a support will be added. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm_defs.h| 3 +-- hw/rdma/vmw/pvrdma_main.c | 15 --- 2 files changed, 1 insertion(+

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-30 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Tue, Apr 03, 2018 at 03:49:07PM +0200, Igor Mammedov wrote: > > On Thu, 29 Mar 2018 13:57:54 -0300 > > Eduardo Habkost wrote: > > > > [...] > > > > As for the future, I agree it would be much more flexible > > > > to allow both -preconfig and -i

[Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-04-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" During a TLS connect we see: migration_channel_connect calls migration_tls_channel_connect (calls after TLS setup) migration_channel_connect My previous error handling fix made migration_channel_connect call migrate_fd_connect in all cases; unfortunately th

Re: [Qemu-devel] [RFC PATCH 00/11] iommu: add MemTxAttrs argument to IOMMU translate function

2018-04-30 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180430181905.32327-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [RFC PATCH 00/11]

Re: [Qemu-devel] [RFC PATCH 00/11] iommu: add MemTxAttrs argument to IOMMU translate function

2018-04-30 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180430181905.32327-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [RFC PATCH 00/11] io

Re: [Qemu-devel] [RFC PATCH 00/11] iommu: add MemTxAttrs argument to IOMMU translate function

2018-04-30 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180430181905.32327-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [RFC PATCH 00/11] iommu: add MemTxAttrs argument to IOMMU translate function === TEST SCRIPT BEGIN === #!/bin/bash # Tes

Re: [Qemu-devel] [PULL 11/13] migration: add postcopy migration of dirty bitmaps

2018-04-30 Thread John Snow
On 04/27/2018 09:22 AM, Peter Maydell wrote: > On 13 March 2018 at 21:14, John Snow wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated. >> >> If destination qemu is already containing a dirty bitmap with the same name >>

[Qemu-devel] [RFC PATCH 01/11] Make address_space_translate() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_translate(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/memory.h | 4 +++- a

[Qemu-devel] [RFC PATCH 07/11] Make flatview_access_valid() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_access_valid(). Its callers now all have an attrs value to hand, so we can correct our earlier temporary use of MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- exec.c | 11 +-

[Qemu-devel] [RFC PATCH 11/11] Add MemTxAttrs argument to IOMMU translate function

2018-04-30 Thread Peter Maydell
Add a MemTxAttrs argument to the IOMMU translate function; this is necessary for IOMMU implementations that care about transaction attributes such as user/privileged or secure/nonsecure when deciding whether a transaction is permitted. Signed-off-by: Peter Maydell --- include/exec/memory.h|

[Qemu-devel] [Bug 1745312] Re: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

2018-04-30 Thread Mario
I have a similar bug: 1674114 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1745312 Title: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issue

[Qemu-devel] [RFC PATCH 06/11] Make MemoryRegion valid.accepts callback take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to the MemoryRegion valid.accepts callback. We'll need this for subpage_accepts(). We could take the approach we used with the read and write callbacks and add new a new _with_attrs version, but since

[Qemu-devel] [RFC PATCH 10/11] Make flatview_do_translate() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_do_translate(). Signed-off-by: Peter Maydell --- exec.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index c29bf47ce2..9c6d9aae28 100644 --

[Qemu-devel] [RFC PATCH 02/11] Make address_space_map() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_map(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/memory.h | 3 ++- include/sys

[Qemu-devel] [RFC PATCH 09/11] Make address_space_get_iotlb_entry() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_get_iotlb_entry(). Signed-off-by: Peter Maydell --- include/exec/memory.h | 2 +- exec.c| 2 +- hw/virtio/vhost.c | 3 ++- 3 files changed, 4 insertions(+), 3 del

[Qemu-devel] [RFC PATCH 04/11] Make flatview_extend_translation() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_extend_translation(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- exec.c | 8 1 file change

[Qemu-devel] [RFC PATCH 03/11] Make address_space_access_valid() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to address_space_access_valid(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. Signed-off-by: Peter Maydell --- include/exec/memory.h | 4 +++-

[Qemu-devel] [RFC PATCH 00/11] iommu: add MemTxAttrs argument to IOMMU translate function

2018-04-30 Thread Peter Maydell
This is an RFC patchset because it's a little bit unmotivated and only lightly tested, but in principle it could be committed, so half-RFC-half-not :-) The Arm SMMU wants to know if the transaction it is handling is secure/nonsecure and user/privileged, because the iommu page tables can be configu

[Qemu-devel] [RFC PATCH 05/11] Make memory_region_access_valid() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to memory_region_access_valid(). Its callers either have an attrs value to hand, or don't care and can use MEMTXATTRS_UNSPECIFIED. The callsite in flatview_access_valid() is part of a recursive loop fl

[Qemu-devel] [RFC PATCH 08/11] Make flatview_translate() take a MemTxAttrs argument

2018-04-30 Thread Peter Maydell
As part of plumbing MemTxAttrs down to the IOMMU translate method, add MemTxAttrs as an argument to flatview_translate(); all its callers now have attrs available. Signed-off-by: Peter Maydell --- include/exec/memory.h | 7 --- exec.c| 17 + 2 files changed,

Re: [Qemu-devel] How to check if Vt-d is capable of posted-interrupt?

2018-04-30 Thread Jintack Lim
On Mon, Apr 30, 2018 at 2:09 PM, Alex Williamson wrote: > On Mon, 30 Apr 2018 13:44:23 -0400 > Jintack Lim wrote: > >> Add iommu mailing list since this question might be more related to iommu. >> >> On Mon, Apr 30, 2018 at 10:11 AM, Jintack Lim >> wrote: >> > Hi, >> > >> > I wonder how to chec

Re: [Qemu-devel] How to check if Vt-d is capable of posted-interrupt?

2018-04-30 Thread Alex Williamson
On Mon, 30 Apr 2018 13:44:23 -0400 Jintack Lim wrote: > Add iommu mailing list since this question might be more related to iommu. > > On Mon, Apr 30, 2018 at 10:11 AM, Jintack Lim wrote: > > Hi, > > > > I wonder how to check if Vt-d is capable of posted-interrupt? I'm > > using Intel E5-2630 v

[Qemu-devel] [PATCH v4 3/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files

2018-04-30 Thread Thomas Huth
'vlan' is very confusing since it does not mean something like IEEE 802.1Q, but rather emulated hubs, so let's switch to that terminology instead. While we're at it, move the subsection about hub a little bit downward in the documentation (it's not as important anymore as it was before the inventio

[Qemu-devel] [PATCH v4 1/3] net: Remove the deprecated "vlan" parameter

2018-04-30 Thread Thomas Huth
It's been marked as deprecated since QEMU v2.9.0, so that should have been enough time for everybody to either just drop unnecessary "vlan=0" parameters, to switch to the modern -device + -netdev syntax for connecting guest NICs with host network backends, or to switch to the "hubport" netdev in ca

[Qemu-devel] [PATCH v4 2/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files

2018-04-30 Thread Thomas Huth
'vlan' is very confusing since it does not mean something like IEEE 802.1Q, but rather emulated hubs, so let's switch to that terminology instead. Buglink: https://bugs.launchpad.net/qemu/+bug/658904 Reviewed-by: Stefan Hajnoczi Signed-off-by: Thomas Huth --- net/hub.c | 7 +++ net/slirp.

[Qemu-devel] [PATCH v4 0/3] net: Get rid of 'vlan'

2018-04-30 Thread Thomas Huth
The 'vlan' term caused a lot of confusion and misconfigurations in the past. The parameter has been marked as deprecated since QEMU v2.9.0, so it's now time to finally remove the parameter and use the better word "hub" in the remaining spots that actually mean the QEMU emulated hub feature. v4: -

Re: [Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 18:44, Alex Bennée wrote: > Peter Maydell writes: >> An ideal long term approach would be to rearrange the CPU state >> so that the tlb_table was not so far along it, but this is tricky >> because it would move it from the "not cleared on CPU reset" part >> of the struct to th

Re: [Qemu-devel] [PULL 4/5] usb-mtp: Introduce write support for MTP objects

2018-04-30 Thread Bandan Das
Peter Maydell writes: > On 27 February 2018 at 08:39, Gerd Hoffmann wrote: >> From: Bandan Das >> >> Allow write operations on behalf of the initiator. The >> precursor to write is the sending of the write metadata >> that consists of the ObjectInfo dataset. This patch introduces >> a flag that

Re: [Qemu-devel] How to check if Vt-d is capable of posted-interrupt?

2018-04-30 Thread Jintack Lim
Add iommu mailing list since this question might be more related to iommu. On Mon, Apr 30, 2018 at 10:11 AM, Jintack Lim wrote: > Hi, > > I wonder how to check if Vt-d is capable of posted-interrupt? I'm > using Intel E5-2630 v3. > > I was once told that APICv and posted-interrupt capability alwa

Re: [Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-30 Thread Alex Bennée
Peter Maydell writes: > The MIPS TCG target makes the assumption that the offset from the > target env pointer to the tlb_table is less than about 64K. This > used to be true, but gradual addition of features to the Arm > target means that it's no longer true there. This results in > the build-t

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Thomas Huth
On 30.04.2018 13:21, Cornelia Huck wrote: > On Mon, 30 Apr 2018 11:33:12 +0100 > Daniel P. Berrangé wrote: [...] >> Given, that we have a clear deprecation process now, my view is that >> we should formally declare that major version numbers changes are >> meaningless. As soon as you try to assign

Re: [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587)

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 18:01, Laurent Vivier wrote: > return the result of packFloatx80() instead of > dropping it. > > Signed-off-by: Laurent Vivier > --- > target/m68k/softfloat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/m68k/softfloat.c b/target/m68k/soft

Re: [Qemu-devel] [PATCH 2/2] m68k: remove dead code (Coverity CID1390617)

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 18:01, Laurent Vivier wrote: > floatx80_sin() and floatx80_cos() are derived from one > sincos() function. They have both unused code coming from > their common origin. Remove it. > > Signed-off-by: Laurent Vivier > --- > target/m68k/softfloat.c | 43 ++---

[Qemu-devel] [PATCH 2/2] m68k: remove dead code (Coverity CID1390617)

2018-04-30 Thread Laurent Vivier
floatx80_sin() and floatx80_cos() are derived from one sincos() function. They have both unused code coming from their common origin. Remove it. Signed-off-by: Laurent Vivier --- target/m68k/softfloat.c | 43 ++- 1 file changed, 14 insertions(+), 29 deleti

[Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587)

2018-04-30 Thread Laurent Vivier
return the result of packFloatx80() instead of dropping it. Signed-off-by: Laurent Vivier --- target/m68k/softfloat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c index dffb371c71..2c069a5efb 100644 --- a/target/m68k/soft

Re: [Qemu-devel] [PATCH 5/5] iotests: Let 216 make use of qemu-io's exit code

2018-04-30 Thread Eric Blake
On 04/28/2018 09:41 AM, Max Reitz wrote: As a showcase of how you can use qemu-io's exit code to determine success or failure (same for qemu-img), this test is changed to use qemu_io_silent() instead of qemu_io(), and to assert the exit code instead of logging the filtered result. One real advan

Re: [Qemu-devel] [PATCH 4/5] iotests.py: Add qemu_io_silent

2018-04-30 Thread Eric Blake
On 04/28/2018 09:41 AM, Max Reitz wrote: With qemu-io now returning a useful exit code, some tests may find it sufficient to just query that instead of logging (and filtering) the whole output. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 9 + 1 file changed, 9 insert

Re: [Qemu-devel] [PATCH 3/5] qemu-io: Exit with error when a command failed

2018-04-30 Thread Eric Blake
On 04/28/2018 09:41 AM, Max Reitz wrote: Currently, qemu-io basically always returns success when it gets to interactive mode (so once the whole command line has been parsed; even before the commands on the command line are interpreted). That is not very useful. This patch makes qemu-io return

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-04-30 Thread Roger Pau Monné
On Mon, Apr 30, 2018 at 01:01:37PM +0100, Paul Durrant wrote: > The grant copy operation was added to libxengnttab in Xen 4.8.0. If grant > copy is available then data from the guest will be copied rather than > mapped. > The xen_disk source can be significantly simplified by removing this now > re

Re: [Qemu-devel] [PULL v1 0/5] Xilinx queue 2018-04-30

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 16:08, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The following changes since commit 6f0c4706b35dead265509115ddbd2a8d1af516c1: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180427-pull-request' into staging (2018-04-27 > 12:27:59 +0100) > > ar

Re: [Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting

2018-04-30 Thread Eric Blake
On 04/28/2018 07:37 AM, Pavel Dovgalyuk wrote: In the subject: s/exitting/exiting/ This patch adds events processing when emulation finishes instead of just cleaning the queue. Now the bdrv coroutines will be in consistent state when emulator closes. It allows correct polling of the block layer

Re: [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot deletion

2018-04-30 Thread Eric Blake
On 04/28/2018 11:34 AM, Max Reitz wrote: This adds a test for an I/O error during snapshot deletion, and maybe more importantly, for how to repair the resulting image. If the snapshot has been deleted before the error occurs, the only negative result will be leaked clusters -- and those should b

Re: [Qemu-devel] [PATCH] trivial: Do not include pci.h if it is not necessary

2018-04-30 Thread Michael S. Tsirkin
On Mon, Apr 30, 2018 at 09:32:19AM +0200, Thomas Huth wrote: > There is no need to include pci.h in these files. > > Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin > --- > include/hw/ppc/ppc4xx.h| 2 -- > include/hw/virtio/virtio-balloon.h | 1 - > include/hw/virtio/vi

Re: [Qemu-devel] [PATCH 2/9] target/arm: Implement vector shifted FCVT for fp16

2018-04-30 Thread Alex Bennée
Richard Henderson writes: > While we have some of the scalar paths for FCVT for fp16, > we failed to decode the fp16 version of these instructions. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 65 > -- > 1 file changed,

Re: [Qemu-devel] [PATCH 1/2] qcow2: Repair OFLAG_COPIED when fixing leaks

2018-04-30 Thread Eric Blake
On 04/28/2018 11:34 AM, Max Reitz wrote: Repairing OFLAG_COPIED is usually safe because it is done after the refcounts have been repaired. Therefore, it we did not find anyone else referencing a data or L2 cluster, it makes no sense to not set OFLAG_COPIED -- and the other direction (clearing OF

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-04-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 April 2018 16:12 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu- > de...@nongnu.org; Anthony Perard ; Kevin > Wolf ; Stefano Stabellini ; Max > Reitz > Subject: Re: [Xen-devel] [PATCH 2/4] block/

Re: [Qemu-devel] [PULL 01/46] memfd: fix configure test

2018-04-30 Thread Greg Kurz
This one is needed to build QEMU 2.11.x on Ubuntu 18.04. On Wed, 20 Dec 2017 18:14:13 +0100 Paolo Bonzini wrote: > Recent glibc added memfd_create in sys/mman.h. This conflicts with > the definition in util/memfd.c: > > /builddir/build/BUILD/qemu-2.11.0-rc1/util/memfd.c:40:12: error: stati

Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-04-30 Thread Su Hang
> A malicious input file can control the following values: > * record_index using whitespace (see "case default" below) > * byte_count in range [0x00, 0xff] > * our_checksum = 0 by choosing the right address field values Oh, that is really a disaster... Thanks for your review. Su Hang > -

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-04-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 April 2018 16:28 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu- > de...@nongnu.org; Anthony Perard ; Kevin > Wolf ; Stefano Stabellini ; Max > Reitz > Subject: Re: [Xen-devel] [PATCH 2/4] block/

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap

2018-04-30 Thread Roger Pau Monné
On Mon, Apr 30, 2018 at 04:16:52PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 30 April 2018 16:12 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu- > > de...@nongnu.org; Anthony Perard ; Kevin > > Wolf ; Ste

[Qemu-devel] [Bug 1766841] Re: QEMU 2.12 Running Problem in Windows 7 Installation

2018-04-30 Thread Stefan Weil
Both messages are warnings – QEMU will work nevertheless. The first warning can be fixed as the message says (that needs an additional installation of Cygwin for gdk-pixbuf-query-loaders). It is also suppressed if there is an empty file loaders.cache. Newer installers (for example those from today

[Qemu-devel] [PULL v1 5/5] target-microblaze: mmu: Make the TLBX MISS bit read-only

2018-04-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make the TLBX MISS bit read-only. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c inde

Re: [Qemu-devel] [PATCH 2/5] qemu-io: Let command functions return error code

2018-04-30 Thread Max Reitz
On 2018-04-30 17:08, Eric Blake wrote: > On 04/28/2018 09:41 AM, Max Reitz wrote: >> This is basically what everything else in the qemu code base does, so we >> can do it here, too. >> >> Signed-off-by: Max Reitz >> --- >>   include/qemu-io.h |   4 +- >>   qemu-io-cmds.c    | 346 >> ++

[Qemu-devel] [PULL v1 3/5] target-microblaze: Don't clobber the IMM reg for ld/st reversed

2018-04-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Do not clobber the IMM register on reversed load/stores. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate

[Qemu-devel] [PULL v1 2/5] target-microblaze: Fix trap checks for FPU insns

2018-04-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fix trap checks for FPU insns when extended FPU insns are enabled. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tar

[Qemu-devel] [Bug 1766841] Re: QEMU 2.12 Running Problem in Windows 7 Installation

2018-04-30 Thread Stefan Weil
** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1766841 Title: QE

[Qemu-devel] [PULL v1 0/5] Xilinx queue 2018-04-30

2018-04-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 6f0c4706b35dead265509115ddbd2a8d1af516c1: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180427-pull-request' into staging (2018-04-27 12:27:59 +0100) are available in the git repository at: g...@github.com:edgarigl/qem

[Qemu-devel] [PULL v1 4/5] target-microblaze: mmu: Make TLBSX write-only

2018-04-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make TLBSX write-only and guest-error log reads from it. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/microbla

[Qemu-devel] [PULL v1 1/5] target-microblaze: Respect MSR.PVR as read-only

2018-04-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Respect MSR.PVR as read-only. We were wrongly overwriting the PVR bit. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c

Re: [Qemu-devel] [PATCH 2/5] qemu-io: Let command functions return error code

2018-04-30 Thread Eric Blake
On 04/28/2018 09:41 AM, Max Reitz wrote: This is basically what everything else in the qemu code base does, so we can do it here, too. Signed-off-by: Max Reitz --- include/qemu-io.h | 4 +- qemu-io-cmds.c| 346 -- qemu-io.c |

Re: [Qemu-devel] Large patch set advice

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 15:44, Warner Losh wrote: > The testing aspect has me intrigued. How hard would it be to add testing > done for bsd-user to your upstream tests? Before this project, I've only > ever been a qemu user, and even then only around the edges so I'm not > familiar with what's availab

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 15:34, Peter Maydell wrote: >> */ >> IOMMUTLBEntry (*translate)(IOMMUMemoryRegion *iommu, hwaddr addr, >> IOMMUAccessFlags flag); > A question I just thought of -- how long is the IOMMUTLBEntry I get > back guaranteed to be valid for? For ins

Re: [Qemu-devel] [PATCH 1/5] qemu-io: Drop command functions' return values

2018-04-30 Thread Eric Blake
On 04/28/2018 09:41 AM, Max Reitz wrote: For qemu-io, a function returns an integer with two possible values: 0 for "qemu-io may continue execution", or 1 for "qemu-io should exit". However, there is only a single command that returns 1, and that is "quit". So let's turn this case into a global

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

2018-04-30 Thread Eric Blake
On 04/27/2018 10:51 PM, Peter Xu wrote: QTAILQ_INIT(&qmp_cap_negotiation_commands); qmp_register_command(&qmp_cap_negotiation_commands, "qmp_capabilities", - qmp_marshal_qmp_capabilities, QCO_NO_OPTIONS); + qmp_marshal_qmp_capabilities,

Re: [Qemu-devel] Large patch set advice

2018-04-30 Thread Warner Losh
On Thu, Apr 26, 2018 at 2:11 AM, Peter Maydell wrote: > On 25 April 2018 at 20:57, Warner Losh wrote: > > I’ve foolishly volunteered to rebase all the changes that the bad-user > > mode folks have done to a recent master rev to get these changes > upstreamed. > > A number of people have been wor

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-04-30 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180430065235.577-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific === TEST SCRIPT BEGIN === #!/bin/bash # Testing script

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 04:23:59PM +0200, Greg Kurz wrote: > On Fri, 27 Apr 2018 16:51:03 +0100 > Peter Maydell wrote: > > > Hi; I usually let people forget about releases for a month or > > so before bringing this topic up, but: > > > > (1) do we want to call the next release 2.13, or something

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 15:23, Greg Kurz wrote: > On Fri, 27 Apr 2018 16:51:03 +0100 > Peter Maydell wrote: > >> Hi; I usually let people forget about releases for a month or >> so before bringing this topic up, but: >> >> (1) do we want to call the next release 2.13, or something else? >> There's no

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Alex Williamson
On Mon, 30 Apr 2018 14:35:20 +0100 Peter Maydell wrote: > On 30 April 2018 at 14:08, Paolo Bonzini wrote: > > On 30/04/2018 14:57, Peter Maydell wrote: > >> On 30 April 2018 at 13:54, Paolo Bonzini wrote: > >>> On 30/04/2018 14:24, Peter Maydell wrote: > -/* Set this up to provid

Re: [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging

2018-04-30 Thread Pavel Dovgalyuk
I'll try to reproduce it next week. ⁣Отправлено с помощью BlueMail ​ На 30 Апр 2018 г., 17:20, в 17:20, Ciro Santilli написал:п>Did you manage to reproduce and solve the savevm and loadvm problems I >mentioned at: >http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg05219.html >? > >I st

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-04-30 Thread Greg Kurz
On Fri, 27 Apr 2018 16:51:03 +0100 Peter Maydell wrote: > Hi; I usually let people forget about releases for a month or > so before bringing this topic up, but: > > (1) do we want to call the next release 2.13, or something else? > There's no particular reason to bump to 3.0 except some combinat

Re: [Qemu-devel] [PATCH v6 1/2] Implement .hex file loader

2018-04-30 Thread Stefan Hajnoczi
On Thu, Apr 26, 2018 at 09:51:37PM +0800, Su Hang wrote: > if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64) && kernel_size < 0) { > kernel_size = load_aarch64_image(info->kernel_filename, > info->loader_start, &entry, as); > is_linux =

Re: [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging

2018-04-30 Thread Ciro Santilli
Did you manage to reproduce and solve the savevm and loadvm problems I mentioned at: http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg05219.html ? I still observe them on the current patch. On Sat, Apr 28, 2018 at 1:36 PM, Pavel Dovgalyuk wrote: > GDB remote protocol supports reverse

Re: [Qemu-devel] [PATCH v2 for 2.13] migration: Don't activate block devices if using -S

2018-04-30 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Activating the block devices causes the locks to be taken on > the backing file. If we're running with -S and the destination libvirt > hasn't started the destination with 'cont', it's expecting the locks are > still unta

[Qemu-devel] How to check if Vt-d is capable of posted-interrupt?

2018-04-30 Thread Jintack Lim
Hi, I wonder how to check if Vt-d is capable of posted-interrupt? I'm using Intel E5-2630 v3. I was once told that APICv and posted-interrupt capability always come together. But it seems like my cpu support APICv (/sys/module/kvm_intel/parameters/enable_apicv is Y), but posted-interrupt capabili

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-04-30 Thread Edgar E. Iglesias
On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: > On 13 February 2018 at 04:07, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: Alistair Francis > > > @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, > > uint8_t *respo

Re: [Qemu-devel] [PATCH v1 1/2] xlnx-zdma: Add a model of the Xilinx ZynqMP generic DMA

2018-04-30 Thread Edgar E. Iglesias
On Sun, Apr 29, 2018 at 02:43:28AM +0200, Francisco Iglesias wrote: > Add a model of the generic DMA found on Xilinx ZynqMP. Hi Francisco, I think we need to look at the VMStateDescription, some state seems to be missing... Cheers, Edgar > > Signed-off-by: Francisco Iglesias > Signed-off-by

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check

2018-04-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180430124651.10340-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] KVM call for 2018 - 05 - 08

2018-04-30 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday 07, I will send an email with the agenda or the cancellation of the call, so hurry up. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 14:08, Paolo Bonzini wrote: > On 30/04/2018 14:57, Peter Maydell wrote: >> On 30 April 2018 at 13:54, Paolo Bonzini wrote: >>> On 30/04/2018 14:24, Peter Maydell wrote: -/* Set this up to provide customized IOMMU replay function */ +/* Set this up to provide

  1   2   3   >