On 04/27/2018 10:51 PM, Peter Xu wrote:
QTAILQ_INIT(&qmp_cap_negotiation_commands);
qmp_register_command(&qmp_cap_negotiation_commands, "qmp_capabilities",
- qmp_marshal_qmp_capabilities, QCO_NO_OPTIONS);
+ qmp_marshal_qmp_capabilities,
+ QCO_ALLOWED_IN_PRECONFIG);
...why are we still special-casing the registration of qmp_capabilities
here...
My understanding is that we have two lists:
QmpCommandList qmp_commands, qmp_cap_negotiation_commands;
And here it only registers with qmp_commands list via:
qmp_init_marshal(&qmp_commands);
But not for the other one, which is explicitly registered at [1]. So
it seems that [1] is still needed?
Ah, that makes sense. I overlooked the difference in list name in the
first parameter to qmp_register_command(), since that line was not
changed in the diff.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
