On 04/30/2018 04:32 AM, Thomas Huth wrote: > There is no need to include pci.h in these files. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > include/hw/ppc/ppc4xx.h | 2 -- > include/hw/virtio/virtio-balloon.h | 1 - > include/hw/virtio/virtio-gpu.h | 1 - > 3 files changed, 4 deletions(-) > > diff --git a/include/hw/ppc/ppc4xx.h b/include/hw/ppc/ppc4xx.h > index cb0bb55..3a2a04c 100644 > --- a/include/hw/ppc/ppc4xx.h > +++ b/include/hw/ppc/ppc4xx.h > @@ -25,8 +25,6 @@ > #ifndef PPC4XX_H > #define PPC4XX_H > > -#include "hw/pci/pci.h" > - > /* PowerPC 4xx core initialization */ > PowerPCCPU *ppc4xx_init(const char *cpu_model, > clk_setup_t *cpu_clk, clk_setup_t *tb_clk,
"ppc4xx.h" misses various includes... > diff --git a/include/hw/virtio/virtio-balloon.h > b/include/hw/virtio/virtio-balloon.h > index 1ea13bd..e0df352 100644 > --- a/include/hw/virtio/virtio-balloon.h > +++ b/include/hw/virtio/virtio-balloon.h > @@ -17,7 +17,6 @@ > > #include "standard-headers/linux/virtio_balloon.h" > #include "hw/virtio/virtio.h" > -#include "hw/pci/pci.h" > > #define TYPE_VIRTIO_BALLOON "virtio-balloon-device" > #define VIRTIO_BALLOON(obj) \ > diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h > index 22ac3c2..79bb3fb 100644 > --- a/include/hw/virtio/virtio-gpu.h > +++ b/include/hw/virtio/virtio-gpu.h > @@ -18,7 +18,6 @@ > #include "ui/qemu-pixman.h" > #include "ui/console.h" > #include "hw/virtio/virtio.h" > -#include "hw/pci/pci.h" > #include "qemu/log.h" > > #include "standard-headers/linux/virtio_gpu.h" > Weirdness of virtio-gpu.h, it uses VIRTIO_PCI_FLAG_USE_IOEVENTFD which is defined in the local hw/virtio/virtio-pci.h (local = not under include/) Anyway any of those requires "hw/pci/pci.h", so: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
