Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-03 Thread Alexander Graf
On 04.02.2014, at 01:44, Peter Maydell wrote: > On 3 February 2014 23:28, Alexander Graf wrote: >> That means that something relies on the incorrect behavior we did >> before to set *plen (end) = *plen (start) after the loop when >> !mr->iommu_ops. I wonder what that could be... > > I bounced

Re: [Qemu-devel] [PATCH] PPC: KVM: suppress warnings about not supported SPRs

2014-02-03 Thread Alexey Kardashevskiy
On 02/04/2014 06:38 PM, Alexander Graf wrote: > > On 04.02.2014, at 05:12, Alexey Kardashevskiy wrote: > >> PR KVM lacks support of many SPRs in set/get one register API but it does s/does/does not/g sorry 8-) >> really break PR KVM. So convert them to switchable traces for now. >> >> Signed

Re: [Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-03 Thread Michael Tokarev
03.02.2014 18:45, Gerd Hoffmann wrote: > Hi, > > Sorry for the delay folks, totally forgot that one. > Here is the seabios update to 1.7.4 final. FWIW, we updated seabios in Debian testing (with qemu 1.7), and now there are several bugs filed in Debian BTS, at least: http://bugs.debian.org/73

Re: [Qemu-devel] [PATCH] PPC: KVM: suppress warnings about not supported SPRs

2014-02-03 Thread Alexander Graf
On 04.02.2014, at 05:12, Alexey Kardashevskiy wrote: > PR KVM lacks support of many SPRs in set/get one register API but it does > really break PR KVM. So convert them to switchable traces for now. > > Signed-off-by: Alexey Kardashevskiy Thanks, applied this patch instead of mine. Alex

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Don't tell the user about missing SPR syncs

2014-02-03 Thread Alexander Graf
On 04.02.2014, at 03:05, Alexey Kardashevskiy wrote: > On 02/04/2014 08:53 AM, Alexander Graf wrote: >> We sync a lot of SPRs automatically between KVM and QEMU now. Some >> of these only matter on newer hardware, some only matter on HV KVM. >> >> With the current code runnign on my reasonably

[Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2014-02-03 Thread Matt Keith
Thanks for posting your script Tobias, I'm having the same problem on Fedora 20 and the script alleviates the symptom. Matt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1174654 Title: qemu-system

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-02-03 Thread Aneesh Kumar K.V
"Michael S. Tsirkin" writes: > On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kumar K.V wrote: >> "Michael S. Tsirkin" writes: >> >> > Haven't used 9pfs in a while. >> > I thought these patches are a good time to play with it some more. >> > I have encountered two issues. >> > >> > What I'm d

[Qemu-devel] migration: broken ram_save_pending

2014-02-03 Thread Alexey Kardashevskiy
Hi! I hit a problem with migration which I would like to know how to fix. I run the source QEMU as this: ./qemu-system-ppc64 -enable-kvm -m 1024 -machine pseries \ -nographic -vga none For the destination, I add "-incoming tcp:localhost:4000". Both run on the same POWER8 machine, the la

[Qemu-devel] Hardware Interrupt handling

2014-02-03 Thread Ayaz Akram
According to my understanding of interrupt handling mechanism in QEMU, when some external interrupt comes, related device emulation code (e.g. kbd_update_irq in pckbd.c ---> qemu_set_irq> ) runs in vcpu thread and io-thread when finds that some interrupt has occured sends signal to

Re: [Qemu-devel] qemu segfauls with spiceport chardev and isa-serial

2014-02-03 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 11:40:41AM +1000, Peter Crosthwaite wrote: > On Tue, Feb 4, 2014 at 4:45 AM, Dr. David Alan Gilbert > wrote: > > (cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo change > > - see below!) > > > > * Martin Kletzander (mklet...@redhat.com) wrote: > >> Hell

[Qemu-devel] [PATCH] misc: Fix case Qemu -> QEMU

2014-02-03 Thread Stefan Weil
Signed-off-by: Stefan Weil --- scripts/switch-timer-api |2 +- tests/i440fx-test.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api index a369a08..b0e230b 100755 --- a/scripts/switch-timer-api +++ b/scripts/swit

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-03 Thread Kazuya Saito
(2014/01/31 19:37), Stefan Hajnoczi wrote:> On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: > > Okay, more feedback after looking at the rest of the patch. Thank you for the feedback. > I think "ust" backend support will simplify the patch a little (see > details below). I'll try

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-03 Thread Kazuya Saito
(2014/01/31 6:00), Stefan Hajnoczi wrote:> On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: > > Some initial comments, I will continue reviewing tomorrow. Thank you for your comment. >> This patch implements "multi tracing backend" which enables several >> tracing backend simultaneo

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-02-03 Thread Paolo Bonzini
Il 23/01/2014 17:23, Wei Liu ha scritto: On Thu, Jan 23, 2014 at 01:54:40PM +, Wei Liu wrote: On Thu, Jan 23, 2014 at 10:11:57AM +0100, Paolo Bonzini wrote: Il 22/01/2014 17:09, Wei Liu ha scritto: On Wed, Jan 22, 2014 at 11:20:38AM +0100, Paolo Bonzini wrote: Il 21/01/2014 19:27, Wei Liu

[Qemu-devel] [PATCH] PPC: KVM: suppress warnings about not supported SPRs

2014-02-03 Thread Alexey Kardashevskiy
PR KVM lacks support of many SPRs in set/get one register API but it does really break PR KVM. So convert them to switchable traces for now. Signed-off-by: Alexey Kardashevskiy --- We use this patch internally for the same purpose. --- target-ppc/kvm.c | 7 +++ trace-events | 2 ++ 2

[Qemu-devel] [PATCH v3 4/4] spapr: print more detailed error message on failed load_elf()

2014-02-03 Thread Alexey Kardashevskiy
This makes use of new error codes which load_elf() can return and prints more informative error message. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 851ce4b..c9dfc6c 100644

[Qemu-devel] [PATCH v3 1/4] spapr: support only ELF kernel images

2014-02-03 Thread Alexey Kardashevskiy
Currently everybody uses ELF kernel images with "-kernel" option on pseries machine but QEMU still tries to boot from an image even it fails to recognize it is ELF. This produces undefined behaviour if the user tries a kernel image compiled for another architecture. This removes support of raw ker

[Qemu-devel] [PATCH v3 0/4] elf loader: exit if incompatible architecture is detected

2014-02-03 Thread Alexey Kardashevskiy
The aim of this set is to print reasonable error if ELF cannot be loaded. While we are here, also fix some other bits. Changes: v3: * added a helper to convert error codes to strings Alexey Kardashevskiy (4): spapr: support only ELF kernel images moxie: fix load_elf() usage elf-loader: add

[Qemu-devel] [PATCH v3 3/4] elf-loader: add more return codes

2014-02-03 Thread Alexey Kardashevskiy
The existing load_elf() just returns -1 if it fails to load ELF. However it could be smarter than this and tell more about the failure such as wrong endianness or incompatible platform. This adds additional return codes for wrong architecture, wrong endianness and if the image is not ELF at all.

[Qemu-devel] [PATCH v3 2/4] moxie: fix load_elf() usage

2014-02-03 Thread Alexey Kardashevskiy
At the moment in the case of error, load_elf() returns -1 so load_kernel() will not signal error at all. Cc: gr...@moxielogic.com Signed-off-by: Alexey Kardashevskiy --- hw/moxie/moxiesim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesi

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Don't tell the user about missing SPR syncs

2014-02-03 Thread Alexey Kardashevskiy
On 02/04/2014 08:53 AM, Alexander Graf wrote: > We sync a lot of SPRs automatically between KVM and QEMU now. Some > of these only matter on newer hardware, some only matter on HV KVM. > > With the current code runnign on my reasonably recent PR KVM kernel > I get a lot of SPR synchronization warn

Re: [Qemu-devel] qemu segfauls with spiceport chardev and isa-serial

2014-02-03 Thread Peter Crosthwaite
On Tue, Feb 4, 2014 at 4:45 AM, Dr. David Alan Gilbert wrote: > (cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo change > - see below!) > > * Martin Kletzander (mklet...@redhat.com) wrote: >> Hello, > > Hi Martin, >I don't know about your spice warnings that triggered this

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-03 Thread Peter Maydell
On 3 February 2014 23:28, Alexander Graf wrote: > That means that something relies on the incorrect behavior we did > before to set *plen (end) = *plen (start) after the loop when > !mr->iommu_ops. I wonder what that could be... I bounced around in a debugger for a bit looking for cases where the

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-02-03 Thread Eric Blake
On 01/23/2014 07:46 AM, Amos Kong wrote: > This patch introduces a new monitor command to query QMP schema > information, the return data is a range of schema structs, which > contains the useful metadata to help management to check supported > features, QMP commands detail, etc. > > We use qapi-i

Re: [Qemu-devel] [PATCH v4 3/5] qobject: introduce qobject_get_str()

2014-02-03 Thread Eric Blake
On 01/23/2014 07:46 AM, Amos Kong wrote: > Signed-off-by: Amos Kong > --- > include/qapi/qmp/qstring.h | 1 + > qobject/qstring.c | 19 +++ > 2 files changed, 20 insertions(+) Is there anything you can add to the testsuite to validate that this works as expected? I'm n

Re: [Qemu-devel] [PATCH v4 2/5] qapi: add qapi-introspect.py code generator

2014-02-03 Thread Eric Blake
On 01/23/2014 07:46 AM, Amos Kong wrote: > This is a code generator for qapi introspection. It will parse > qapi-schema.json, extend schema definitions and generate a schema > table with metadata, it references to the new structs which we used > to describe dynamic data structs. The metadata will

Re: [Qemu-devel] [PATCH V6 5/8] block: Create authorizations mechanism for external snapshot and resize.

2014-02-03 Thread Jeff Cody
On Thu, Jan 23, 2014 at 09:31:36PM +0100, Benoît Canet wrote: > From: Benoît Canet > > Signed-off-by: Benoit Canet > --- > block.c | 65 > --- > block/blkverify.c | 2 +- > blockdev.c| 2 +- > include/block

[Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-03 Thread Sander Eikelenboom
Grmbll my fat fingers hit the send shortcut too soon by accident .. let's try again .. Hi Michael, A git bisect turned out that commit 9e047b982452c633882b486682966c1d97097015 breaks pci-passthrough on Xen. commit 9e047b982452c633882b486682966c1d97097015 Author: Michael S. Tsirkin Date: Mon

[Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 seems to break Xen pci-passthrough

2014-02-03 Thread Sander Eikelenboom
Hi Michael, A git bisect turned out that commit 9e047b982452c633882b486682966c1d97097015 breaks pci-passthrough on Xen. The error is not very verbose :

Re: [Qemu-devel] [PATCH v2 00/13] A64: Add Neon instructions, third set

2014-02-03 Thread Peter Maydell
On 1 February 2014 22:59, Peter Maydell wrote: > This is the v2 from my 'Neon second and third sets' patch from > last week. The first 8 patches from that were all OK so have gone > into target-arm.next. Thanks for the review; I've added this series to target-arm.next. -- PMM

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-03 Thread Alexander Graf
On 03.02.2014, at 23:58, Alexander Graf wrote: > > On 03.02.2014, at 22:13, Alexander Graf wrote: > >> >> On 03.02.2014, at 21:44, Mark Cave-Ayland >> wrote: >> >>> On 03/02/14 20:02, Nitin Srivastava wrote: >>> Hi , I downloaded the latest qemu source from git and compiled it

[Qemu-devel] [PATCH] PPC: KVM: Don't tell the user about missing SPR syncs

2014-02-03 Thread Alexander Graf
We sync a lot of SPRs automatically between KVM and QEMU now. Some of these only matter on newer hardware, some only matter on HV KVM. With the current code runnign on my reasonably recent PR KVM kernel I get a lot of SPR synchronization warnings though: $ ./ppc64-softmmu/qemu-system-ppc64 -nog

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-03 Thread Peter Maydell
On 3 February 2014 22:56, Chris Johns wrote: > On 3/02/2014 9:29 pm, Daniel P. Berrange wrote: >> This change will cause -pthread linker + compiler flag to be lost. >> > > I see in gthread-2.0.pc .. > > Libs: -L${libdir} -lgthread-2.0 > Cflags: -D_REENTRANT > > and qemu includes 'glib.h'. Witho

[Qemu-devel] [PATCH V15 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 17695d6..157efdf 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,16 @@

[Qemu-devel] [PATCH V15 09/13] quorum: Add quorum_co_get_block_status.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index cef4424..677a96d 100644 --- a/block/quorum.c +++ b/block/quoru

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-03 Thread Peter Maydell
On 3 February 2014 22:39, Michael Walle wrote: > Am 2014-02-01 21:31, schrieb Michael Walle: > >> Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: >>> >>> On 20 January 2014 19:34, Michael Walle wrote: >>> > Do not use qemu_log(). >>> > >>> > Signed-off-by: Michael Walle >>> > --- >>

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-03 Thread Alexander Graf
On 03.02.2014, at 22:13, Alexander Graf wrote: > > On 03.02.2014, at 21:44, Mark Cave-Ayland > wrote: > >> On 03/02/14 20:02, Nitin Srivastava wrote: >> >>> Hi , >>> I downloaded the latest qemu source from git and compiled it on my >>> centos 6.5 machine. >>> According to the following e-m

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-03 Thread Chris Johns
On 3/02/2014 9:29 pm, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote: Building against with a recent glib in a custom prefix fails because the gthread cflags in the pkg-config file do not have the correct path while the glib pc file does. Signed-off-by: Ch

[Qemu-devel] [PATCH V15 06/13] quorum: Add quorum mechanism.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/Makefile.objs | 2 +- block/quorum.c| 386 +- configure | 36 + docs/qmp/qmp-events.txt | 33 include/

[Qemu-devel] [PATCH V15 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\ file.children.0.driver=raw,\ file.children.1.file.filename=2.raw,\ file.children.1.node-name=2.raw,\ file.children.1.driver=raw,\ file.children

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-03 Thread Michael Walle
Am 2014-02-01 21:31, schrieb Michael Walle: Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: On 20 January 2014 19:34, Michael Walle wrote: > Do not use qemu_log(). > > Signed-off-by: Michael Walle > --- > > hw/misc/lm32_sys.c |2 +- > 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PATCH V15 00/13] Quorum block filter

2014-02-03 Thread Benoît Canet
in v15: remove now uneeded ret = s->threshold <= acb->success_count ? 0 : quorum_vote_error(acb); in quorum_aio_finalize Change flush error handling [Max] s/againt/against/ [Max] add \n in fprintf [Max] get rid of quorum_get_first_error from the git history [Benoît] use if

[Qemu-devel] [PATCH V15 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/quorum.c | 54 + 2 files changed, 55 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/M

Re: [Qemu-devel] [PATCH V14 00/13] Quorum block filter

2014-02-03 Thread Benoît Canet
Le Monday 03 Feb 2014 à 16:10:00 (-0500), Jeff Cody a écrit : > On Mon, Feb 03, 2014 at 08:11:39PM +0100, Benoît Canet wrote: > > v14: > >Use quorum_report_failure in early failure test suggested by Max [Benoît] > > > > v13: > > update copyright date and company legal status > > > > Benoî

[Qemu-devel] [PATCH V15 10/13] quorum: Add quorum_co_flush().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 28 1 file changed, 28 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 677a96d..c9e3b2a 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -6

[Qemu-devel] [PATCH V15 07/13] quorum: Add quorum_getlength().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Check that every bs file returns the same length. Otherwise, return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a

[Qemu-devel] [PATCH V15 03/13] quorum: Add quorum_aio_writev and its dependencies.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 104 + 1 file changed, 104 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 157efdf..81bffdd 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -64,11 +6

[Qemu-devel] [PATCH V15 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/blkverify.c | 108 +- include/qemu-common.h | 2 + util/iov.c| 103 +++ 3 files changed, 107 insertions(

[Qemu-devel] [PATCH V15 13/13] quorum: Add unit test.

2014-02-03 Thread Benoît Canet
Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- tests/qemu-iotests/075 | 95 ++ tests/qemu-iotests/075.out | 34 + tests/qemu-iotests/group | 1 + 3 files changed, 130 insertions(+) create mode 100755 tests/qemu-iotests/0

[Qemu-devel] [PATCH V15 11/13] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index c9e3b2a..1e683f8 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -695,6 +695,23 @@ static

[Qemu-devel] [PATCH V15 05/13] quorum: Add quorum_aio_readv.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 81bffdd..699b512 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -86,10

[Qemu-devel] [PATCH V15 08/13] quorum: Add quorum_invalidate_cache().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 2f302b4..cef4424 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -609,6 +609,16 @@ static int64_t

Re: [Qemu-devel] [PATCH V14 00/13] Quorum block filter

2014-02-03 Thread Jeff Cody
On Mon, Feb 03, 2014 at 08:11:39PM +0100, Benoît Canet wrote: > v14: >Use quorum_report_failure in early failure test suggested by Max [Benoît] > > v13: > update copyright date and company legal status > > Benoît Canet (13): > quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIO

Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-03 Thread Peter Maydell
On 3 February 2014 21:27, Richard Henderson wrote: > On 02/01/2014 10:16 AM, Peter Maydell wrote: >> This looks at least superficially OK, but I'm not really familiar >> with QEMU's breakpoint/watchpoint support code. RTH: do >> you want to have a look over this one? > > It's copied verbatim from

Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-03 Thread Richard Henderson
On 02/01/2014 10:16 AM, Peter Maydell wrote: > This looks at least superficially OK, but I'm not really familiar > with QEMU's breakpoint/watchpoint support code. RTH: do > you want to have a look over this one? It's copied verbatim from the i386 port, missing braces and all. So it certainly passe

[Qemu-devel] osx pci vs. 99fd437dee468609de8218f0eb3b16621fb6a9c9

2014-02-03 Thread Gabriel L. Somlo
Michael, Prior to commit 99fd437dee468609de8218f0eb3b16621fb6a9c9 (enable hotplug for pci bridges), PCI cards used to show up in the "device tree" of OS X (System Information). E.g., on MountainLion I have: Hardware -> PCI Cards: Card Type Driver Installed Slot *eth

Re: [Qemu-devel] [PATCH v2 12/13] target-arm: A64: Add 2-reg-misc REV* instructions

2014-02-03 Thread Richard Henderson
On 02/01/2014 03:00 PM, Peter Maydell wrote: > From: Alex Bennée > > Add the byte-reverse operations REV64, REV32 and REV16 from the > two-reg-misc group. > > Signed-off-by: Alex Bennée > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 71 > +

Re: [Qemu-devel] [PATCH v2 02/13] target-arm: A64: Implement remaining non-pairwise int SIMD 3-reg-same insns

2014-02-03 Thread Richard Henderson
On 02/01/2014 02:59 PM, Peter Maydell wrote: > Implement the SIMD 3-reg-same instructions where the size == 3 case > is reserved: SHADD, UHADD, SRHADD, URHADD, SHSUB, UHSUB, SMAX, > UMAX, SMIN, UMIN, SABD, UABD, SABA, UABA, MLA, MLS, MUL, PMUL, > SQRDMULH, SQDMULH. (None of these have scalar-3-same

Re: [Qemu-devel] [PATCH V14 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Benoît Canet
Le Monday 03 Feb 2014 à 21:22:45 (+0100), Max Reitz a écrit : > On 03.02.2014 20:11, Benoît Canet wrote: > >From: Benoît Canet > > > >Example of command line: > >-drive if=virtio,file.driver=quorum,\ > >file.children.0.file.filename=1.raw,\ > >file.children.0.node-name=1.raw,\ > >file.children.0.d

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-03 Thread Alexander Graf
On 03.02.2014, at 21:44, Mark Cave-Ayland wrote: > On 03/02/14 20:02, Nitin Srivastava wrote: > >> Hi , >> I downloaded the latest qemu source from git and compiled it on my >> centos 6.5 machine. >> According to the following e-mail from this mailing list I tried the >> following >> _http://co

Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-03 Thread Eric Blake
On 02/03/2014 01:38 PM, Igor Mammedov wrote: >>> +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceState >>> *handler, >>> +Error **errp) >>> +{ >>> +object_property_set_link(OBJECT(bus), OBJECT(handler), >>> +

Re: [Qemu-devel] [PATCH v5 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2014-02-03 Thread Igor Mammedov
On Mon, 03 Feb 2014 12:37:58 -0700 Eric Blake wrote: > On 02/03/2014 08:57 AM, Igor Mammedov wrote: > > changes since v4: > > - rebased on top of PCI tree > > - added wrapper to set hotplug-device property > > > > I don't consider myself qualified to review this one on technical > merits, but

Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-03 Thread Igor Mammedov
On Mon, 03 Feb 2014 12:30:04 -0700 Eric Blake wrote: > On 02/03/2014 08:57 AM, Igor Mammedov wrote: > > It will allow to reuse field with different BUSes, > > reducing code duplication. Field is intended for > > replacing 'hotplug_qdev' field in PCIBus and also > > will allow to avoid adding equi

Re: [Qemu-devel] [PATCH V14 13/13] quorum: Add unit test.

2014-02-03 Thread Max Reitz
On 03.02.2014 20:11, Benoît Canet wrote: Signed-off-by: Benoit Canet --- tests/qemu-iotests/075 | 95 ++ tests/qemu-iotests/075.out | 34 + tests/qemu-iotests/group | 1 + 3 files changed, 130 insertions(+) create mode 100

Re: [Qemu-devel] [PATCH V14 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Max Reitz
On 03.02.2014 20:11, Benoît Canet wrote: From: Benoît Canet Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\ file.children.0.driver=raw,\ file.children.1.file.filename=2.raw,\ file.children.1.node-name=2.raw,\

Re: [Qemu-devel] [PATCH] s390: Storage key global access

2014-02-03 Thread Jason J. Herne
On 01/22/2014 10:48 AM, Jason J. Herne wrote: From: "Jason J. Herne" Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne --- hw/s390x/s390-virtio-ccw.c | 3 +-- hw/s390x/s390-virtio.c | 6 +++--

[Qemu-devel] [PATCH V14 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 17695d6..157efdf 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,16 @@

[Qemu-devel] [PATCH V14 07/13] quorum: Add quorum_getlength().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Check that every bs file returns the same length. Otherwise, return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a

[Qemu-devel] [PATCH V14 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/quorum.c | 54 + 2 files changed, 55 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/M

Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-03 Thread Eric Blake
On 02/03/2014 08:57 AM, Igor Mammedov wrote: > It will allow to reuse field with different BUSes, > reducing code duplication. Field is intended for > replacing 'hotplug_qdev' field in PCIBus and also > will allow to avoid adding equivalent field to > DimmBus with possiblitity to refactor other BUS

[Qemu-devel] [PATCH V14 03/13] quorum: Add quorum_aio_writev and its dependencies.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 123 + 1 file changed, 123 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 157efdf..7d0f123 100644 --- a/block/quorum.c +++ b/blo

Re: [Qemu-devel] [PATCH v4 1/5] qapi: introduce DataObject to describe dynamic structs

2014-02-03 Thread Eric Blake
On 01/23/2014 07:46 AM, Amos Kong wrote: > This patch introduced a DataObject union in qapi-schema.json, > we use it to describe dynamic data structs. > > We will use it in following patches to support to QMP full > introspection. We have many kinds of schema in json file, > they all can be descri

[Qemu-devel] [PATCH V14 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/blkverify.c | 108 +- include/qemu-common.h | 2 + util/iov.c| 103 +++ 3 files changed, 107 insertions(

[Qemu-devel] [PATCH V14 11/13] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 5b77c02..a4716b3 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -703,6 +703,23 @@ static

Re: [Qemu-devel] [PATCH V14 10/13] quorum: Add quorum_co_flush().

2014-02-03 Thread Max Reitz
On 03.02.2014 20:11, Benoît Canet wrote: From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 34 ++ 1 file changed, 34 insertions(+) See my reply to V10: You're only counting results which are not 0 (i.e

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-02-03 Thread Eduardo Habkost
On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: > Il 21/01/2014 16:51, Andreas Färber ha scritto: > >>> We already do that for other bits (e.g. XSAVE/OSXSAVE), > >Please point me to the commit, a search for xsave did not come up with a > >commit changing such a thing - either it did

[Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-03 Thread Alexander Graf
When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id "" bus: ide.0 type IDE dev: macio-ide, id "" bus: ide.0

Re: [Qemu-devel] [PATCH V14 09/13] quorum: Add quorum_co_get_block_status.

2014-02-03 Thread Max Reitz
On 03.02.2014 20:11, Benoît Canet wrote: From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 51 +++ 1 file changed, 51 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH V14 06/13] quorum: Add quorum mechanism.

2014-02-03 Thread Max Reitz
On 03.02.2014 20:11, Benoît Canet wrote: From: Benoît Canet Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/Makefile.objs | 2 +- block/quorum.c| 401 +++--- configure | 36 +

Re: [Qemu-devel] [PATCH v5 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2014-02-03 Thread Eric Blake
On 02/03/2014 08:57 AM, Igor Mammedov wrote: > changes since v4: > - rebased on top of PCI tree > - added wrapper to set hotplug-device property > I don't consider myself qualified to review this one on technical merits, but I did spot a number of typos and other minor improvements. > > Igor

Re: [Qemu-devel] [PATCH v5 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API

2014-02-03 Thread Eric Blake
On 02/03/2014 08:57 AM, Igor Mammedov wrote: > Split piix4_device_hotplug() into hotplug/unplug callbacks > and register them as "hotplug-handler" interface implementation of > PIIX4_PM device. > > Replace pci_bus_hotplug() wiring with setting link on > PCI BUS "hotplug-handler" property to PIIX4_

Re: [Qemu-devel] [PATCH v5 4/9] hw/acpi: move typeinfo to the file end

2014-02-03 Thread Eric Blake
On 02/03/2014 08:57 AM, Igor Mammedov wrote: > do so to avoid not necessary forward declarations and > place typeinfo registration at the file end where it's > usualy expected. s/usualy/usually/ > > Signed-off-by: Igor Mammedov > --- > hw/acpi/piix4.c | 92 +++

Re: [Qemu-devel] [PATCH v5 3/9] qdev: add "hotpluggable" property to Device

2014-02-03 Thread Eric Blake
On 02/03/2014 08:57 AM, Igor Mammedov wrote: > Currently it's possible to make PCIDevice not hotpluggable > by using no_hotplug field of PCIDeviceClass. However it > limits this only to PCI devices and prevents from > generalizing hotplug code. > > + > +/* by default all devices were consider

Re: [Qemu-devel] [PATCH v5 1/9] define hotplug interface

2014-02-03 Thread Eric Blake
On 02/03/2014 08:57 AM, Igor Mammedov wrote: > Provide a generic hotplug interface for hotplug handlers. > Intended for replacing hotplug mechanism used by > PCI/PCIE/SHPC code and will be used for memory hotplug. > > Signed-off-by: Igor Mammedov > --- > v3: > * amend commit description as reques

[Qemu-devel] [PATCH V14 09/13] quorum: Add quorum_co_get_block_status.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 4b726ba..6f7a40d 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -621,6 +621,56 @@

[Qemu-devel] [PATCH V14 06/13] quorum: Add quorum mechanism.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/Makefile.objs | 2 +- block/quorum.c| 401 +++--- configure | 36 + docs/qmp/qmp-events.txt | 33 include/

[Qemu-devel] [PATCH V14 10/13] quorum: Add quorum_co_flush().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 6f7a40d..5b77c02 100644 --- a/block/quorum.c +++ b/block/quorum.c

[Qemu-devel] [PATCH V14 00/13] Quorum block filter

2014-02-03 Thread Benoît Canet
v14: Use quorum_report_failure in early failure test suggested by Max [Benoît] v13: update copyright date and company legal status Benoît Canet (13): quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. quorum: Create BDRVQuorumState and BlkDriver and do init. quorum: Add

[Qemu-devel] [PATCH V14 08/13] quorum: Add quorum_invalidate_cache().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a3920d8..4b726ba 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -611,6 +611,16 @@ static int64_t

[Qemu-devel] [PATCH V14 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Benoît Canet
From: Benoît Canet Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\ file.children.0.driver=raw,\ file.children.1.file.filename=2.raw,\ file.children.1.node-name=2.raw,\ file.children.1.driver=raw,\ file.children

[Qemu-devel] [PATCH V14 05/13] quorum: Add quorum_aio_readv.

2014-02-03 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Max Reitz --- block/quorum.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 7d0f123..5b11ac1 100644 --- a/block/quorum.c +++ b/block/q

[Qemu-devel] [PATCH V14 13/13] quorum: Add unit test.

2014-02-03 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/qemu-iotests/075 | 95 ++ tests/qemu-iotests/075.out | 34 + tests/qemu-iotests/group | 1 + 3 files changed, 130 insertions(+) create mode 100755 tests/qemu-iotests/075 create mode 100644 t

Re: [Qemu-devel] [PATCH v1] virtex_ml507: Add support for loading initrd images

2014-02-03 Thread Alexander Graf
On 03.02.2014, at 19:47, Andreas Färber wrote: > Am 03.02.2014 16:20, schrieb Edgar E. Iglesias: >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias >> --- >> hw/ppc/virtex_ml507.c | 34 +- >> 1 file changed, 33 insertions(+), 1 deletion(-) >> >

Re: [Qemu-devel] [PATCH V10 10/13] quorum: Add quorum_co_flush().

2014-02-03 Thread Max Reitz
On 03.02.2014 12:57, Benoît Canet wrote: Le Sunday 02 Feb 2014 à 23:02:57 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 34 ++

Re: [Qemu-devel] [PATCH V10 06/13] quorum: Add quorum mechanism.

2014-02-03 Thread Max Reitz
On 03.02.2014 12:44, Benoît Canet wrote: Le Saturday 01 Feb 2014 à 00:04:01 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/Makefile.objs | 2 +- block/quorum.

Re: [Qemu-devel] [PATCH v1] virtex_ml507: Add support for loading initrd images

2014-02-03 Thread Andreas Färber
Am 03.02.2014 16:20, schrieb Edgar E. Iglesias: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > hw/ppc/virtex_ml507.c | 34 +- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507

Re: [Qemu-devel] qemu segfauls with spiceport chardev and isa-serial

2014-02-03 Thread Dr. David Alan Gilbert
(cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo change - see below!) * Martin Kletzander (mklet...@redhat.com) wrote: > Hello, Hi Martin, I don't know about your spice warnings that triggered this but looking down the backtrace I can see something odd: > current HEAD (2f

Re: [Qemu-devel] [PATCH v1] virtex_ml507: Add support for loading initrd images

2014-02-03 Thread Alexander Graf
On 03.02.2014, at 16:20, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qapi: cleanup redundant variable

2014-02-03 Thread Eric Blake
On 02/01/2014 02:49 AM, Michael Tokarev wrote: > 23.01.2014 12:54, Amos Kong wrote: >> No need to re-append an expr list, it's ok to return schema.exprs >> >> Signed-off-by: Amos Kong >> --- >> scripts/qapi.py | 5 + >> 1 file changed, 1 insertion(+), 4 deletions(-) >> @@ -185,9 +183,8 @@ de

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-03 Thread Eric Blake
On 02/01/2014 04:52 AM, Martin Kletzander wrote: > Introduce 'query-chardev-backends' QMP command which lists all > supported character device backends. > > Signed-off-by: Martin Kletzander > --- > v3: > - Omit commas at the end of list in JSON > v2: > - Version changed from "1.8.0" to "2.0" >

  1   2   3   4   >