On 04.02.2014, at 03:05, Alexey Kardashevskiy <a...@ozlabs.ru> wrote:
> On 02/04/2014 08:53 AM, Alexander Graf wrote: >> We sync a lot of SPRs automatically between KVM and QEMU now. Some >> of these only matter on newer hardware, some only matter on HV KVM. >> >> With the current code runnign on my reasonably recent PR KVM kernel >> I get a lot of SPR synchronization warnings though: >> >> $ ./ppc64-softmmu/qemu-system-ppc64 -nographic -enable-kvm >> Warning: Unable to set SPR 17 to KVM: Invalid argument >> Warning: Unable to set SPR 29 to KVM: Invalid argument >> Warning: Unable to set SPR 157 to KVM: Invalid argument >> Warning: Unable to set SPR 308 to KVM: Invalid argument >> Warning: Unable to set SPR 309 to KVM: Invalid argument >> Warning: Unable to set SPR 318 to KVM: Invalid argument >> Warning: Unable to set SPR 770 to KVM: Invalid argument >> Warning: Unable to set SPR 945 to KVM: Invalid argument >> Warning: Unable to set SPR 946 to KVM: Invalid argument >> Warning: Unable to set SPR 1013 to KVM: Invalid argument >> Warning: Unable to set SPR 17 to KVM: Invalid argument >> Warning: Unable to set SPR 29 to KVM: Invalid argument >> Warning: Unable to set SPR 157 to KVM: Invalid argument >> Warning: Unable to set SPR 308 to KVM: Invalid argument >> Warning: Unable to set SPR 309 to KVM: Invalid argument >> Warning: Unable to set SPR 318 to KVM: Invalid argument >> Warning: Unable to set SPR 770 to KVM: Invalid argument >> Warning: Unable to set SPR 945 to KVM: Invalid argument >> Warning: Unable to set SPR 946 to KVM: Invalid argument >> Warning: Unable to set SPR 1013 to KVM: Invalid argument >> >> Eventually we want to have something like a "verbose" flag that allows >> us to get these warnings when we see something goes wrong. But until >> then they do more harm than good exposed to casual users, so let's move >> them to debug prints. > > Why are not these tracepoints? Then we would not need any "verbose" flag. True, we should convert all of the debug prints to trace points. But that's for later :). Alex
