Re: [Qemu-devel] [PATCH] qcow2: use start_of_cluster() and offset_into_cluster() everywhere

2013-12-04 Thread Fam Zheng
On 2013年12月05日 14:32, Hu Tao wrote: Signed-off-by: Hu Tao --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 22 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 791083a..b54ad3c 100644 --- a

Re: [Qemu-devel] [PATCH] Fix processing of the MMU faults caused by the helper functions

2013-12-04 Thread Pavel Dovgaluk
Hello! Will anyone comment this patch? Pavel Dovgaluk > -Original Message- > From: qemu-devel-bounces+pavel.dovgaluk=ispras...@nongnu.org > [mailto:qemu-devel- > bounces+pavel.dovgaluk=ispras...@nongnu.org] On Behalf Of Pavel Dovgaluk > Sent: Monday, November 18, 2013 2:58 PM > To: 'q

[Qemu-devel] [PATCH] qcow2: use start_of_cluster() and offset_into_cluster() everywhere

2013-12-04 Thread Hu Tao
Signed-off-by: Hu Tao --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 22 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 791083a..b54ad3c 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-

[Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-04 Thread Fernando Luis Vázquez Cao
VCPU TSC is not cleared by a warm reset (*), which leaves many Linux guests vulnerable to the overflow in cyc2ns_offset fixed by upstream commit 9993bc635d01a6ee7f6b833b4ee65ce7c06350b1 ("sched/x86: Fix overflow in cyc2ns_offset"). To put it in a nutshell, if a Linux guest without the patch above

Re: [Qemu-devel] [PATCH] kvm: clear guest TSC on reset

2013-12-04 Thread Fernando Luis Vázquez Cao
I realized that the TSC reset should be done in QEMU so I will be replying with a QEMU patch instead of a KVM one. - Fernando On 12/03/2013 05:04 PM, Fernando Luis Vázquez Cao wrote: I think there is a problem with the current patch, so please ignore for the moment. I will be replying with an

Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-04 Thread Wenchao Xia
于 2013/12/5 4:42, Eric Blake 写道: On 12/04/2013 02:10 AM, Wenchao Xia wrote: Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia --- @@ -1183,6 +1189,18 @@ static int img_convert(int argc, char **argv) case 's': snap

Re: [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb)

2013-12-04 Thread Peter Lieven
> Am 05.12.2013 um 03:12 schrieb Eric Blake : > > On 12/04/2013 09:46 AM, Peter Lieven wrote: > >>> I guess a sane size would be cluster size. For a raw file 4 KB is >>> reasonable since that's the file system block size. >> in case of iscsi the cluster size could be much too high as for examp

Re: [Qemu-devel] [PATCH 03/14] spapr_pci: add get-sensor-state RTAS interface

2013-12-04 Thread Alexey Kardashevskiy
On 12/05/2013 12:19 PM, Michael Roth wrote: > From: Mike Day > > Signed-off-by: Mike Day > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 72 > > include/hw/ppc/spapr.h |6 +++- > 2 files changed, 77 insertions(+), 1 deletio

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-04 Thread Li Guang
Peter Crosthwaite wrote: Hi Liguang, V9 has some checkpatch errors: [pcrost@xsjandreislx qemu]$ git format-patch HEAD~5 0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch 0002-hw-timer-add-allwinner-a10-timer.patch 0003-hw-intc-add-allwinner-A10-interrupt-controller.patch 0004-hw-arm-add-allwinner-a10

Re: [Qemu-devel] [PATCH 01/14] spapr_pci: add set-indicator RTAS interface

2013-12-04 Thread Alexey Kardashevskiy
On 12/05/2013 12:19 PM, Michael Roth wrote: > From: Mike Day > > Signed-off-by: Mike Day > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 83 > > include/hw/ppc/spapr.h | 30 + > 2 files changed, 113 insertions

Re: [Qemu-devel] [PATCH 07/14] spapr: add helper to retrieve a PHB/device DrcEntry

2013-12-04 Thread Alexey Kardashevskiy
On 12/05/2013 12:19 PM, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > hw/ppc/spapr.c | 36 > include/hw/ppc/spapr.h |2 ++ > 2 files changed, 38 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 0607559..2250ee1

[Qemu-devel] [PATCH 10/14] pci: allow 0 address for PCI IO regions

2013-12-04 Thread Michael Roth
Some kernels program a 0 address for io regions. PCI 3.0 spec sectio 6.2.5.1 doesn't seem to disallow this. Signed-off-by: Michael Roth --- hw/pci/pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f15bbb0..fe5729c 100644 --- a/hw/pci/p

[Qemu-devel] [PATCH 00/14] spapr: add support for pci hotplug

2013-12-04 Thread Michael Roth
This patches are based on ppc-next, and can also be obtained from: https://github.com/mdroth/qemu/commits/spapr-pci-hotplug-r4-ppc-next OVERVIEW These patches add support for PCI hotplug for SPAPR guests. We advertise each PHB as DR-capable (as defined by PAPR 13.5/13.6) with 32 hotpluggable PCI

[Qemu-devel] [PATCH 14/14] spapr_pci: emit hotplug add/remove events during hotplug

2013-12-04 Thread Michael Roth
From: Tyrel Datwyler This uses extension of existing EPOW interrupt/event mechanism to notify userspace tools like librtas/drmgr to handle in-guest configuration/cleanup operations in response to device_add/device_del. Userspace tools that don't implement this extension will need to be run manua

[Qemu-devel] [PATCH 06/14] spapr_pci: populate DRC dt entries for PHBs

2013-12-04 Thread Michael Roth
Reserve 32 entries of type PCI in each PHB's initial FDT. This advertises to guests that each PHB is DR-capable device with physical hotpluggable slots. This is necessary for allowing hotplugging of devices to it later via bus rescan or guest rpaphp hotplug module. Each entry is assigned a name of

Re: [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb)

2013-12-04 Thread Eric Blake
On 12/04/2013 09:46 AM, Peter Lieven wrote: >> I guess a sane size would be cluster size. For a raw file 4 KB is >> reasonable since that's the file system block size. > in case of iscsi the cluster size could be much too high as for example > my storage has a cluster_size of 15MB. >> >> Is it ne

[Qemu-devel] [PATCH 09/14] pci: make pci_bar useable outside pci.c

2013-12-04 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/pci/pci.c |3 ++- include/hw/pci/pci.h |1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index ed32059..f15bbb0 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -103,7 +103,8 @@ static const VMStateDes

[Qemu-devel] [PATCH 12/14] spapr_events: re-use EPOW event infrastructure for hotplug events

2013-12-04 Thread Michael Roth
From: Nathan Fontenot This extends the data structures currently used to report EPOW events to gets via the check-exception RTAS interfaces to also include event types for hotplug/unplug events. This is currently undocumented and being finalized for inclusion in PAPR specification, but we implem

[Qemu-devel] [PATCH 03/14] spapr_pci: add get-sensor-state RTAS interface

2013-12-04 Thread Michael Roth
From: Mike Day Signed-off-by: Mike Day Signed-off-by: Michael Roth --- hw/ppc/spapr_pci.c | 72 include/hw/ppc/spapr.h |6 +++- 2 files changed, 77 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c inde

[Qemu-devel] [PATCH v9 2/5] hw/timer: add allwinner a10 timer

2013-12-04 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10-pit.c | 253 ++ include/hw/timer/allwinner-a10-pit.h | 57 4 files changed, 314 insertions(+), 0 dele

[Qemu-devel] [PATCH 01/14] spapr_pci: add set-indicator RTAS interface

2013-12-04 Thread Michael Roth
From: Mike Day Signed-off-by: Mike Day Signed-off-by: Michael Roth --- hw/ppc/spapr_pci.c | 83 include/hw/ppc/spapr.h | 30 + 2 files changed, 113 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index

[Qemu-devel] [PATCH 05/14] spapr: populate DRC entries for root dt node

2013-12-04 Thread Michael Roth
From: Nathan Fontenot This add entries to the root OF node to advertise our PHBs as being DR-capable in according with PAPR specification. Each PHB is given a name of PHB, advertised as a PHB type, and associated with a power domain of -1 (indicating to guests that power management is handled au

[Qemu-devel] [PATCH 07/14] spapr: add helper to retrieve a PHB/device DrcEntry

2013-12-04 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/ppc/spapr.c | 36 include/hw/ppc/spapr.h |2 ++ 2 files changed, 38 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 0607559..2250ee1 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -277,6 +

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-04 Thread Li Guang
I think with your suggestion of new definition will remove the warnings, and I will fix the error report. Thanks! Peter Crosthwaite wrote: Hi Liguang, V9 has some checkpatch errors: [pcrost@xsjandreislx qemu]$ git format-patch HEAD~5 0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch 0002-hw-timer-

Re: [Qemu-devel] [PATCH v8 2/5] hw/timer: add allwinner a10 timer

2013-12-04 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Dec 4, 2013 at 6:09 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10-pit.c | 253 ++ include/hw/ti

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-04 Thread Peter Crosthwaite
Hi Liguang, V9 has some checkpatch errors: [pcrost@xsjandreislx qemu]$ git format-patch HEAD~5 0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch 0002-hw-timer-add-allwinner-a10-timer.patch 0003-hw-intc-add-allwinner-A10-interrupt-controller.patch 0004-hw-arm-add-allwinner-a10-SoC-support.patch 0005-hw-

[Qemu-devel] [PATCH v9 4/5] hw/arm: add allwinner a10 SoC support

2013-12-04 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/arm/Makefile.objs|1 + hw/arm/allwinner-a10.c | 87 +++ include/hw/arm/allwinner-a10.h | 35 4 files changed, 124 insertions(+), 0 deletions(-

[Qemu-devel] [PATCH 11/14] spapr_pci: enable basic hotplug operations

2013-12-04 Thread Michael Roth
From: Mike Day This enables hotplug for PHB bridges. Upon hotplug we generate the OF-nodes required by PAPR specification and IEEE 1275-1994 "PCI Bus Binding to Open Firmware" for the device. We associate the corresponding FDT for these nodes with the DrcEntry corresponding to the slot, which wi

Re: [Qemu-devel] [PATCH v8 2/5] hw/timer: add allwinner a10 timer

2013-12-04 Thread Peter Crosthwaite
On Wed, Dec 4, 2013 at 6:09 PM, liguang wrote: > Signed-off-by: liguang > --- > default-configs/arm-softmmu.mak |2 + > hw/timer/Makefile.objs |2 + > hw/timer/allwinner-a10-pit.c | 253 > ++ > include/hw/timer/allwinner-a10-pi

[Qemu-devel] [PATCH 13/14] spapr_events: event-scan RTAS interface

2013-12-04 Thread Michael Roth
From: Tyrel Datwyler We don't actually rely on this interface to surface hotplug events, and instead rely on the similar-but-interrupt-driven check-exception RTAS interface used for EPOW events. However, the existence of this interface is needed to ensure guest kernels initialize the event-report

[Qemu-devel] [PATCH 02/14] spapr_pci: add get/set-power-level RTAS interfaces

2013-12-04 Thread Michael Roth
From: Nathan Fontenot Signed-off-by: Nathan Fontenot Signed-off-by: Michael Roth --- hw/ppc/spapr_pci.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 3117390..64077f9 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spap

[Qemu-devel] [PATCH 04/14] spapr_pci: add ibm, configure-connector RTAS interface

2013-12-04 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/ppc/spapr_pci.c | 111 1 file changed, 111 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 95336f7..5eb6852 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -569,6 +569,11

[Qemu-devel] [PATCH 08/14] memory: add memory_region_find_subregion

2013-12-04 Thread Michael Roth
Similar to memory_region_find, but only search for overlaps among regions that are a child of the region passed in. This is useful for finding free ranges within a parent range to map to, in addition to the use-cases similarly served by memory_region_find. Signed-off-by: Michael Roth --- include

Re: [Qemu-devel] [RFC qom-cpu v4 00/10] i386: add cpu hot remove support

2013-12-04 Thread Chen Fan
On Wed, 2013-12-04 at 16:42 +0100, Igor Mammedov wrote: > On Wed, 04 Dec 2013 10:15:16 +0800 > Chen Fan wrote: > > > On Thu, 2013-11-28 at 15:41 +0100, Igor Mammedov wrote: > > > On Wed, 9 Oct 2013 17:43:08 +0800 > > > Chen Fan wrote: > > > > > > > Via implementing ACPI standard methods _EJ0 in

[Qemu-devel] [PATCH v9 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-04 Thread liguang
Signed-off-by: liguang --- include/migration/vmstate.h |4 savevm.c| 31 +++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 9d09e60..977cf52 100644 --- a/inc

[Qemu-devel] [PATCH v9 5/5] hw/arm: add cubieboard support

2013-12-04 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 53 ++ 2 files changed, 54 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs index 012b

[Qemu-devel] [PATCH v9 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-04 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/allwinner-a10-pic.c | 218 +++ include/hw/intc/allwinner-a10-pic.h | 40 +++ 4 files changed, 260 insertions(+), 0 deletion

[Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-04 Thread liguang
lay a foundation for allwinner A10 SoC with a cortex-a8 processor, and will add more devices later. v2: split timer and interrupt controller emulation into their corresponding files. v3: 1. change loader_start address 2. add 64-bit counter 3. fixup fail to clear interrup status

[Qemu-devel] [PATCH v2 5/6] qemu-option: Remove qemu_opts_create_nofail

2013-12-04 Thread Peter Crosthwaite
This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. null/0 arguments needs to be added for the id and fail_if_exists fields in affected callsites due to argument inconsistency between the normal and no_fail variants. Signed-off-by: Peter Crosthwai

[Qemu-devel] [PATCH v2 6/6] qerror: Remove assert_no_error()

2013-12-04 Thread Peter Crosthwaite
This is no longer needed, and is obsoleted by error_abort. Remove. Signed-off-by: Peter Crosthwaite --- include/qapi/qmp/qerror.h | 1 - qobject/qerror.c | 8 2 files changed, 9 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index c30c2f6..73c

[Qemu-devel] [PATCH v2 3/6] hw: Remove assert_no_error usages

2013-12-04 Thread Peter Crosthwaite
Replace assert_no_error() usages with the error_abort system. &error_abort is passed into API calls to signal to the Error sub-system that any errors are fatal. Removes need for caller assertions. Signed-off-by: Peter Crosthwaite --- changed since v1: Split unrelated dead code removal to sep patc

[Qemu-devel] [PATCH v2 4/6] target-i386: Remove assert_no_error usage

2013-12-04 Thread Peter Crosthwaite
Replace an assert_no_error() usage with the error_abort system. Signed-off-by: Peter Crosthwaite --- target-i386/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 47af9a8..b930ca5 100644 --- a/target-i386/cpu.c +++ b/target-

[Qemu-devel] [PATCH v2 2/6] hw/core/qdev: Delete dead code

2013-12-04 Thread Peter Crosthwaite
This is unreachable code, as it's already asserted that no errors have occurred. Delete. Signed-off-by: Peter Crosthwaite --- hw/core/qdev.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index e374a93..adbff18 100644 --- a/hw/core/qdev.c +++ b/hw/core/q

[Qemu-devel] [PATCH v2 0/6] Add error_abort and associated cleanups

2013-12-04 Thread Peter Crosthwaite
Following our discussion RE self asserting API calls, here is a spin of my proposal. This series obsoletes the need for _nofail variants for Error ** accepting APIs. Is also greatly reduces the verbosity of calls sites that are currently asserting against errors. Patch 1 is the main event - additi

[Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-04 Thread Peter Crosthwaite
Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting APIs. No need for this pattern: Error * local_err = NULL;

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-04 Thread Peter Crosthwaite
On Thu, Dec 5, 2013 at 7:20 AM, Antony Pavlov wrote: > On Wed, 4 Dec 2013 20:29:05 + > Peter Maydell wrote: > >> On 4 December 2013 20:22, Antony Pavlov wrote: >> > Here is my proposition: >> > >> > 1. qemu board code setup CPU to start from 0x. (0x is a >> > ROM address >>

Re: [Qemu-devel] [PATCH v8 4/5] hw/arm: add allwinner a10 SoC support

2013-12-04 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Dec 4, 2013 at 6:09 PM, liguang wrote: Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/allwinner-a10.c | 77 include/hw/arm/allwinner-a10.h | 36 ++ 3 files

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-04 Thread Peter Crosthwaite
On Thu, Dec 5, 2013 at 7:34 AM, Peter Maydell wrote: > On 4 December 2013 21:20, Antony Pavlov wrote: >> On Wed, 4 Dec 2013 20:29:05 + >> Peter Maydell wrote: >> >>> On 4 December 2013 20:22, Antony Pavlov wrote: >>> > Here is my proposition: >>> > >>> > 1. qemu board code setup CPU to star

Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-04 Thread Eric Blake
On 12/03/2013 06:26 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > blockdev.c | 49 + > hmp.c| 4 +++- > qapi-schema.json | 13 ++--- > qmp-commands.hx | 11 ++- > 4 files changed, 64 insertions(+),

Re: [Qemu-devel] [RFC V3 5/7] qmp: Allow block_resize to manipulate bs graph nodes.

2013-12-04 Thread Eric Blake
On 12/03/2013 06:26 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > blockdev.c | 13 + > hmp.c| 2 +- > qapi-schema.json | 10 -- > qmp-commands.hx | 3 ++- > 4 files changed, 20 insertions(+), 8 deletions(-) > > diff --git a/blockdev.c b/bl

Re: [Qemu-devel] [RFC V3 4/7] qmp: Allow block_passwd to manipulate bs graph nodes.

2013-12-04 Thread Eric Blake
On 12/03/2013 06:26 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > > +BlockDriverState * bdrv_lookup_bs(bool has_device, const char * device, > + bool has_node_name, const char * node_name, Style: no space after * (3 instances) > +

Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-04 Thread Eric Blake
On 12/03/2013 06:26 AM, Benoît Canet wrote: In addition to Fam's review, s/skeletton/skeleton/ in subject > --- > blockdev.c | 8 > qapi-schema.json | 32 > 2 files changed, 40 insertions(+) > > diff --git a/blockdev.c b/blockdev.c > index a474b

Re: [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option.

2013-12-04 Thread Eric Blake
On 12/03/2013 06:26 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c | 42 +- > 1 file changed, 37 insertions(+), 5 deletions(-) > > @@ -880,7 +881,14 @@ int bdrv_file_open(BlockDriverState **pbs, const char > *filename, > o

Re: [Qemu-devel] [RFC V3 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph.

2013-12-04 Thread Eric Blake
On 12/03/2013 06:25 AM, Benoît Canet wrote: > Add the minimum of code to prepare the followings patches. s/prepare/prepare for/ s/followings/following/ > > Signed-off-by: Benoit Canet > --- Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization l

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-04 Thread Alexey Kardashevskiy
On 12/05/2013 12:12 AM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 12/04/2013 08:33 PM, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: > Normally the user is expected to eject DVD if it is not locked by >

Re: [Qemu-devel] [PATCH V3 9/9] qapi script: do not add "_" for every capitalized char in enum

2013-12-04 Thread Eric Blake
On 11/29/2013 01:41 AM, Wenchao Xia wrote: > Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT, > "X86CPU" will generate X86_CPU instead of X86_C_P_U. > > Signed-off-by: Wenchao Xia > --- > +l = len(c_fun_str) > +for i in range(l): > +c = c_fun_str[i] > +

Re: [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns

2013-12-04 Thread Peter Maydell
On 4 December 2013 22:29, Richard Henderson wrote: > On 12/05/2013 11:14 AM, Peter Maydell wrote: >> It doesn't need initialization, does it? It's a static array, and we >> fill it as new temps are requested. So all we need to do is clear >> the count so it starts "empty". Or have I missed somethi

Re: [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns

2013-12-04 Thread Richard Henderson
On 12/05/2013 11:14 AM, Peter Maydell wrote: > On 4 December 2013 21:55, Richard Henderson wrote: >> On 12/05/2013 08:33 AM, Peter Maydell wrote: >>> @@ -680,6 +720,7 @@ void gen_intermediate_code_internal_a64(ARMCPU *cpu, >>> dc->condjmp = 0; >>> >>> dc->aarch64 = 1; >>> +dc->tmp_a6

Re: [Qemu-devel] [PATCH v2 12/12] target-arm: A64: add support for compare and branch imm

2013-12-04 Thread Peter Maydell
On 4 December 2013 21:59, Richard Henderson wrote: > On 12/05/2013 08:33 AM, Peter Maydell wrote: >> +static TCGv_i64 read_cpu_reg(DisasContext *s, int reg, int sf) >> +{ >> +TCGv_i64 v = new_tmp_a64_zero(s); >> +if (reg != 31) { > > This is going to issue a garbage "movi tmp, 0" opcode fo

Re: [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns

2013-12-04 Thread Peter Maydell
On 4 December 2013 21:55, Richard Henderson wrote: > On 12/05/2013 08:33 AM, Peter Maydell wrote: >> @@ -680,6 +720,7 @@ void gen_intermediate_code_internal_a64(ARMCPU *cpu, >> dc->condjmp = 0; >> >> dc->aarch64 = 1; >> +dc->tmp_a64_count = 0; >> dc->thumb = 0; >> dc->bswap

Re: [Qemu-devel] [PATCH v2 12/12] target-arm: A64: add support for compare and branch imm

2013-12-04 Thread Richard Henderson
On 12/05/2013 08:33 AM, Peter Maydell wrote: > +static TCGv_i64 read_cpu_reg(DisasContext *s, int reg, int sf) > +{ > +TCGv_i64 v = new_tmp_a64_zero(s); > +if (reg != 31) { This is going to issue a garbage "movi tmp, 0" opcode for every non-XZR read. While the optimizer will remove that, i

Re: [Qemu-devel] [PATCH v2 11/12] target-arm: A64: add support for 'test and branch' imm

2013-12-04 Thread Richard Henderson
On 12/05/2013 08:33 AM, Peter Maydell wrote: > From: Alexander Graf > > This patch adds emulation for the test and branch insns, > TBZ and TBNZ. > > Signed-off-by: Alexander Graf > [claudio: > adapted for new decoder > always compare with 0 > remove a TCG temporary > ] > Signed-off-by: Cl

Re: [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns

2013-12-04 Thread Richard Henderson
On 12/05/2013 08:33 AM, Peter Maydell wrote: > @@ -680,6 +720,7 @@ void gen_intermediate_code_internal_a64(ARMCPU *cpu, > dc->condjmp = 0; > > dc->aarch64 = 1; > +dc->tmp_a64_count = 0; > dc->thumb = 0; > dc->bswap_code = 0; > dc->condexec_mask = 0; Still no initiali

Re: [Qemu-devel] [PATCH v2 10/12] target-arm: A64: add support for conditional branches

2013-12-04 Thread Richard Henderson
On 12/05/2013 08:33 AM, Peter Maydell wrote: > From: Alexander Graf > > This patch adds emulation for the conditional branch (b.cond) instruction. > > Signed-off-by: Alexander Graf > [claudio: adapted to new decoder structure, > reused arm infrastructure for checking the flags] > Sign

Re: [Qemu-devel] gpu and console chicken and egg

2013-12-04 Thread Dave Airlie
On Wed, Dec 4, 2013 at 6:23 PM, Gerd Hoffmann wrote: > On Mi, 2013-12-04 at 17:02 +1000, Dave Airlie wrote: >> So I've hit a bit of a init ordering issue that I'm not sure how best to >> solve, >> >> Just some background: >> In order for the virt GPU and the UI layer (SDL or GTK etc) to >> intera

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-04 Thread Peter Maydell
On 4 December 2013 21:20, Antony Pavlov wrote: > On Wed, 4 Dec 2013 20:29:05 + > Peter Maydell wrote: > >> On 4 December 2013 20:22, Antony Pavlov wrote: >> > Here is my proposition: >> > >> > 1. qemu board code setup CPU to start from 0x. (0x is a >> > ROM address >> > on D

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-04 Thread Antony Pavlov
On Wed, 4 Dec 2013 20:29:05 + Peter Maydell wrote: > On 4 December 2013 20:22, Antony Pavlov wrote: > > Here is my proposition: > > > > 1. qemu board code setup CPU to start from 0x. (0x is a ROM > > address > > on DIGIC chips) > > Sort of. What we need is: > 1a. Add a "hi

Re: [Qemu-devel] RESEND: [PATCHv2 0/6] ui/vnc: update optimizations

2013-12-04 Thread Peter Lieven
Am 04.12.2013 19:20, schrieb Stefan Weil: > Am 04.12.2013 18:56, schrieb Peter Lieven: >> Ping >> >> Am 21.11.2013 09:51, schrieb Peter Lieven: >>> this series includes several optimizations for the ui/vnc guest to server >>> and server to client >>> update cycles. comments/reviews appreciated. >>

Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-04 Thread Eric Blake
On 12/04/2013 02:10 AM, Wenchao Xia wrote: > Now qemu-img convert have similar options as qemu-nbd for internal > snapshot. > > Signed-off-by: Wenchao Xia > --- > @@ -1183,6 +1189,18 @@ static int img_convert(int argc, char **argv) > case 's': > snapshot_name = optarg; >

[Qemu-devel] [PATCH v2 10/12] target-arm: A64: add support for conditional branches

2013-12-04 Thread Peter Maydell
From: Alexander Graf This patch adds emulation for the conditional branch (b.cond) instruction. Signed-off-by: Alexander Graf [claudio: adapted to new decoder structure, reused arm infrastructure for checking the flags] Signed-off-by: Claudio Fontana Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH v2 04/12] target-arm: Support fp registers in gdb stub

2013-12-04 Thread Peter Maydell
Register the aarch64-fpu XML and implement the necessary read/write handlers so we can support reading and writing of FP registers in the gdb stub. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- configure |2 +- gdb-xml/aarch64-fpu.xml | 86 +

[Qemu-devel] [PATCH v2 03/12] target-arm: A64: provide functions for accessing FPCR and FPSR

2013-12-04 Thread Peter Maydell
The information which AArch32 holds in the FPSCR is split for AArch64 into two logically distinct registers, FPSR and FPCR. Since they are carefully arranged to use non-overlapping bits, we leave the underlying state in the same place, and provide accessor functions which just update the appropriat

[Qemu-devel] [PATCH v2 07/12] target-arm: A64: expand decoding skeleton for system instructions

2013-12-04 Thread Peter Maydell
From: Claudio Fontana Decode the various kinds of system instructions: hints (HINT), which include NOP, YIELD, WFE, WFI, SEV, SEL sync instructions, which include CLREX, DSB, DMB, ISB msr_i, which move immediate to processor state field sys, which include all SYS and SYSL instructions msr, w

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-04 Thread Peter Maydell
On 4 December 2013 20:22, Antony Pavlov wrote: > Here is my proposition: > > 1. qemu board code setup CPU to start from 0x. (0x is a ROM > address > on DIGIC chips) Sort of. What we need is: 1a. Add a "hivecs" property to the ARM CPU object (which just sets env->cp15.c1_sys bit

Re: [Qemu-devel] [PATCH 5/5] Add vhost-user calls implementation

2013-12-04 Thread Michael S. Tsirkin
On Fri, Nov 29, 2013 at 08:52:26PM +0100, Antonios Motakis wrote: > Each ioctl request of vhost-kernel has a vhost-user message equivalent, > which is sent it over the control socket. > > The general approach is to copy the data from the supplied argument > pointer to a designated field in the mes

[Qemu-devel] [PATCH] PPC: Use default pci bus name for grackle and heathrow

2013-12-04 Thread Alexander Graf
There's no good reason to call our bus "pci" rather than let the default bus name take over ("pci.0"). The big downside to calling it different from anyone else is that tools that pass -device get confused. They are looking for a bus "pci.0" rather than "pci". To make life easier for everyone, le

[Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-04 Thread Alexander Graf
When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id "" bus: ide.0 type IDE dev: macio-ide, id "" bus: ide.0

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-04 Thread Antony Pavlov
On Thu, 17 Oct 2013 20:17:15 +0100 Peter Maydell wrote: > On 17 October 2013 19:51, Georg Hofstetter wrote: > > flash (ROM1) on these cameras starts at 0xF800 and is either > > 0x0080, 0x0100 ox 0x0200 large. just like with every > > chip-selected memory, where the CS/EN line is

[Qemu-devel] [PATCH v2 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal()

2013-12-04 Thread Peter Maydell
The A32/T32 gen_intermediate_code_internal() is complicated because it has to deal with: * conditionally executed instructions * Thumb IT blocks * kernel helper page * M profile exception-exit special casing None of these apply to A64, so putting the "this is A64 so call the A64 decoder" check

[Qemu-devel] [PATCH v2 02/12] target-arm: A64: add set_pc cpu method

2013-12-04 Thread Peter Maydell
From: Alexander Graf When executing translation blocks we need to be able to recover our program counter. Add a method to set it for AArch64 CPUs. This covers user-mode, but for system mode emulation we will need to check if the CPU is in an AArch32 execution state. Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH v2 05/12] target-arm: A64: add stubs for a64 specific helpers

2013-12-04 Thread Peter Maydell
From: Alexander Graf We will need helpers that only make sense with AArch64. Add helper-a64.{c,h} files as stubs that we can fill with these helpers in the following patches. Signed-off-by: Alexander Graf Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/Makefile.obj

[Qemu-devel] [PATCH v2 06/12] target-arm: A64: provide skeleton for a64 insn decoding

2013-12-04 Thread Peter Maydell
From: Claudio Fontana Provide a skeleton for a64 instruction decoding in translate-a64.c, by dividing instructions into the classes defined by the ARM Architecture Reference Manual(DDI0487A_a) section C3. Signed-off-by: Claudio Fontana Signed-off-by: Peter Maydell Reviewed-by: Richard Henderso

[Qemu-devel] [PATCH v2 12/12] target-arm: A64: add support for compare and branch imm

2013-12-04 Thread Peter Maydell
From: Alexander Graf This patch adds emulation for the compare and branch insns, CBZ and CBNZ. Signed-off-by: Alexander Graf [claudio: adapted to new decoder, compare with immediate 0, introduce read_cpu_reg to get the 0 extension on (!sf)] Signed-off-by: Claudio Fontana Si

[Qemu-devel] [PATCH v2 11/12] target-arm: A64: add support for 'test and branch' imm

2013-12-04 Thread Peter Maydell
From: Alexander Graf This patch adds emulation for the test and branch insns, TBZ and TBNZ. Signed-off-by: Alexander Graf [claudio: adapted for new decoder always compare with 0 remove a TCG temporary ] Signed-off-by: Claudio Fontana Signed-off-by: Peter Maydell --- target-arm/translat

[Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns

2013-12-04 Thread Peter Maydell
From: Alexander Graf Implement the B and BL instructions (PC relative branches and calls). For convenience in managing TCG temporaries which might be generated if a source register is the zero-register XZR, we provide a simple mechanism for creating a new temp which is automatically freed at the

[Qemu-devel] [PATCH v2 00/12] target-arm: A64 decoder, foundation plus branches

2013-12-04 Thread Peter Maydell
Round two of the first-chunk of A64 decoder work, updated following code review. Contents: * the new decoder skeleton, * gdbstub support for FP insns * a patch from me which gives the A64 decoder its own gen_intermediate_code_internal() loop for simplicity * the branch related patches from

[Qemu-devel] [PATCH v2 09/12] target-arm: A64: add support for BR, BLR and RET insns

2013-12-04 Thread Peter Maydell
From: Alexander Graf Implement BR, BLR and RET. This is all of the 'unconditional branch (register)' instruction category except for ERET and DPRS (which are system mode only). Signed-off-by: Alexander Graf [claudio: reimplemented on top of new decoder structure] Signed-off-by: Claudio Fontana

Re: [Qemu-devel] [RFC PATCH v0 2/3] gluster: Implement .bdrv_co_write_zeroes for gluster

2013-12-04 Thread Jeff Cody
On Fri, Nov 22, 2013 at 12:46:17PM +0530, Bharata B Rao wrote: > Support .bdrv_co_write_zeroes() from gluster driver by using GlusterFS API > glfs_zerofill() that off-loads the writing of zeroes to GlusterFS server. > > Signed-off-by: Bharata B Rao > --- > block/gluster.c | 101 > ++

Re: [Qemu-devel] [RFC PATCH v0 3/3] gluster: Add support for creating zero-filled image

2013-12-04 Thread Jeff Cody
On Fri, Nov 22, 2013 at 12:46:18PM +0530, Bharata B Rao wrote: > GlusterFS supports creation of zero-filled file on GlusterFS volume > by means of an API called glfs_zerofill(). Use this API from QEMU to > create an image that is filled with zeroes by using the preallocation > option of qemu-img. >

Re: [Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to -help output

2013-12-04 Thread Eduardo Habkost
On Wed, Dec 04, 2013 at 11:51:17AM -0700, Eric Blake wrote: > On 12/04/2013 11:42 AM, Eduardo Habkost wrote: > > Bugzilla: 972773 > > > > Add support statement to -help output, reporting direct qemu-kvm usage > > as unsupported by Red Hat, and advising users to use libvirt instead. > > > > Signed

Re: [Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to -help output

2013-12-04 Thread Eric Blake
On 12/04/2013 11:42 AM, Eduardo Habkost wrote: > Bugzilla: 972773 > > Add support statement to -help output, reporting direct qemu-kvm usage > as unsupported by Red Hat, and advising users to use libvirt instead. > > Signed-off-by: Eduardo Habkost > --- > vl.c | 9 + > 1 file changed, 9

[Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to -help output

2013-12-04 Thread Eduardo Habkost
Bugzilla: 972773 Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272 Add support statement to -help output, reporting direct qemu-kvm usage as unsupported by Red Hat, and advising users to use libvirt instead. Signed-off-by: Eduardo Habkost --- vl.c | 9 + 1

Re: [Qemu-devel] RESEND: [PATCHv2 0/6] ui/vnc: update optimizations

2013-12-04 Thread Stefan Weil
Am 04.12.2013 18:56, schrieb Peter Lieven: > Ping > > Am 21.11.2013 09:51, schrieb Peter Lieven: >> this series includes several optimizations for the ui/vnc guest to server >> and server to client >> update cycles. comments/reviews appreciated. >> >> v1->v2: - new patches 2,4,5 >> - patch

Re: [Qemu-devel] QEMU For Windows

2013-12-04 Thread Cumberland, Lonnie
Hi Stefan, Thanks for getting back to me regarding your QEMU on Windows. I actually do realize that QEMU on a Windows os is much slower, but I have limited options in this area as the basis of the project (which will take a fair amount of time and effort to get going) is to have a Type 2 Hyperv

Re: [Qemu-devel] [V3 PATCH 00/14] target-ppc: VSX Stage 4

2013-12-04 Thread Tom Musta
On 12/3/2013 6:25 PM, Richard Henderson wrote: > > I think I've now reviewed the entire series, as I think that only the fma > patch > was really outstanding. It would be helpful if you'd copy any given > Reviewed-by into the patch description for subsequent rounds, if the patch is > unchanged.

[Qemu-devel] RESEND: [PATCHv2 0/6] ui/vnc: update optimizations

2013-12-04 Thread Peter Lieven
Ping Am 21.11.2013 09:51, schrieb Peter Lieven: > this series includes several optimizations for the ui/vnc guest to server and > server to client > update cycles. comments/reviews appreciated. > > v1->v2: - new patches 2,4,5 > - patch3: added performance test [Anthony] > - patch3

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-04 Thread Paolo Bonzini
Il 04/12/2013 15:06, Stefan Hajnoczi ha scritto: > On Thu, Oct 10, 2013 at 05:07:18PM +0200, Paolo Bonzini wrote: >> @@ -298,30 +278,31 @@ static void handle_notify(EventNotifier *e) >> vring_disable_notification(s->vdev, &s->vring); >> >> for (;;) { >> -head = vring

Re: [Qemu-devel] QEMU For Windows

2013-12-04 Thread Stefan Weil
Am 04.12.2013 16:30, schrieb Cumberland, Lonnie: > > Greetings All, > > I hope that you are well today. > > For a learning/development project, I am interested in the “QEMU for > Windows” which is being developed by Stefan Weil as I think that it > would make a great starting point. I found the lat

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: check for meduim on ALLOW_MEDIUM_REMOVAL

2013-12-04 Thread Paolo Bonzini
Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: > This prevents the guest from preventing DVD medium removal when > there is no medium. > > Without this, if the user has ejected a DVD, it is possible to > have a block device with an open tray, no media but locked. This state is weird but sh

Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm

2013-12-04 Thread Richard Henderson
On 12/05/2013 06:02 AM, Peter Maydell wrote: > I think that kind of thing tips the balance in favour of having > read_cpu_reg() always return a trashable temporary. Fair enough. r~

  1   2   3   >