Am 04.12.2013 18:56, schrieb Peter Lieven:
> Ping
>
> Am 21.11.2013 09:51, schrieb Peter Lieven:
>> this series includes several optimizations for the ui/vnc guest to server
>> and server to client
>> update cycles. comments/reviews appreciated.
>>
>> v1->v2: - new patches 2,4,5
>> - patch3: added performance test [Anthony]
>> - patch3: further optimized the vnc_update_client by searching for
>> the next zero bit
>> with find_next_zero_bit.
>> - patch3: further optimized vnc_dpy_switch by using bitmap_set to
>> mask bits dirty.
>>
>> Peter
>>
>> Peter Lieven (6):
>> ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro
>> ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT
>> ui/vnc: optimize dirty bitmap tracking
>> ui/vnc: optimize clearing in find_and_clear_dirty_height()
>> ui/vnc: optimize setting in vnc_dpy_update()
>> ui/vnc: disable adaptive update calculations if not needed
>>
>> ui/vnc.c | 185
>> ++++++++++++++++++++++++++++++++++++--------------------------
>> ui/vnc.h | 9 ++-
>> 2 files changed, 115 insertions(+), 79 deletions(-)
Hallo Peter,
there was an e-mail from Eric which you might consider in a 2nd version
of your patch series.
Please check also your patches using scripts/checkpatch.pl. Some of them
currently produce warnings:
total: 0 errors, 1 warnings, 139 lines
checked0001-ui-vnc-introduce-VNC_DIRTY_PIXELS_PER_BIT-macro.patch
total: 0 errors, 6 warnings, 212 lines
checked0003-ui-vnc-optimize-dirty-bitmap-tracking.patch
total: 0 errors, 1 warnings, 17 lines
checked0005-ui-vnc-optimize-setting-in-vnc_dpy_update.patch
I think it would also be reasonable to fix the coding style for this
code location in a separate patch
before modifying the else statement, but maybe this is optional:
else
- w_lim = w - (w_lim % 16);
+ w_lim = w - (w_lim % VNC_DIRTY_PIXELS_PER_BIT);
Viele Grüße
Stefan Weil
