Stefan Weil writes:
> Commit 3435f39513a104294b5e3bbf3612047028d25cfc reduced the ifdeffery with
> this result for MinGW:
>
> exec.c: In function ‘qemu_ram_free’:
> exec.c:1239:17: warning:
> implicit declaration of function ‘munmap’ [-Wimplicit-function-declaration]
> exec.c:1239:17: warning:
>
Commit 3435f39513a104294b5e3bbf3612047028d25cfc reduced the ifdeffery with
this result for MinGW:
exec.c: In function ‘qemu_ram_free’:
exec.c:1239:17: warning:
implicit declaration of function ‘munmap’ [-Wimplicit-function-declaration]
exec.c:1239:17: warning:
nested extern declaration of ‘munma
On Wed, Sep 18, 2013 at 12:02:51AM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 21:51, Michael S. Tsirkin ha scritto:
> > A much more interesting case is e.g. disabling memory.
> > E.g.
> >
> > config write (disable memory)
> > read (flush out outstanding writes)
> > write <- must now have no effec
Sounds fantastic, will play it. :)
On 09/17/2013 03:22 AM, Pekka Enberg wrote:
> Hello,
>
> We're proud to announce release 0.01 of OSv, a new operating system
> for running applications on virtual machines. OSv is free software,
> released under the BSD license, and you can find it in
> https://
On Wed, Sep 18, 2013 at 01:04:01PM +1000, Alexey Kardashevskiy wrote:
> On 09/05/2013 04:07 PM, Paolo Bonzini wrote:
> > Il 05/09/2013 05:16, Alexey Kardashevskiy ha scritto:
> >> Sorry for my ignorance, but this is The Kernel, it is already there,
> >> broken
> >> or not, even if it i
This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
Signed-off-by: Alexey Kardashevskiy
---
include/sysemu/kvm.h | 4
kvm-all.c| 31 +++
2 files changed, 35 insertions(+)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index
On Wed, 09/04 14:35, Stefan Hajnoczi wrote:
> On Thu, Aug 15, 2013 at 04:14:06PM +0800, Fam Zheng wrote:
> > diff --git a/block/commit.c b/block/commit.c
> > index 2227fc2..b5e024b 100644
> > --- a/block/commit.c
> > +++ b/block/commit.c
> > @@ -17,14 +17,13 @@
> > #include "block/blockjob.h"
> >
On 09/05/2013 04:07 PM, Paolo Bonzini wrote:
> Il 05/09/2013 05:16, Alexey Kardashevskiy ha scritto:
>> Sorry for my ignorance, but this is The Kernel, it is already there,
>> broken
>> or not, even if it is broken, qemu cannot stay isolated, no?
>> This is a mechanical change, no
Il 17/09/2013 19:33, Stefan Weil ha scritto:
> Debian wheezy includes libiscsi-dev 1.4.0 which does not provide
> SCSI_PROVISIONING_TYPE_DEALLOCATED. Drop iscsi_co_get_block_status
> in this case to allow compilation without errors.
>
> Signed-off-by: Stefan Weil
> ---
> block/iscsi.c |6 +++
Il 17/09/2013 21:51, Michael S. Tsirkin ha scritto:
> A much more interesting case is e.g. disabling memory.
> E.g.
>
> config write (disable memory)
> read (flush out outstanding writes)
> write <- must now have no effect
This works already. memory_region_del_subregion is synchronous, and
will
On 17 September 2013 19:46, Richard Henderson wrote:
> On 09/17/2013 10:46 AM, Michael Walle wrote:
>> Am Montag, 9. September 2013, 18:47:21 schrieb Peter Maydell:
>>> For lm32 you might consider raising EXCP_BREAKPOINT;
>>> then if you have a gdb connected to the debug stub
>>> the developer wil
On 17 September 2013 18:03, Stefan Weil wrote:
> could you please review this patch which removes code added by you earlier?
> I have run tests with the old code and assertions to see whether the values
> were really smashed. They never were, and from the documentation of setjmp
> I'd not expect t
Report from clang analyzer:
clock.c:42:15: warning:
Value stored to 'cpu' during its initialization is never read
Signed-off-by: Stefan Weil
---
hw/i386/kvm/clock.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c
index 92aabb8..38
On 17 September 2013 11:44, benno wrote:
> I'm not convinced the logic is correct.
It's not. There have been a few attempts by people to submit patches
to this though, but none of them have actually been sufficiently
convincing. See for instance
http://lists.nongnu.org/archive/html/qemu-devel/201
On Tue, Sep 17, 2013 at 09:07:05PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 19:26, Michael S. Tsirkin ha scritto:
> > On Tue, Sep 17, 2013 at 07:16:15PM +0200, Paolo Bonzini wrote:
> >> Il 17/09/2013 19:07, Michael S. Tsirkin ha scritto:
> >>> After memory_region_del_subregion returns,
> >>> it'
Signed-off-by: Hans de Goede
---
hw/usb/combined-packet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/combined-packet.c b/hw/usb/combined-packet.c
index 13f6602..ad77705 100644
--- a/hw/usb/combined-packet.c
+++ b/hw/usb/combined-packet.c
@@ -39,6 +39,7 @@ static void usb_combined_
Transfers are part of an epctx, which is part of a slot, which is part of
a xhci. Transfers cannot dynamically be moved from one epctx to another,
so once created their xhci, slotid and epid are constant, so lets set these
up at creation time, rather then re-initializing them with the same
value ea
And use it instead of prying the USBEndpoint out of the packet struct
in various places.
Signed-off-by: Hans de Goede
---
hw/usb/hcd-xhci.c | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 120b038..
Signed-off-by: Hans de Goede
---
hw/usb/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index 31960c2..cf59a1a 100644
--- a/hw/usb/core.c
+++ b/hw/usb/core.c
@@ -622,6 +622,7 @@ void usb_ep_reset(USBDevice *dev)
dev->ep_ctl.nr = 0;
dev->ep_ctl
On 09/17/2013 04:17 PM, Corey Bryant wrote:
On 09/17/2013 01:14 PM, Eduardo Otubo wrote:
On 09/17/2013 11:43 AM, Paul Moore wrote:
On Tuesday, September 17, 2013 02:06:06 PM Daniel P. Berrange wrote:
On Tue, Sep 17, 2013 at 10:01:23AM -0300, Eduardo Otubo wrote:
Paul, what exactly are
The USBPacket-s in the transfers need to be cleaned up so that the memory
allocated by the iovec in there gets freed.
Signed-off-by: Hans de Goede
---
hw/usb/hcd-xhci.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index c209228..18d2e13 100644
--
On Tue, Sep 17, 2013 at 05:33:57PM +0300, Andriy Gapon wrote:
> on 17/09/2013 15:32 Andreas Färber said the following:
> > Hi,
> >
> > Am 17.09.2013 13:37, schrieb Andriy Gapon:
> >>
> >> It seems that when qemu is run with accel=kvm:tcg then -d in_asm does not
> >> produce anything. At least, wi
Il 17/09/2013 19:26, Michael S. Tsirkin ha scritto:
> On Tue, Sep 17, 2013 at 07:16:15PM +0200, Paolo Bonzini wrote:
>> Il 17/09/2013 19:07, Michael S. Tsirkin ha scritto:
>>> After memory_region_del_subregion returns,
>>> it's a promise that there will not be accesses
>>> to the region.
>>
>> It's
On 09/17/2013 10:46 AM, Michael Walle wrote:
> Am Montag, 9. September 2013, 18:47:21 schrieb Peter Maydell:
>> For lm32 you might consider raising EXCP_BREAKPOINT;
>> then if you have a gdb connected to the debug stub
>> the developer will get dropped into the debugger for
>> the offending insn an
On 09/17/2013 01:14 PM, Eduardo Otubo wrote:
On 09/17/2013 11:43 AM, Paul Moore wrote:
On Tuesday, September 17, 2013 02:06:06 PM Daniel P. Berrange wrote:
On Tue, Sep 17, 2013 at 10:01:23AM -0300, Eduardo Otubo wrote:
Paul, what exactly are you planning to add to libvirt? I'm not a big
f
On 17 Sep 2013, at 18:04, Paolo Bonzini wrote:
> Alex, what's missing before block.c and QED can use aio_timer_new on
> the main AioContext, instead of timer_new?
If we assume at this stage the threading is no different, very little
I think. Off the top of my head it should be a case of:
1. Aud
Am 17.09.2013 15:32, schrieb Igor Mammedov:
> user is able to crash running QEMU when following monitor
> command is called:
>
> device_add intel-hda-generic
>
> crash is caused by assertion in object_initialize_with_type()
> when type is abstract.
>
> Checking if type is abstract before instan
Hi Andreas,
Am Mittwoch, 4. September 2013, 11:04:40 schrieb Andreas Färber:
> On part 11, rth said for alpha that using CPUAlphaState in DisasContext was
> bad and that the relevant fields should be copied into DisasContext
> instead; a few targets still have an env field though and use it for
>
Debian wheezy includes libiscsi-dev 1.4.0 which does not provide
SCSI_PROVISIONING_TYPE_DEALLOCATED. Drop iscsi_co_get_block_status
in this case to allow compilation without errors.
Signed-off-by: Stefan Weil
---
block/iscsi.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/block/is
On Tue, 17 Sep 2013 19:42:08 +0200
Andreas Färber wrote:
> > diff --git a/qdev-monitor.c b/qdev-monitor.c
> > index 410cdcb..bb2e1b6 100644
> > --- a/qdev-monitor.c
> > +++ b/qdev-monitor.c
> > @@ -472,6 +472,12 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> > return NULL;
> > }
On 09/17/2013 02:14 PM, Eduardo Otubo wrote:
On 09/17/2013 11:43 AM, Paul Moore wrote:
On Tuesday, September 17, 2013 02:06:06 PM Daniel P. Berrange wrote:
On Tue, Sep 17, 2013 at 10:01:23AM -0300, Eduardo Otubo wrote:
Paul, what exactly are you planning to add to libvirt? I'm not a big
f
Am 14.09.2013 21:47, schrieb Michael Tokarev:
> From: Stefan Weil
>
> The page dump writes a table with 3 abi_ulong values in each row.
> These values take 8 or 16 characters (depending on sizeof abi_ulong).
>
> Fix the table headings to be aligned with the table columns.
>
> old:
> startend
Am Montag, 9. September 2013, 18:47:21 schrieb Peter Maydell:
> On 9 September 2013 17:39, Michael Walle wrote:
> > Am 2013-09-04 11:04, schrieb Andreas Färber:
> >> On part 11, rth said for alpha that using CPUAlphaState in
> >> DisasContext was bad
> >> and that the relevant fields should be cop
Il 17/09/2013 19:07, Michael S. Tsirkin ha scritto:
> After memory_region_del_subregion returns,
> it's a promise that there will not be accesses
> to the region.
It's racy anyway. You can have memory_region_del_subregion happen one
clock cycle after the other (physical) CPU has done checked that
Am 17.09.2013 19:17, schrieb Jan Kiszka:
> On 2013-09-17 19:03, Stefan Weil wrote:
>> 'cpu' and 'env' are not modified after sigsetjmp. Therefore they will
>> still have their last value after longjmp restored the stack context.
>>
>> The code which should "reload" both variables causes a compiler
Am Montag, 2. September 2013, 00:58:42 schrieb Peter Crosthwaite:
> On Sun, Sep 1, 2013 at 3:22 AM, Antony Pavlov
wrote:
> > qemu_chr_fe_write() is capable of returning 0
> > to indicate EAGAIN (and friends) and we don't
> > handle this.
> >
> > Just change it to qemu_chr_fe_write_all() to fix.
On Tue, Sep 17, 2013 at 07:16:15PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 19:07, Michael S. Tsirkin ha scritto:
> > After memory_region_del_subregion returns,
> > it's a promise that there will not be accesses
> > to the region.
>
> It's racy anyway. You can have memory_region_del_subregion
Il 17/09/2013 19:18, Stefan Weil ha scritto:
> Latest QEMU git is broken on Debian wheezy:
>
> block/iscsi.c: In function ‘iscsi_co_get_block_status’:
> block/iscsi.c:842:5: error: implicit declaration of function
> ‘iscsi_get_lba_status_task’ [-Werror=implicit-function-declaration]
> block/iscsi.
Am 12.09.2013 13:17, schrieb Paolo Bonzini:
> From: Peter Lieven
>
> this patch adds a coroutine for .bdrv_co_block_status as well as
> a generic framework that can be used to build coroutines in block/iscsi.
>
> Signed-off-by: Peter Lieven
> Signed-off-by: Paolo Bonzini
> ---
> block/iscsi.c |
On 2013-09-17 18:38, Alex Bligh wrote:
>
> On 17 Sep 2013, at 17:19, Paolo Bonzini wrote:
>
>> Il 17/09/2013 18:09, Jan Kiszka ha scritto:
>>> On 2013-08-13 16:22, Stefan Hajnoczi wrote:
On Tue, Aug 13, 2013 at 03:45:44PM +0200, Jan Kiszka wrote:
> Yeah:
>
> -/* No AIO operat
Am 17.09.2013 17:06, schrieb Anthony Liguori:
> On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev wrote:
>> Just a bit late but here's the next trivial-patches pull request.
>>
>> Thanks,
> Breaks the build:
>
> /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
> /home/anthony/git/qe
Il 17/09/2013 18:29, Michael S. Tsirkin ha scritto:
> > BTW, qemu_del_nic is another one that I forgot to mention. You could
> > have MMIO that triggers a transmit while the device is going down, for
> > example.
>
> Wait a second. This API simply does not make sense.
> If region is not visible
The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3:
block/stream.c:141:22: error:
‘copy’ may be used uninitialized in this function [-Werror=uninitialized]
This is not a real bug - a better compiler would not complain.
Now 'copy' has always a defined value, so the check for ret >= 0
Could be MPT is not parsed correctly?
I see that we put 0 in the ID in bios code.
Could you dump the MPT and send it on list?
On Tue, Sep 17, 2013 at 03:25:38PM +, Bret Ketchum wrote:
>
> The emulated e1000 uses legacy interrupts. I'm wondering if someone can
> help me understand the mp
On 2013-09-17 19:03, Stefan Weil wrote:
> 'cpu' and 'env' are not modified after sigsetjmp. Therefore they will
> still have their last value after longjmp restored the stack context.
>
> The code which should "reload" both variables causes a compiler warning:
>
> cpu-exec.c:204:15: error:
> vari
Il 17/09/2013 18:50, Jan Kiszka ha scritto:
> On 2013-09-17 18:38, Alex Bligh wrote:
>>
>> On 17 Sep 2013, at 17:19, Paolo Bonzini wrote:
>>
>>> Il 17/09/2013 18:09, Jan Kiszka ha scritto:
On 2013-08-13 16:22, Stefan Hajnoczi wrote:
> On Tue, Aug 13, 2013 at 03:45:44PM +0200, Jan Kiszka wr
On Tue, Sep 17, 2013 at 06:58:37PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 18:29, Michael S. Tsirkin ha scritto:
> > > BTW, qemu_del_nic is another one that I forgot to mention. You could
> > > have MMIO that triggers a transmit while the device is going down, for
> > > example.
> >
> > Wait
On 17 Sep 2013, at 17:50, Jan Kiszka wrote:
>>
>> If
>> that's true, I think we /shouldn't/ return. Equally if there
>> are no timers but something is genuinely attempting to wait
>> on an aio_notify, I don't think we should return.
>>
>
> In any case, test-aio seems to stress that if clause.
On 09/17/13 11:51, Richard Jones wrote:
>> There's at least three cases here I guess (KVM + eventfd, KVM without
>> eventfd (enforceable eg. with the "ioeventfd" property for virtio
>> devices), and TCG). We're probably talking about the third case.
>
> To clarify on this point: I have reproduced
'cpu' and 'env' are not modified after sigsetjmp. Therefore they will
still have their last value after longjmp restored the stack context.
The code which should "reload" both variables causes a compiler warning:
cpu-exec.c:204:15: error:
variable ‘cpu’ might be clobbered by ‘longjmp’ or ‘vfork’
On 17 Sep 2013, at 17:19, Paolo Bonzini wrote:
> Il 17/09/2013 18:09, Jan Kiszka ha scritto:
>> On 2013-08-13 16:22, Stefan Hajnoczi wrote:
>>> On Tue, Aug 13, 2013 at 03:45:44PM +0200, Jan Kiszka wrote:
Yeah:
-/* No AIO operations? Get us out of here */
-if (!busy)
On 09/17/2013 11:43 AM, Paul Moore wrote:
On Tuesday, September 17, 2013 02:06:06 PM Daniel P. Berrange wrote:
On Tue, Sep 17, 2013 at 10:01:23AM -0300, Eduardo Otubo wrote:
Paul, what exactly are you planning to add to libvirt? I'm not a big
fan of using qemu command line to pass syscalls f
Il 17/09/2013 18:09, Jan Kiszka ha scritto:
> On 2013-08-13 16:22, Stefan Hajnoczi wrote:
>> On Tue, Aug 13, 2013 at 03:45:44PM +0200, Jan Kiszka wrote:
>>> Yeah:
>>>
>>> -/* No AIO operations? Get us out of here */
>>> -if (!busy) {
>>> +/* early return if we only have the aio_notify(
On Tue, Sep 17, 2013 at 06:13:51PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 17:59, Michael S. Tsirkin ha scritto:
> > Yes but just not freeing it is unlikely to be enough.
> > We need to make sure data structures are consistent.
> > So this really needs to be done carefully, device by device.
>
The /perf/nesting benchmark is broken because the counters are
not reset after each iteration. Therefore, nesting is done only
on the first iteration, and skipped on every other.
This patch fixes the issue, and reduces the number of iterations
to make it possible to run the benchmark in a reasonab
On 09/17/2013 03:02 AM, Emmanuel Blot wrote:
> There is a piece of code I'm not sure to understand, in
>get_page_addr_code(CPUArchState *env1, target_ulong addr)
>
> …
> if (unlikely(env1->tlb_table[mmu_idx][page_index].addr_code !=
> (addr & TARGET_PAGE_MASK))) {
>
On Tue, Sep 17, 2013 at 05:41:52PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 16:45, Michael S. Tsirkin ha scritto:
> > On Tue, Sep 17, 2013 at 04:41:45PM +0200, Paolo Bonzini wrote:
> >> Il 17/09/2013 14:47, Michael S. Tsirkin ha scritto:
> >>> Ergo, to make sure a referenced MR does not get
> >>
Il 17/09/2013 17:59, Michael S. Tsirkin ha scritto:
> Yes but just not freeing it is unlikely to be enough.
> We need to make sure data structures are consistent.
> So this really needs to be done carefully, device by device.
Of course. I checked SCSI already and it's sane.
- del_vm_change_
On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev wrote:
> Just a bit late but here's the next trivial-patches pull request.
>
> Thanks,
Breaks the build:
/home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
/home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
be clob
Il 17/09/2013 16:45, Michael S. Tsirkin ha scritto:
> On Tue, Sep 17, 2013 at 04:41:45PM +0200, Paolo Bonzini wrote:
>> Il 17/09/2013 14:47, Michael S. Tsirkin ha scritto:
>>> Ergo, to make sure a referenced MR does not get
>>> destroyed, we must make sure only finalize
>>> calls memory_region_dest
Current coroutine performance benchmarks test only coroutine creation,
either directly or in a nested way. This patch adds a benchmark to
evaluate the performance of qemu_coroutine_yield.
Signed-off-by: Gabriel Kerneis
---
tests/test-coroutine.c | 33 +
1 file cha
On 09/17/2013 12:55 AM, Claudio Fontana wrote:
> On 16.09.2013 17:50, Richard Henderson wrote:
>> On 09/16/2013 02:16 AM, Claudio Fontana wrote:
>>> I agree in general with the approach "lets see if it is more convenient to
>>> start with MOVN".
>>> The existing implementation is, although not eas
Le Tuesday 17 Sep 2013 à 14:44:13 (+0200), Stefan Hajnoczi a écrit :
> Hi Benoit,
> Kevin and I had a chance to chat face-to-face and we discussed what
> concrete changes are necessary to merge quorum (without solving all the
> other block layers problems at once).
>
> I think quorum could be merg
On 2013-08-13 16:22, Stefan Hajnoczi wrote:
> On Tue, Aug 13, 2013 at 03:45:44PM +0200, Jan Kiszka wrote:
>> On 2013-08-13 15:39, Alex Bligh wrote:
>>> Jan,
>>>
>>> On 13 Aug 2013, at 14:25, Jan Kiszka wrote:
>>>
To my understanding, the use case behind the current behavior is
qemu_aio_wa
On 09/17/2013 01:23 AM, Claudio Fontana wrote:
>> It would have been handy if ARM had officially assigned identifiers to the
>> formats, like Power, S390, and ia64 do. Then one can build in the format ids
>> into both the function and enumeration names and use the preprocessor for
>> typechecking
The emulated e1000 uses legacy interrupts. I'm wondering if someone can
help me understand the mptable (used by FreeBSD to route interrupts and defined
in Intel's MP spec):
Bus:Bus ID Type
0 PCI
1 ISA
I/O APICs: APIC ID Versio
On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote:
> From: Markus Armbruster
>
> This gets rid of one of the last get_param_value() users, makes
> multiple -smbios work sanely, cleans up the gross side effect in
> qemu_uuid_parse(), and more. Topped off with a little feature in t
On Tue, Sep 17, 2013 at 04:41:45PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 14:47, Michael S. Tsirkin ha scritto:
> > Ergo, to make sure a referenced MR does not get
> > destroyed, we must make sure only finalize
> > calls memory_region_destroy.
> >
> > So I think this patchset should do exactl
Il 17/09/2013 14:47, Michael S. Tsirkin ha scritto:
> Ergo, to make sure a referenced MR does not get
> destroyed, we must make sure only finalize
> calls memory_region_destroy.
>
> So I think this patchset should do exactly that,
> not try to move out more stuff to finalize.
Yes, this is the par
On Tuesday, September 17, 2013 02:06:06 PM Daniel P. Berrange wrote:
> On Tue, Sep 17, 2013 at 10:01:23AM -0300, Eduardo Otubo wrote:
>
> > Paul, what exactly are you planning to add to libvirt? I'm not a big
> > fan of using qemu command line to pass syscalls for blacklist as
> > arguments, but I
on 17/09/2013 15:32 Andreas Färber said the following:
> Hi,
>
> Am 17.09.2013 13:37, schrieb Andriy Gapon:
>>
>> It seems that when qemu is run with accel=kvm:tcg then -d in_asm does not
>> produce anything. At least, with the qemu and kvm that I have access to.
>
> Are you saying that with acc
Il 17/09/2013 15:32, Igor Mammedov ha scritto:
> user is able to crash running QEMU when following monitor
> command is called:
>
> device_add intel-hda-generic
>
> crash is caused by assertion in object_initialize_with_type()
> when type is abstract.
>
> Checking if type is abstract before ins
On 09/17/2013 01:01 AM, Claudio Fontana wrote:
> I don't have anything against it in principle, but just adding c0 and c1,
> which iirc should cover all uses, would be fine by me.
Not really.
There are 6 potential args[] values, 5 of which might be const_args[].
r~
this patch adds a call to completely zero out a block device.
the operation is sped up by checking the block status and
only writing zeroes to the device if they currently do not
return zeroes. optionally the zero writing can be sped up
by setting the flag BDRV_REQ_MAY_UNMAP to emulate the zero
wri
Signed-off-by: Peter Lieven
---
block.c | 29 +
include/block/block.h |2 ++
include/block/block_int.h | 13 +
3 files changed, 44 insertions(+)
diff --git a/block.c b/block.c
index 6f498fc..177720e 100644
--- a/block.c
+++ b/
Reviewed-by: Eric Blake
Signed-off-by: Peter Lieven
---
block.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 805ee26..461a1d7 100644
--- a/block.c
+++ b/block.c
@@ -3195,7 +3195,7 @@ static int64_t coroutine_fn
bdrv_co_get_block_status(BlockDriv
Signed-off-by: Peter Lieven
---
block.c | 57 +
1 file changed, 41 insertions(+), 16 deletions(-)
diff --git a/block.c b/block.c
index 177720e..74ec342 100644
--- a/block.c
+++ b/block.c
@@ -2660,28 +2660,53 @@ static int coroutine_fn
bd
Signed-off-by: Peter Lieven
---
block/raw_bsd.c | 56 +--
1 file changed, 34 insertions(+), 22 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index bd4811b..0bfa5fc 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -131,6 +13
Hello,
I have been using 'qemu-nbd' and 'qemu-img' for some time to provide
loop filesystems in my environment.
Recently I have been experimenting with hibernating (suspend to disk)
the physical host on which I have qemu running.
I am using the kernel functionality directly with the commands:
Public bug reported:
On ARMv7M interrupts handlers will be called even if emulated code
executes "cpsid i" instruction.
Underlying cause described below:
In cpu-exec.c:cpu_exec there is a block of code that determines if an
interrupt should be raised or not:
/* ARMv7-M inte
Hello,
We're proud to announce release 0.01 of OSv, a new operating system
for running applications on virtual machines. OSv is free software,
released under the BSD license, and you can find it in
https://github.com/cloudius-systems/osv and http://www.osv.io.
To build and run OSv under KVM/QEMU,
Signed-off-by: Peter Lieven
---
qemu-img.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 3e5e388..7600b58 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -100,8 +100,10 @@ static void help(void)
" '-h' with or without a comma
if the call is invoked through bdrv_is_allocated the caller might
expect *pnum = 0 on error. however, a new implementation of
bdrv_get_block_status might only return a negative exit value on
error while keeping *pnum untouched.
Reviewed-by: Eric Blake
Signed-off-by: Peter Lieven
---
block.c |
Signed-off-by: Peter Lieven
---
block/iscsi.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 21b1ecf..46c7c8d 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1440,6 +1440,18 @@ static int iscsi_has_zero_init(BlockDrive
if a raw device like an iscsi target or host device is used
the current implementation makes a second call out to get
the block status of bs->file. however, the raw driver already
has called bdrv_get_block_status on bs->file.
Reviewed-by: Eric Blake
Signed-off-by: Peter Lieven
---
block.c |
if the target has_zero_init = 0, but supports efficiently
writing zeroes by unmapping we call bdrv_zeroize to
avoid fully allocating the target. this currently
is designed especially for iscsi.
Signed-off-by: Peter Lieven
---
qemu-img.c | 10 +-
1 file changed, 9 insertions(+), 1 delet
Signed-off-by: Peter Lieven
---
block.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 74ec342..ecc5be4 100644
--- a/block.c
+++ b/block.c
@@ -4181,7 +4181,39 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs
Signed-off-by: Peter Lieven
---
block/iscsi.c | 59 +
1 file changed, 59 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 46c7c8d..4df33fc 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -56,6 +56,7 @@ typedef struct Iscsi
this patch does 2 things:
a) only do additional call outs if BDRV_BLOCK_ZERO is not already set.
b) use the newly introduced bdrv_has_discard_zeroes() to return the
zero state of an unallocated block. the used callout to
bdrv_has_zero_init() is only valid right after bdrv_create.
Signed-off-
Signed-off-by: Peter Lieven
---
block/iscsi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index aabcddb..21b1ecf 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1362,6 +1362,16 @@ static int iscsi_open(BlockDriverState *bs, QDict
*options, i
now that bdrv_co_discard can handle limits we do not need
the request split logic here anymore.
Signed-off-by: Peter Lieven
---
block/iscsi.c | 67 +
1 file changed, 25 insertions(+), 42 deletions(-)
diff --git a/block/iscsi.c b/block/is
Signed-off-by: Peter Lieven
---
block/raw_bsd.c |4
1 file changed, 4 insertions(+)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 0bfa5fc..dfdb375 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -149,6 +149,10 @@ static int raw_create(const char *filename,
QEMUOptionParame
this patch adds the ability for targets to stay sparse during
block migration (if the zero_blocks capability is set) and qemu-img convert
even if the target does not have has_zero_init = 1.
the series was especially developed for iSCSI, but it should also work
with other drivers with little or no
Signed-off-by: Peter Lieven
---
include/block/block_int.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 85c3474..692b9ed 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -280,6 +280,18 @@ st
Signed-off-by: Peter Lieven
---
block-migration.c |3 ++-
block.c |4
block/backup.c|2 +-
include/block/block.h |7 +++
4 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 713a8e3..fc4ef93
Reviewed-by: Eric Blake
Signed-off-by: Peter Lieven
---
block-migration.c |2 +-
block.c | 20 +++-
block/backup.c|3 ++-
block/qcow2.c |2 +-
block/qed.c |3 ++-
block/raw_bsd.c |5 ++
Reviewed-by: Eric Blake
Signed-off-by: Peter Lieven
---
block.c |5 -
include/block/block.h |5 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index a325efc..878f365 100644
--- a/block.c
+++ b/block.c
@@ -51,11 +51,6 @@
#define
user is able to crash running QEMU when following monitor
command is called:
device_add intel-hda-generic
crash is caused by assertion in object_initialize_with_type()
when type is abstract.
Checking if type is abstract before instance is created in
qdev_device_add() allows to prevent crash on
On Tue, Sep 17, 2013 at 10:01:23AM -0300, Eduardo Otubo wrote:
>
>
> On 09/11/2013 01:49 PM, Daniel P. Berrange wrote:
> >On Wed, Sep 11, 2013 at 12:45:54PM -0400, Corey Bryant wrote:
> >>
> >>
> >>On 09/06/2013 03:21 PM, Eduardo Otubo wrote:
> >>>New command line options for the seccomp blacklis
On 09/11/2013 01:49 PM, Daniel P. Berrange wrote:
On Wed, Sep 11, 2013 at 12:45:54PM -0400, Corey Bryant wrote:
On 09/06/2013 03:21 PM, Eduardo Otubo wrote:
New command line options for the seccomp blacklist feature:
$ qemu -sandbox on[,strict=]
The strict parameter will turn on or off
1 - 100 of 156 matches
Mail list logo
